Re: [PATCH weston 1/2] clients: consolidate timer code part 1

2018-03-09 Thread Daniel Stone
Hi, On 9 March 2018 at 17:32, Derek Foreman wrote: > On 2018-03-09 05:44 AM, Pekka Paalanen wrote: >> There are multiple copies for the timerfd handling code, and I need a >> timer in one more app. Consolidate all the timerfd code into window.c to >> reduce the duplication. Many of the copies wer

Re: [PATCH weston 1/2] clients: consolidate timer code part 1

2018-03-09 Thread Derek Foreman
On 2018-03-09 05:44 AM, Pekka Paalanen wrote: From: Pekka Paalanen There are multiple copies for the timerfd handling code, and I need a timer in one more app. Consolidate all the timerfd code into window.c to reduce the duplication. Many of the copies were also flawed against the race mentione

Re: [PATCH] compositor-wayland: Ignore pointer enter on destroyed surface

2018-03-09 Thread Pekka Paalanen
On Fri, 9 Mar 2018 14:14:11 + Daniel Stone wrote: > Hi, > > On 9 March 2018 at 14:08, Pekka Paalanen wrote: > > On Fri, 9 Mar 2018 10:08:37 + > > Daniel Stone wrote: > >> + if (!surface) { > >> + input->output = NULL; > >> + input->has_focus = false; > >>

Re: [PATCH] compositor-wayland: Ignore pointer enter on destroyed surface

2018-03-09 Thread Daniel Stone
Hi, On 9 March 2018 at 14:08, Pekka Paalanen wrote: > On Fri, 9 Mar 2018 10:08:37 + > Daniel Stone wrote: >> + if (!surface) { >> + input->output = NULL; >> + input->has_focus = false; >> + notify_pointer_focus(&input->base, NULL, 0, 0); >> +

Re: [PATCH] compositor-wayland: Ignore pointer enter on destroyed surface

2018-03-09 Thread Pekka Paalanen
On Fri, 9 Mar 2018 10:08:37 + Daniel Stone wrote: > Due to race conditions, it is (vanishingly unlikely but) possible to > receive a wl_pointer.enter event referring to a wl_surface we have just > destroyed. If this happens, wl_surface will be NULL. Detect this, clear > out our focus, and re

[PATCH weston 1/2] clients: consolidate timer code part 1

2018-03-09 Thread Pekka Paalanen
From: Pekka Paalanen There are multiple copies for the timerfd handling code, and I need a timer in one more app. Consolidate all the timerfd code into window.c to reduce the duplication. Many of the copies were also flawed against the race mentioned in toytimer_fire(). This patch handles clickd

[PATCH weston 2/2] clients: consolidate timer code part 2

2018-03-09 Thread Pekka Paalanen
From: Pekka Paalanen Continue moving bits to use toytimer instead of carelessly open-coded equivalent. Many of the copies were flawed against the race mentioned in toytimer_fire(). This patch handles window.c's key repeat, confine demo, and desktop-shell panel clock. Signed-off-by: Pekka Paalan

Re: [PATCH weston] libweston/compositor-drm: Reset repaint scheduled status when setting DPMS level to off

2018-03-09 Thread Marius-cristian Vlad
On Fri, 2018-03-09 at 09:35 +, Daniel Stone wrote: > Hi Marius, > > On 7 March 2018 at 17:36, Marius Vlad > wrote: > > Otherwise when setting dpms level DPMS_ON, > > weston_output_schedule_repaint() > > will bail out early and never get a chance to wake up the output. > > > > Arguably this c

Re: [PATCH wayland v2 1/4] Revert "wayland-egl-symbols-check: pass the DSO name via the build system"

2018-03-09 Thread Daniel Stone
Hi Emil, On 9 March 2018 at 10:59, Emil Velikov wrote: > On 9 March 2018 at 09:47, Daniel Stone wrote: >> Patches 2-4 look fine and I'm happy to merge them with my review, but >> could you please explain some more about this patch? I very much like >> keeping details of the build system (specifi

Re: [PATCH wayland v2 1/4] Revert "wayland-egl-symbols-check: pass the DSO name via the build system"

2018-03-09 Thread Emil Velikov
On 9 March 2018 at 09:47, Daniel Stone wrote: > Hi Emil, > > On 8 March 2018 at 18:32, Emil Velikov wrote: >> On 28 February 2018 at 16:38, Emil Velikov wrote: >>> This reverts commit 85cb5ed64aa8246f4da93fc5b76dfc34096bf803. >>> >>> It seems like we've misread the existing code - the DSO name c

Re: [PATCH weston] compositor-wayland: handle wl_keyboard.enter(NULL)

2018-03-09 Thread Daniel Stone
Hi Pekka, On 22 February 2018 at 14:54, Pekka Paalanen wrote: > Destroying an output (wl_surface) can race against the parent compositor > sending wl_keyboard.enter. When this race is lost, wayland-backend > receives wl_keyboard.enter with a NULL wl_surface for the surface it > just destroyed. >

[PATCH] compositor-wayland: Ignore pointer enter on destroyed surface

2018-03-09 Thread Daniel Stone
Due to race conditions, it is (vanishingly unlikely but) possible to receive a wl_pointer.enter event referring to a wl_surface we have just destroyed. If this happens, wl_surface will be NULL. Detect this, clear out our focus, and return. Other pointer and keyboard events are robust against destr

Re: [PATCH wayland v2 1/4] Revert "wayland-egl-symbols-check: pass the DSO name via the build system"

2018-03-09 Thread Daniel Stone
Hi Emil, On 8 March 2018 at 18:32, Emil Velikov wrote: > On 28 February 2018 at 16:38, Emil Velikov wrote: >> This reverts commit 85cb5ed64aa8246f4da93fc5b76dfc34096bf803. >> >> It seems like we've misread the existing code - the DSO name can be >> propagated via the build-system. The one availa

Re: [PATCH weston] libweston/compositor-drm: Reset repaint scheduled status when setting DPMS level to off

2018-03-09 Thread Daniel Stone
Hi Marius, On 7 March 2018 at 17:36, Marius Vlad wrote: > Otherwise when setting dpms level DPMS_ON, weston_output_schedule_repaint() > will bail out early and never get a chance to wake up the output. > > Arguably this could also be done in drm_set_dpms() when setting > dpms_off_pending > but I

Re: [PATCH weston] ivi-layout-test: Fix compilation error

2018-03-09 Thread Daniel Stone
Hi Philippe, On 8 March 2018 at 18:16, Philippe Normand wrote: > Sorry, this patch won't apply on master because there's no such ivi- > layout-test.c file in tests/ Right, in master it's called ivi_layout-test-plugin.c. In the atomic series, I renamed the file in one of the commits to add suppor