Re: [PATCH weston 00/25] A new touchscreen calibrator

On Mon, Mar 26, 2018 at 2:36 AM, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Fri, 23 Mar 2018 09:33:10 -0700 > Jason Gerecke <killert...@gmail.com> wrote: > >> Nice! Do you think its reasonable to extend the allowed use of this >> protocol to other kinds of

Re: [PATCH weston 00/25] A new touchscreen calibrator

Nice! Do you think its reasonable to extend the allowed use of this protocol to other kinds of direct-input devices? I don't see anything which would prevent this protocol from working equally well to calibrate the pen input for a tablet PC or Cintiq for example. The compositor would need to

[PATCH weston] compositor-rdp: Correct mouse scrolling direction

causes window contents to scroll down and button 5 to be reported to xwayland clients. The xfreerdp client does not seem to be the cause of this since scrolling works correctly when connecting to a Windows host. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- libweston/compositor-rdp

Re: [PATCH xserver] xwayland: Support for BTN_STYLUS3 kernel events

On Thu, Nov 9, 2017 at 2:19 PM, Jason Gerecke <killert...@gmail.com> wrote: > On Tue, Nov 7, 2017 at 2:37 PM, Peter Hutterer <peter.hutte...@who-t.net> > wrote: >> On Tue, Nov 07, 2017 at 11:09:44AM -0800, Jason Gerecke wrote: >>> BTN_STYLUS3 has been introduced b

Re: [PATCH weston v3 00/17] Tablet device support for weston

On Tue, Dec 19, 2017 at 12:33 AM, Maniraj Devadoss wrote: > Hi Jason, > > I found the root cause for the backtrace you shared > https://lists.freedesktop.org/archives/wayland-devel/2017-November/035964.html > > The issue is that the tablet tool's surface and view is

Re: [PATCH weston v2 00/16] Tablet device support for weston

On Thu, Nov 23, 2017 at 2:17 AM, Maniraj Devadoss <maniraj.devad...@in.bosch.com> wrote: > Hi, > > The previous posting of this series was at > https://lists.freedesktop.org/archives/wayland-devel/2017-October/035534.html > > which had some issues when Jason Gerecke <

Re: [PATCH weston 00/16] Tablet device support for weston

Tel. +91 80 6136-4382 > > > -Original Message- > From: wayland-devel [mailto:wayland-devel-boun...@lists.freedesktop.org] On > Behalf Of Jason Gerecke > Sent: Tuesday, November 7, 2017 8:52 AM > To: Bastian Farkas <bfar...@de.adit-jv.com> > Cc: wayland-devel@lists.f

Re: [PATCH xserver] xwayland: Support for BTN_STYLUS3 kernel events

On Tue, Nov 7, 2017 at 2:37 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Tue, Nov 07, 2017 at 11:09:44AM -0800, Jason Gerecke wrote: >> BTN_STYLUS3 has been introduced by the Linux 4.15 kernel to report the >> status of the third button present on Wacom's ne

[PATCH xserver] xwayland: Support for BTN_STYLUS3 kernel events

BTN_STYLUS3 has been introduced by the Linux 4.15 kernel to report the status of the third button present on Wacom's new "Pro Pen 3D" stylus. Treat this button like xf86-input-wacom and send a button 8 event ("navigate back") when received from Wayland. Signed-off-by: Jason

Re: [PATCH weston 00/16] Tablet device support for weston

On Wed, Oct 25, 2017 at 4:12 AM, Bastian Farkas wrote: > Hi, > > with Peter Hutterers permission I modified an outdated patchset from him that > adds support for tablet devices to the weston compositor. Several minor > changes were needed to get the patches working with

Re: [PATCH libinput 2/2] pad: use libwacom to get the evdev to button number mapping

t; + litest_assert_pad_button_event(li, > + i, > + > LIBINPUT_BUTTON_STATE_RELEASED); > + } > + > + > + libwacom_destroy(wac

Re: [PATCH libinput] udev: add quirk for Chalkboard Electronics HID Touchscreen

On Thu, Sep 21, 2017 at 7:00 AM, Matt Porter wrote: > On Thu, Sep 21, 2017 at 10:59:08AM +0200, Hans de Goede wrote: >> Hi, >> >> On 19-09-17 18:41, Matt Porter wrote: >> > The Chalkboard Electronics HID Touchscreen is classified as >> > a tablet device by systemd udev

Re: [PATCH libinput] evdev: accept accelerometers if they are tagged as other devices too

.code = ABS_MISC, .value = 0 }, > + { .type = EV_SYN, .code = SYN_REPORT, .value = 0 }, > + { .type = -1, .code = -1 }, > +} ; > + > +static struct litest_device_interface interface = { > + .touch_down_events = down, > + .touch_move_events = move, > + .pad_ring_st

Re: [PATCH libinput] lid: disable all types but EV_SYN and EV_SW

a more capable animal. Reviewed-by: Jason Gerecke <jason.gere...@wacom.com> Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t take seven from three,/ So you look at the sixty-fours > &

Re: [RFC wayland-protocols] Color management protocol

On Mon, Dec 19, 2016 at 7:04 AM, James Feeney wrote: > On 12/19/2016 03:04 AM, Pekka Paalanen wrote: >> We very deliberately avoid defining any "standard" Wayland interfaces >> for configuring a compositor, because every compositor is different. >> With X11, you had the one

Re: [PATCH wayland-protocols] tablet: specify the tool button numbers are simply sequentially numbered

On 11/03/2016 06:46 PM, Peter Hutterer wrote: > We're using sequentially numbered buttons for the pad because actual tablets > are quite varied in how the present buttons (BTN_A, BTN_0, etc.). For this > reason, libinput numbers pad buttons sequentially. > > Let's do the same for tablet tools.

Re: weston and graphics tablet support?

On 10/27/2016 10:22 PM, Peter Hutterer wrote: > Time to discuss graphics tablet support in weston: I had a patchset for some > earlier version of the tablet protocol, since then we've added a few bits > and bobs, including the mode switching support. > > Short story behind this email is: I

Re: [PATCH v2 libinput 6/6] tablet: add touch arbitration

t; > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> The revised series looks good to me -- thanks again :) Reviewed-by: Jason Gerecke <jason.gere...@wacom.com> Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, e

Re: [PATCH libinput 6/6] tablet: add touch arbitration

The first 5 patches look fine, but I have a few questions about this one, especially in the unit tests: On 08/21/2016 11:14 PM, Peter Hutterer wrote: > So far we've relied on the wacom kernel module to do touch arbitration for us > but that won't be the case in upcoming kernels. Implement touch

Re: [PATCH v2 libinput] tablet: if a serial comes in late, discard it

/* Same as above, but don't bother checking the serial number */ > - list_for_each(t, tool_list, link) { > + * list > + * Same as above, but don't bother checking the serial number > + */ > + list_for_each(t, >tool_list, lin

Re: [PATCH libinput] tablet: don't send tip up/button release/prox out events for unknown tools

On 08/17/2016 10:20 PM, Peter Hutterer wrote: > If the kernel does not send the MSC_SERIAL information with every event, we > end up creating a tool with a serial of 0. When the MSC_SERIAL comes in > later for this tool libinput will think it's a new tool. On proximity out of > that new tool we

Re: [PATCH wayland-protocols v5 4/4] tablet: Add pad support to the tablet protocol

ffectively sets of button/ring/strip > configurations. Those groups may have multiple modes each, so that > users/clients may map several actions to a single element. > > Signed-off-by: Carlos Garnacho <carl...@gnome.org> > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.

Re: [PATCH v4 wayland-protocols 4/4] tablet: Add pad support to the tablet protocol

st which enables a >>>> client >>>> to set a user-defined string to display for an OSD on the current mappings. >>>> This request is available for buttons, rings and strips. >>>> >>>> Finally, the pad supports groups, effectively sets

Re: [PATCH v2 libinput 00/10] pad: add a mode toggle API

n an upstream kernel I'll update the implementation, for now we go with > this one. > > Cheers, > Peter Aside from the small comments on two of the patches, this looks good to me. Testing also seems to look good aside from the not-yet-implemented direct mode switching on my 24HD. Revi

Re: [PATCH v2 libinput 05/10] pad: Add a new API for modes and mode groups

On 06/14/2016 11:37 PM, Peter Hutterer wrote: > Move mode control to libinput. This reduces some flexibility on what we can do > with modes but makes it a lot easier for anyone to implement modes correctly > and have the LEDs apply appropriately, etc. Let's go with the option to make > the 95%

Re: [PATCH libinput 6/7] Implement tablet pad group mode support

On Sun, Jun 5, 2016 at 11:50 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > configure.ac | 2 +- > src/Makefile.am | 1 + > src/evdev-tablet-pad-leds.c | 621 >

Re: [PATCH libinput 5/7] pad: Add a new API for modes and mode groups

On Sun, Jun 5, 2016 at 11:50 PM, Peter Hutterer wrote: > Move mode control to libinput. This reduces some flexibility on what we can do > with modes but makes it a lot easier for anyone to implement modes correctly > and have the LEDs apply appropriately, etc. Let's go

Re: [PATCH v3 wayland-protocols 4/4] tablet: Add pad support to the tablet protocol

On 05/17/2016 03:02 AM, Carlos Garnacho wrote: > Hey :), > > On Tue, May 17, 2016 at 2:50 AM, Peter Hutterer > wrote: >> On Tue, May 17, 2016 at 01:30:03AM +0200, Carlos Garnacho wrote: >>> Hey :), >>> >>> On Wed, May 11, 2016 at 4:51 AM, Peter Hutterer >>>

Re: [PATCH v3 wayland-protocols 4/4] tablet: Add pad support to the tablet protocol

On Tue, May 10, 2016 at 7:51 PM, Peter Hutterer wrote: > From: Carlos Garnacho > > The pad's interface is similar to the tool interface, a client is notified of > the pad after the tablet_added event. > > The pad has three functionalities: buttons,

Re: [PATCH wayland-protocols 3/4] tablet: restrict the cursor surface to one per tool

On Tue, May 10, 2016 at 7:51 PM, Peter Hutterer wrote: > The initial approach was to allow one surface to be re-used between tools, > seats and even used together as wl_pointer cursor surface. This has a few > drawbacks, most of which are related to managing the surface

Re: [PATCH libinput] tablet: fix distance normalization range after 25a9f39

/bugs.freedesktop.org/show_bug.cgi?id=95074 > > And while we're at it, sneak in a test for pressure ranges too. > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Looks good to me -- Reviewed-by: Jason Gerecke <jason.gere...@wacom.com> Jason --- Now instead of four i

Re: [PATCH v2 wayland-protocols] Add pad support to the tablet protocol

On Thu, Apr 21, 2016 at 7:02 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Thu, Apr 21, 2016 at 05:46:24PM -0700, Jason Gerecke wrote: >> On Mon, Apr 18, 2016 at 10:00 PM, Peter Hutterer >> <peter.hutte...@who-t.net> wrote: >> > From

Re: [PATCH v2 wayland-protocols] Add pad support to the tablet protocol

On Mon, Apr 18, 2016 at 10:00 PM, Peter Hutterer wrote: > From: Carlos Garnacho > > The pad's interface is similar to the tool interface, a client is notified of > the pad after the tablet_added event. > > The pad has three functionalities: buttons,

Re: [PATCH v2 libinput 0/5] Add tablet pad support

) to the more explicitly named > libinput_event_tablet_pad_get_button_number(). Just to drive the point home. > > Cheers, > Peter Just a few small issues highlighted in their respective patches (esp. in patch 4), but nothing that I think is beyond a pre-push fixup. Reviewed-by: Jas

Re: [PATCH v2 libinput 2/5] Add the LIBINPUT_DEVICE_CAP_TABLET_PAD capability and matching interface

On 04/10/2016 09:15 PM, Peter Hutterer wrote: > This interface handles the buttons on the physical tablet itself, including > the touch ring and the strip. > > A notable difference to other libinput interfaces here is that we do not use > linux/input.h event codes for buttons. Instead, the

Re: [PATCH v2 libinput 4/5] pad: implement wacom pad support

On 04/10/2016 09:15 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > Adjustments for the new API in 2/5 > > src/Makefile.am| 1 + > src/evdev-tablet-pad.c | 614 > + > src/evdev-tablet-pad.h |

Re: [PATCH libinput] tablet: add a fuzz-filter to avoid spamming callers with subpixel updates

) since the lack of fuzz isn't a huge issue but is still something that should be fixed? Reviewed-by: Jason Gerecke <jason.gere...@wacom.com> Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t tak

Re: [PATCH v7 wayland-protocols] Add the tablet protocol

On 03/08/2016 10:10 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > Reviewed-by: Daniel Stone > Reviewed-by: Jonas Ådahl > --- > Changes to v6: > - a bunch of typos/grammar fixes > - clarified the "down" event on

Re: [PATCH v6 wayland-protocols] Add the tablet protocol

A number of tiny fixes, and a couple of questions: On 02/29/2016 04:09 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > Reviewed-by: Daniel Stone > --- > Changes to v5: > - remove leftover statement falsely claminig

Re: [PATCH libinput] tablet: use the tilt resolution if we have it

y the subtle need for "range_max"). You might consider having the normalization only occur in the 'else' case so that the 'if' can be written more straightforwardly: double value; const int WACOM_MAX_DEGREES = 64; if ( /* can use resolution */ ) { value = 180.0/M_PI * absinfo->value/absinfo

Re: [PATCH libinput] tablet: change tilt axes to use degrees

@@ -251,8 +263,8 @@ convert_tilt_to_rotation(struct tablet_dispatch *tablet) >values. The device has a 175 degree CCW hardware offset but since > we use >atan2 the effective offset is just 5 degrees. >*/ > - x = tablet->axes.tilt.x; >

Re: [PATCH v3 wayland-protocols] Add the tablet protocol

On Tue, Feb 2, 2016 at 1:12 PM, Bill Spitzak <spit...@gmail.com> wrote: > > > On Mon, Feb 1, 2016 at 6:38 PM, Jason Gerecke <killert...@gmail.com> wrote: >> >> >> Ultimately, the tilt information is almost universally used by >> applications to set b

Re: [PATCH v3 wayland-protocols] Add the tablet protocol

On Sun, Jan 31, 2016 at 2:27 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Fri, Jan 29, 2016 at 11:40:44AM -0800, Jason Gerecke wrote: >> On Thu, Jan 28, 2016 at 8:32 PM, Peter Hutterer >> <peter.hutte...@who-t.net> wrote: >> > Signed-off-by: Pete

Re: [PATCH v3 wayland-protocols] Add the tablet protocol

On Mon, Feb 1, 2016 at 4:55 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Mon, Feb 01, 2016 at 04:12:24PM -0800, Jason Gerecke wrote: >> On Sun, Jan 31, 2016 at 2:27 PM, Peter Hutterer >> <peter.hutte...@who-t.net> wrote: >> > On Fri, Jan 29, 201

Re: [PATCH v3 wayland-protocols] Add the tablet protocol

On Thu, Jan 28, 2016 at 8:32 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > Changes to v2: > - renamed hwserial to hardware_serial > - renamed to hwid event to a hardware_id_wacom. no-one else uses this ID > type, so having

Re: [PATCH libinput] tablet: allow the various get_ on tablet button events

shared between the various events, > treating button events separately here doesn't get us any benefit. > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Still not convinced about providing axis info in the tip and button events, but its not my API to design :D Acked

Re: [PATCH libinput 0/7] tablet: add support for relative x/y motion deltas

anyway. > > Pointer acceleration is quite simple atm, it's a flat profile and the speed > setting simply multiplies the vector. Can be extended later if need be. > > Cheers, > Peter Looks good! I don't see any obvious problems, though I'm still not 100% familiar with the codeba

Re: [PATCH libinput 3/5] tablet: add pressure threshold handling

'On Mon, Jan 4, 2016 at 5:21 PM, Peter Hutterer wrote: > On tablets with ABS_PRESSURE use a pressure value to determine tip state, not > BTN_TOUCH. This enables us (down the road) to have device-specific pressure > thresholds. For now we use a 5% default for all devices.

Re: [PATCH libinput 4/5] tablet: a tip event can replace an axis event

On Mon, Jan 4, 2016 at 5:21 PM, Peter Hutterer wrote: > When we're only dealing with BTN_TOUCH we can make the tip event independent > of the axis event. Now that we handle pressure thresholds to trigger tip state > this does not work, we'd have to send an axis event

Re: [PATCH libinput 0/5] tablet: pressure threshold handling

Largely looks good, aside from a few comments. For the series: Acked-by: Jason Gerecke <jason.gere...@wacom.com> Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t take seven from three,

Re: [PATCH libinput] tablet: insert "STATE" into proximity/tip states

and the Amazing Technicolor Bikeshed? :) (but seriously: yay for consistency!) Reviewed-by: Jason Gerecke <jason.gere...@wacom.com> Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t take s

Re: [PATCH libinput 6/8] tablet: support tool-specific pressure offsets

On Sun, Dec 6, 2015 at 8:22 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Thu, Dec 03, 2015 at 07:57:30PM -0800, Jason Gerecke wrote: >> On Wed, Dec 2, 2015 at 5:03 PM, Peter Hutterer <peter.hutte...@who-t.net> >> wrote: >> > On Wed, Dec 02, 201

Re: [PATCH libinput 6/8] tablet: support tool-specific pressure offsets

On Wed, Dec 2, 2015 at 5:03 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Wed, Dec 02, 2015 at 04:21:56PM -0800, Jason Gerecke wrote: >> On Tue, Dec 1, 2015 at 5:46 PM, Peter Hutterer <peter.hutte...@who-t.net> >> wrote: >> > If a tool wears ou

Re: [PATCH libinput 6/8] tablet: support tool-specific pressure offsets

On Tue, Dec 1, 2015 at 5:46 PM, Peter Hutterer wrote: > If a tool wears out, it may have a pre-loaded pressure offset. In that case, > even when the tool is not physically in contact with the tablet surface it > will send pressure events. > > The X.Org wacom driver has

Re: [PATCH wayland-protocols] Add the tablet protocol

On Fri, Nov 6, 2015 at 4:11 PM, Bill Spitzak wrote: > Having read this more carefully, the cursor scheme absolutely will not work. > > The main problem is that the client may want to choose a cursor for a tool > based on the location at which it came into proximity. It cannot

Re: [PATCH libinput 6/6] tablet: rename all tool types to LIBINPUT_TOOL_TYPE_*

On Thu, Nov 5, 2015 at 8:55 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> The weston patches are going to have to be modified to work with this API change, but otherwise... For the series: Reviewed-by: Jason Gere

Re: [PATCH wayland-protocols] Add the tablet protocol

+ be sent until the button is actually released or the tool leaves the > + proximity of the tablet. > + > + > + > + > + > + Sent whenever the tablet tool comes in contact with the surface of the > + tablet. If the tablet tool moves out

Re: [PATCH weston 00/13] Add tablet support

On Thu, Nov 5, 2015 at 8:31 PM, Peter Hutterer wrote: > > This set adds support for graphics tablets to weston. It's not fully > complete, there are a couple of fixmes in it but the patchset is getting a > bit unwieldly. And there are some discussions on how to do things

[PATCH libinput] doc: fix more typos

Signed-off-by: Jason Gerecke jason.gere...@wacom.com --- doc/absolute-axes.dox | 2 +- doc/faqs.dox | 2 +- doc/gestures.dox | 2 +- doc/palm-detection.dox | 4 ++-- doc/reporting-bugs.dox | 2 +- doc/seats.dox | 4 ++-- doc/tapping.dox| 2 +- doc/tools.dox

Re: [PATCH libinput] tablet: Do not create a tablet device for Wacom touchscreens

On 8/17/2015 7:21 PM, Peter Hutterer wrote: On Mon, Aug 17, 2015 at 05:29:14PM -0700, Jason Gerecke wrote: Similar to the issue mentioned in the commit message of 2365f7d, libwacom assigns both ID_INPUT_TABLET and ID_INPUT_TOUCHSCREEN to touchscreens like the Cintiq 24HDT. This patch ensures

[PATCH libinput] tablet: Do not create a tablet device for Wacom touchscreens

Similar to the issue mentioned in the commit message of 2365f7d, libwacom assigns both ID_INPUT_TABLET and ID_INPUT_TOUCHSCREEN to touchscreens like the Cintiq 24HDT. This patch ensures that neither touchpads nor touchscreens will accidentally be handled by the tablet code. Signed-off-by: Jason

Re: [PATCH libinput] touchpad: count the tapping fingers separately from the main touchpad code

if five or more fingers are physically present (due to the behavior of 'tp_unhover_touches' mentioned in the bug report). That said, the patch *does* prevent the error messages from appearing, so at the very least: Tested-by: Jason Gerecke jason.gere...@wacom.com Jason --- Now instead of four

Re: [PATCH libinput v2 0/4] touchpad gestures support

with the 3 cm heuristic (about half the time I try to scroll, its interpreted as a pinch) but I'd probably get used to it after a little use. Acked-by: Jason Gerecke jason.gere...@wacom.com [1]: https://bugs.freedesktop.org/show_bug.cgi?id=89800 Jason --- Now instead of four in the eights

[PATCH libinput] tools: List relative wheel among axis capabilities

Signed-off-by: Jason Gerecke jason.gere...@wacom.com --- For Peter's tablet-support branch. tools/event-debug.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/event-debug.c b/tools/event-debug.c index d2ac415..e8e49cd 100644 --- a/tools/event-debug.c +++ b/tools/event-debug.c

Re: [RFC v2 libinput 2/2] buttonset: implement buttonset handling for Wacom tablet pads

Did some practical testing of these patches and noticed two issues with the touchstrips: On 3/17/2015 11:58 PM, Peter Hutterer wrote: From: Benjamin Tissoires benjamin.tissoi...@gmail.com Same approach as evdev-tablet (started as copy/paste), with axis and buttons adjusted. Wacom's handling

[PATCH libinput] evdev: Do not mark tablet touchscreens as tablets

Devices like the Cintiq 24HDT are marked with both ID_INPUT_TABLET and ID_INPUT_TOUCHSCREEN in udev. Be sure that we don't try to use such a device as a tablet. Signed-off-by: Jason Gerecke killert...@gmail.com --- For Peter's tablet-support branch. src/evdev.c | 10 +- 1 file changed

Re: [RFC v2 libinput 2/2] buttonset: implement buttonset handling for Wacom tablet pads

David's already asked the API questions that popped in my head, so I'll just wait for feedback on his thread. As far as this patch goes, things look pretty good though there are two comments: On 3/17/2015 11:58 PM, Peter Hutterer wrote: From: Benjamin Tissoires benjamin.tissoi...@gmail.com

Re: [PATCH v2 libinput 00/26] tablet: support the remaining tools

On 2/23/2015 10:21 PM, Peter Hutterer wrote: This is a v2 of the patchset here http://lists.freedesktop.org/archives/wayland-devel/2015-February/020036.html but reshuffled, rebased and a couple of things merged in. Notable: libinput now uses libwacom to get tool/tablet information. This is

Re: [PATCH libinput 19/26] tablet: support z-rotation for the mouse/lens tool

On 2/23/2015 10:21 PM, Peter Hutterer wrote: Needs to be calculated from the x/y tilt values, the mouse has a fixed offset of 175 degrees counterclockwise. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 88

Re: [PATCH libinput 21/26] tablet: support artpen rotation

On 2/23/2015 10:21 PM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 35 +++- src/evdev-tablet.h | 6 src/libinput.h | 3 +- test/tablet.c | 95 ++ 4

Re: [PATCH libinput 23/26] tools: only print the tablet axes we have on the tool

On 2/23/2015 10:21 PM, Peter Hutterer wrote: This doesn't really have an effect, since we don't set the per-tool axes correctly yet. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/event-debug.c | 106 +++- 1 file changed, 56

Re: [PATCH libinput 12/26] tablet: explicitly ignore ABS_THROTTLE, ABS_RX, ABS_RY, and ABS_RZ

On 2/23/2015 10:21 PM, Peter Hutterer wrote: ABS_THROTTLE: Tablets still advertise this axis but the mouse itself isn't available anymore. The Pad sends the second wheel as ABS_THROTTLE but that's a task for the buttonset interface. Explanation of what the throttle

Re: [PATCH libinput 00/15] tablet: support the remaining tools

On 2/17/2015 9:45 PM, Peter Hutterer wrote: This patchset adds the remaining tools to the tablet branch (at least for Wacom tools). The notable additions are: * rotation support for mouse/lens cursor * rotation support for the artpen * 'wheel' support for the airbrush * correct per-tool

Re: [RFC libinput 1/2] Add a buttonset interface for button-only devices

On Wed, Feb 18, 2015 at 5:29 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Feb 18, 2015 at 01:57:17PM -0800, Jason Gerecke wrote: On 2/16/2015 9:11 PM, Peter Hutterer wrote: On Mon, Feb 16, 2015 at 08:13:01AM +0100, Hans de Goede wrote: Hi, On 16-02-15 04:50, Peter Hutterer

Re: [RFC libinput 1/2] Add a buttonset interface for button-only devices

On 2/16/2015 9:11 PM, Peter Hutterer wrote: On Mon, Feb 16, 2015 at 08:13:01AM +0100, Hans de Goede wrote: Hi, On 16-02-15 04:50, Peter Hutterer wrote: snip ok, I've played around with the ideas in this thread and discussed it with Benjamin this morning. Short summary: I think we should go

[PATCH libinput 2/3] Implement support for pen barrel rotation

Some Wacom tablets can report the rotation of the pen about its barrel in the ABS_Z axis. Report this via LIBINPUT_TABLET_AXIS_TWIST. Signed-off-by: Jason Gerecke killert...@gmail.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 6 ++ src/evdev-tablet.h | 6

[PATCH libinput 1/3] Deduplicate and rename normalization functionality

Changes the names to reflect the functionality, not the use case. Also defines one in terms of the other so that we aren't repeating ourselves. Signed-off-by: Jason Gerecke killert...@gmail.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 15 ++- 1 file

[PATCH libinput 3/3] Add tests for pen rotation

Signed-off-by: Jason Gerecke killert...@gmail.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest-wacom-intuos-tablet.c | 3 +++ test/tablet.c | 41 +-- 2 files changed, 42 insertions(+), 2 deletions(-) diff --git a/test

Re: [PATCH libinput 2/3] Implement support for pen barrel rotation

rotation regardless of tilt. Having said, I do like the term roll, better than twist. Cheers, Peter On 12/08/2014 09:59 AM, Jason Gerecke wrote: --- a/src/libinput.h +++ b/src/libinput.h @@ -277,7 +277,8 @@ enum libinput_tablet_axis { LIBINPUT_TABLET_AXIS_PRESSURE = 3

[PATCH] Remove spurious addition from range normalization calculation

The presence of a +1 in the range calculation prevents the normalization functions from returning a value of 1.0 when absinfo-value has reached its maximum. Signed-off-by: Jason Gerecke killert...@gmail.com --- src/evdev-tablet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH libinput] Fix normalization functions

We need to *subtract*, not *add* the minimum to determine the range-effective value. For example: if (min, current, max) is (100, 100, 1000) then the normalized value would be 0.0, not 0.2. Signed-off-by: Jason Gerecke killert...@gmail.com --- This patch should be applied to the 'tablet-support

Re: [PATCH weston 00/19] Basic tablet support in Weston

On Aug 19, 2014 5:04 AM, Pekka Paalanen ppaala...@gmail.com wrote: On Wed, 6 Aug 2014 19:07:50 -0400 Stephen Chandler Paul thatsly...@gmail.com wrote: Hi! As some of you have been aware, I have been working on implementing tablet ssupport in libinput, the wayland protocol and weston. This

Re: wl_tablet draft v2

On Sat, Aug 2, 2014 at 12:31 PM, Lyude thatsly...@gmail.com wrote: I'm sorry I took so long to reply to this! I only just found this e-mail while I was cleaning my inbox up. On Wed, 2014-07-30 at 17:33 -0700, Jason Gerecke wrote: On Tue, Jul 29, 2014 at 12:44 PM, Lyude thatsly...@gmail.com

Re: wl_tablet draft v2

/ (That is to say, eight) to the two, / But you can’t take seven from three,/ So you look at the sixty-fours On Tue, 2014-07-29 at 10:07 -0700, Jason Gerecke wrote: On Mon, Jul 28, 2014 at 10:54 AM, Bill Spitzak spit...@gmail.com wrote: On 07/28/2014 09:41 AM, Jason Gerecke wrote

Re: wl_tablet draft v2

On Mon, Jul 28, 2014 at 10:54 AM, Bill Spitzak spit...@gmail.com wrote: On 07/28/2014 09:41 AM, Jason Gerecke wrote: Normalizing the data is fine, but the resolution data needs to be available somewhere as well. The GTK+ API doesn't require anything more than the former, but Qt requires

Re: wl_tablet draft v2

On Wed, Jul 16, 2014 at 5:08 PM, Lyude thatsly...@gmail.com wrote: On Mon, 2014-07-14 at 13:25 -0700, Jason Gerecke wrote: On Sun, Jul 13, 2014 at 12:17 PM, Lyude thatsly...@gmail.com wrote: wl_tablet specifications Version 2

Re: wl_tablet draft v2

On Sun, Jul 13, 2014 at 12:17 PM, Lyude thatsly...@gmail.com wrote: wl_tablet specifications Version 2 General notes: - Many of the axis values in this are normalized to either 0-65535 or (-65535)-65535. I would leave the axis

Re: Window placement

On Wed, Jul 2, 2014 at 3:33 PM, Fabrice Rey faboune...@gmail.com wrote: The question is: what action triggers it to make this ring of icons appear? A global shortkey (and yes I know it's not yet possible on Wayland, that's another problem on its own). What's the application doing? Does it

Re: wl_tablet specification draft

On Mon, Jun 30, 2014 at 3:46 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On 30/06/2014 20:23 , Pekka Paalanen wrote: On Mon, 30 Jun 2014 09:33:15 +0300 Pekka Paalanen ppaala...@gmail.com wrote: On Mon, 30 Jun 2014 11:08:35 +1000 Peter Hutterer peter.hutte...@who-t.net wrote: On

Re: [PATCH libinput] Add functions to get the device name, PID and VID

On Thu, Jun 26, 2014 at 8:02 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Those three are the ones that matter for logging or device identification in callers, so let's provide them. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Have you thought about how to handle

Re: wl_tablet specification draft

On Thu, Jun 26, 2014 at 12:12 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Jun 26, 2014 at 09:48:37AM +0300, Pekka Paalanen wrote: Hi, it seems you forgot to reply-to-all, so I have re-added everyone and not trimmed the quotation. On Wed, 25 Jun 2014 18:37:08 -0400 Lyude

Re: Comments about adding tablet support to Wayland

On Wed, Jun 25, 2014 at 5:50 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Replying to three emails at once here to keep the thread a bit more managable. On Wed, Jun 25, 2014 at 01:38:22PM -0700, Jason Gerecke wrote: On Wed, Jun 25, 2014 at 12:38 AM, Lyude thatsly...@gmail.com wrote

Re: Comments about adding tablet support to Wayland

On Wed, Jun 25, 2014 at 12:38 AM, Lyude thatsly...@gmail.com wrote: On Wed, 2014-06-25 at 11:06 +0400, Dmitry Kazakov wrote: Hi, all! I am a developer from Krita painting application team. We recently did quite much work on incorporating better tablet support in Krita. I have several

Re: [PATCH libinput 0/24] Tablet support

On Tue, May 27, 2014 at 3:20 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, May 27, 2014 at 04:32:14PM -0400, Chandler Paul wrote: On Tue, 2014-05-27 at 13:11 -0700, Jason Gerecke wrote: I've been away from my computer for most of the (long) weekend up here, so apologies

Re: [PATCH libinput 0/24] Tablet support

On Tue, May 27, 2014 at 3:52 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, May 27, 2014 at 01:11:31PM -0700, Jason Gerecke wrote: I've been away from my computer for most of the (long) weekend up here, so apologies for being a bit quiet :) On Sun, May 25, 2014 at 7:13 PM, Peter

Re: [PATCH libinput 0/24] Tablet support

On Thu, May 22, 2014 at 8:45 AM, Bill Spitzak spit...@gmail.com wrote: - One device has 2 strips, which report on ABS_RX/RY (radial??). Min/max are 0..4096, but the reported values are 1,2,4,8,16... So effectively a log2 scale, or more graphically a bit shifting over a bunch of

Re: [PATCH libinput 0/24] Tablet support

On Wed, May 21, 2014 at 10:17 PM, Chandler Paul thatsly...@gmail.com wrote: Hi! Sorry this took so long to write, I've been spending a lot of my time recently trying to understand the libinput code and all of that good stuff, and I wanted to make sure I had a decent understanding of it before