the opening /* even if there was whitespace at the start of
the very first line.
Only emits a */ if a /* was printed.
Signed-off-by: Derek Foreman <der...@osg.samsung.com>
Looks good to me:
Reviewed-by: Jon A. Cruz <j...@osg.samsung.com>
---
src/scanner.c | 16 ++---
Adds an initial implementation of a testing tool that uses the unit
test framework to run checks against an arbitrary Wayland compositor.
Note that this is not intended for Weston-specific testing, but for
generic Wayland testing.
Signed-off-by: Jon A. Cruz <j...@osg.samsung.com>
---
C
Cleaned up test runner script to unify sections launching weston.
This makes the sections more legible and differences easier to spot.
Signed-off-by: Jon A. Cruz <j...@osg.samsung.com>
---
tests/weston-tests-env | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
Cleaned up test runner script to unify sections launching weston.
This makes the sections more legible and differences easier to spot.
Signed-off-by: Jon A. Cruz <j...@osg.samsung.com>
---
tests/weston-tests-env | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
On 11/05/2015 10:17 AM, Pekka Paalanen wrote:
> On Fri, 16 Oct 2015 12:23:47 -0700
> "Jon A. Cruz" <j...@osg.samsung.com> wrote:
>
>> On 10/15/2015 01:51 AM, Pekka Paalanen wrote:
>>> I think it's better to land this stuff in pieces than massage a
>
Fixed instance where spaces were used instead of tabs.
Changes since v1:
* rebased
Signed-off-by: Jon A. Cruz <j...@osg.samsung.com>
---
src/wayland-server-core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/wayland-server-core.h b/src/wayland-server-core.h
Generated code was unconditionally adding a space to lines
in comments for copyright blocks even if the line was blank.
Updated to not add trailing whitespace for blank lines.
Signed-off-by: Jon A. Cruz <j...@osg.samsung.com>
---
src/scanner.c | 3 ++-
1 file changed, 2 insertions(+), 1 de
Fixed instances where spaces were used instead of tabs.
Signed-off-by: Jon A. Cruz <j...@osg.samsung.com>
---
src/wayland-client-core.h | 2 +-
src/wayland-server-core.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/wayland-client-core.h b/src/wayland-client-
A few of the header files had function prototypes that were not
following project conventions, sometimes even in the same file.
Corrected these to follow as per wayland-os.h.
Signed-off-by: Jon A. Cruz <j...@osg.samsung.com>
---
src/wayland-client-core.h
* Clarify documentation on ZUC_ASSERT_* behavior in regards to return
vs. abort()
* Added overview section on return behavior.
* Fixed spelling
* Removed outdated reference to tap function.
Changes since v1:
* Incorporated grammatical feedback.
Signed-off-by: Jon A. Cruz &l
This patch addresses some feedback of review from unrelated changes
of adding waycheck. Since that review pointed out some lack of
clarity in return behavior, it seemed appropriate to address it
independent of adding waycheck.
Jon A. Cruz (1):
zunitc: Clarify documentation on return behavior
During review of the addition of waycheck, it was pointed out that there
could be problems due to ZUC_TEST_F() creating an input parameter with a
hidden implicit name. This change addresses that by making the name of
the passed in parameter a required third input on the ZUC_TEST_F() macro.
Jon
Instead of using the implicit name 'data', changed the test
with fixture macro ZUC_TEST_F() to use an additional value
to explicitly set the name to use for test data from the
fixture.
Signed-off-by: Jon A. Cruz <j...@osg.samsung.com>
---
tests/config-parser-test.c
* Clarify documentation on ZUC_ASSERT_* behavior in regards to return
vs. abort()
* Added overview section on return behavior.
* Fixed spelling
* Removed outdated reference to tap function.
Signed-off-by: Jon A. Cruz <j...@osg.samsung.com>
---
tools/zunitc/doc/zunitc.dox
This patch addresses some feedback of review from unrelated changes
of adding waycheck. Since that review pointed out some lack of
clarity in return behavior, it seemed appropriate to address it
independent of adding waycheck.
Jon A. Cruz (1):
zunitc: Clarify documentation on return behavior
as a separate set might make juggling git a
little easier on me. But not to a degree to outweigh what would make
reviewing things easier.
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
j...@osg.samsung.com
___
wayland-devel ma
in the context of acceptance testing, while
leaving the third phase's submission to be useful for unit and/or
integration testing.
Jon A. Cruz (1):
tests: Adding simple waycheck validation tool.
.gitignore |1 +
Makefile.am| 56
Adds an initial implementation of a testing tool that uses the unit
test framework to run checks against an arbitrary Wayland compositor.
Note that this is not intended for Weston-specific testing, but for
generic Wayland testing.
Signed-off-by: Jon A. Cruz <j...@osg.samsung.com>
---
.git
Adds a config item to prevent doxygen from using absolute paths in
generated diagrams. This trims off the base directory during config to
leave just relative paths.
Signed-off-by: Jon A. Cruz <j...@osg.samsung.com>
---
doc/doxygen/tooldev.doxygen.in | 1 +
doc/doxygen/tools.doxygen.in |
.
With C++ code arrangement gets a bit more regular, with one .cpp per
class and one or two corresponding .h (foo.h and foo_internal.h) files
becoming the norm. Since we are not in that arena it is not a big factor.
Since we are dealing with C code, required layouts are much more liberated.
--
Jon
want that case :-)
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
j...@osg.samsung.com
signature.asc
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http
) \
-e 's|@bindir[@]|$(bindir)|g' \
-e 's|@abs_top_builddir[@]|$(abs_top_builddir)|g' \
-e 's|@abs_top_srcdir[@]|$(abs_top_srcdir)|g' \
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
j...@osg.samsung.com
-by: Jon A. Cruz j...@osg.samsung.com
---
Makefile.am | 9 +
configure.ac | 25 ++
tools/zunitc/src/zuc_junit_reporter.c | 470 ++
tools/zunitc/src/zuc_junit_reporter.h | 38 +++
tools/zunitc/src/zunitc_impl.c
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
Makefile.am| 9 +-
tests/config-parser-test.c | 371 +
2 files changed, 319 insertions(+), 61 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 0ab5b0a..118bafb 100644
.
- Relocated Doxygen specific input files to match Wayland structure.
Jon A. Cruz (3):
Enables output in the JUnit XML format.
Converted the config parser test to the new framework.
Adding doxygen setup and info for the testing framework.
.gitignore| 2
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
.gitignore | 2 +
Makefile.am| 22 +++
README | 6 +++
configure.ac | 20 ++
doc/doxygen/devtools.dox | 51 +
doc
On 07/07/2015 05:35 AM, Pekka Paalanen wrote:
On Thu, 2 Jul 2015 23:36:47 -0700
Jon A. Cruz j...@osg.samsung.com wrote:
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
.gitignore | 2 +
Makefile.am| 22 +++
configure.ac
On 07/07/2015 04:49 AM, Pekka Paalanen wrote:
On Thu, 2 Jul 2015 23:36:45 -0700
Jon A. Cruz j...@osg.samsung.com wrote:
Adds basic support for optionally outputting in the XML format
commonly used by JUnit compatible tools.
This format is supported by default by many tools, including
On 07/07/2015 05:08 AM, Pekka Paalanen wrote:
On Thu, 2 Jul 2015 23:36:46 -0700
Jon A. Cruz j...@osg.samsung.com wrote:
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
Makefile.am| 10 +-
tests/config-parser-test.c | 371
Factoring in the comments by Bryce, this looks good to me.
Acked-by: Jon A. Cruz j...@osg.samsung.com
On 07/14/2015 03:07 AM, Pekka Paalanen wrote:
From: Pekka Paalanen pekka.paala...@collabora.co.uk
What is libweston and where do we intend to go with it.
Cc: Giulio Camuffo giuliocamu
and config parsing
definitely fall into this area) and what functionality should eventually
migrate to live inside libweston can benefit from clarity on this
design intent.
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
j...@osg.samsung.com
On 07/02/2015 11:02 PM, Pekka Paalanen wrote:
On Thu, 02 Jul 2015 18:12:21 -0700
Jon A. Cruz j...@osg.samsung.com wrote:
On 06/25/2015 07:18 AM, Pekka Paalanen wrote:
On Sat, 20 Jun 2015 15:47:47 -0700
Jon A. Cruz j...@osg.samsung.com wrote:
+static void *setup_test_config(void *data
-by: Jon A. Cruz j...@osg.samsung.com
---
Makefile.am | 9 +
configure.ac | 26 ++
tools/zunitc/src/zuc_junit_reporter.c | 488 ++
tools/zunitc/src/zuc_junit_reporter.h | 38 +++
tools/zunitc/src/zunitc_impl.c
construction, including being able to specify the Wayland
instance to connect to.
- Reduced Doxygen config files to non-defaults only.
- Relocated Doxygen specific input files to match Wayland structure.
Jon A. Cruz (4):
Added simple unit/integration test framework and corresponding
test
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
.gitignore | 2 +
Makefile.am| 22 +++
configure.ac | 20 ++
doc/doxygen/devtools.dox | 51 +
doc/doxygen/tooldev.doxygen.in | 11
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
Makefile.am| 10 +-
tests/config-parser-test.c | 371 +
2 files changed, 320 insertions(+), 61 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 89d9e4c..42f0ed4 100644
On 06/25/2015 07:18 AM, Pekka Paalanen wrote:
On Sat, 20 Jun 2015 15:47:47 -0700
Jon A. Cruz j...@osg.samsung.com wrote:
+static void *setup_test_config(void *data)
+{
+ struct weston_config *config = load_config(data, true);
+
+ if (zuc_has_failure())
+ ZUC_MARK_FATAL
On 06/25/2015 07:18 AM, Pekka Paalanen wrote:
On Sat, 20 Jun 2015 15:47:47 -0700
Jon A. Cruz j...@osg.samsung.com wrote:
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
Makefile.am| 9 +-
tests/config-parser-test.c | 368
non-obvious that the both-null
case is the valid uninitialized situation and thus could warrant a
comment after all. Given that there already was some misreading of
Peter's intent, it might help maintenance to add a simple one.
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source
On 06/25/2015 05:36 AM, Pekka Paalanen wrote:
On Sat, 20 Jun 2015 15:47:44 -0700
Jon A. Cruz j...@osg.samsung.com wrote:
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
tools/zunitc/src/main.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/tools
On 06/24/2015 09:32 AM, Bill Spitzak wrote:
On Tue, Jun 23, 2015 at 9:55 PM, Jon A. Cruz j...@osg.samsung.com wrote:
Looking into it more, I think I've figured out much of that on my part
comes from C++ and other OO languages I've worked in. Especially with
C++ one should start a class
after a ivi_surface in render order is destoryed
Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp
Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk
Looks good.
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
---
tests/ivi_layout-test-plugin.c | 113
-surface, and
commit_changes
Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp
Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk
Looks good.
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
---
tests/ivi_layout-test-plugin.c | 134
...@collabora.co.uk
Looks good.
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
---
tests/ivi_layout-internal-test.c | 74
1 file changed, 74 insertions(+)
diff --git a/tests/ivi_layout-internal-test.c
b/tests/ivi_layout-internal-test.c
index 3fb5148..3b9d6b9
Tanibata nobuhiko_tanib...@xddp.denso.co.jp
Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk
Looks good.
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
---
tests/ivi-test.h | 4
tests/ivi_layout-test-plugin.c | 42
With those details explained, this looks good.
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
On 06/23/2015 05:56 AM, Pekka Paalanen wrote:
On Mon, 22 Jun 2015 17:28:23 -0700
Jon A. Cruz j...@osg.samsung.com wrote:
On 06/21/2015 11:33 PM, Nobuhiko Tanibata wrote:
From: Nobuhiko Tanibata
order with bad parameter
- destroy ivi-layer in the ivi-screen and call commit_changes
Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp
Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk
Looks good.
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
---
tests/ivi_layout
of ivi-layers in ivi-screen
Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp
Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk
Looks good.
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
---
tests/ivi_layout-internal-test.c | 105
Looks good.
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
---
tests/ivi_layout-internal-test.c | 307
+++
1 file changed, 307 insertions(+)
diff --git a/tests/ivi_layout-internal-test.c
b/tests/ivi_layout-internal-test.c
index fc7527e..befdf94 100644
- orientation
- dimension
- position
- destination rectangle
- source rectangle
Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp
Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk
Looks good.
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
---
tests/ivi_layout
order with bad parameter
- destroy ivi-layer in the ivi-screen and call commit_changes
Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp
Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk
Looks good.
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
---
tests/ivi_layout
parameter
Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp
Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk
Looks good.
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
---
tests/ivi_layout-internal-test.c | 69
1 file
serialization checks, rename the global, rewrite commit message.]
Signed-off-by: Pekka Paalanen pekka.paala...@collabora.co.uk
Looks good.
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
---
tests/ivi_layout-test-plugin.c | 45
--
1 file changed, 35 insertions
-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp
Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk
Looks good.
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
---
tests/ivi_layout-test-plugin.c | 22 ++
tests/ivi_layout-test.c| 1 +
2 files changed
-surface configure
- notification of creating ivi-surface
- notification of removing ivi-surface
Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp
Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk
Looks good.
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
://lists.freedesktop.org/mailman/listinfo/wayland-devel
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
j...@osg.samsung.com
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo
considered during design and implementation.
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
.gitignore |3 +
Makefile.am| 87 +-
tools/waycheck/moretest.c | 89 ++
tools/waycheck/rough_draw.c
to
me like something we can clean up in a later patchset.
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
j...@osg.samsung.com
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman
been in a few situations where this
really helps. Looks good.
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
---
Makefile.am | 59 ++-
configure.ac | 3 +++
src/input.c | 2 +-
3 files changed, 42 insertions(+), 22 deletions
Just a few minor low-level items in this feedback...
On 06/22/2015 01:02 PM, Giulio Camuffo wrote:
The backends used to have lots of code dealing with weston specific configs.
To allow them to be used by other compositors with their own configurations
remove all the usage of weston_config from
Oh I forgot an item on the placement of comments.
On 06/23/2015 04:31 PM, Jon A. Cruz wrote:
Minor doxygen note: the explicit \brief is not needed, and the brief
description should end with a '.' to allow the auto-brief to pick it up.
Overall looks good, but missing a few extra
which is set by the
libweston application.
- weston_compositor_destroy(compositor) is called by the libweston
application when tearing down the compositor. The compositor is destroyed
and the memory freed.
---
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
src/compositor-drm.c | 8
(ivi_layout_runner, basic_test_names)
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
j...@osg.samsung.com
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
tools/zunitc/src/main.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/tools/zunitc/src/main.c b/tools/zunitc/src/main.c
index cc86185..8179807 100644
--- a/tools/zunitc/src/main.c
+++ b/tools/zunitc/src/main.c
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
Makefile.am| 9 +-
tests/config-parser-test.c | 368 +
2 files changed, 310 insertions(+), 67 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index f0ed4d2..8234d2a 100644
Adds basic support for optionally outputting in the Test Anything
Protocol (TAP) format.
This format is a bit older and simplistic, but certain tools
handle it well.
https://testanything.org/
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
Makefile.am | 2 +
tools
Doxygen config files to non-defaults only.
- Relocated Doxygen specific input files to match Wayland structure.
Jon A. Cruz (6):
Added simple unit/integration test framework and corresponding
test program.
By default, stop test execution if unrecognized parameters are
encountered
-by: Jon A. Cruz j...@osg.samsung.com
---
Makefile.am | 10 +
configure.ac | 6 +
tools/zunitc/inc/zunitc/zunitc.h | 10 +
tools/zunitc/src/zuc_junit_reporter.c | 464 ++
tools/zunitc/src/zuc_junit_reporter.h
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
.gitignore| 2 +
doc/doxygen/devtools.dox | 55
doc/doxygen/tooldev.doxygen | 11 ++
doc/doxygen/tools.dox | 32
doc/doxygen/tools.doxygen | 11 ++
doc
framework could fail immediately due to this.
Looks good.
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
j...@osg.samsung.com
___
wayland-devel mailing list
wayland-devel
);
+ TFD_CLOEXEC | TFD_NONBLOCK);
source-func = func;
return add_source(loop, source-base, WL_EVENT_READABLE, data);
Looks good. (Seems like someone had tabs set to 4 and didn't notice.)
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
--
Jon
we want to use, can someone
point me to the preferred version?
(I had used the text from one of the recent license change patches, but
guess I might have missed the final form)
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
j...@osg.samsung.com
this in the
documentation when checking for some other things I was adding (and
disentangling for testing).
Reviewed-by: Jon A. Cruz j...@osg.samsung.com
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
j...@osg.samsung.com
___
wayland-devel
A. Cruz j...@osg.samsung.com
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
j...@osg.samsung.com
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel
On 06/16/2015 06:21 AM, Pekka Paalanen wrote:
On Tue, 9 Jun 2015 15:15:52 +1000
Peter Hutterer peter.hutte...@who-t.net wrote:
On Thu, Jun 04, 2015 at 12:50:47AM -0700, Jon A. Cruz wrote:
On 06/03/2015 10:15 PM, Peter Hutterer wrote:
On Tue, May 26, 2015 at 04:06:37PM -0700, Jon A. Cruz
On 06/16/2015 02:48 AM, Pekka Paalanen wrote:
On Mon, 15 Jun 2015 15:37:08 -0700
Jon A. Cruz j...@osg.samsung.com wrote:
To help reduce code duplication and also 'kitchen-sink' includes
the ARRAY_LENGTH macro was moved to a stand-alone file and
referenced from the sources consuming
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
Makefile.am | 1 -
1 file changed, 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 1cfc982..125d8c3 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -190,7 +190,6 @@ westoninclude_HEADERS = \
src
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
Makefile.am | 129
1 file changed, 95 insertions(+), 34 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 261798c..1cfc982 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -86,6
This covers a couple of follow-up items Pekka spotted in the
patchset moving a few common macros into the new helpers.h header.
Jon A. Cruz (2):
Added new include file to all SOURCES variables with files that
use it.
Do not install the new helpers macro header file.
Makefile.am
To help reduce code duplication and also 'kitchen-sink' includes
the ARRAY_LENGTH macro was moved to a stand-alone file and
referenced from the sources consuming it. Other macros will be
added in subsequent passes.
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
Makefile.am
As a follow-up to review feedback from Peter Hutterer this
set moves a few duplicated macros into a common header,
including ARRAY_LENGTH.
Changes since v1:
- Added example to container_of() doc comment.
Jon A. Cruz (4):
Remove redundant #include path component.
Moved helper macro
Removed multiple definitions of the MIN() macro from existing
locations and unified with a single definition. Updated sources
to use the shared version.
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
clients/nested.c | 2 --
clients/weston-info.c | 2 --
clients/window.c | 2
Using the parent '../' path component in #include statements makes
the codebase more rigid and is redundant due to proper -I use.
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
clients/calibrator.c | 2 +-
clients/desktop-shell.c| 4 ++--
clients/dnd.c
Removed duplicate definitions of the container_of() macro and
refactored sources to use the single implementation.
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
clients/clickdot.c | 1 +
clients/desktop-shell.c | 1 +
clients/window.h| 4
To help reduce code duplication and also 'kitchen-sink' includes
the ARRAY_LENGTH macro was moved to a stand-alone file and
referenced from the sources consuming it. Other macros will be
added in subsequent passes.
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
Makefile.am
As a follow-up to review feedback from Peter Hutterer this
set moves a few duplicated macros into a common header,
including ARRAY_LENGTH.
Jon A. Cruz (4):
Remove redundant #include path component.
Moved helper macro to a discrete include file.
Moved the MIN() macro to the helper include
Removed multiple definitions of the MIN() macro from existing
locations and unified with a single definition. Updated sources
to use the shared version.
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
clients/nested.c | 2 --
clients/weston-info.c | 2 --
clients/window.c | 2
Using the parent '../' path component in #include statements makes
the codebase more rigid and is redundant due to proper -I use.
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
clients/calibrator.c | 2 +-
clients/desktop-shell.c| 4 ++--
clients/dnd.c
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
.gitignore| 2 ++
doc/doxygen/devtools.dox | 52 +++
doc/doxygen/tooldev.doxygen | 11 ++
doc/doxygen/tools.dox | 29 +++
doc/doxygen/tools.doxygen | 11 ++
doc
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
Makefile.am| 9 +-
tests/config-parser-test.c | 368 +
2 files changed, 310 insertions(+), 67 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 9bd4b29..81f0f41 100644
Adds basic support for optionally outputting in the Test Anything
Protocol (TAP) format.
This format is a bit older and simplistic, but certain tools
handle it well.
https://testanything.org/
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
Makefile.am | 2 +
tools
-by: Jon A. Cruz j...@osg.samsung.com
---
Makefile.am | 2 +
tools/zunitc/inc/zunitc/zunitc.h | 8 +
tools/zunitc/src/zuc_junit_reporter.c | 473 ++
tools/zunitc/src/zuc_junit_reporter.h | 35 +++
tools/zunitc/src/zunitc_impl.c
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
tools/zunitc/src/main.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/tools/zunitc/src/main.c b/tools/zunitc/src/main.c
index 3e155d8..9a110d4 100644
--- a/tools/zunitc/src/main.c
+++ b/tools/zunitc/src/main.c
to.
- Reduced Doxygen config files to non-defaults only.
- Relocated Doxygen specific input files to match Wayland structure.
Jon A. Cruz (6):
Added simple unit/integration test framework and corresponding
test program.
By default, stop test execution if unrecognized parameters
from updating.
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
j...@osg.samsung.com
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel
as technically null-termination is
not guaranteed.
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
j...@osg.samsung.com
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo
On 06/09/2015 04:55 PM, Derek Foreman wrote:
On 09/06/15 06:24 PM, Jon A. Cruz wrote:
On 06/08/2015 09:46 AM, Derek Foreman wrote:
We were loading modules out of the system dirs unconditionally, so
tests that loaded modules would use the system ones, or fail if
they weren't installed
*text_backend)
if (!text_backend-input_method.path)
return;
+ if (strcmp(text_backend-input_method.path, ) == 0)
+ return;
+
if (text_backend-input_method.process.pid != 0)
return;
--
Jon A. Cruz - Senior Open Source Developer
use and follow up. Might
just be choice of name and reusing a term from a slightly different
context...
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
j...@osg.samsung.com
___
wayland-devel mailing list
wayland-devel
Added code to check for errors in getcwd() and system() that
were previously ignored and silently dropped.
Signed-off-by: Jon A. Cruz j...@osg.samsung.com
---
test/litest.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/test/litest.c b/test/litest.c
index
1 - 100 of 170 matches
Mail list logo
