Re: [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Kristian Høgsberg
On Thu, Feb 27, 2020 at 7:38 PM Dave Airlie wrote: > > On Fri, 28 Feb 2020 at 07:27, Daniel Vetter wrote: > > > > Hi all, > > > > You might have read the short take in the X.org board meeting minutes > > already, here's the long version. > > > > The good news: gitlab.fd.o has become very popular

Re: Migrating Wayland & Weston to GitLab

2018-05-31 Thread Kristian Høgsberg
On Thu, May 31, 2018 at 3:53 AM Pekka Paalanen wrote: > > On Thu, 31 May 2018 08:47:48 +0100 > Daniel Stone wrote: > > > Hi all, > > > > On 29 May 2018 at 10:59, Daniel Stone wrote: > > > I intend to migrate the wayland/wayland-protocols/wayland-web/weston > > > repository hosting only (issues d

Re: [Mesa-dev] [ANNOUNCE] Wayland/Weston/Mesa HDR support (proof of concept)

2017-12-22 Thread Kristian Høgsberg
On Thu, Dec 21, 2017 at 6:21 AM, Ville Syrjälä wrote: > Here's a quick proof of concept implementation of HDR support > for Wayland/Weston/Mesa. > > I'm not posting this as patches right now because I'm not sure > that would do much good given how rough this is. But here are > all the repos/branch

Re: [PATCH weston] make error() portable

2017-05-04 Thread Kristian Høgsberg
On Sat, May 30, 2015 at 12:02 PM, Jon A. Cruz wrote: > On 05/29/2015 09:14 PM, Khem Raj wrote: >> error() is not posix but gnu extension so may not be available on all >> kind of systemsi e.g. musl. > > Hi, > > Just including a few low-level notes. > >> >> Signed-off-by: Khem Raj >> --- >> confi

Re: Skylane - implementation of Wayland in Rust

2017-05-04 Thread Kristian Høgsberg
On Thu, May 4, 2017 at 8:59 AM, Wojciech Kluczka wrote: > Hello, > > This was supposed to be only a short announcement of Skylane - > implementation of Wayland in Rust - but it was pointed to me that one can > not use hardware acceleration without original libwayland so I have to also > ask some q

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

2017-04-24 Thread Kristian Høgsberg
On Fri, Apr 21, 2017 at 5:50 AM Olivier Fourdan wrote: > > Hi Jonas, > > > > [...] > > > For that last point, I'd rather use: > > > > > > * does not guarantee that events sent to this client are > continuous, > > > a compositor may change and reroute keyboard events while the > grab > >

Re: [RFC PATCH 0/8] Meson build system

2016-11-30 Thread Kristian Høgsberg
Hi Daniel, Thanks for doing this! I share a lot of the same background - I've worked with autotools for many years, know them well and have also been hesitant to move away. I've recently ported a small personal project from autotools to meson and I found it very nice and easy to work with. It fee

Re: Introduction and updates from NVIDIA

2016-05-12 Thread Kristian Høgsberg
On Wed, May 11, 2016 at 4:08 PM, James Jones wrote: > On 05/11/2016 02:31 PM, Daniel Stone wrote: >> >> Hi James, >> >> On 11 May 2016 at 21:43, James Jones wrote: >>> >>> On 05/04/2016 08:56 AM, Daniel Stone wrote: Right - but as with the point I was making below, GBM _right now_ is >>

Re: Introduction and updates from NVIDIA

2016-05-03 Thread Kristian Høgsberg
On Tue, May 3, 2016 at 11:58 AM, James Jones wrote: > On 05/03/2016 09:58 AM, Daniel Stone wrote: >> >> Hi James, >> >> On 3 May 2016 at 17:29, James Jones wrote: >>> >>> Given Wayland is designed such that clients drive buffer allocation >> >> >> I'd just note that this isn't strictly true. I've

Re: [PATCH 01/11] COPYING: Update to MIT Expat License rather than MIT X License

2015-06-11 Thread Kristian Høgsberg
hese. For all code copyright to myself or Collabora, Ltd., > as well as the code written by myself and copyright Intel Corporation, > this patch is: > Signed-off-by: Daniel Stone Thanks Bryce. Signed-off-by: Kristian Høgsberg > Cheers, >

Re: Wayland not MIT-licensed / FAQ wrong

2015-05-28 Thread Kristian Høgsberg
Yes, it appears you're correct. The HPND license is widely used in X (even new additions such as http://cgit.freedesktop.org/xorg/xserver/tree/dri3/dri3.c) and I think I assumed it was the most recent/modern version of the MIT license. It was certainly the intention to change the license to MIT and

Re: [PATCH weston] desktop-shell: Don't assume there is a pointer when resizing

2014-06-23 Thread Kristian Høgsberg
On Mon, Jun 23, 2014 at 4:18 AM, Emilio Pozuelo Monfort wrote: > Hi Kristian, > > On 19/06/14 07:37, Kristian Høgsberg wrote: >> On Wed, Jun 18, 2014 at 05:48:58PM +0200, Emilio Pozuelo Monfort wrote: >>> From: Emilio Pozuelo Monfort >>> >>> Fixes a cras

Re: [PATCH weston] desktop-shell: Don't assume there is a pointer when resizing

2014-06-18 Thread Kristian Høgsberg
On Wed, Jun 18, 2014 at 05:48:58PM +0200, Emilio Pozuelo Monfort wrote: > From: Emilio Pozuelo Monfort > > Fixes a crash on touch devices without a pointer, when touching > the window frame of a client. Thanks, applied. At some point we'll get rid of all these pointer assumptions. Kristian >

Re: [PATCH] connection: remove unreached code

2014-06-18 Thread Kristian Høgsberg
On Wed, Jun 04, 2014 at 11:39:08AM +0800, Boyan Ding wrote: Heh, oops, that was silly. Patch committed, thanks. Kristian > --- > src/connection.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/connection.c b/src/connection.c > index 47ee556..f292853 100644 > --- a/src/connectio

Re: [PATCH weston client window] Fixed the input region of the popup menu

2014-06-18 Thread Kristian Høgsberg
On Mon, Jun 02, 2014 at 01:53:38PM +0200, Tomek Obrebski wrote: > Changed the input region of the menu popup window to exclude the shadow and > border regions and set to frame's internal region only. This is a good patch but there are a few stylistic issues. First, the commit message is usually

Re: [PATCH weston] weston/configure.ac: make lcms configurable

2014-06-18 Thread Kristian Høgsberg
On Fri, May 30, 2014 at 09:51:32AM -0700, Tim Orling wrote: > From: Tim Orling > > Make lcms support explicitly configurable. > > Signed-off-by: Tim Orling > --- > configure.ac | 22 +- > 1 file changed, 17 insertions(+), 5 deletions(-) > > diff --git a/configure.ac b/conf

Re: [PATCH] weston: Fix memleak issue in compositor.c

2014-06-18 Thread Kristian Høgsberg
On Tue, May 27, 2014 at 02:30:59PM +0530, Srivardhan Hebbar wrote: > This fix is upon "Hardening " patch. [PATCH 2/2] Handle > OOM with signal events. Thanks, applied. I edited the commit message to wrap at 72 columns. Kristian > > Signed-off-by: Srivardhan Hebbar > --- > src/compositor.c |

Re: [PATCH] compositor-wayland: Fix compiler warning

2014-06-18 Thread Kristian Høgsberg
On Tue, May 27, 2014 at 09:08:29AM +0200, Thierry Reding wrote: > From: Thierry Reding > > sizeof returns size_t, for which the correct printf specifier is %zu. > Fixes the following warning when building for ARMv7. > > src/compositor-wayland.c: In function 'wayland_output_get_shm_buffer':

Re: [PATCH] build: Silence libtoolize warnings

2014-06-18 Thread Kristian Høgsberg
On Tue, May 27, 2014 at 09:07:54AM +0200, Thierry Reding wrote: > From: Thierry Reding > > When running the autogen.sh script, libtoolize complains thusly: > > libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to configure.ac > and > libtoolize: rerunning libtoolize, to keep t

Re: [PATCH weston 5/5] desktop-shell: make background applications less dark

2014-06-18 Thread Kristian Høgsberg
On Thu, May 22, 2014 at 10:41:34PM +0200, Jonny Lamb wrote: Patch applied. Kristian > --- > desktop-shell/shell.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c > index 51683ee..a5886d7 100644 > --- a/desktop-shell/s

Re: [PATCH weston 4/5] animation: ensure repaints are always scheduled during animations

2014-06-18 Thread Kristian Høgsberg
On Thu, May 22, 2014 at 10:41:33PM +0200, Jonny Lamb wrote: > Animations are run off the repaint cycle so if there's nothing to > repaint, an animation will stop running. This is usually not a problem > as each frame function of an animation causes something to change and > therefore a repaint to h

Re: [PATCH weston 3/5] desktop-shell: use panel location to calculate correct sizes and ranges

2014-06-18 Thread Kristian Høgsberg
On Thu, May 22, 2014 at 10:41:32PM +0200, Jonny Lamb wrote: > Now the client can let us know where the panel is using > desktop_shell.set_panel_position, we can correctly calculate where to > put new views and how big maximized views should be. > --- > desktop-shell/shell.c | 229 > ++

Re: [PATCH weston 1/5] animation: fix move scale animation

2014-06-18 Thread Kristian Høgsberg
On Thu, May 22, 2014 at 10:41:30PM +0200, Jonny Lamb wrote: > Both weston_move_scale_run() and weston_slide_run() were broken in > commit 3a869019. Commit a4a6f161 fixed and explained the problem for > weston_slide_run() but weston_move_scale_run() remained broken. > > To fix weston_move_scale_run

Re: [PATCH weston] exposay: fix crash when navigating with the keyboard

2014-06-18 Thread Kristian Høgsberg
On Sat, May 24, 2014 at 02:43:04AM +0200, Emilio Pozuelo Monfort wrote: > From: Emilio Pozuelo Monfort > > Commit a7592019 introduced an optimization that caused some > exposay struct members to not be properly initialized, particularly > cur_output, leading to crashes in some circumstances (e.g.

Re: [PATCH] protocol: remove redundant 'the' in description

2014-06-18 Thread Kristian Høgsberg
On Fri, May 23, 2014 at 07:26:56AM +0200, Silvan Jegen wrote: > Signed-off-by: Silvan Jegen Thanks, applied. Kristian > --- > protocol/wayland.xml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/protocol/wayland.xml b/protocol/wayland.xml > index 22eb6e7..113c7b7

Re: [PATCH weston] Apply output transform to the cursor while copying into a plane

2014-06-18 Thread Kristian Høgsberg
On Wed, May 21, 2014 at 07:36:21PM +0100, Neil Roberts wrote: > Previously if the output had a transform then the cursor plane would > be disabled. However as we have to copy the cursor image into a buffer > with the CPU anyway it probably won't cost much extra to also apply > the transform in the

Re: [PATCH] protocol: remove redundant 'the' in description

2014-05-23 Thread Kristian Høgsberg
On Fri, May 23, 2014 at 2:31 AM, Hardening wrote: > Le 23/05/2014 09:14, Pekka Paalanen a écrit : > >> On Fri, 23 May 2014 03:04:29 -0400 >> "Jasper St. Pierre" wrote: >> >>> On Fri, May 23, 2014 at 2:49 AM, Pekka Paalanen >>> wrote: >>> > > [...] > > This is obviously correct. >>

[PATCH] shell: Tiling wm proof of concept

2014-05-21 Thread Kristian Høgsberg
--- Jasper and have been talking about how one could implement a tiling wm by using the 'maximized' state in xdg-shell and I decided to give it a quick try. This is obviously a bit crude, but it was done in a couple of hours. It supports two tiling layouts: all vertical split: http://people.fr

Wayland and Weston 1.5.0 is released

2014-05-20 Thread Kristian Høgsberg
Hi, I tagged 1.5.0 of Wayland and Weston and uploaded tar balls last night. Tarballs available from http://wayland.freedesktop.org/releases.html as usual. Magic SHA1 number for the tags and tar balls: bace08b4a531ea4b80b4cf4e953320bc48ed7efe wayland-1.5.0.tar.xz 3ac62cd6b6012f40e37b1bd7fc1

Second and final release candidate for 1.5 (1.4.93)

2014-05-12 Thread Kristian Høgsberg
Hi, Here's the second release candidate for Wayland and Weston 1.5: ee6d6367ef6c3f6b46e39ce6b4568f316e2d1667 wayland-1.4.93.tar.xz 8511544e6be4385a87d2111c87f7f397c63c43ff wayland 1.4.93 tag 9d81584d203cc10ad7d9c49b18ffe2642ee5d7d4 weston-1.4.93.tar.xz 7098948463836104c28f6adc0b41cd08

Re: [PATCH weston] window: Ignore input events from subsurfaces

2014-05-12 Thread Kristian Høgsberg
On Tue, May 06, 2014 at 03:25:40PM +0300, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > Toytoolkit was not designed to handle input from subsurfaces and > instead it expects subsurfaces to have an empty input region. That way > input events for subsurfaces are generat

Re: [PATCH] Do not distribute generated headers

2014-05-12 Thread Kristian Høgsberg
On Wed, May 07, 2014 at 02:09:35PM +0200, Thierry Reding wrote: > From: Thierry Reding > > The wayland-server-protocol.h and wayland-client-protocol.h headers are > currently being shipped in tarballs created using make dist. This causes > out-of-tree builds to fail since make will detect that th

Re: [PATCH] doc: Remove obsolete doxygen tags

2014-05-12 Thread Kristian Høgsberg
On Mon, May 12, 2014 at 08:40:03PM +0800, Boyan Ding wrote: > --- > doc/doxygen/wayland.doxygen.in | 28 > 1 file changed, 28 deletions(-) > > diff --git a/doc/doxygen/wayland.doxygen.in b/doc/doxygen/wayland.doxygen.in > index dd98594..e64512f 100644 > --- a/doc/doxy

Re: [PATCH V2] event: assert wl_event_source pointer is NULL.

2014-05-12 Thread Kristian Høgsberg
On Mon, May 12, 2014 at 08:31:14AM +, Bryce W. Harrington wrote: > On Mon, May 12, 2014 at 11:26:01AM +0530, Srivardhan Hebbar wrote: > > Signed-off-by: Srivardhan Hebbar > > --- > > src/event-loop.c |6 +- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/src/e

Re: [PATCH weston 2/2] build: let 'make clean' remove logs/ again

2014-05-12 Thread Kristian Høgsberg
On Mon, May 12, 2014 at 10:08:57AM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > Before in the recursive automake setting, we had tests/logs/ for > explicitly created test log files. There is a Makefile rule to > remove the logs directory on 'make clean'. The rule broke on moving to > n

Re: [PATCH weston] desktop-shell: Fix order of desktop_shell messages

2014-05-12 Thread Kristian Høgsberg
On Sat, May 10, 2014 at 10:43:34AM +0200, Jonas Ådahl wrote: > There was a bug in wayland-scanner that failed to detect when an > message with implicitly set version (i.e. version 1) came after a > message with a newer version. This patch fixes the weston desktop shell > protocol to pass again. >

Re: [PATCH weston] editor: Fix cursor positioning with pointer and touch

2014-05-09 Thread Kristian Høgsberg
On Thu, May 08, 2014 at 02:55:50PM +0300, Ander Conselvan de Oliveira wrote: > The calculation off the vertical offset between the widget coordinates > and where the text was rendered was wrong. It was using the constant for > horizontal offset for that too. > --- > clients/editor.c | 33 +

Re: [PATCH weston 5/5] tests: rename xwayland test

2014-05-09 Thread Kristian Høgsberg
On Wed, May 07, 2014 at 04:26:29PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > If the test is named xwayland.weston, then the automake test harness > keys it off xwayland.log. Making xwayland.log runs the test. > The test harness has implicit rules to create a %.log from all of > %$TE

Re: [PATCH wayland 6/6] scanner: Generate macros for getting the 'since' version of an event

2014-05-09 Thread Kristian Høgsberg
On Thu, May 08, 2014 at 11:39:49PM +0200, Jonas Ådahl wrote: > This could be useful for compositors who need to be able to not send > events if the client bound a version lower than the newest provided. > > Event version numbers are exposed as > [INTERFACE_NAME]_[EVENT_NAME]_SINCE_VERSION for exam

Re: [PATCH] desktop-shell: Fix black edges on scaled desktop pattern

2014-05-09 Thread Kristian Høgsberg
On Fri, May 09, 2014 at 01:52:33PM -0700, Bill Spitzak wrote: > Thanks, it looks like that setup worked, patch sent correctly now. Great, it's good to have git send-email working. As it turns out, I didn't have any problems applying your initial email, but I do have the fix whitespace option Pekk

Re: [PATCH weston] libinput-seat: literal values for WESTON_LIBINPUT_LOG_PRIORITY

2014-05-09 Thread Kristian Høgsberg
On Fri, May 09, 2014 at 11:24:40AM -0700, U. Artie Eoff wrote: > Only accept specific literal values from the environment variable > WESTON_LIBINPUT_LOG_PRIORITY... "debug", "info", or "error". > > Signed-off-by: U. Artie Eoff Thanks Artie, I think we can squeeze that in with the RC2. Kristian

Re: [PATCH 2/2] Handle OOM with signal events

2014-05-09 Thread Kristian Høgsberg
On Fri, May 09, 2014 at 04:03:52PM +0200, Hardening wrote: > This patch handles the case where a signal event source can not be created. > --- > src/compositor.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/src/compositor.c b/src/compositor.c > index 6ad338

Re: [PATCH 1/2] Set to NULL event source after a call to wl_event_source_remove

2014-05-09 Thread Kristian Høgsberg
On Fri, May 09, 2014 at 04:03:51PM +0200, Hardening wrote: > This patch sets to NULL event sources after a call to wl_event_source_remove() > has been made. We don't generally set freed memory to NULL, unless we rely on testing that to decide whether the pointer points to an object or not. Kristi

Re: [PATCH weston] vaapi-recorder: Don't loop trying to write on out of space condition

2014-05-09 Thread Kristian Høgsberg
On Fri, May 09, 2014 at 03:57:38PM +0300, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > The error handling for the function that writes the encoded frame on > the disk was bogus, always assuming the buffer supplied to the encoder > was too small. That would cause a bi

Re: [PATCH weston] rpi: build fix for compute_rects debug

2014-05-09 Thread Kristian Høgsberg
On Fri, May 09, 2014 at 03:08:06PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > See 918f2dd4cfb8b177f67b45653efbbe4325cbe9dc Thanks Pekka, applied. Kristian > Signed-off-by: Pekka Paalanen > --- > src/rpi-renderer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [PATCH] event: Cheking for NULL before dereferencing the pointer.

2014-05-09 Thread Kristian Høgsberg
On Fri, May 09, 2014 at 02:56:14PM +0530, Srivardhan wrote: > > > > -Original Message- > > From: wayland-devel [mailto:wayland-devel- > > boun...@lists.freedesktop.org] On Behalf Of Hardening > > Sent: Friday, May 09, 2014 1:08 PM > > To: wayland-devel@lists.freedesktop.org > > Subject: R

Re: [PATCH] desktop-shell: Fix black edges on scaled desktop pattern

2014-05-09 Thread Kristian Høgsberg
On Thu, May 08, 2014 at 08:00:35PM -0700, Bill Spitzak wrote: > Filter sampling outside the source image can leak black into the edges of > the > desktop image. This is most easily seen by scaling the default tiled image > with this weston.ini: > > # no background-image and no background-col

Re: [PATCH weston] shell: Don't allow maximized surfaces to be moved with touch

2014-05-09 Thread Kristian Høgsberg
On Wed, May 07, 2014 at 02:22:23PM +0300, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > Moving a maximized surface with the pointer is already not possible, > so make the behavior with touch consistent. > > https://bugs.freedesktop.org/show_bug.cgi?id=78208 Thanks,

Re: [PATCH weston 3/3] shell: Fix crash when restoring focus state during workspace change

2014-05-09 Thread Kristian Høgsberg
On Wed, May 07, 2014 at 11:57:28AM +0300, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > The check to avoid calling weston_keyboard_set_focus() for a seat that > didn't have a keyboard in restore_focus_state() was cheking the wrong > seat (the one from the previous loo

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

2014-05-09 Thread Kristian Høgsberg
On Wed, May 07, 2014 at 11:47:08AM +0300, Pekka Paalanen wrote: > On Tue, 6 May 2014 14:40:53 -0700 > Kristian Høgsberg wrote: > > > On Mon, May 05, 2014 at 05:02:15PM +0300, Ander Conselvan de Oliveira > > wrote: > > > From: Ander Conselvan de Oliveira > >

Re: [PATCH v2] doc: Added API documentation for wl_display_create function.

2014-05-09 Thread Kristian Høgsberg
On Wed, May 07, 2014 at 09:37:45AM +0530, Srivardhan Hebbar wrote: > Signed-off-by: Srivardhan Hebbar > --- > src/wayland-server.c |9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/wayland-server.c b/src/wayland-server.c > index f2b1b42..57b65ce 100644 > --- a/src/wayland-

Re: [PATCH 5/5] clients: Use xstrdup instead of strdup

2014-05-09 Thread Kristian Høgsberg
On Wed, May 07, 2014 at 02:13:11AM +, Bryce W. Harrington wrote: > > Signed-off-by: Bryce Harrington > --- > clients/editor.c | 12 ++-- > clients/image.c|4 ++-- > clients/keyboard.c | 12 ++-- > clients/terminal.c |2 +- > 4 files changed, 15 insertions(+)

Re: [PATCH 4/5] clients: Use xzalloc instead of xcalloc when allocating single element

2014-05-09 Thread Kristian Høgsberg
On Wed, May 07, 2014 at 02:13:11AM +, Bryce W. Harrington wrote: > > Signed-off-by: Bryce Harrington > --- > clients/desktop-shell.c |2 +- > clients/editor.c|2 +- > clients/fullscreen.c|2 +- > clients/subsurfaces.c |6 +++--- > clients/window.c|4

Re: [PATCH 3/5] clients: Use calloc instead of malloc/memset=0

2014-05-09 Thread Kristian Høgsberg
On Wed, May 07, 2014 at 02:13:11AM +, Bryce W. Harrington wrote: > > Signed-off-by: Bryce Harrington > --- > clients/editor.c |4 +--- > clients/subsurfaces.c |8 ++-- > clients/window.c | 13 ++--- > 3 files changed, 5 insertions(+), 20 deletions(-) > > diff

Re: [PATCH] clients: Initialize label in keyboard handling code

2014-05-09 Thread Kristian Høgsberg
On Wed, May 07, 2014 at 01:11:07AM +, Bryce W. Harrington wrote: > Quells warning: > clients/keyboard.c: In function ‘keyboard_handle_key.isra.5’: > clients/keyboard.c:556:11: warning: ‘label’ may be used uninitialized in > this function [-Wuninitialized] > > Signed-off-by: Bryce Harring

Re: [PATCH weston 3/3] compositor-wayland: avoid possible NULL deref in handle_keymap

2014-05-06 Thread Kristian Høgsberg
On Tue, May 06, 2014 at 02:50:03PM -0700, U. Artie Eoff wrote: > If data is NULL, then we jumped to error which attempts to > dereference data. Instead, just close(fd) and return when > data is NULL. > > Signed-off-by: U. Artie Eoff All three look good, applied. Kristian > --- > src/composit

Re: [PATCH weston] Apply the zoom transformation before the output transformation

2014-05-06 Thread Kristian Høgsberg
On Tue, May 06, 2014 at 07:04:15PM +0100, Neil Roberts wrote: > The zoom translation is just a scale and a translate. The translation > is calculated based on the coordinates of the pointer which are in > global space. Previously the calculated translation was transformed by > the output transforma

Re: [PATCH weston] compositor-drm: Don't use vaapi recorder with unsupported formats

2014-05-06 Thread Kristian Høgsberg
On Tue, May 06, 2014 at 04:49:06PM +0300, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > We only support recording with GBM_FORMAT_XRGB888 format, so don't try > to record if the output has a differnt format. That looks good, applied. Kristian > > https://bugs.free

Re: [PATCH wayland-web 6/6] xwayland: add xserver build options

2014-05-06 Thread Kristian Høgsberg
On Tue, May 06, 2014 at 04:25:40PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > With these, it will only install the Xwayland binary. No Xorg, no > modules, no cruft. Just 4 files in total here. Thanks for updating that, all applied. Kristian > --- > xserver.html | 4 +++- > 1 file

Re: [PATCH] wcap: Check for mmap and malloc return value in wcap decode module

2014-05-06 Thread Kristian Høgsberg
On Tue, May 06, 2014 at 03:54:49PM +0530, vivek wrote: > Checking for return value in main.c for wcap_decoder_create function > and mmap, malloc return value in wcap_decoder_create function to avoid > crashes Thanks, that looks better. Kristian > Signed-off-by: vivek > --- > wcap/main.c

Re: [PATCH] doc: Added API documentation for wl_display_create function.

2014-05-06 Thread Kristian Høgsberg
On Tue, May 06, 2014 at 03:52:12PM +0530, Srivardhan Hebbar wrote: > Signed-off-by: Srivardhan Hebbar > --- > src/wayland-server.c |9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/wayland-server.c b/src/wayland-server.c > index f2b1b42..7b32848 100644 > --- a/src/wayland-

Re: [PATCH wayland] server: fix potential memleak and NULL deref

2014-05-06 Thread Kristian Høgsberg
On Mon, May 05, 2014 at 04:28:26PM -0700, U. Artie Eoff wrote: > If for some reason that errno is neither value (ENOMEM or > EINVAL), then prior to this patch, there would be a NULL > deref in wl_closure_lookup(...) at the "else if" conditional > when closure == NULL. Also, closure might not be NUL

Re: [PATCH wayland 2/2] connection-test: check malloc result

2014-05-06 Thread Kristian Høgsberg
On Mon, May 05, 2014 at 02:45:20PM -0700, U. Artie Eoff wrote: > Signed-off-by: U. Artie Eoff Applied, thanks. > --- > tests/connection-test.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/connection-test.c b/tests/connection-test.c > index 1213875..659bf68 100644 > --- a/te

Re: [PATCH wayland 1/2] scanner: check wl_array_add result

2014-05-06 Thread Kristian Høgsberg
On Mon, May 05, 2014 at 02:45:19PM -0700, U. Artie Eoff wrote: > Signed-off-by: U. Artie Eoff Thanks, applied. Kristian > --- > src/scanner.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/scanner.c b/src/scanner.c > index 622d4d8..dd1c7b6 100644 > --- a/src/scan

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

2014-05-06 Thread Kristian Høgsberg
On Mon, May 05, 2014 at 05:02:15PM +0300, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > Otherwise it might receive touch events. I think a better approach is to just hide the tooltip if it (or the panel) gets touch events. I don't think I agree with Pekka that we ca

Release candidate 1 out for 1.5 (1.4.92)

2014-05-01 Thread Kristian Høgsberg
Hi all, I've just tagged the 1.4.92 release candidate in git and uploaded tarballs: 0dbe48041a90b8f62993270ca11d29b84c9fe12f wayland-1.4.92.tar.xz 4a4523fa92e8a1110b84d3595a2467bd16dc22af wayland 1.4.92 tag 2afea6c88f796c03ba924f67f8fff38b89e8276a weston-1.4.92.tar.xz d7d71e8d962d7d82

Re: [PATCH weston] drm: Don't use the cursor overlay if the scale doesn't match

2014-05-01 Thread Kristian Høgsberg
On Thu, May 01, 2014 at 06:00:41PM +0100, Neil Roberts wrote: > If the scale for the cursor surface doesn't match that of the output > then we shouldn't use the cursor overlay because otherwise it will be > drawn at the wrong size. This problem is particularly noticable with > multiple pointers bec

Re: [PATCH weston] Take into account the zoom when applying the output transform

2014-05-01 Thread Kristian Høgsberg
On Thu, May 01, 2014 at 04:13:55PM +0100, Neil Roberts wrote: > When converting output-relative coordinates (such as from an input > event) to global coordinates it now takes into account the zoom > transform. Previously this would only work for the primary pointer > because the transform doesn't a

Re: [PATCH 6/6] window: Add a simple getenv to force SHM rendering

2014-04-30 Thread Kristian Høgsberg
On Mon, Apr 28, 2014 at 11:19:32AM -0400, Jasper St. Pierre wrote: Yeah, that's useful, applied. Kristian > --- > clients/window.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/clients/window.c b/clients/window.c > index d822af7..3897440 100644 > --- a/clients/wi

Re: [PATCH 4/6] cairo-util: Don't show a resize cursor on edges when we're maximized

2014-04-30 Thread Kristian Høgsberg
On Mon, Apr 28, 2014 at 11:19:30AM -0400, Jasper St. Pierre wrote: > This is substantially confusing to users, namely me. That is indeed confusing. However, I edited the patch to just set grip_size to 0 if we're maximized. Kristian > --- > shared/cairo-util.c | 13 - > 1 file chang

Re: [PATCH 1/6] compositor: Fix the documentation for surface->configure

2014-04-30 Thread Kristian Høgsberg
On Mon, Apr 28, 2014 at 11:19:27AM -0400, Jasper St. Pierre wrote: > It's called on commit, not on attach. Additionally, correct the > interface name to be wl_surface, not surface. > --- > src/compositor.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/compositor

Re: [PATCH weston v2] screen-share: Don't unset server environment variables

2014-04-30 Thread Kristian Høgsberg
On Wed, Apr 30, 2014 at 10:53:30AM -0500, Jason Ekstrand wrote: > Looks good to me. > > Reviewed-by: Jason Ekstrand Thanks, committed. Kristian > On Apr 30, 2014 3:52 AM, "Andrew Wedgbury" > wrote: > > > There is no need to unset WAYLAND_DISPLAY and WAYLAND_SOCKET when > > screen-share > > l

Re: [PATCH] desktop-shell: Properly handle seat hotplugging

2014-04-29 Thread Kristian Høgsberg
On Mon, Apr 21, 2014 at 07:42:58PM -0500, Jason Ekstrand wrote: > Previously, desktop-shell would only create its internal shell_seat object > for each seat available when the desktop-shell module is loaded. This is a > problem any time seats are created dynamically. In particular, the Wayland >

Re: [PATCH weston] desktop-shell: Properly handle lowered fullscreen surfaces

2014-04-29 Thread Kristian Høgsberg
On Thu, Jan 30, 2014 at 02:01:10PM +0100, poch...@gmail.com wrote: > From: Emilio Pozuelo Monfort > > lower_fullscreen_surface() was removing fullscreen surfaces from > the fullscreen layer and inserting them in the normal workspace > layer. However, those fullscreen surfaces were never put back

Re: [PATCH weston 2/2] shell: Fix crash when a client is destroyed during the resize grab

2014-04-29 Thread Kristian Høgsberg
On Tue, Apr 29, 2014 at 05:54:03PM +0300, Ander Conselvan de Oliveira wrote: > If a client exists during a resize grab, the resource for the shell > surface being resized is destroyed. The shell surface is not destroyed > immediately, however, because of the window close animation. In that > case,

Re: [PATCH] terminal: Convert all *alloc's to x*alloc's.

2014-04-29 Thread Kristian Høgsberg
On Mon, Apr 28, 2014 at 06:44:08PM +, Bryce W. Harrington wrote: > This ensures the allocation results are checked for NULL (out of > memory), and terminates the program in such a case. > > Signed-off-by: Bryce Harrington Applied, thanks. Kristian > --- > clients/terminal.c |6 +++---

Re: [PATCH] Wrong bo handles can be referenced in func call, drmModeAddFB2 due to uninitialized array elements in handles[4]

2014-04-29 Thread Kristian Høgsberg
On Mon, Apr 28, 2014 at 03:26:18PM -0700, Dongwon Kim wrote: > Need all bo handles in the array, handles[4] to be initialized with integer > value that > indicates "NOT VALID handle" to prevent any of those uninitialized from being > processed as > "VALID" handles. The format code determines whi

Re: [PATCH 3/3] clients: Check zalloc return for out of memory situation

2014-04-29 Thread Kristian Høgsberg
On Mon, Apr 28, 2014 at 06:43:43PM +, Bryce W. Harrington wrote: > On Thu, Apr 24, 2014 at 04:26:20PM +0300, Pekka Paalanen wrote: > > On Mon, 21 Apr 2014 23:51:03 + > > "Bryce W. Harrington" wrote: > > > terminal = xzalloc(sizeof *terminal); > > > + if (terminal == NULL) > > > +

Re: [PATCH 6/6] window: Add a simple getenv to force SHM rendering

2014-04-29 Thread Kristian Høgsberg
On Tue, Apr 29, 2014 at 5:35 AM, Pekka Paalanen wrote: > On Mon, 28 Apr 2014 11:19:32 -0400 > "Jasper St. Pierre" wrote: > >> --- >> clients/window.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/clients/window.c b/clients/window.c >> index d822af7..3897440 1006

Re: [PATCH wayland] Use non-blocking timerfd to prevent blocking when updating timer event sources

2014-04-25 Thread Kristian Høgsberg
On Fri, Apr 25, 2014 at 03:00:54PM +0100, Andrew Wedgbury wrote: > This implements a simple fix for the blocking problem that occurs when > updating a timer event source after the timer expires, but before its > callback is dispatched. This can happen when another event happens during the > same

Re: [PATCH weston] Simply the matrix calculation for zooming

2014-04-25 Thread Kristian Høgsberg
On Fri, Apr 25, 2014 at 01:19:37PM +0100, Neil Roberts wrote: > In order to apply the zoom transformation to the output matrix, Weston was > doing the following: > > • Create a temporary matrix to hold the translation > • Invert the translation matrix using weston_matrix_invert into > another te

Re: [PATCH weston] clients/window: Don't remove the touch listener on a frame event

2014-04-25 Thread Kristian Høgsberg
On Wed, Apr 23, 2014 at 06:02:47PM +0100, Neil Roberts wrote: > It looks like the handler for frame events from the wl_touch interface for > widgets may have been erroneously copied from the cancel handler so that it > removes all handlers as they are processed. I don't think this makes much > sen

Re: [PATCH] Use the correct width/height when transforming surfaces with viewports.

2014-04-25 Thread Kristian Høgsberg
On Tue, Apr 22, 2014 at 09:51:53AM +0300, Pekka Paalanen wrote: > On Mon, 21 Apr 2014 20:56:46 -0500 > Jason Ekstrand wrote: > > > Previously, because of the wrong width/height, > > weston_surface_to_buffer_* would return the wrong values when > > wl_viewport was used in combination with wl_surfa

Re: [PATCH 1/3] Check zalloc return for out of memory situation

2014-04-25 Thread Kristian Høgsberg
On Fri, Apr 25, 2014 at 1:18 PM, Kristian Høgsberg wrote: > On Mon, Apr 21, 2014 at 11:51:02PM +, Bryce W. Harrington wrote: >> Most zalloc calls in weston are checked, this fixes a handful that were >> being ignored. As found by `grep -EIsr "[^x]zalloc\(" . -A1`

Re: [PATCH 2/3] xwayland: Check zalloc return for out of memory situation

2014-04-25 Thread Kristian Høgsberg
On Mon, Apr 21, 2014 at 11:51:03PM +, Bryce W. Harrington wrote: > > Signed-off-by: Bryce Harrington > --- Applied, thanks. Kristian > xwayland/launcher.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/xwayland/launcher.c b/xwayland/launcher.c > index ac692de..70703a4 1006

Re: [PATCH 3/3] clients: Check zalloc return for out of memory situation

2014-04-25 Thread Kristian Høgsberg
On Mon, Apr 21, 2014 at 11:51:03PM +, Bryce W. Harrington wrote: > Checking for these errors in the clients is perhaps a bit gratuitous but > can't hurt. In the clients we use the x*alloc functions which abort on allocation failure. Kristian > Signed-off-by: Bryce Harrington > --- > client

Re: [PATCH 1/3] Check zalloc return for out of memory situation

2014-04-25 Thread Kristian Høgsberg
On Mon, Apr 21, 2014 at 11:51:02PM +, Bryce W. Harrington wrote: > Most zalloc calls in weston are checked, this fixes a handful that were > being ignored. As found by `grep -EIsr "[^x]zalloc\(" . -A1` Thanks Bryce, applied with once change as mentioned below. Kristian > Signed-off-by: Bryc

Re: [PATCH] Check malloc result

2014-04-21 Thread Kristian Høgsberg
On Fri, Apr 11, 2014 at 09:06:58AM +0200, Hardening wrote: > This patch checks malloc was successfull and release resources if it > wasn't. Commmitted, thanks. Kristian > --- > src/screen-share.c | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/src/sc

Re: [PATCHv2 weston] gl-renderer: Remove gl_renderer_interface from gl-renderer.h

2014-04-21 Thread Kristian Høgsberg
On Thu, Apr 10, 2014 at 08:05:17PM +0200, John Kåre Alsaker wrote: > The rationale here is, that this line would create an instance of > gl_renderer_interface in every compilation unit that included > gl-renderer.h. This is not necessary, and it can actually be harmful by > masking the real exporte

Re: [PATCH weston] weston-info: fix log message typo

2014-04-21 Thread Kristian Høgsberg
On Fri, Apr 18, 2014 at 09:30:07AM -0700, U. Artie Eoff wrote: > Signed-off-by: U. Artie Eoff > --- Committed, thanks. Kristian > clients/weston-info.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/clients/weston-info.c b/clients/weston-info.c > index 147dc48..df869

Re: [PATCH] editor: react on Enter, Tab, and Up-Down arrow keys

2014-04-21 Thread Kristian Høgsberg
On Fri, Apr 18, 2014 at 12:52:03PM +0200, Manuel Bachmann wrote: > This fixes : > https://bugs.freedesktop.org/show_bug.cgi?id=77496 > Yup, the patch looks good, thanks Manuel. Kristian > Regards, > Manuel > > > 2014-04-18 12:50 GMT+02:00 Manuel Bachmann < > manuel.bachm...@open.eurogiciel.or

Re: [PATCH wayland] connection: Don't write past the end of the connection buffer

2014-04-21 Thread Kristian Høgsberg
On Thu, Apr 17, 2014 at 06:20:37PM +0300, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > If a message was too big to fit in the connection buffer, the code > in wl_buffer_put would just write past the end of it. > > I haven't seen any real world use case that would tr

Re: [PATCH weston v2 0/5] Input bug fixes

2014-04-21 Thread Kristian Høgsberg
On Thu, Apr 17, 2014 at 07:53:21AM -0700, U. Artie Eoff wrote: > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=77578 > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=77577 > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=77341 > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=77

Re: [PATCH] shell: display the input panel on the active output

2014-04-21 Thread Kristian Høgsberg
On Thu, Apr 17, 2014 at 02:04:32PM +0200, Manuel Bachmann wrote: > We now dynamically move the input panel (i.e. virtual > keyboard) surface to the output containing the currently > focused surface. That works, but it does seem like we're missing a link from the input panel surface to the input co

Re: [PATCH weston] compositor-drm: Fix crash when setting up seat constrained by an output

2014-04-21 Thread Kristian Høgsberg
On Thu, Apr 17, 2014 at 01:08:45PM +0300, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > Commit 58e15865 changed the parameters for udev_get_seat_by_name() to > receive a struct udev_input. However, when this gets called from > create_output_from_connector() during ini

Re: [PATCH] keyboard: add the missing symbols layout, fix arabic layout

2014-04-16 Thread Kristian Høgsberg
On Tue, Apr 15, 2014 at 12:38:31PM +0200, Manuel Bachmann wrote: > The "symbols" modifier key of weston-keyboard is no longer > inactive, but will provide an additionnal layout with > numerals and special characters. > > Fix the Arabic keyboard, which was rendering out of the > bounds, and now use

Re: [PATCH v2] tests: fix bad-buffer-test

2014-04-16 Thread Kristian Høgsberg
On Sat, Apr 12, 2014 at 12:19:28PM +0300, Pekka Paalanen wrote: > On Fri, 11 Apr 2014 11:48:55 +0200 > Marek Chalupa wrote: > > > bad-buffer-test is FAIL_TEST and every assert() (or even SIGSEGV signal) > > make it pass. It shouldn't be so for example when assert() is invoked > > when a client co

Re: [PATCH] desktop-shell: Get rid of get_shell_client

2014-04-16 Thread Kristian Høgsberg
On Wed, Apr 16, 2014 at 09:12:10PM -0500, Jason Ekstrand wrote: > We now carry the shell_client around with each shell_surface. This is much > more reliable than tacitly assuming that there is only one wl_shell or > xdg_shell instance bound to a particular wl_client. In particular, weston > would

Re: [PATCH weston] compositor-drm: Pass the right stride to the vaapi recorder

2014-04-16 Thread Kristian Høgsberg
On Wed, Apr 16, 2014 at 12:05:12PM +0300, Ander Conselvan de Oliveira wrote: > It takes the stride in bytes, not pixels. The bug was hidden when using > va intel-driver 1.2.1 because it would ignore the stride from user and > set the surface state in a wrong way. > > https://bugs.freedesktop.org/s

Re: [PATCH] gl-renderer: Fix a typo in the output_set_border description

2014-04-11 Thread Kristian Høgsberg
On Fri, Apr 11, 2014 at 03:42:59AM -0500, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand Thanks, applied. Kristian > --- > src/gl-renderer.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/gl-renderer.h b/src/gl-renderer.h > index db42f6c..bdfe93e 10064

  1   2   3   4   5   6   7   8   9   10   >