On Mon, 10 Sep 2018 10:12:18 +0200
Dirk Eibach wrote:
> Perhaps I should add, that with rolling back to weston 4.0.0.
> everything works fine. So nouveau support must have been broken
> somewhere inbetween.
Hi,
right, so it's a regression. Weston does not have code specific to
Nouveau, but it
On Tue, 4 Sep 2018 13:05:37 -0600
Chris Murphy wrote:
> I've come across a regression from Fedora 28 to Fedora 29. Problem
> happens with combination of:
> 1. Wayland session
> 2. Chrome with hardware acceleration enabled; and also glxgears
> 3. multiple displays
> 4. moving the application
On Thu, 30 Aug 2018 18:24:31 +0800
zou lan wrote:
> Hi pekka & all
>
> I find function weston_view_update_transform_enable() function will
> calculate view's bounding box, but after that function,
> weston_view_update_transform will update subsurface's scissor region by
> parent surface's
On Tue, 28 Aug 2018 23:19:18 +0100
Daniel Stone wrote:
> From: Emmanuele Bassi
>
> Add a script which generates the desired Doxygen configuration for our
> various output formats and executes it using that configuration.
>
> [daniels: Properly install into mandir/man3 via some gross
>
On Tue, 28 Aug 2018 23:19:17 +0100
Daniel Stone wrote:
> From: Emmanuele Bassi
>
> Meson is a next generation build system, simpler than Autotools and,
> more importantly, faster and more portable. While the latter
> consideration is of lesser importance for Wayland, being easier to
>
paths
like
/var/tmp/buildbuilder/packages/dev-lib/wayland/wayland-1.123/tmp/work/install-prefix/sysroot/tmp/build/...
Use PATH_MAX instead?
Otherwise looks good to me, so
Reviewed-by: Pekka Paalanen
Thanks,
pq
> +
> + if (test_build_dir == NULL || test_build_dir[0] == 0) {
> +
his fixes the Meson build, where we later create
> doc/doxygen/xml/meson.build.
>
> Signed-off-by: Daniel Stone
> ---
> doc/doxygen/Makefile.am | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
Hi Daniel,
this makes sense to me, so even though I didn't test:
please feel free to grab that branch and
> run with it; in the meantime, these seem like good fixes to have
> regardless.
Hi,
I'm thrilled where this is going. This series is:
Reviewed-by: Pekka Paalanen
Patch 3 could maybe use a code comment for being so s
On Mon, 27 Aug 2018 16:20:41 +0100
Daniel Stone wrote:
> Hi Pekka,
>
> On Fri, 24 Aug 2018 at 09:12, Pekka Paalanen wrote:
> > On another matter, I've been wondering if storing the debug scopes in
> > weston_compositor is a good thing. We have the logger initialized
&
On Mon, 27 Aug 2018 16:15:23 +0100
Daniel Stone wrote:
> Hi Pekka,
>
> On Mon, 6 Aug 2018 at 14:05, Pekka Paalanen wrote:
> > On Fri, 20 Jul 2018 20:03:24 +0100 Daniel Stone
> > wrote:
> > > + while (len_ > 0) {
> > > +
On Tue, 28 Aug 2018 08:46:51 -0400
Sichem Zhou wrote:
> Hi all,
>
> Yesterday I just updated my compositor from `libweston-4` to `libweston-5`.
> Great job on the new weston_head API. I've noticed the changes mapping
> `wl_output` to `weston_head` that I hope to pose a question on that:
>
>
On Tue, 28 Aug 2018 12:00:56 +0800
binnan hao wrote:
> I'm using Busybox root file system, and the default setting on Busybox is
> mdev instead of udev.
Hi,
whatever you have or do, you need to set up the device attributes the
way libinput expects them to be to recognize an input device as a
On Thu, 23 Aug 2018 15:12:03 +
Marius-cristian Vlad wrote:
> On Thu, 2018-08-23 at 14:39 +0300, Pekka Paalanen wrote:
> > > > > Especially EDID info would be most useful for finding the right
> > > > > VR
> > > > > headset.
> >
On Thu, 23 Aug 2018 17:53:07 +0100
Daniel Stone wrote:
> Hi Pekka,
>
> On Mon, 6 Aug 2018 at 12:16, Pekka Paalanen wrote:
> > On Fri, 20 Jul 2018 20:03:24 +0100 Daniel Stone
> > wrote:
> > > +/** Format current time as a string
> > &
Sorry for the potentially duplicate email, my MUA messed up the CC list
on the first go.
On Thu, 23 Aug 2018 08:41:30 +0200
Philipp Zabel wrote:
> Hi,
>
> On Wed, 2018-08-22 at 11:12 +, Marius-cristian Vlad wrote:
> [...]
> > > Why not just send the connectors one by one, a single event
On Thu, 23 Aug 2018 08:30:35 +0300
Teemu K wrote:
> Well, since it's i.MX6 and NXP (still) doesn't provide proper video
> driver so proprietary EGL driver is being used. I think they even made
> their own fork for Weston 2.0.0 onward that they can keep using their
> old driver instead fixing it
On Wed, 22 Aug 2018 12:18:00 +0300
Teemu K wrote:
> Hi,
>
> I have custom iMX6 based HW running image generated with Yocto 2.4
> (Wayland 2.0.0) and Linux kernel 4.1.x that I've been testing with
> suspend/resume cycles.
>
> I noticed that after each suspend/resume cycle open file count
>
+++
> 1 file changed, 63 insertions(+)
>
Hi,
looks good!
Reviewed-by: Pekka Paalanen
I also tested 32-bit builds in CI with and without the fixes, and those
worked as expected too.
Thanks,
pq
> diff --git a/tests/connection-test.c b/tests/connection-test.c
> index 157e1bc..018e2a
On Tue, 14 Aug 2018 13:07:51 +0200
Michal Srb wrote:
> Attempting to demarshal message with array or string longer than its
> body should return failure. Handling the length correctly is tricky when
> it gets to near-UINT32_MAX values. Unexpected overflows can cause
> crashes and other security
too. I also
checked that (end - p) cannot become negative.
Reviewed-by: Pekka Paalanen
I'm still playing with the tests patch a bit.
Thanks,
pq
>
> diff --git a/src/connection.c b/src/connection.c
> index 31396bc..a0f10ae 100644
> --- a/src/connection.c
> +++ b/src/connection.c
>
NT32_MAX. After the division it is again safe to
> +// cast back to uint32_t.
> +return (uint32_t) (((uint64_t) n + (a - 1)) / a);
> +}
The above has a few style issues:
- div_roundup should start on a new line as it is a function now
- use /* */ comment style
- use tabs for indent
-
On Fri, 10 Aug 2018 18:31:03 +
ferreiradaselva wrote:
> Oh,
>
> I solved the problem with the extern variable
> (wl_registry_interface), I could get a pointer to it using
> `dlsym(handler, "wl_registry_interface")`.
>
> The other question remains: can I use the content of the inline
>
that, if present, allows
calling eglMakeCurrent() with EGL_NO_SURFACE, so you can do all the GL
setup without a wl_surface.
You could also do the GL setup on the first show, and keep the shaders
etc. beyond the destruction of the wl_surface. I assume that should
work from EGL and GL point of view.
Thanks,
pq
ut/
>
> I skipped the Review/Commit Rights sections for now until there's some demand
> for it. Same with the Licensing/Stabilising for releases sections.
>
> Cc: Daniel Stone ,
> Cc: Pekka Paalanen ,
> Cc: Quentin Glidic
> Signed-off-by: Peter Hutterer
On Wed, 8 Aug 2018 12:59:45 +0300
Pekka Paalanen wrote:
> On Tue, 7 Aug 2018 19:05:01 +0530
> Harsha M M wrote:
>
> > valgrind reports several invalid memory access during shutdown of
> > weston. In general problem is with components which do not remove
> &
On Tue, 7 Aug 2018 19:05:01 +0530
Harsha M M wrote:
> valgrind reports several invalid memory access during shutdown of
> weston. In general problem is with components which do not remove
> the signals added using wl_signal_emit, but free their memory.
>
> This patch series fixes invalid memory
moved, but I think it's ok anyway.
The seat_created fix seems obviously good.
The weston_compositor::destroy_signal I have checked that we do already
have at least one listener that gets removed on the callback, so we do
need to have all listeners removed.
Reviewed-by: Pekka Paalanen
Thanks,
pq
On Tue, 7 Aug 2018 19:05:04 +0530
Harsha M M wrote:
> Signed-off-by: Harsha M M
> ---
> ivi-shell/ivi-shell.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/ivi-shell/ivi-shell.c b/ivi-shell/ivi-shell.c
> index 58f53bc..92e8f17 100644
> --- a/ivi-shell/ivi-shell.c
> +++
land/
> -for links where to get it and the sample `.pwclientrc` for Wayland/Weston.
> +for links where to get it and the sample `.pwclientrc` for Wayland.
>
>
> Coding style
Reviewed-by: Pekka Paalanen
Thanks,
pq
pgp4Zud90qxrV.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
ols, with `autogen.sh` and `make`. It often
> depends
> +on the current release versions of
> +[Wayland](https://gitlab.freedesktop.org/wayland/wayland) and
> +[wayland-protocols](https://cgit.freedesktop.org/wayland/wayland-protocols).
> +
> +Every commit of Weston is b
On Mon, 6 Aug 2018 14:20:51 +0300
Pekka Paalanen wrote:
> On Fri, 20 Jul 2018 20:03:27 +0100
> Daniel Stone wrote:
>
> > From: Pekka Paalanen
> >
> > This registers a new weston-debug scope "log" through which one can get
> > live log output inters
On Fri, 20 Jul 2018 20:03:35 +0100
Daniel Stone wrote:
> Add a 'drm-debug' scope which prints verbose information about the DRM
> backend's repaint cycle, including the decision tree on how views are
> assigned (or not) to planes.
>
> Signed-off-by: Daniel Stone
> ---
>
LY_SYNC:
> - break;
> - case DRM_STATE_APPLY_ASYNC:
> - flags |= DRM_MODE_PAGE_FLIP_EVENT | DRM_MODE_ATOMIC_NONBLOCK;
> - break;
> - case DRM_STATE_TEST_ONLY:
> - flags |= DRM_MODE_ATOMIC_TEST_ONLY;
> - break;
On Mon, 6 Aug 2018 14:54:16 -0700
Lloyd Pique wrote:
> Hi Pekka,
>
> Sorry for the lack of any updates for (over) a month. I was on holiday for
> a while, and had a few other things come up delaying me from getting back
> to this.
Hi,
so was I! :-)
>
> I've created a first set of patches
On Fri, 20 Jul 2018 20:03:33 +0100
Daniel Stone wrote:
> Add a 'scene-graph' debug scope which will dump out the current set of
> outputs, layers, and views and as much information as possible about how
> they are rendered and composited.
>
> Signed-off-by: Daniel Stone
> ---
>
&&
> +layer->mask.x2 == INT32_MIN + UINT32_MAX &&
> +layer->mask.y2 == INT32_MIN + UINT32_MAX;
> +}
Hi Daniel,
I suppose this repeats what weston_layer_set_mask_infinite() does, so
Reviewed-by: Pekka Paalanen
They are both overflowing int or m
On Fri, 20 Jul 2018 20:03:24 +0100
Daniel Stone wrote:
> From: Pekka Paalanen
>
> weston_debug is both a libweston API for relaying debugging messages,
> and the compositor-debug wayland protocol implementation for accessing those
> debug messages from a
eston_debug_scope_timestamp() return void.
Reading the manual, you are correct and this is needed.
Squashing this into the appropriate commit (patch 6) retains:
Reviewed-by: Pekka Paalanen
custom_handler() and vlog_continue() seem to need the same fix.
Thanks,
pq
pgp5JAuCJQqif.pgp
Description:
On Fri, 20 Jul 2018 20:03:27 +0100
Daniel Stone wrote:
> From: Pekka Paalanen
>
> This registers a new weston-debug scope "log" through which one can get
> live log output interspersed with possible other debugging prints.
>
> Signed-off-by: Pekka Paala
On Fri, 20 Jul 2018 20:03:24 +0100
Daniel Stone wrote:
> From: Pekka Paalanen
>
> weston_debug is both a libweston API for relaying debugging messages,
> and the compositor-debug wayland protocol implementation for accessing those
> debug messages from a
On Fri, 20 Jul 2018 20:03:26 +0100
Daniel Stone wrote:
> From: Pekka Paalanen
>
> A tool for accessing the zcompositor_debug_v1 interface features.
>
> Installed along weston-info, because it should be potentially useful for
> people running libweston-based compositor
On Fri, 3 Aug 2018 18:04:36 -0400
Sichem Zhou wrote:
> Hi Pekka,
>
> Thanks for your reply. Yes, preferably if I can hide the map and unmap from
> client, in this case I cannot because it is part of a desktop shell. After
> I unmap it and remap the view next time, it is not expected the shell
On Fri, 20 Jul 2018 20:03:24 +0100
Daniel Stone wrote:
> From: Pekka Paalanen
>
> weston_debug is both a libweston API for relaying debugging messages,
> and the compositor-debug wayland protocol implementation for accessing those
> debug messages from a
> On Sat, Jul 28, 2018 at 8:15 PM, Sichem Zhou wrote:
>
> > Dear Weston devs:
> >
> > Sorry for the bothering in when weston-5.0 is approaching, but I am stuck
> > in the project for three days I need some one's help very much.
> >
> > I have a widget implementation of shell widgets that
+[many GitLab CLI
> clients](https://about.gitlab.com/applications/#cli-clients),
> +if you prefer to avoid the web interface. It may be difficult to follow
> review
> +comments without using the web interface though, so we do recommend using
> this
> +to go through the review pr
gain
> +privileged access to input and output devices by running as root, then
> granting
> +access to the main Weston binary running as your user. Running Weston this
> way
> +is not recommended unless necessary.
I've seen people struggle with the remote launch before, so
On Fri, 20 Jul 2018 12:26:22 +0100
Daniel Stone wrote:
> Hi Deepak,
>
> On Fri, 20 Jul 2018 at 12:21, Deepak Singh Rawat wrote:
> > In brief the damage is in frame-buffer coordinate of attached fb to the
> > plane.
> > Unlike plane src coordinates, damage clips are not in 16.16 fixed point.
i,
thanks for working on this, much appreciated.
These patches are:
Acked-by: Pekka Paalanen
The CI stuff is still pretty new to me, so I'd leave pushing and
verifying these for Daniel if that's ok. Strictly thinking we'd need to
wait for the final Wayland release before merging these, but I'd be ok
la
On Thu, 12 Jul 2018 13:49:06 +0200
Santiago Otero wrote:
> Hi all,
>
> I have a display device that supports up to three different display
> buffers: one graphic layer and two video layers. The graphic layer is at
> the top (zpos=2).
>
> I'm using Weston (DRM backend) with a Qt5 application
On Wed, 11 Jul 2018 21:42:24 -0400
Sichem Zhou wrote:
> Hi All,
>
> I have a question related to the wl_client creation in the compositor. I
> followed these step like weston did:
>
> 1. create socketpair.
> 2. fork a process and close `socket[0]` in child, close `socket[1]` in in
> parent
ne.
>
> Shift the check downwards so it only applies to overlay rather than
> scanout planes.
>
> Signed-off-by: Daniel Stone
> ---
> libweston/compositor-drm.c | 14 --
> 1 file changed, 8 insertions(+), 6 deletions(-)
Reviewed-by: Pekka Paalanen
Thanks,
On Wed, 11 Jul 2018 13:16:18 +0100
Daniel Stone wrote:
> a0f8276fe814 ("compositor-drm: Disallow overlapping overlay planes") was
> a little too pessimistic in rejecting occluded views. Whilst it
> correctly prevented overlay planes from occluding each other, it also
> prevented overlay planes
state->ev = ev;
> + state->output = output;
> + drm_plane_state_coords_for_view(state, ev);
Forgot to check that drm_plane_state_coords_for_view() succeeded.
> + if (state->src_w != state->dest_w << 16 ||
> +
rm_view_is_opaque(ev))
> force_renderer = true;
>
> + if (force_renderer && !renderer_ok) {
> + pixman_region32_fini(_view);
> + goto err_region;
> + }
This early exit seems com
force_renderer = true;
> +
> /* Ignore views we know to be totally occluded. */
> pixman_region32_init(_view);
> pixman_region32_intersect(_view,
Reviewed-by: Pekka Paalanen
Thanks,
pq
pgpEWbKEqd5Fe.pgp
Description: Ope
ing KMS state to a device. Updates the state for all outputs in the
> - * pending_state, as well as disabling any unclaimed outputs.
> + * Tests a pending state, to see if the kernel will accept the update as
> + * constructed.
> *
> - * Unconditionally takes ownership of pending_stat
hanged, 31 insertions(+), 32 deletions(-)
Reviewed-by: Pekka Paalanen
Oh, I've forgot to nitpick about commit messages. E.g. this one is
missing the "why". ;-)
Thanks,
pq
>
> diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
> index 56e7e5d1f..4bf18581b 1
ixed and renderer-only modes (previously
> differentiated only by the sprites_are_broken flag), with the
> planes-only mode being left for a later patch.
>
> Signed-off-by: Daniel Stone
> ---
> libweston/compositor-drm.c | 70 ++++--
> 1 file changed, 45
On Tue, 10 Jul 2018 18:58:44 +0100
Daniel Stone wrote:
> The atomic API can allow us to test state before we apply it, to see if
> it will be valid. Use this when we construct a plane configuration, to
> see if it has a chance of ever working. If not, we can fail
> assign_planes early.
>
> This
On Wed, 11 Jul 2018 10:31:09 +0100
Daniel Stone wrote:
> Hi Pekka,
> On Wed, 11 Jul 2018 at 10:21, Pekka Paalanen wrote:
> > On Tue, 10 Jul 2018 18:58:42 +0100 Daniel Stone
> > wrote:
> > > @@ -3339,13 +3347,16 @@ drm_output_propose_state(struct weston
atter below, but it does look a little strange that a cursor surface
can first hit the cursor plane, and being non-opaque it also sets
force_renderer.
Actually, I think this will become a problem with "Add planes-only mode
to state proposal" patch.
Should probably be
if (!ps &am
On Wed, 11 Jul 2018 12:21:07 +0300
Pekka Paalanen wrote:
> On Tue, 10 Jul 2018 18:58:42 +0100
> Daniel Stone wrote:
>
> > Add support for multiple modes to drm_output_propose_state. Currently we
> > intend to operate in three modes: planes-only (no renderer buffer,
> &g
gt; struct weston_view *ev;
> struct weston_plane *primary = _base->compositor->primary_plane;
> + enum drm_output_propose_state_mode mode;
> +
> + if (!b->sprites_are_broken)
> + state = drm_output_propose_state(output_base, pending_state,
> +
>
for scanout bypass when using the
> non-atomic path. Future patches lift the restriction when using atomic
> modesetting, as we can actually test and ensure that the view is
> compatible with scanout.
>
> Signed-off-by: Daniel Stone
> Reported-by: Pekka Paalanen
> ---
>
Adding more people to CC.
On Tue, 10 Jul 2018 17:53:15 +0200
Emilio Pozuelo Monfort wrote:
> No need to write libdrm driver specific code for each supported
> driver, we can just let GBM call the right one for us now.
>
> Signed-off-by: Emilio Pozuelo Monfort
> ---
>
> Hi,
>
> This
On Tue, 10 Jul 2018 14:56:18 +0100
Daniel Stone wrote:
> Return a pointer to the plane state, rather than indirecting via a
> weston_plane.
>
> Signed-off-by: Daniel Stone
> Tested-by: Emre Ucan
> ---
> libweston/compositor-drm.c | 58 --
> 1 file changed,
On Tue, 10 Jul 2018 14:56:17 +0100
Daniel Stone wrote:
> Add support for multiple modes to drm_output_propose_state. Currently we
> intend to operate in three modes: planes-only (no renderer buffer,
> client buffers in planes only), mixed-mode (promote client buffers to
> planes where possible,
nout bypass when using the non-atomic
> path, however future patches lift the restriction when using atomic
> modesetting, as we can actually test and ensure that the view is
> compatible with scanout.
>
> Signed-off-by: Daniel Stone
> Reported-by: Pekka Paalanen
> ---
> l
ever intersect each
> other.
>
> Signed-off-by: Daniel Stone
> Reported-by: Pekka Paalanen
> ---
> libweston/compositor-drm.c | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
> index 51b24
On Mon, 9 Jul 2018 17:38:49 +0200
Emilio Pozuelo Monfort wrote:
> This code calls into EGL to see if the dmabuf import modifiers
> extension is available, and if not it assumes XRGB is supported.
>
> Rather than disabling this client doesn't get build if one disables
> EGL, we can just
On Tue, 3 Jul 2018 16:46:29 +0100
Emil Velikov wrote:
> Hi Emilio,
>
> On 2 July 2018 at 16:22, Emilio Pozuelo Monfort wrote:
> > Signed-off-by: Emilio Pozuelo Monfort
> > ---
> > I tried a build with --disable-egl as I didn't have the headers
> > installed, and it broke here. The EGL usage
On Tue, 10 Jul 2018 11:47:15 +0900
Tomohito Esaki wrote:
> Since the repaint status of the flushed output may be reset if a output
> repaint is failed, it is necessary to clear the repainted flag
> immediately after output repaint flush/cancel.
>
> Signed-off-by: Tomohito Esaki
> ---
>
; + */
> + if (!b->atomic_modeset)
> + b->sprites_are_broken = 1;
> +
Maybe one day we could replace sprites_are_broken with !atomic_modeset?
Reviewed-by: Pekka Paalanen
Thanks,
pq
> ret = drmSetClientCap(b->drm.fd, DRM_CLIENT_CAP_ASPECT_RATI
sted-by: Emre Ucan
> ---
> libweston/compositor-drm.c | 21 +
> 1 file changed, 13 insertions(+), 8 deletions(-)
Reviewed-by: Pekka Paalanen
Thanks,
pq
>
> diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
> index 0a3f524f5..b97872aa1 10064
On Mon, 9 Jul 2018 14:23:17 +0100
Daniel Stone wrote:
> Return a pointer to the plane state, rather than indirecting via a
> weston_plane.
>
> Signed-off-by: Daniel Stone
> Tested-by: Emre Ucan
> ---
> libweston/compositor-drm.c | 71 +-
> 1 file changed,
On Tue, 10 Jul 2018 12:06:00 +0300
Pekka Paalanen wrote:
> On Mon, 9 Jul 2018 14:23:15 +0100
> Daniel Stone wrote:
>
> > When trying to assign planes, keep track of the areas which are
> > already occluded, and ignore views which are completely occluded. This
> >
On Tue, 10 Jul 2018 08:53:54 +0100
Daniel Stone wrote:
> Hi,
> On Mon, 29 Jan 2018 at 10:55, Pekka Paalanen wrote:
> > On Mon, 29 Jan 2018 09:17:49 + Daniel Stone
> > wrote:
> > > On 26 January 2018 at 14:04, Pekka Paalanen wrote:
> > >
pixman_region32_union(_region,
> _region,
> - >transform.boundingbox);
> + _view);
> + else if (output->cursor_plane &&
> +
On Tue, 10 Jul 2018 08:41:46 +0100
Daniel Stone wrote:
> Hi Pekka,
>
> On Mon, 29 Jan 2018 at 15:01, Pekka Paalanen wrote:
> > On Wed, 20 Dec 2017 12:26:57 + Daniel Stone
> > wrote:
> > > @@ -212,6 +212,9 @@ if test x$enable_drm_compositor = xyes; t
insertions(+), 8 deletions(-)
>
> On Mon, 9 Jul 2018 at 14:54, Pekka Paalanen wrote:
> > I'm fairly paranoid of copying GPL code. The implementation sure is
> > trivial, but what exactly did you take from the kernel?
> > The documentation bit looks already copyrightable.
t;
> Signed-off-by: Daniel Stone
> Tested-by: Emre Ucan
> ---
> configure.ac | 3 ++
> libweston/compositor-drm.c | 57 --
> 2 files changed, 51 insertions(+), 9 deletions(-)
>
Reviewed-by: Pekka Paalanen
Thanks,
pq
quot;plane (%d) and IN_FORMATS (%d)\n",
> + plane->count_formats,
> +fmt_mod_blob->count_formats);
> + weston_log("This represents a kernel bug; Weston is "
> +"unable to continu
+ BUILD_BUG_ON(ARRAY_LENGTH(import_mod.offsets) !=
> + ARRAY_LENGTH(dmabuf->attributes.offset));
> + BUILD_BUG_ON(sizeof(import_mod.offsets) !=
> + sizeof(dmabuf->attributes.offset));
> + memcpy(import_mod.offsets, dmabuf->attributes.offset,
> +sizeof(import_mod.offsets));
Nice catch, I didn't even see the wrong names before.
All my comments are addressed.
Reviewed-by: Pekka Paalanen
Thanks,
pq
pgpNZH5rb4lSy.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
ORMAT_MOD_INVALID;
> - fb->size = fb->strides[0] * fb->height;
> + fb->size = 0;
> fb->fd = backend->drm.fd;
>
> if (!fb->format) {
Reviewed-by: Pekka Paalanen
Thanks,
pq
pgpicrplFPoYO.pgp
Description: OpenPGP digital signature
_
fb->handles[i]; i++)
> + for (i = 0; i < ARRAY_LENGTH(mods) && fb->handles[i]; i++)
> mods[i] = fb->modifier;
> ret = drmModeAddFB2WithModifiers(fb->fd, fb->width, fb->height,
>
On Mon, 9 Jul 2018 14:23:07 +0100
Daniel Stone wrote:
> Import the trivial definition of BUILD_BUG_ON() from the Linux kernel.
> This evaluates an expression such that it will call sizeof() on a
> negative-length array if the expression is false, generating a compiler
> error.
>
> This will be
On Mon, 9 Jul 2018 13:42:45 +0100
Daniel Stone wrote:
> Hi,
> On Mon, 9 Jul 2018 at 11:08, Pekka Paalanen wrote:
> > On Thu, 5 Jul 2018 18:16:41 +0100 Daniel Stone
> > wrote:
> > > The per-plane IN_FORMATS property adds information about format
> > >
On Mon, 9 Jul 2018 13:25:50 +0100
Daniel Stone wrote:
> Hi Pekka,
>
> On Mon, 9 Jul 2018 at 11:22, Pekka Paalanen wrote:
> > On Mon, 9 Jul 2018 12:39:30 +0300 Pekka Paalanen
> > wrote:
> > > On Thu, 5 Jul 2018 18:16:40 +0100 Daniel Stone
> > >
On Fri, 6 Jul 2018 11:36:49 +0100
Daniel Stone wrote:
> The DPMS connector property is an enum property in KMS, which made our
> property handling complain at startup as we weren't defining its enums.
> Fix our definition so we parse the enum values.
>
> The only user of the property is the
On Fri, 6 Jul 2018 16:18:39 +0530
"Nautiyal, Ankit K" wrote:
> From: Ankit Nautiyal
>
> The weston.ini.man describes the mode-formats that a user can specify
> for selecting a video mode. The DRM specific examples are already
> provided in weston-drm.man, so this inofrmation is redundant and
On Thu, 5 Jul 2018 18:16:42 +0100
Daniel Stone wrote:
> Use the extended GBM allocator interface to support modifiers and
> multi-planar BOs.
>
> Signed-off-by: Daniel Stone
> Tested-by: Emre Ucan
> ---
> configure.ac | 3 ++
> libweston/compositor-drm.c | 61
On Mon, 9 Jul 2018 12:39:30 +0300
Pekka Paalanen wrote:
> On Thu, 5 Jul 2018 18:16:40 +0100
> Daniel Stone wrote:
>
> > Add support for the GBM_BO_IMPORT_FD_MODIFIER path, which allows us to
> > import multi-plane dmabufs, as well as format modifiers.
> >
>
On Thu, 5 Jul 2018 18:16:41 +0100
Daniel Stone wrote:
> From: Sergi Granell
>
> The per-plane IN_FORMATS property adds information about format
> modifiers; we can use these to both feed GBM with the set of modifiers
> we want to use for rendering, and also as an early-out test when we're
>
On Thu, 5 Jul 2018 18:16:40 +0100
Daniel Stone wrote:
> Add support for the GBM_BO_IMPORT_FD_MODIFIER path, which allows us to
> import multi-plane dmabufs, as well as format modifiers.
>
> Signed-off-by: Daniel Stone
> Tested-by: Emre Ucan
> ---
> configure.ac | 6 +-
>
y API, and we don't try to account for
> + * simple cropping/translation in cursor_bo_update. */
> + plane_state->output = output;
> + if (!drm_plane_state_coords_for_view(plane_state, ev))
> + goto err;
> +
> + if (plane_state->src_x != 0
lt; 16 ||
> + state->dest_x != 0 || state->dest_y != 0 ||
> + state->dest_w != (unsigned) output->base.current_mode->width ||
> + state->dest_h != (unsigned) output->base.current_mode->height)
> + goto err;
> +
> bo = gbm_bo_import(b->gbm, GBM_BO_IMPORT_WL_BUFFER,
> buffer->resource, GBM_BO_USE_SCANOUT);
>
Anyway:
Reviewed-by: Pekka Paalanen
Thanks,
pq
pgpecLNxbfgqb.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
On Thu, 5 Jul 2018 18:16:33 +0100
Daniel Stone wrote:
> Put some more transformation checks in drm_view_transform_supported.
>
Please mention that this patch removes the requirement of identical
scales for overlays and the reason why. It seems to have been replaced
with a less strict check
On Thu, 5 Jul 2018 18:16:32 +0100
Daniel Stone wrote:
> In our new and improved helper to determine the src/dest values for a
> buffer on a given plane, make sure we account for all buffer
> transformations, including viewport clipping.
>
> Rather than badly open-coding it ourselves, just use
output->base.width,
> - output->base.height);
> - pixman_region32_subtract(, , >opaque);
> + /* We can scanout an ARGB buffer if the surface's
> + * opaque region covers the who
erty_get_value(struct drm_property_info *info,
> -drmModeObjectPropertiesPtr props,
> +const drmModeObjectProperties *props,
> uint64_t def)
> {
> unsigned int i;
Hi,
'info' could be similarly const too.
Reviewed-by: Pekka Paalanen
701 - 800 of 5785 matches
Mail list logo
