Re: [PATCH weston 1/3] compositor-drm: Read FB2_MODIFIERS capability

2018-09-17 Thread Sinclair Yeh
This series, Acked-by: Sinclair Yeh On Wed, Sep 05, 2018 at 05:18:15PM -0700, Deepak Rawat wrote: > Not all drivers support fb2 modifiers so read the capability before > using drmModeAddFB2WithModifiers. > > Signed-off-by: Deepak Rawat > --- > libweston/com

[PATCH] Prevent zero sized wl_egl_window

2014-02-12 Thread Sinclair Yeh
It is illegal to create or resize a window to zero (or negative) width and/or height. This patch prevents such a request from happening. --- src/egl/wayland/wayland-egl/wayland-egl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/egl/wayland/wayland-egl/wayland-egl.c

Re: [PATCH weston 2/3] gl-renderer: Fix initial upload of SHM buffer as texture

2013-06-10 Thread Sinclair Yeh
, -gs-height / es-buffer_scale); + + gs-needs_full_upload = 1; } if (wl_shm_buffer_get_format(buffer) == WL_SHM_FORMAT_XRGB) This looks good to me. Reviewed-by: Sinclair Yeh sinclair

[PATCH] Avoid unnecessarily re-allocating texture buffer when the size hasn't changed.

2013-06-06 Thread Sinclair Yeh
v4: Incorporated krh and anderco's comments. Now adding newly allocated buffer's dimensions to texture_damage v3: * Removed unnecessary parentheses * Added check for switching from EGL image to SHM buffer * Moved shader assignment out of IF condition v2: Fixed the wrong comparison v1:

Re: [PATCH] gl-renderer: Always release previous EGL images on attach

2013-06-06 Thread Sinclair Yeh
On Wed, 5 Jun 2013 12:21:05 +0300 Ander Conselvan de Oliveira conselv...@gmail.com wrote: From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com When attaching a new buffer, the EGL images created for the previous one would be released if this new buffer was an EGL or NULL

Re: [PATCH] Avoid unnecessarily re-allocating texture buffer when the size hasn't changed.

2013-05-28 Thread Sinclair Yeh
On Sun, 26 May 2013 20:03:40 -0400 Kristian Høgsberg hoegsb...@gmail.com wrote: + /* Only allocate a texture if it doesn't match existing one */ + if (((wl_shm_buffer_get_stride(buffer) / 4) != gs-pitch) || + (buffer-height != gs-height)) { I would

[PATCH] Avoid unnecessarily re-allocating texture buffer when the size hasn't changed.

2013-05-28 Thread Sinclair Yeh
v3: * Removed unnecessary parentheses * Added check for switching from EGL image to SHM buffer * Moved shader assignment out of IF condition v2: Fixed the wrong comparison v1: Depending on specific DRI driver implementation, glTexImage2D() with data set to NULL may or may not re-allocate the

[PATCH] Avoid unnecessarily re-allocating texture buffer when the size hasn't changed.

2013-05-23 Thread Sinclair Yeh
Depending on specific DRI driver implementation, glTexImage2D() with data set to NULL may or may not re-allocate the texture buffer each time it is called. Unintended consequences happen if later glTexSubImage2D() is called to only update a sub-region of the texture buffer. I've explored moving

Re: [PATCH] Avoid unnecessarily re-allocating texture buffer when the size hasn't changed.

2013-05-23 Thread Sinclair Yeh
On Thu, May 23, 2013 at 05:47:01PM +0100, Daniel Stone wrote: Hi, On 23 May 2013 17:38, Sinclair Yeh sinclair@intel.com wrote: + /* Only allocate a texture if it doesn't match existing one */ + if (((wl_shm_buffer_get_stride(buffer) / 4) != gs-pitch

[PATCH] Avoid unnecessarily re-allocating texture buffer when the size hasn't changed.

2013-05-23 Thread Sinclair Yeh
v2: Fixed the wrong comparison v1: Depending on specific DRI driver implementation, glTexImage2D() with data set to NULL may or may not re-allocate the texture buffer each time it is called. Unintended consequences happen if later glTexSubImage2D() is called to only update a sub-region of the