Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-08-14 Thread Pekka Paalanen
On Thu, 13 Aug 2015 13:12:42 +1000 Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Aug 12, 2015 at 02:41:08PM +0300, Pekka Paalanen wrote: On Mon, 25 May 2015 01:12:15 -0700 Dima Ryazanov d...@gmail.com wrote: Although defaulting to wayland-0 seems convenient, it has an

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-08-14 Thread Ray Strode
Hi, thanks, and sorry I didn't see your reply before I pushed. :-D So this commit totally broke gtk+. Thread 1 (Thread 0x7f3813651980 (LWP 537)): #0 g_logv (log_domain=0x7f38128b01ce Gdk, log_level=G_LOG_LEVEL_ERROR, format=optimized out, args=optimized out) at ../../glib/gmessages.c:1078

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-08-12 Thread Peter Hutterer
On Wed, Aug 12, 2015 at 02:41:08PM +0300, Pekka Paalanen wrote: On Mon, 25 May 2015 01:12:15 -0700 Dima Ryazanov d...@gmail.com wrote: Although defaulting to wayland-0 seems convenient, it has an undesirable side effect: clients may unintentionally connect to the wrong compositor.

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-08-12 Thread Dima Ryazanov
Sounds good, will do! On Wed, Aug 12, 2015 at 4:41 AM, Pekka Paalanen ppaala...@gmail.com wrote: On Mon, 25 May 2015 01:12:15 -0700 Dima Ryazanov d...@gmail.com wrote: Although defaulting to wayland-0 seems convenient, it has an undesirable side effect: clients may unintentionally connect

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-08-12 Thread Pekka Paalanen
On Mon, 25 May 2015 01:12:15 -0700 Dima Ryazanov d...@gmail.com wrote: Although defaulting to wayland-0 seems convenient, it has an undesirable side effect: clients may unintentionally connect to the wrong compositor. Generally, it's safer to fail instead. Here's a real example: In Fedora

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-06-24 Thread Dima Ryazanov
Bringing this up again. What do you guys think? Does it make sense to push this change? On Wed, May 27, 2015 at 1:50 AM, Dima Ryazanov d...@gmail.com wrote: (Oops, sent too soon by accident.) Yep, DISPLAY always needs to be set - and I figured, there's a reason it is that way, so that's

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-06-24 Thread Jasper St. Pierre
I'm for it as well. On Wed, Jun 24, 2015 at 9:53 AM, Dima Ryazanov d...@gmail.com wrote: Bringing this up again. What do you guys think? Does it make sense to push this change? On Wed, May 27, 2015 at 1:50 AM, Dima Ryazanov d...@gmail.com wrote: (Oops, sent too soon by accident.) Yep,

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-05-27 Thread Dima Ryazanov
Yep, DISPLAY always needs to be set - and I figured, there's a reason On Tue, May 26, 2015 at 2:59 AM, Pekka Paalanen ppaala...@gmail.com wrote: On Tue, 26 May 2015 10:40:15 +0100 Daniel Stone dan...@fooishbar.org wrote: Hi, On 26 May 2015 at 10:26, Giulio Camuffo

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-05-27 Thread Dima Ryazanov
(Oops, sent too soon by accident.) Yep, DISPLAY always needs to be set - and I figured, there's a reason it is that way, so that's actually why I thought it made sense to use the same convention for WAYLAND_DISPLAY. Also, regarding Bill's first comment: yeah, that certainly works, but it feels

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-05-26 Thread Pekka Paalanen
On Mon, 25 May 2015 01:12:15 -0700 Dima Ryazanov d...@gmail.com wrote: Although defaulting to wayland-0 seems convenient, it has an undesirable side effect: clients may unintentionally connect to the wrong compositor. Generally, it's safer to fail instead. Here's a real example: In Fedora

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-05-26 Thread Pekka Paalanen
On Tue, 26 May 2015 10:40:15 +0100 Daniel Stone dan...@fooishbar.org wrote: Hi, On 26 May 2015 at 10:26, Giulio Camuffo giuliocamu...@gmail.com wrote: 2015-05-26 12:21 GMT+03:00 Pekka Paalanen ppaala...@gmail.com: I have a vague recollection this has been proposed before, but I can't

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-05-26 Thread Giulio Camuffo
2015-05-26 12:21 GMT+03:00 Pekka Paalanen ppaala...@gmail.com: On Mon, 25 May 2015 01:12:15 -0700 Dima Ryazanov d...@gmail.com wrote: Although defaulting to wayland-0 seems convenient, it has an undesirable side effect: clients may unintentionally connect to the wrong compositor. Generally,

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-05-26 Thread Daniel Stone
Hi, On 26 May 2015 at 10:26, Giulio Camuffo giuliocamu...@gmail.com wrote: 2015-05-26 12:21 GMT+03:00 Pekka Paalanen ppaala...@gmail.com: I have a vague recollection this has been proposed before, but I can't remember if there was any interest or discussion, nor what was the original intent

[PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-05-25 Thread Dima Ryazanov
Although defaulting to wayland-0 seems convenient, it has an undesirable side effect: clients may unintentionally connect to the wrong compositor. Generally, it's safer to fail instead. Here's a real example: In Fedora 22, Gtk+ prefers Wayland over X11, though the default session is still a

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-05-25 Thread Bill Spitzak
It can use wayland-0 if $DISPLAY is not set. So the rules programs that can use both Wayland and X11 but prefer Wayland could be: Use $WAYLAND_DISPLAY if set Use $DISPLAY if set Use wayland-0 On 05/25/2015 01:12 AM, Dima Ryazanov wrote: Although defaulting to wayland-0 seems convenient, it