Re: Reusing wl_egl_window for multiple EGL surfaces

2014-10-28 Thread Pekka Paalanen
On Mon, 27 Oct 2014 10:15:20 -0700 Virtual Presence virtualpresence.u...@gmail.com wrote: I see. Thank you for the info. What i am trying to do is have multiple contexts with its own EGLSurface but sharing the same window or wl_surface on wayland, where one thread renders a gl_triangle and the

Re: [PATCH libinput] evdev: Log evdev event queue overflows

2014-10-28 Thread Ran Benita
On Mon, Oct 27, 2014 at 09:26:39AM -0500, Derek Foreman wrote: Log a message when the kernel event queue overflows and events are dropped. After 10 messages logging stops to avoid flooding the logs if the condition is persistent. --- src/evdev.c | 10 ++ 1 file changed, 10

[PATCH] smoke: fix valgrind invalid read errors

2014-10-28 Thread Frank Binns
There are a number of invalid read errors reported by valgrind of the form: ==13428== Invalid read of size 4 ==13428==at 0x405656: advect (smoke.c:116) ==13428==by 0x405E80: redraw_handler (smoke.c:228) ==13428==by 0x40DE74: widget_redraw (window.c:3995)

Re: [PATCH v3] wayland-util: added wl_strtol/wl_strtoul utility functions

2014-10-28 Thread Giulio Camuffo
2014-10-27 18:51 GMT+02:00 Jasper St. Pierre jstpie...@mecheye.net: Can I also suggest that we don't make this public API? These are internal helpers for libwayland, not designed for any consumers. We've been burned by making too much internal helper API public before. +1 I don't think this

Re: [PATCH libinput] evdev: Log evdev event queue overflows

2014-10-28 Thread Derek Foreman
On 27/10/14 07:11 PM, Peter Hutterer wrote: On Mon, Oct 27, 2014 at 09:33:45AM -0500, Derek Foreman wrote: A couple of questions on this one: Is it ok to limit logging to 10 messages like this? IMO yes. Should I be doing that on a per device basis instead of globally? you are doing it

Re: [RFC PATCH v2 0/6] Initial per-surface color management

2014-10-28 Thread Kai-Uwe Behrmann
Am 27.10.2014 um 19:07 schrieb Niels Ole Salscheider: The support to mask the area of a surface so that its color space is not converted has been removed. Instead, the color profile of the main output of that surface can be attached if an application has a need to display uncorrected colors.

Re: [PATCH v3] wayland-util: added wl_strtol/wl_strtoul utility functions

2014-10-28 Thread Daniel Stone
Hi, On 28 October 2014 11:21, Giulio Camuffo giuliocamu...@gmail.com wrote: 2014-10-27 18:51 GMT+02:00 Jasper St. Pierre jstpie...@mecheye.net: Can I also suggest that we don't make this public API? These are internal helpers for libwayland, not designed for any consumers. We've been

Re: [PATCH v3] wayland-util: added wl_strtol/wl_strtoul utility functions

2014-10-28 Thread Imran Zaman
You guys should check the reason why the patch is there rather than throwing out random thoughts or blunt comments. I did this patch mainly because weston/wayland has been using strtol/strtoul functions in number of places with buggy error checks, and duplicate code everywhere. Weston and wayland

Re: [PATCH v3] wayland-util: added wl_strtol/wl_strtoul utility functions

2014-10-28 Thread Daniel Stone
Hi, On 28 October 2014 15:40, Imran Zaman imran.za...@gmail.com wrote: You guys should check the reason why the patch is there rather than throwing out random thoughts or blunt comments. I did this patch mainly because weston/wayland has been using strtol/strtoul functions in number of

Re: [PATCH Weston 1/1] desktop-shell: implement autolaunch

2014-10-28 Thread Daniel Stone
Hi, On 24 October 2014 11:18, Pekka Paalanen pekka.paala...@collabora.co.uk wrote: On Fri, 24 Oct 2014 10:28:57 +0100 Daniel Stone dan...@fooishbar.org wrote: Hmm. Can we please use weston_client_start here instead of open-coding it? weston_client_start() does not support passing in

Re: [PATCH libinput] evdev: Log evdev event queue overflows

2014-10-28 Thread Derek Foreman
On 28/10/14 03:20 AM, Ran Benita wrote: On Mon, Oct 27, 2014 at 09:26:39AM -0500, Derek Foreman wrote: Log a message when the kernel event queue overflows and events are dropped. After 10 messages logging stops to avoid flooding the logs if the condition is persistent. --- src/evdev.c | 10

Re: [PATCH libinput] evdev: Log evdev event queue overflows

2014-10-28 Thread Bill Spitzak
I can't imagine any way this static variable will mess up with multiple threads. At worst not exactly 10 messages will be printed but that seems really harmless. Every processor writes to memory a number larger than it read, so eventually every processor will see a number = 10 even if there

Re: [PATCH libinput] evdev: Log evdev event queue overflows

2014-10-28 Thread Peter Hutterer
On Tue, Oct 28, 2014 at 02:18:25PM -0500, Derek Foreman wrote: On 28/10/14 03:20 AM, Ran Benita wrote: On Mon, Oct 27, 2014 at 09:26:39AM -0500, Derek Foreman wrote: Log a message when the kernel event queue overflows and events are dropped. After 10 messages logging stops to avoid flooding

Re: [PATCH libinput] evdev: Log evdev event queue overflows

2014-10-28 Thread Peter Hutterer
On Tue, Oct 28, 2014 at 09:32:20AM -0500, Derek Foreman wrote: On 27/10/14 07:11 PM, Peter Hutterer wrote: On Mon, Oct 27, 2014 at 09:33:45AM -0500, Derek Foreman wrote: A couple of questions on this one: Is it ok to limit logging to 10 messages like this? IMO yes. Should I be