[webkit-changes] [294897] trunk

2022-05-26 Thread david_quesada
Title: [294897] trunk Revision 294897 Author david_ques...@apple.com Date 2022-05-26 14:12:24 -0700 (Thu, 26 May 2022) Log Message Define WK_NOT_NO in SDKVariant.xcconfig https://bugs.webkit.org/show_bug.cgi?id=240963 rdar://problem/93984643 Reviewed by Alexey Proskuryakov. Provide a de

[webkit-changes] [294855] trunk/Source

2022-05-25 Thread david_quesada
Title: [294855] trunk/Source Revision 294855 Author david_ques...@apple.com Date 2022-05-25 18:16:04 -0700 (Wed, 25 May 2022) Log Message USE_SYSTEM_CONTENT_PATH and USE_STAGING_INSTALL_PATH should be able to coexist https://bugs.webkit.org/show_bug.cgi?id=240723 rdar://92000421 Reviewed

[webkit-changes] [294853] trunk/metadata/contributors.json

2022-05-25 Thread david_quesada
Title: [294853] trunk/metadata/contributors.json Revision 294853 Author david_ques...@apple.com Date 2022-05-25 17:23:12 -0700 (Wed, 25 May 2022) Log Message Add my GitHub account to contributors.json Reviewed by Jonathan Bedard. * metadata/contributors.json: Canonical link: https://co

[webkit-changes] [291943] trunk/Source/WebKit

2022-03-26 Thread david_quesada
Title: [291943] trunk/Source/WebKit Revision 291943 Author david_ques...@apple.com Date 2022-03-26 13:30:34 -0700 (Sat, 26 Mar 2022) Log Message Update the check in the sandbox profiles to guard the system content path rules https://bugs.webkit.org/show_bug.cgi?id=238419 rdar://90878560

[webkit-changes] [291941] trunk/Source/WebKit

2022-03-26 Thread david_quesada
Title: [291941] trunk/Source/WebKit Revision 291941 Author david_ques...@apple.com Date 2022-03-26 12:54:57 -0700 (Sat, 26 Mar 2022) Log Message REGRESSION(r291814): WebAuthn sandbox profile is missing https://bugs.webkit.org/show_bug.cgi?id=238418 rdar://90878872 Reviewed by Per Arne Vo

[webkit-changes] [291713] trunk/Source/ThirdParty/libwebrtc

2022-03-22 Thread david_quesada
Title: [291713] trunk/Source/ThirdParty/libwebrtc Revision 291713 Author david_ques...@apple.com Date 2022-03-22 15:28:11 -0700 (Tue, 22 Mar 2022) Log Message REGRESSION(r291455): libwebrtc has the wrong install name when using override frameworks directory https://bugs.webkit.org/show_bu

[webkit-changes] [288451] trunk/Source

2022-01-24 Thread david_quesada
Title: [288451] trunk/Source Revision 288451 Author david_ques...@apple.com Date 2022-01-24 09:44:12 -0800 (Mon, 24 Jan 2022) Log Message Simplify accesses to SystemVersion.plist https://bugs.webkit.org/show_bug.cgi?id=234306 Reviewed by Alexey Proskuryakov. Source/WebCore: No new test

[webkit-changes] [268197] trunk/Source/WebKit

2020-10-08 Thread david_quesada
Title: [268197] trunk/Source/WebKit Revision 268197 Author david_ques...@apple.com Date 2020-10-08 11:50:42 -0700 (Thu, 08 Oct 2020) Log Message WKWebViewConfiguration._shouldRelaxThirdPartyCookieBlocking should be available on iOS https://bugs.webkit.org/show_bug.cgi?id=217443 rdar://pro

[webkit-changes] [264785] trunk/Source/WebKit

2020-07-23 Thread david_quesada
Title: [264785] trunk/Source/WebKit Revision 264785 Author david_ques...@apple.com Date 2020-07-23 13:16:49 -0700 (Thu, 23 Jul 2020) Log Message Unable to present file upload picker after interactively dismissing a previously opened picker https://bugs.webkit.org/show_bug.cgi?id=209613 rd

[webkit-changes] [261436] trunk/Source

2020-05-09 Thread david_quesada
Title: [261436] trunk/Source Revision 261436 Author david_ques...@apple.com Date 2020-05-09 09:02:26 -0700 (Sat, 09 May 2020) Log Message Remove HAVE_UI_SCROLL_VIEW_INDICATOR_FLASHING_SPI https://bugs.webkit.org/show_bug.cgi?id=211662 rdar://problem/63048713 Reviewed by Darin Adler. Sou

[webkit-changes] [259061] trunk/Source/WebKit

2020-03-26 Thread david_quesada
Title: [259061] trunk/Source/WebKit Revision 259061 Author david_ques...@apple.com Date 2020-03-26 11:58:42 -0700 (Thu, 26 Mar 2020) Log Message Add SPI to specify whether file upload panels are uploading to an enterprise-managed destination https://bugs.webkit.org/show_bug.cgi?id=209607

[webkit-changes] [258095] trunk

2020-03-07 Thread david_quesada
Title: [258095] trunk Revision 258095 Author david_ques...@apple.com Date 2020-03-07 20:01:00 -0800 (Sat, 07 Mar 2020) Log Message Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated https://bugs.webkit.org/show_bug.cgi?id

[webkit-changes] [258017] trunk

2020-03-06 Thread david_quesada
Title: [258017] trunk Revision 258017 Author david_ques...@apple.com Date 2020-03-06 12:25:25 -0800 (Fri, 06 Mar 2020) Log Message Add _WKResourceLoadInfo.resourceType SPI https://bugs.webkit.org/show_bug.cgi?id=208723 Reviewed by Alex Christensen. Source/WebCore: Covered by API tests.

[webkit-changes] [255533] trunk

2020-01-31 Thread david_quesada
Title: [255533] trunk Revision 255533 Author david_ques...@apple.com Date 2020-01-31 16:47:57 -0800 (Fri, 31 Jan 2020) Log Message REGRESSION(r252185): NetworkSessionCocoa cancels downloads that receive authentication challenges https://bugs.webkit.org/show_bug.cgi?id=206984 rdar://proble

[webkit-changes] [255496] trunk/Source/WebKit

2020-01-31 Thread david_quesada
Title: [255496] trunk/Source/WebKit Revision 255496 Author david_ques...@apple.com Date 2020-01-31 08:07:18 -0800 (Fri, 31 Jan 2020) Log Message Remove unused WKProcessPool downloads SPI https://bugs.webkit.org/show_bug.cgi?id=207029 rdar://problem/59052066 Reviewed by Anders Carlsson.

[webkit-changes] [255222] trunk/Source/WebKit

2020-01-27 Thread david_quesada
Title: [255222] trunk/Source/WebKit Revision 255222 Author david_ques...@apple.com Date 2020-01-27 19:09:35 -0800 (Mon, 27 Jan 2020) Log Message Support observing a different set of view service state notifications in ApplicationStateTracker https://bugs.webkit.org/show_bug.cgi?id=201737

[webkit-changes] [253256] trunk/Source/WebKit

2019-12-07 Thread david_quesada
Title: [253256] trunk/Source/WebKit Revision 253256 Author david_ques...@apple.com Date 2019-12-07 10:46:28 -0800 (Sat, 07 Dec 2019) Log Message REGRESSION(r253231): Debug assertion failures under ~WebDeviceOrientationUpdateProvider(Proxy) https://bugs.webkit.org/show_bug.cgi?id=204977 rd

[webkit-changes] [251108] trunk/Source

2019-10-14 Thread david_quesada
Title: [251108] trunk/Source Revision 251108 Author david_ques...@apple.com Date 2019-10-14 16:24:01 -0700 (Mon, 14 Oct 2019) Log Message Remove WebCore::IOSApplication::isWebApp() https://bugs.webkit.org/show_bug.cgi?id=181259 Reviewed by Alex Christensen. Source/WebCore: As of iOS 11

[webkit-changes] [250248] trunk/Source/WebKit

2019-09-23 Thread david_quesada
Title: [250248] trunk/Source/WebKit Revision 250248 Author david_ques...@apple.com Date 2019-09-23 13:15:19 -0700 (Mon, 23 Sep 2019) Log Message [iOS] REGRESSION(r250151): Occasional assertion failures in ShareableBitmap::~ShareableBitmap() https://bugs.webkit.org/show_bug.cgi?id=202112 r

[webkit-changes] [249720] trunk/Source/WebKit

2019-09-10 Thread david_quesada
Title: [249720] trunk/Source/WebKit Revision 249720 Author david_ques...@apple.com Date 2019-09-10 09:56:46 -0700 (Tue, 10 Sep 2019) Log Message Remove a leftover reference to the StorageProcess https://bugs.webkit.org/show_bug.cgi?id=192759 Reviewed by Alex Christensen. * WebKit.xcodep

[webkit-changes] [249632] trunk/Source/WebKit

2019-09-08 Thread david_quesada
Title: [249632] trunk/Source/WebKit Revision 249632 Author david_ques...@apple.com Date 2019-09-08 23:41:17 -0700 (Sun, 08 Sep 2019) Log Message Remove some unused constants in VersionChecks.h https://bugs.webkit.org/show_bug.cgi?id=201599 Reviewed by Youenn Fablet. * UIProcess/Cocoa/Ve

[webkit-changes] [249628] trunk/Source/WTF

2019-09-07 Thread david_quesada
Title: [249628] trunk/Source/WTF Revision 249628 Author david_ques...@apple.com Date 2019-09-07 22:57:17 -0700 (Sat, 07 Sep 2019) Log Message REGRESSION(r248533): Unable to use WTF::RefCounted when building in a debug configuration against a non-debug WebKit https://bugs.webkit.org/show_b

[webkit-changes] [246551] trunk/Source/WebKit

2019-06-18 Thread david_quesada
Title: [246551] trunk/Source/WebKit Revision 246551 Author david_ques...@apple.com Date 2019-06-18 10:51:05 -0700 (Tue, 18 Jun 2019) Log Message Network process crash in SandboxExtension::consume() via Download::publishProgress https://bugs.webkit.org/show_bug.cgi?id=198968 rdar://problem

[webkit-changes] [246548] trunk/Tools

2019-06-18 Thread david_quesada
Title: [246548] trunk/Tools Revision 246548 Author david_ques...@apple.com Date 2019-06-18 10:20:10 -0700 (Tue, 18 Jun 2019) Log Message REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing https://b

[webkit-changes] [245901] trunk

2019-05-30 Thread david_quesada
Title: [245901] trunk Revision 245901 Author david_ques...@apple.com Date 2019-05-30 12:52:57 -0700 (Thu, 30 May 2019) Log Message REGRESSION (r245756) [Mac] 2 TestWebKitAPI.DownloadProgress* and TestWebKitAPI._WKDownload.DownloadMonitorCancel are flaky timeouts https://bugs.webkit.org/sh

[webkit-changes] [245756] trunk/Source/WebKit

2019-05-24 Thread david_quesada
Title: [245756] trunk/Source/WebKit Revision 245756 Author david_ques...@apple.com Date 2019-05-24 15:13:02 -0700 (Fri, 24 May 2019) Log Message Crash under WebCore::TimerBase::~TimerBase after a download is canceled https://bugs.webkit.org/show_bug.cgi?id=197927 rdar://problem/50822728

[webkit-changes] [244512] trunk/Source/WebKit

2019-04-22 Thread david_quesada
Title: [244512] trunk/Source/WebKit Revision 244512 Author david_ques...@apple.com Date 2019-04-22 14:54:58 -0700 (Mon, 22 Apr 2019) Log Message Remove linked-on-or-after check for download attribute handling https://bugs.webkit.org/show_bug.cgi?id=197176 rdar://problem/48459714 Reviewed

[webkit-changes] [242693] trunk

2019-03-10 Thread david_quesada
Title: [242693] trunk Revision 242693 Author david_ques...@apple.com Date 2019-03-10 17:27:22 -0700 (Sun, 10 Mar 2019) Log Message ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap() https://bugs.webkit.org/show_bug.cgi?id=152480 Reviewed by Chris Dumez. Source/

[webkit-changes] [242521] trunk

2019-03-05 Thread david_quesada
Title: [242521] trunk Revision 242521 Author david_ques...@apple.com Date 2019-03-05 16:48:44 -0800 (Tue, 05 Mar 2019) Log Message [WK2] It should be possible to follow links with 'download' attributes https://bugs.webkit.org/show_bug.cgi?id=195145 rdar://problem/48462642 Reviewed by Ale

[webkit-changes] [242236] trunk

2019-02-28 Thread david_quesada
Title: [242236] trunk Revision 242236 Author david_ques...@apple.com Date 2019-02-28 15:37:43 -0800 (Thu, 28 Feb 2019) Log Message Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction https://bugs.webkit.org/show_bug.cgi?id=195121 rdar://problem/48450302 Reviewed by A

[webkit-changes] [240881] trunk/Source/WebKit

2019-02-01 Thread david_quesada
Title: [240881] trunk/Source/WebKit Revision 240881 Author david_ques...@apple.com Date 2019-02-01 15:08:48 -0800 (Fri, 01 Feb 2019) Log Message Network Process crash when resuming downloads: '-[__NSDictionaryI setObject:forKey:]: unrecognized selector sent to instance %p' https://bugs.we

[webkit-changes] [239359] trunk/Tools

2018-12-18 Thread david_quesada
Title: [239359] trunk/Tools Revision 239359 Author david_ques...@apple.com Date 2018-12-18 15:59:34 -0800 (Tue, 18 Dec 2018) Log Message REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=192810 Reviewed by

[webkit-changes] [239218] trunk/Source/WebKit

2018-12-14 Thread david_quesada
Title: [239218] trunk/Source/WebKit Revision 239218 Author david_ques...@apple.com Date 2018-12-14 10:14:32 -0800 (Fri, 14 Dec 2018) Log Message Remove a global 'using namespace WebKit' in WebViewImpl.mm https://bugs.webkit.org/show_bug.cgi?id=192690 Reviewed by Tim Horton. * UIProcess/

[webkit-changes] [238937] trunk/Source/WebKit

2018-12-06 Thread david_quesada
Title: [238937] trunk/Source/WebKit Revision 238937 Author david_ques...@apple.com Date 2018-12-06 12:07:38 -0800 (Thu, 06 Dec 2018) Log Message -[WKProcessPool _resumeDownloadFromData:path:] should allow specifying the originating web view https://bugs.webkit.org/show_bug.cgi?id=192411 r

[webkit-changes] [238742] trunk

2018-11-30 Thread david_quesada
Title: [238742] trunk Revision 238742 Author david_ques...@apple.com Date 2018-11-30 10:50:55 -0800 (Fri, 30 Nov 2018) Log Message -[WKProcessPool _downloadURLRequest:] should allow specifying the initiating web view https://bugs.webkit.org/show_bug.cgi?id=192212 rdar://problem/46363706

[webkit-changes] [238710] trunk

2018-11-29 Thread david_quesada
Title: [238710] trunk Revision 238710 Author david_ques...@apple.com Date 2018-11-29 16:38:29 -0800 (Thu, 29 Nov 2018) Log Message Add SPI to publish NSProgress on active downloads https://bugs.webkit.org/show_bug.cgi?id=192021 rdar://problem/44405661 Reviewed by Alex Christensen. Sourc

[webkit-changes] [238381] trunk

2018-11-19 Thread david_quesada
Title: [238381] trunk Revision 238381 Author david_ques...@apple.com Date 2018-11-19 14:52:42 -0800 (Mon, 19 Nov 2018) Log Message EXC_BAD_ACCESS when invoking a DownloadProxy's destination decision handler after the download has been canceled https://bugs.webkit.org/show_bug.cgi?id=19176

[webkit-changes] [236689] trunk/Source/WebKit

2018-10-01 Thread david_quesada
Title: [236689] trunk/Source/WebKit Revision 236689 Author david_ques...@apple.com Date 2018-10-01 13:38:47 -0700 (Mon, 01 Oct 2018) Log Message Add missing Objective-C versions of downloads SPI https://bugs.webkit.org/show_bug.cgi?id=190149 rdar://problem/44915592 Reviewed by Alex Chris

[webkit-changes] [234634] trunk/Tools

2018-08-06 Thread david_quesada
Title: [234634] trunk/Tools Revision 234634 Author david_ques...@apple.com Date 2018-08-06 16:49:09 -0700 (Mon, 06 Aug 2018) Log Message webkitdirs.pm should default to iPhone SE for 64-bit testing https://bugs.webkit.org/show_bug.cgi?id=188361 Reviewed by Daniel Bates. Use iPhone SE as

[webkit-changes] [228036] trunk

2018-02-02 Thread david_quesada
Title: [228036] trunk Revision 228036 Author david_ques...@apple.com Date 2018-02-02 16:49:56 -0800 (Fri, 02 Feb 2018) Log Message WebAppManifest scope should default to the containing directory of start_url if 'scope' is not specified https://bugs.webkit.org/show_bug.cgi?id=182363 rdar:/

[webkit-changes] [225991] trunk/Tools

2017-12-15 Thread david_quesada
Title: [225991] trunk/Tools Revision 225991 Author david_ques...@apple.com Date 2017-12-15 16:32:22 -0800 (Fri, 15 Dec 2017) Log Message Unreviewed, adding myself to contributors.json * Scripts/webkitpy/common/config/contributors.json: Modified Paths trunk/Tools/ChangeLog trunk/Tools/S