Re: [webkit-dev] Skipping Flakey Tests

2009-09-23 Thread David Levin
If a test is flaky, it doesn't seem good to keep in the mix because it will turn red for no reason and people will think a check in was bad. oth, if a test is flaky but has enough logging in it to indicated an underlying cause, then it may be worth keeping in the mix so that the root issue may be d

Re: [webkit-dev] Skipping Flakey Tests

2009-09-23 Thread Maciej Stachowiak
On Sep 23, 2009, at 11:09 PM, Eric Seidel wrote: Alexey and I have been discussing if WebKit should add flakey tests to Skipped lists: https://bugs.webkit.org/show_bug.cgi?id=29322 Alexey asked that I bring the discussion to a larger audience. Pros: - Buildbots stay green. - Red bots/tests me

Re: [webkit-dev] Two Pass Layout?

2009-09-23 Thread Roland Steiner
On Sat, Sep 19, 2009 at 12:42 AM, Alex Milowski wrote: > On Thu, Sep 17, 2009 at 11:36 PM, Roland Steiner > wrote: > > Hi Alex, > > I'm in the process of doing ruby layout, currently under review > (reviewers: > > *hint, hint*), where I had several of the same issues, albeit not quite > as > > s

[webkit-dev] Skipping Flakey Tests

2009-09-23 Thread Eric Seidel
Alexey and I have been discussing if WebKit should add flakey tests to Skipped lists: https://bugs.webkit.org/show_bug.cgi?id=29322 Alexey asked that I bring the discussion to a larger audience. Pros: - Buildbots stay green. - Red bots/tests means your change caused an error. Cons: - Skipped tes

Re: [webkit-dev] Runtime setting for incomplete features

2009-09-23 Thread Drew Wilson
Yeah, I'm thinking A also. OK, sounds like we're on the same page for A (which is all I really care about). For B it does impact the web app's ability to do capabilities detection which seems bad, but it's not worth arguing about hypotheticals I think. -atw On Wed, Sep 23, 2009 at 6:10 PM, Maciej

Re: [webkit-dev] Runtime setting for incomplete features

2009-09-23 Thread Maciej Stachowiak
On Sep 23, 2009, at 6:05 PM, Peter Kasting wrote: On Wed, Sep 23, 2009 at 6:03 PM, Maciej Stachowiak wrote: My thinking on the topic is basically this: A) For experimental features, it makes sense to make them disappear completely when turned off, since turning them on is an unusual and

Re: [webkit-dev] Runtime setting for incomplete features

2009-09-23 Thread Peter Kasting
On Wed, Sep 23, 2009 at 6:03 PM, Maciej Stachowiak wrote: > My thinking on the topic is basically this: > A) For experimental features, it makes sense to make them disappear > completely when turned off, since turning them on is an unusual and > experimental state. > B) For end-user features that

Re: [webkit-dev] Runtime setting for incomplete features

2009-09-23 Thread Maciej Stachowiak
On Sep 23, 2009, at 5:24 PM, Drew Wilson wrote: Following up on this, because I missed Maciej's response. On Mon, Sep 21, 2009 at 1:22 PM, Maciej Stachowiak wrote: Fair enough. But I would be against user-level preferences that add or remove entire APIs. Rather, the preference should a

Re: [webkit-dev] Runtime setting for incomplete features

2009-09-23 Thread Drew Wilson
Following up on this, because I missed Maciej's response. On Mon, Sep 21, 2009 at 1:22 PM, Maciej Stachowiak wrote: > > Fair enough. But I would be against user-level preferences that add or > remove entire APIs. Rather, the preference should affect the behavior of the > API (possibly making it