[webkit-dev] Calling all committers: The pending-commit list is overflowing

2009-10-19 Thread Adam Barth
We have 43 patches that have been reviewed and are waiting to land: http://webblaze.org/pending-commit If you're a committer, you can help drive that number to zero. Here's what you can do: 1) If you have a patch on that list, please land it. 2) If you see a patch on the list that's ready to

Re: [webkit-dev] Calling all committers: The pending-commit list is overflowing

2009-10-19 Thread Adam Barth
Mark correctly points out that I meant: http://webkit.org/pending-commit (webblaze.org is my server for running experiments.) Adam On Sun, Oct 18, 2009 at 11:34 PM, Adam Barth aba...@webkit.org wrote: We have 43 patches that have been reviewed and are waiting to land:

Re: [webkit-dev] Calling all committers: The pending-commit list isoverflowing

2009-10-19 Thread Yong Li
- Original Message - From: Adam Barth aba...@webkit.org To: webkit-dev@lists.webkit.org Sent: Monday, October 19, 2009 3:21 AM Subject: Re: [webkit-dev] Calling all committers: The pending-commit list isoverflowing If you're a committer, you can help drive that number to zero.

Re: [webkit-dev] Calling all committers: The pending-commit list isoverflowing

2009-10-19 Thread Yong Li
I'm able to do it now. Thanks. -Yong - Original Message - From: Eric Seidel esei...@google.com To: Yong Li yong...@torchmobile.com Cc: Adam Barth aba...@webkit.org; webkit-dev@lists.webkit.org Sent: Monday, October 19, 2009 11:33 AM Subject: Re: [webkit-dev] Calling all committers:

Re: [webkit-dev] Calling all committers: The pending-commit list is overflowing

2009-10-19 Thread Eric Seidel
On Sun, Oct 18, 2009 at 11:34 PM, Adam Barth aba...@webkit.org wrote: 2) If you see a patch on the list that's ready to land (almost all of them), you can mark it commit-queue+ to have the commit bot land it. When you do this, please be sure to watch the tree for regressions, just like you

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread David Hyatt
On Oct 16, 2009, at 7:07 PM, Evan Martin wrote: When you select multiple lines of text in WebKit, the highlight paints over whitespace on the right margin. This is correct behavior for Mac, but not for Windows or Linux. I would suggest making it be controlled by a Setting rather than

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread Ben Goodger
I agree. I would like to retain this mode of selection in Windows Chrome at least. I think it's only ragged in most apps because people don't take the time to make it look nice. -Ben On Mon, Oct 19, 2009 at 12:57 PM, David Hyatt hy...@apple.com wrote: On Oct 16, 2009, at 7:07 PM, Evan Martin

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread Jeremy Orlow
FYI, this was filed some time ago: http://code.google.com/p/chromium/issues/detail?id=3527 https://bugs.webkit.org/show_bug.cgi?id=21960 On Mon, Oct 19, 2009 at 1:03 PM, Ben Goodger b...@google.com wrote: I agree. I would like to retain this mode of selection in Windows Chrome at least. I

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread Ben Goodger
To me, it looks ugly to have a ragged edge if you can avoid it. Dave did a great job making it look nice in WebKit. I don't have a strong feeling on Linux so if people feel strongly there whatever. But on Windows Chrome I want to retain the solid edge. Maybe there are ways the solid edge can be

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread Peter Kasting
On Mon, Oct 19, 2009 at 1:10 PM, David Hyatt hy...@apple.com wrote: I can get how editing in text fields you might feel a desire to match the platform (where ragged selection may be the convention), but once you get into rich text selection (images, floats, tables, columns, etc.), there

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread Evan Martin
On Mon, Oct 19, 2009 at 1:13 PM, Ben Goodger b...@google.com wrote: To me, it looks ugly to have a ragged edge if you can avoid it. Dave did a great job making it look nice in WebKit. I don't have a strong feeling on Linux so if people feel strongly there whatever. But on Windows Chrome I want

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread David Hyatt
On Oct 19, 2009, at 3:19 PM, Peter Kasting wrote: On Mon, Oct 19, 2009 at 1:10 PM, David Hyatt hy...@apple.com wrote: I can get how editing in text fields you might feel a desire to match the platform (where ragged selection may be the convention), but once you get into rich text selection

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread David Hyatt
On Oct 19, 2009, at 3:19 PM, Peter Kasting wrote: On Mon, Oct 19, 2009 at 1:10 PM, David Hyatt hy...@apple.com wrote: I can get how editing in text fields you might feel a desire to match the platform (where ragged selection may be the convention), but once you get into rich text selection

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread Peter Kasting
On Mon, Oct 19, 2009 at 1:21 PM, David Hyatt hy...@apple.com wrote: On Oct 19, 2009, at 3:19 PM, Peter Kasting wrote: I'm not quite sure what you mean. Do you just mean it looks visually confusing, but when you copy/paste you get the right text? Or are you saying that it's actually

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread David Hyatt
On Oct 19, 2009, at 3:27 PM, Peter Kasting wrote: On Mon, Oct 19, 2009 at 1:21 PM, David Hyatt hy...@apple.com wrote: On Oct 19, 2009, at 3:19 PM, Peter Kasting wrote: I'm not quite sure what you mean. Do you just mean it looks visually confusing, but when you copy/paste you get the right

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread Peter Kasting
On Mon, Oct 19, 2009 at 1:31 PM, David Hyatt hy...@apple.com wrote: You aren't only selecting text on a page though. For example, copying can be of all the HTML content. This includes tables, images, plugins, etc. If you don't highlight that content, then you're lying about what gets

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread Darin Fisher
On Mon, Oct 19, 2009 at 1:37 PM, Peter Kasting pkast...@google.com wrote: On Mon, Oct 19, 2009 at 1:31 PM, David Hyatt hy...@apple.com wrote: You aren't only selecting text on a page though. For example, copying can be of all the HTML content. This includes tables, images, plugins, etc. If

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread Peter Kasting
On Mon, Oct 19, 2009 at 1:40 PM, Darin Fisher da...@chromium.org wrote: I think there is a good use case for copying a selection of HTML from any web page and pasting that into the rich text editor of a web mail program. I agree, but that case does not degrade badly when you only copy the

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread Darin Fisher
On Mon, Oct 19, 2009 at 1:43 PM, Peter Kasting pkast...@google.com wrote: On Mon, Oct 19, 2009 at 1:40 PM, Darin Fisher da...@chromium.org wrote: I think there is a good use case for copying a selection of HTML from any web page and pasting that into the rich text editor of a web mail

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread Peter Kasting
On Mon, Oct 19, 2009 at 1:45 PM, David Hyatt hy...@apple.com wrote: On Oct 19, 2009, at 3:37 PM, Peter Kasting wrote: The only time non-text should be copied is when it is part of a rich text area. In that case copying rich content makes sense. Ok, well we fundamentally disagree on this

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread Timothy Hatcher
On Oct 19, 2009, at 1:43 PM, Peter Kasting wrote: Note that within Chrome we put in ctrl-shift-v to paste as plain text precisely because of issues like this. Most other programs don't have that option though (and even in Chrome it's hard to discover). On Mac we call this Paste and

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread Timothy Hatcher
On Oct 19, 2009, at 1:43 PM, Peter Kasting wrote: Note that within Chrome we put in ctrl-shift-v to paste as plain text precisely because of issues like this. Most other programs don't have that option though (and even in Chrome it's hard to discover). I guess it isn't exactly what you

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread Pam Greene
On Mon, Oct 19, 2009 at 1:43 PM, Peter Kasting pkast...@google.com wrote: On Mon, Oct 19, 2009 at 1:40 PM, Darin Fisher da...@chromium.org wrote: I think there is a good use case for copying a selection of HTML from any web page and pasting that into the rich text editor of a web mail

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread Peter Kasting
On Mon, Oct 19, 2009 at 1:55 PM, Pam Greene p...@chromium.org wrote: On Mon, Oct 19, 2009 at 1:43 PM, Peter Kasting pkast...@google.comwrote: On Mon, Oct 19, 2009 at 1:40 PM, Darin Fisher da...@chromium.org wrote: I think there is a good use case for copying a selection of HTML from any web

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread Peter Kasting
On Mon, Oct 19, 2009 at 1:58 PM, Joe Mason j...@notcharles.ca wrote: Perhaps the browser should have Copy text and Copy all objects options (in which case either WebKit needs to support both modes, or the browser would need to filter the copied data). Yes, that could help. Filed

Re: [webkit-dev] Calling all committers: The pending-commit list is overflowing

2009-10-19 Thread Eric Seidel
We're back down to 25 after Yong's epic cq+ing this morning. The queue had a record 13 patch backlog for a while. Thank you Yong for cleaning the pending-commit list! Still 25 to go. All of which require manual attention from committers. -eric On Mon, Oct 19, 2009 at 11:52 AM, Eric Seidel

Re: [webkit-dev] Keypress event for ctrl+key and/or ⌘+key?

2009-10-19 Thread Peter Kasting
On Mon, Oct 19, 2009 at 6:03 PM, Oliver Hunt oli...@apple.com wrote: The real issue is whether application shortcuts get precedence over DOM event handlers, currently on mac the DOM event handlers get precedence (and thus the ability to override/prevent application shortcuts) and on windows

Re: [webkit-dev] Calling all committers: The pending-commit list is overflowing

2009-10-19 Thread Adam Barth
WebKit, you are awesome. We're down to our usual 17 now. Thanks everyone! Adam On Mon, Oct 19, 2009 at 3:27 PM, Eric Seidel e...@webkit.org wrote: We're back down to 25 after Yong's epic cq+ing this morning.  The queue had a record 13 patch backlog for a while.  Thank you Yong for cleaning

Re: [webkit-dev] Keypress event for ctrl+key and/or ⌘+key?

2009-10-19 Thread Erik Arvidsson
On Mon, Oct 19, 2009 at 18:03, Oliver Hunt oli...@apple.com wrote: On Oct 19, 2009, at 5:18 PM, Erik Arvidsson wrote: I'm trying to clean up some inconsistencies with when keypress events are dispatched. WebKit's key event model is modeled to be compatible with Internet Explorer and

Re: [webkit-dev] Calling all committers: The pending-commit list is overflowing

2009-10-19 Thread David Kilzer
Why are there 17 patches with review+ that never get landed? This has bothered me in the past, but I wasn't sure if it was the same group of patches or not. Dave On Mon, October 19, 2009 at 7:08:50 PM, Adam Barth wrote: WebKit, you are awesome. We're down to our usual 17 now. Thanks

Re: [webkit-dev] Calling all committers: The pending-commit list is overflowing

2009-10-19 Thread Adam Barth
On Mon, Oct 19, 2009 at 8:54 PM, Adam Barth aba...@webkit.org wrote: On Mon, Oct 19, 2009 at 8:39 PM, David Kilzer ddkil...@webkit.org wrote: Why are there 17 patches with review+ that never get landed? This has bothered me in the past, but I wasn't sure if it was the same group of patches