Re: [webkit-dev] Yet another bug-less change hosed the tree.

Sent from the wrong email address the first time, sorry. >> 2) Your patch can be vetted by the various bots that analyze patches >> posted for review. > > True, if what you're really asking for is not just a bug report but also a > "cooling off period" during which you wait for a result from the

Re: [webkit-dev] Yet another bug-less change hosed the tree.

On Mon, May 10, 2010 at 6:04 PM, Brent Fulgham wrote: > On Mon, May 10, 2010 at 2:44 PM, Adam Barth wrote: >> On Mon, May 10, 2010 at 2:30 PM, Geoffrey Garen wrote: 2) Your patch can be vetted by the various bots that analyze patches posted for review. >>> >>> True, if what you're real

Re: [webkit-dev] Yet another bug-less change hosed the tree.

On Mon, May 10, 2010 at 11:39 PM, Eric Seidel wrote: > On Mon, May 10, 2010 at 2:30 PM, Geoffrey Garen wrote: >>> 2) Your patch can be vetted by the various bots that analyze patches >>> posted for review. >> >> True, if what you're really asking for is not just a bug report but also a >> "cooli

Re: [webkit-dev] WebKit Nightly website scripts

Those which can be found in SVN can be found here: http://trac.webkit.org/browser/trunk/WebKitTools/BuildSlaveSupport/ Last I heard, the rest are on Mark Rowe's harddrive, somewhere. -eric On Sat, May 8, 2010 at 5:10 PM, Trevor Downs wrote: > Hi. I'm trying to find the scripts for

Re: [webkit-dev] prepare-Changelog crashing on cygwin

More information about rebase here: http://www.tishler.net/jason/software/rebase/rebase-2.2.README I still haven't found any way to detect the problem so we could warn people before scripts start blowing up. -eric On Mon, May 10, 2010 at 1:33 PM, Peter Kasting wrote: > On Mon, May 10, 2010 at 1

Re: [webkit-dev] Python on the Tiger build bot

On May 10, 2010, at 11:01 PM, Eric Seidel wrote: On Mon, May 10, 2010 at 2:25 AM, Maciej Stachowiak wrote: My feeling about requiring a higher Python version for Tiger remains this: "I'd prefer that we provide an easy means to do the install of Python 2.6 (ideally a single script you ca

Re: [webkit-dev] Python on the Tiger build bot

On Mon, May 10, 2010 at 2:25 AM, Maciej Stachowiak wrote: > My feeling about requiring a higher Python version for Tiger remains this: > > "I'd prefer that we provide an easy means to do the install of Python 2.6 > (ideally a single script you can run, and ideally without affecting the > system co

Re: [webkit-dev] Yet another bug-less change hosed the tree.

On May 10, 2010, at 7:50 PM, Adam Barth wrote: > On Mon, May 10, 2010 at 6:04 PM, Brent Fulgham wrote: >> I'm not sure this is totally correct. I'm sure more people than >> ggaren find the TPS cover sheet / cooling off period to be an added >> cost. These added costs apply to *all* developers,

Re: [webkit-dev] New in-rietveld patch flag

I'm pretty sure we can modify the template to just hide that one particular flag. I'll look into it tomorrow. Julie On Mon, May 10, 2010 at 8:23 PM, Eric Seidel wrote: > I have made the flag inactive. it was driving my poor little eyes > bonkers. I will work with Julie/Ojan on some less UI-h

Re: [webkit-dev] New in-rietveld patch flag

I have made the flag inactive. it was driving my poor little eyes bonkers. I will work with Julie/Ojan on some less UI-hateful solution. -eric On Mon, May 10, 2010 at 4:46 PM, Eric Seidel wrote: > There is an "is Active" checkbox, which I could uncheck: > https://bugs.webkit.org/editflagtypes.

Re: [webkit-dev] Yet another bug-less change hosed the tree.

On Mon, May 10, 2010 at 6:04 PM, Brent Fulgham wrote: > On Mon, May 10, 2010 at 2:44 PM, Adam Barth wrote: >> On Mon, May 10, 2010 at 2:30 PM, Geoffrey Garen wrote: 2) Your patch can be vetted by the various bots that analyze patches posted for review. >>> >>> True, if what you're real

Re: [webkit-dev] Yet another bug-less change hosed the tree.

On Mon, May 10, 2010 at 2:44 PM, Adam Barth wrote: > On Mon, May 10, 2010 at 2:30 PM, Geoffrey Garen wrote: >>> 2) Your patch can be vetted by the various bots that analyze patches >>> posted for review. >> >> True, if what you're really asking for is not just a bug report but also a >> "cooling

[webkit-dev] Behavior of file:// URLs when dragging

>From the discussion on https://bugs.webkit.org/show_bug.cgi?id=25882, I believe the general consensus is that file:// URLs should not be exposed when dragging and dropping. Removing file:// URL population from event.dataTransfer is pretty easy; however, what should we do when the user drops a fil

Re: [webkit-dev] New in-rietveld patch flag

There is an "is Active" checkbox, which I could uncheck: https://bugs.webkit.org/editflagtypes.cgi?action=edit&id=4 I'm not sure how the tools would be able to set this flag if I did that. We could also hack the various UI to hide the flag? -eric On Mon, May 10, 2010 at 4:41 PM, Adam Barth wro

Re: [webkit-dev] New in-rietveld patch flag

Can we hide this in the UI? My understanding is that it will be used only by the tools. Adam On Mon, May 10, 2010 at 4:37 PM, Eric Seidel wrote: > As part of https://bugs.webkit.org/show_bug.cgi?id=38866 I've added a > new flag to bugzilla patches called "in-rietveld". > > This flag may be cha

[webkit-dev] Custom event question

I'm trying to add a new custom event to WebKit, descended from MouseRelatedEvent. It's about 90% finished, but I'm hitting a roadblock. At runtime, the new event's "type" property is visible from JavaScript - but nothing else is. For instance, "clientX" reports to JavaScript as "undefined." I'v

[webkit-dev] New in-rietveld patch flag

As part of https://bugs.webkit.org/show_bug.cgi?id=38866 I've added a new flag to bugzilla patches called "in-rietveld". This flag may be changed or removed in the coming weeks. If you have questions/comments/concerns please bring them up with Ojan or Julie on the bug. Thanks to both of them for

Re: [webkit-dev] Yet another bug-less change hosed the tree.

On May 10, 2010, at 2:05 PM, Adam Barth wrote: That's part of what motivated us to create webkit-patch, which makes creating and managing bugs and patches quite easy. Personally, I find "webkit-patch upload" to be an easier way to prepare a patch for review than approaches you might expec

Re: [webkit-dev] Yet another bug-less change hosed the tree.

Correct. Bill is not the blocker on the fix-the-author-to-be-not-e...@webkit.org-in-postcommit-patch. The blocker how fast I'm able to pop items off my work queue. I'm happy to hand this item to someone else. Bill will have to be involved in the end. The plan was detailed here: https://lists.w

Re: [webkit-dev] Yet another bug-less change hosed the tree.

On May 10, 2010, at 2:44 PM, Adam Barth wrote: > On Mon, May 10, 2010 at 2:31 PM, Geoffrey Garen wrote: >>> If you'll allow me to climb higher on my horse, I'll advocate for >>> landing patches like this through the commit queue. >> >> Personally, I find the output of the commit queue incredibly

Re: [webkit-dev] Yet another bug-less change hosed the tree.

On Mon, May 10, 2010 at 2:31 PM, Geoffrey Garen wrote: >> If you'll allow me to climb higher on my horse, I'll advocate for >> landing patches like this through the commit queue. > > Personally, I find the output of the commit queue incredibly confusing, since > it claims that Eric Seidel wrote e

Re: [webkit-dev] Yet another bug-less change hosed the tree.

On Mon, May 10, 2010 at 2:28 PM, Peter Kasting wrote: > On Mon, May 10, 2010 at 2:26 PM, Adam Barth wrote: > >> in addition to bot integration, there are also >> "people integration" benefits to using the bug tracker. > > > Can you say more? > Never mind, clearly you're referring to the points

Re: [webkit-dev] Yet another bug-less change hosed the tree.

> If you'll allow me to climb higher on my horse, I'll advocate for > landing patches like this through the commit queue. Personally, I find the output of the commit queue incredibly confusing, since it claims that Eric Seidel wrote every patch. Geoff ___

Re: [webkit-dev] Yet another bug-less change hosed the tree.

>> What value would a bug report add in a situation >> like http://trac.webkit.org/changeset/59086? > > Having a bug serves a couple useful purposes: > > 1) Your patch can be reviewed by other members of the project who > aren't sitting next to you on couch. I don't think anyone else had a revie

Re: [webkit-dev] Yet another bug-less change hosed the tree.

On Mon, May 10, 2010 at 2:26 PM, Adam Barth wrote: > in addition to bot integration, there are also > "people integration" benefits to using the bug tracker. Can you say more? PK ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.we

Re: [webkit-dev] Yet another bug-less change hosed the tree.

On Mon, May 10, 2010 at 2:09 PM, Peter Kasting wrote: > On Mon, May 10, 2010 at 2:05 PM, Adam Barth wrote: >> On Mon, May 10, 2010 at 1:30 PM, Peter Kasting >> wrote: >> > I agree that a 1:1 association between patches and bugs (which has been >> > suggested to me in the past, thus mentioning it

Re: [webkit-dev] Yet another bug-less change hosed the tree.

On Mon, May 10, 2010 at 2:05 PM, Adam Barth wrote: > On Mon, May 10, 2010 at 1:30 PM, Peter Kasting > wrote: > > I agree that a 1:1 association between patches and bugs (which has been > > suggested to me in the past, thus mentioning it here) seems like a > mistake. > > Your email appears to be

Re: [webkit-dev] Yet another bug-less change hosed the tree.

On Mon, May 10, 2010 at 1:23 PM, Geoffrey Garen wrote: >> On Mon, May 10, 2010 at 12:56 PM, Eric Seidel wrote: >> I thought it was generally good practice to have bug.webkit.org bugs >> with changes? > > I wasn't aware of that. > > What value would a bug report add in a situation > like http://tr

Re: [webkit-dev] prepare-Changelog crashing on cygwin

On Mon, May 10, 2010 at 1:27 PM, Tony Gentilcore wrote: > On Mon, May 10, 2010 at 1:07 PM, Eric Seidel wrote: > >> Is this caused by the base load address of both perl and svn >> conflicting/overlapping? (I don't really know how CYGWIN works.) >> > > I'm by no means a cygwin expert. I just happ

Re: [webkit-dev] Yet another bug-less change hosed the tree.

On Mon, May 10, 2010 at 1:23 PM, Geoffrey Garen wrote: > I thought it was generally good practice to have bug.webkit.org bugs > with changes? > > > I wasn't aware of that. > > What value would a bug report add in a situation like > http://trac.webkit.org/changeset/59086? > > Personally, I'd prefe

Re: [webkit-dev] prepare-Changelog crashing on cygwin

On Mon, May 10, 2010 at 1:07 PM, Eric Seidel wrote: > Is this caused by the base load address of both perl and svn > conflicting/overlapping? (I don't really know how CYGWIN works.) > I'm by no means a cygwin expert. I just happened to run into the same problem last week. This thread is where

Re: [webkit-dev] Yet another bug-less change hosed the tree.

> I thought it was generally good practice to have bug.webkit.org bugs > with changes? I wasn't aware of that. What value would a bug report add in a situation like http://trac.webkit.org/changeset/59086? Personally, I'd prefer it if we kept the TPS reports in our project to a minimum. In this

Re: [webkit-dev] prepare-Changelog crashing on cygwin

Is this caused by the base load address of both perl and svn conflicting/overlapping? (I don't really know how CYGWIN works.) Is this something we should detect in our scripts and warn about? On Mon, May 10, 2010 at 12:41 PM, John Abd-El-Malek wrote: > btw, I finally solved this.  credit to ton

[webkit-dev] Yet another bug-less change hosed the tree.

This is the 3rd in the last few days. http://trac.webkit.org/changeset/59086 I thought it was generally good practice to have bug.webkit.org bugs with changes? webkit-patch upload certainly attempts to make that easy. If there are other tools we can build to make it easier to always commit with

Re: [webkit-dev] prepare-Changelog crashing on cygwin

btw, I finally solved this. credit to tonyg: 1) close cygwin 2) C:\cygwin\bin>ash rebaseall On Mon, May 10, 2010 at 12:20 PM, Eric Seidel wrote: > On Mon, May 10, 2010 at 11:31 AM, Eric Seidel wrote: > > I have seen this on the win-ews ec2 instance. > > > > On May 10, 2010 1:35 PM, "John Abd-

Re: [webkit-dev] prepare-Changelog crashing on cygwin

On Mon, May 10, 2010 at 11:31 AM, Eric Seidel wrote: > I have seen this on the win-ews ec2 instance. > > On May 10, 2010 1:35 PM, "John Abd-El-Malek" wrote: > > After reimaging my Windows 7 machine, prepare-Changelog always crashes for > me now.  It seems to have problems running "svn diff".  I i

[webkit-dev] prepare-Changelog crashing on cygwin

After reimaging my Windows 7 machine, prepare-Changelog always crashes for me now. It seems to have problems running "svn diff". I installed cygwin through the installer on webkit.org. I don't have any anti-virus programs running, and DEP is turned off for cygwin.exe and svn.exe. Has anyone els

Re: [webkit-dev] Python on the Tiger build bot

On May 7, 2010, at 9:10 PM, Eric Seidel wrote: 2. Additionally, Tiger seems mostly ignored by WebKit (note examples like https://bugs.webkit.org/show_bug.cgi?id=38743). No one develops on Tiger to my knowledge (note mjs last night in #webkit noting how he had no access to a Tiger machine, I c