On Fri, Jul 30, 2010 at 7:55 PM, Eric Seidel wrote:
> On Fri, Jul 30, 2010 at 5:42 AM, Jeremy Orlow wrote:
>> Why wasn't it done that way originally? That sounds (to my uneducated ear)
>> much better than what's done today.
>
> The world was very different back then. :)
>
> - WebKit was only on
On Fri, Jul 30, 2010 at 5:42 AM, Jeremy Orlow wrote:
> Why wasn't it done that way originally? That sounds (to my uneducated ear)
> much better than what's done today.
> J
The world was very different back then. :)
- WebKit was only on one platform (Mac).
- Much of what is now WebCore, was up i
On Fri, Jul 30, 2010 at 3:57 PM, Darin Adler wrote:
> It’s in non-bot contexts that I think it’s not good. I think that means I
> agree with you both who said that running webkit-patch on the command line
> shouldn't require it. We can have the commit bot use an option to tell
> webkit-patch it
Last time I did that, I was accused of shouting... :)
http://trac.webkit.org/changeset/45647
But I support making prepare-ChangeLog less confusing. Our "fix up
one of the OOPS, but don't touch the other!" expectation of
contributors is the source of much confusion. :)
-eric
On Fri, Jul 30, 201
It’s totally reasonable for the bot to require a reviewer line, because the bot
requires a reviewer on the bug too.
It’s in non-bot contexts that I think it’s not good. I think that means I agree
with you both who said that running webkit-patch on the command line shouldn't
require it. We can h
This was added to enable a sane "you filled in a reviewer" check.
Requiring patch submitters to be explicit that the patch was not
reviewed instead of the case where they got the reviewer information
wrong.
We *very* commonly have cases where contributors (especially new ones)
just delete the "Rev
On Fri, Jul 30, 2010 at 1:10 PM, Darin Adler wrote:
> It’s come to my attention that some webkit-patch or some other script
> requires that patches without review contain the string “Unreviewed”
> somewhere in their change log message. I personally think this is not
> helpful. In my opinion pat
Hi folks.
It’s come to my attention that some webkit-patch or some other script requires
that patches without review contain the string “Unreviewed” somewhere in their
change log message. I personally think this is not helpful. In my opinion
patches that are don’t need review, such as some simp
On Jul 30, 2010, at 2:10 AM, Shinichiro Hamaji wrote:
> I've noticed WebKit uses slightly different font size for printing on Mac.
We should discuss specifics instead of this broad issue. There’s a good chance
this is something that has been misdiagnosed.
> My colleague told me Mac's font API h
I will be out of the office starting 07/30/2010 and will not return until
08/16/2010.
I will respond to your message when I return.___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
On Fri, Jul 30, 2010 at 2:56 AM, Steve Block wrote:
>> WebCore::LayoutTestController would be exposed to JavaScript running
>> in LayoutTests directly (like the DOM), so we can skip the type
>> conversions.
>
> There might still be the need for some plumbing though. In the case of
> DeviceOrientat
I suspect, originally, layoutTestController was more about poking
DumpRenderTree than about poking WebCore.
Adam
On Fri, Jul 30, 2010 at 2:42 AM, Jeremy Orlow wrote:
> Why wasn't it done that way originally? That sounds (to my uneducated ear)
> much better than what's done today.
>
> On Thu, J
> WebCore::LayoutTestController would be exposed to JavaScript running
> in LayoutTests directly (like the DOM), so we can skip the type
> conversions.
There might still be the need for some plumbing though. In the case of
DeviceOrientation and SpeechInput, we're mocking a client which is
provided
Why wasn't it done that way originally? That sounds (to my uneducated ear)
much better than what's done today.
J
On Thu, Jul 29, 2010 at 11:19 PM, Adam Barth wrote:
> WebCore::LayoutTestController would be exposed to JavaScript running
> in LayoutTests directly (like the DOM), so we can skip t
Hi,
I've noticed WebKit uses slightly different font size for printing on Mac.
My colleague told me Mac's font API has a feature to select the best font
for printing. This feature isn't good for a team in Google because they want
exactly same results between screen and printing. I searched a worka
15 matches
Mail list logo
