Re: [webkit-dev] Review tool changes

2010-09-16 Thread Ojan Vafai
On Fri, Sep 17, 2010 at 4:39 PM, Adam Barth wrote: > On Thu, Sep 16, 2010 at 5:33 PM, Darin Adler wrote: > >1) I am happy with the review tool. I have been using it for a lot of > reviews. There may be no one left who prefers the old review page. > > Thanks. Please let me know if you have i

Re: [webkit-dev] Review tool changes

2010-09-16 Thread Julie Parent
On Fri, Sep 17, 2010 at 4:39 PM, Adam Barth wrote: > On Thu, Sep 16, 2010 at 5:33 PM, Darin Adler wrote: > >1) I am happy with the review tool. I have been using it for a lot of > reviews. There may be no one left who prefers the old review page. > > Thanks. Please let me know if you have i

Re: [webkit-dev] Review tool changes

2010-09-16 Thread Adam Barth
On Thu, Sep 16, 2010 at 5:33 PM, Darin Adler wrote: >    1) I am happy with the review tool. I have been using it for a lot of > reviews. There may be no one left who prefers the old review page. Thanks. Please let me know if you have ideas for how to improve the tool. One thing Ojan suggested

Re: [webkit-dev] Review tool changes

2010-09-16 Thread Ryosuke Niwa
On Thu, Sep 16, 2010 at 6:48 PM, Maciej Stachowiak wrote: > On Sep 16, 2010, at 6:25 PM, Ojan Vafai wrote: > > On Fri, Sep 17, 2010 at 10:33 AM, Darin Adler wrote: > >> 2) It’s kind of crazy that the review tool’s URL is >> "...&action=prettypatch". It was nice of you to leave the old review too

Re: [webkit-dev] Review tool changes

2010-09-16 Thread Maciej Stachowiak
On Sep 16, 2010, at 6:25 PM, Ojan Vafai wrote: > On Fri, Sep 17, 2010 at 10:33 AM, Darin Adler wrote: > 2) It’s kind of crazy that the review tool’s URL is "...&action=prettypatch". > It was nice of you to leave the old review tool unchanged, at least in part > to placate me, but you’re squatt

Re: [webkit-dev] Review tool changes

2010-09-16 Thread Darin Fisher
Push the publish button to review your comments :-) On Sep 16, 2010 6:36 PM, "Alexey Proskuryakov" wrote: > > 16.09.2010, в 17:33, Darin Adler написал(а): > >> 1) I am happy with the review tool. I have been using it for a lot of reviews. There may be no one left who prefers the old review page.

Re: [webkit-dev] Review tool changes

2010-09-16 Thread Alexey Proskuryakov
16.09.2010, в 17:33, Darin Adler написал(а): >1) I am happy with the review tool. I have been using it for a lot of > reviews. There may be no one left who prefers the old review page. It's only now that I realized there's a new review tool at action=prettypatch :-) Is there a way to pre

Re: [webkit-dev] Review tool changes

2010-09-16 Thread Ojan Vafai
On Fri, Sep 17, 2010 at 10:33 AM, Darin Adler wrote: > 2) It’s kind of crazy that the review tool’s URL is > "...&action=prettypatch". It was nice of you to leave the old review tool > unchanged, at least in part to placate me, but you’re squatting on another > feature’s territory! I think we wan

[webkit-dev] Review tool changes

2010-09-16 Thread Darin Adler
Hi Adam. A few thoughts on the review tools on bugs.webkit.org. 1) I am happy with the review tool. I have been using it for a lot of reviews. There may be no one left who prefers the old review page. 2) It’s kind of crazy that the review tool’s URL is "...&action=prettypatch". It was

Re: [webkit-dev] map.d.co.il broken - back out r66156?

2010-09-16 Thread Maciej Stachowiak
On Sep 16, 2010, at 9:14 AM, Jeremy Moskovich wrote: > Hi, > > http://trac.webkit.org/changeset/66156/ broke map.d.co.il which is one of the > larger maps sites in Israel. > > https://bugs.webkit.org/show_bug.cgi?id=45679 was filed to track this. > > Andy: do you have an eta for a fix? Are yo

[webkit-dev] map.d.co.il broken - back out r66156?

2010-09-16 Thread Jeremy Moskovich
Hi, http://trac.webkit.org/changeset/66156/ broke map.d.co.il which is one of the larger maps sites in Israel. https://bugs.webkit.org/show_bug.cgi?id=45679 was filed to track this. Andy: do you have an eta for a fix? Are you ok reverting the change in the interim? Best regards, Jeremy