Re: [webkit-dev] Ruby Text Enhancements

2010-10-13 Thread Roland Steiner
Thanks a lot for the review! The patch has landed and should be a much cleaner foundation for generated content (which may also have to be overlapped). Speaking of general ruby text enhancements: there is a new bug https://bugs.webkit.org/show_bug.cgi?id=47596 regarding the ruby display types. The

Re: [webkit-dev] Should we recommend explicit constructors as part of WebKit style?

2010-10-13 Thread David Levin
It sounds like there is consensus. Here's a patch for adding this to the style guide: https://bugs.webkit.org/show_bug.cgi?id=47646 dave On Wed, Sep 29, 2010 at 9:41 AM, Darin Adler wrote: > On Sep 28, 2010, at 4:31 PM, Maciej Stachowiak wrote: > >> I think the rule should be something like: >>

Re: [webkit-dev] Protecting against stale pointers in DrawingBuffer and GraphicsContext3D

2010-10-13 Thread Darin Adler
On Oct 12, 2010, at 10:12 PM, Darin Fisher wrote: > Caused more harm than good? I think it was a good decision. I don’t have a lot of patience for these abstract debates — I would much prefer to talk about a specific example rather than these vague principles — but here are some of my thought

Re: [webkit-dev] Regarding cache memory leaks

2010-10-13 Thread sumanrapolu
Hi Holger, When we use the default cache model i.e 8MB cache size in this case it is storing the images beyond the 8MB that is untill complete RAM memory. So we disabled the cache by using WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER even though the images and JS are storing in the Cache. We observ

Re: [webkit-dev] Status of WTFURL

2010-10-13 Thread Adam Barth
On Wed, Oct 13, 2010 at 12:54 AM, Maciej Stachowiak wrote: > On Oct 12, 2010, at 11:47 PM, Adam Barth wrote: >> I'd like to gauge interest in the WTFURL work [1].  Currently, there >> are two WTFURL patches that have been up for review for over a month >> without a single comment: >> >> https://bu

Re: [webkit-dev] Status of WTFURL

2010-10-13 Thread Maciej Stachowiak
On Oct 12, 2010, at 11:47 PM, Adam Barth wrote: > Hi webkit-dev, > > I'd like to gauge interest in the WTFURL work [1]. Currently, there > are two WTFURL patches that have been up for review for over a month > without a single comment: > > https://bugs.webkit.org/show_bug.cgi?id=45085 > https:

Re: [webkit-dev] Pixel test experiment

2010-10-13 Thread Nikolas Zimmermann
Am 12.10.2010 um 22:43 schrieb James Robinson: To add a concrete data point, http://trac.webkit.org/changeset/69517 caused a number of SVG tests to fail. It required 14 text rebaselines for Mac and a further two more for Leopard (done by Adam Barth). In order to pass the pixel tests in C