Re: [webkit-dev] Implementing

2011-09-09 Thread Antti Koivisto
On Fri, Sep 9, 2011 at 12:28 AM, Roland Steiner wrote: > > ad 3.) Implementation of scoped selector matching works as follows: > > .) scoped style sheet rules are contained in a separate map element address> -> RuleSet > .) add a field to ParentStackFrame that identifies the > closest ParentStack

Re: [webkit-dev] How does a *Prefix.h work on other platforms?

2011-09-09 Thread 王显著
On Thu, Sep 8, 2011 at 12:54 PM, Mark Rowe wrote: > > On 2011-09-07, at 21:22, Xianzhu Wang (王显著) wrote: > > > Hi, > > > > There are some *Prefix.h files that I guess are injected as header files > into *.cpp files when compiling with xcode. I guess on other platforms they > are just no use and t

Re: [webkit-dev] run-bindings-tests

2011-09-09 Thread Eric Seidel
On Thu, Sep 8, 2011 at 12:44 PM, Darin Adler wrote: > On Sep 8, 2011, at 12:29 PM, Eric Seidel wrote: > >> I'm happy to write a run-all-tests script which runs all known tests that >> platform can handle. :) > > I think run-webkit-tests should be this. We can come up with a new name for > the “j

Re: [webkit-dev] run-bindings-tests

2011-09-09 Thread Adam Roben
On Sep 9, 2011, at 10:52 AM, Eric Seidel wrote: > On Thu, Sep 8, 2011 at 12:44 PM, Darin Adler wrote: >> On Sep 8, 2011, at 12:29 PM, Eric Seidel wrote: >> >>> I'm happy to write a run-all-tests script which runs all known tests that >>> platform can handle. :) >> >> I think run-webkit-tests s

Re: [webkit-dev] run-bindings-tests

2011-09-09 Thread Adam Roben
On Sep 9, 2011, at 10:59 AM, Adam Roben wrote: > On Sep 9, 2011, at 10:52 AM, Eric Seidel wrote: > >> On Thu, Sep 8, 2011 at 12:44 PM, Darin Adler wrote: >>> On Sep 8, 2011, at 12:29 PM, Eric Seidel wrote: >>> I'm happy to write a run-all-tests script which runs all known tests that

Re: [webkit-dev] run-bindings-tests

2011-09-09 Thread Adam Barth
run-layout-tests? On Sep 9, 2011 8:04 AM, "Adam Roben" wrote: > On Sep 9, 2011, at 10:59 AM, Adam Roben wrote: > >> On Sep 9, 2011, at 10:52 AM, Eric Seidel wrote: >> >>> On Thu, Sep 8, 2011 at 12:44 PM, Darin Adler wrote: On Sep 8, 2011, at 12:29 PM, Eric Seidel wrote: > I'm happy

Re: [webkit-dev] run-bindings-tests

2011-09-09 Thread Jarred Nicholls
On Fri, Sep 9, 2011 at 12:07 PM, Adam Barth wrote: > run-layout-tests? > too obvious. as an ode to Paul, I propose run-the-mother-effing-layout-tests http://mothereffinghsl.com/ ;) > On Sep 9, 2011 8:04 AM, "Adam Roben" wrote: > > On Sep 9, 2011, at 10:59 AM, Adam Roben wrote: > > > >> On

Re: [webkit-dev] run-bindings-tests

2011-09-09 Thread Darin Adler
On Sep 9, 2011, at 9:07 AM, Adam Barth wrote: > run-layout-tests? Sorry in advance for bikeshed'ing this: That would be a good name if we thought LayoutTests was the right name for our main regression test suite. Since I think it’s not, I would love to figure out that new name and have the scr

Re: [webkit-dev] run-bindings-tests

2011-09-09 Thread Geoffrey Garen
> I also think it’s good to have a WebKit-specific or specific-enough word in > script names when possible so you can have the scripts in your path even when > not working on WebKit. That’s why run-webkit-tests has the word WebKit in it, > and run-safari does not. I'd suggest one script -- run-

Re: [webkit-dev] run-bindings-tests

2011-09-09 Thread Ryosuke Niwa
On Fri, Sep 9, 2011 at 7:59 AM, Adam Roben wrote: > > An alternate path to success would be: > > 1) Decide what to call the script that just runs tests from LayoutTests > 2) Rename run-webkit-tests to that new name and add a new script called > run-webkit-tests that just calls the renamed script >

Re: [webkit-dev] run-bindings-tests

2011-09-09 Thread Dirk Pranke
On Fri, Sep 9, 2011 at 10:17 AM, Geoffrey Garen wrote: > I also think it’s good to have a WebKit-specific or specific-enough word in > script names when possible so you can have the scripts in your path even > when not working on WebKit. That’s why run-webkit-tests has the word WebKit > in it, and

[webkit-dev] Do you maintain PLATFORM(BREWMP) or OS(QNX)?

2011-09-09 Thread Geoffrey Garen
Hi folks. It looks like the two build variants that rely on threads not existing in WebKit and JavaScriptCore are PLATFORM(BREWMP) and OS(QNX). In the short term, I think this means that making threads always exist in WebKit and JavaScriptCore will break those two build variants. Do you mainta

Re: [webkit-dev] Implementing

2011-09-09 Thread Roland Steiner
On Thu, Sep 8, 2011 at 6:51 PM, Ryosuke Niwa wrote: > Very excited for this feature! > > On Thu, Sep 8, 2011 at 2:28 PM, Roland Steiner > wrote: >> >> As per discussion on >> http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2011-June/032056.html, >> our implementation would diverge from the c

Re: [webkit-dev] Implementing

2011-09-09 Thread Ryosuke Niwa
On Fri, Sep 9, 2011 at 12:51 PM, Roland Steiner wrote: > On Thu, Sep 8, 2011 at 6:51 PM, Ryosuke Niwa wrote: > >> Very excited for this feature! >> >> On Thu, Sep 8, 2011 at 2:28 PM, Roland Steiner < >> rolandstei...@chromium.org> wrote: >>> >>> As per discussion on >>> http://lists.whatwg.org/pi

[webkit-dev] Do you compile with ENABLE_SVG diabled?

2011-09-09 Thread Eric Seidel
I am interested in removing the ENABLE_SVG define, and all associated sub-defines ENABLE_SVG_ANIMATION ENABLE_SVG_AS_IMAGE ENABLE_SVG_FONTS ENABLE_SVG_FOREIGN_OBJECT ENABLE_SVG_USE SVG is part of HTML5, and all major ports compile and ship with SVG enabled (and have for years). Please let me kno

Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?

2011-09-09 Thread Andy Kling
I build debug with !ENABLE_SVG on my laptop to mitigate some of the pain of building on the road. Not saying I couldn't live without it, it'd just be a life of ~doubled compile times. :-) -Kling On Fri, Sep 9, 2011 at 11:42 PM, Eric Seidel wrote: > I am interested in removing the ENABLE_SVG def

Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?

2011-09-09 Thread Levi Weintraub
I know webOS ships (or doesn't these days?) sans-SVG. On Fri, Sep 9, 2011 at 2:42 PM, Eric Seidel wrote: > I am interested in removing the ENABLE_SVG define, and all associated > sub-defines > > ENABLE_SVG_ANIMATION > ENABLE_SVG_AS_IMAGE > ENABLE_SVG_FONTS > ENABLE_SVG_FOREIGN_OBJECT > ENABLE_SVG

Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?

2011-09-09 Thread Dirk Schulze
We could at least remove the subsets of SVG. Some developers build without SVG for compile time reasons. Dirk Am 09.09.2011 um 23:45 schrieb Levi Weintraub: > I know webOS ships (or doesn't these days?) sans-SVG. > > On Fri, Sep 9, 2011 at 2:42 PM, Eric Seidel wrote: >> I am interested in rem

Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?

2011-09-09 Thread Levi Weintraub
That seems like a very reasonable solution to me. On Fri, Sep 9, 2011 at 2:51 PM, Dirk Schulze wrote: > We could at least remove the subsets of SVG. Some developers build without > SVG for compile time reasons. > > Dirk > > Am 09.09.2011 um 23:45 schrieb Levi Weintraub: > >> I know webOS ships (

[webkit-dev] Color profiles in expected.png files

2011-09-09 Thread Simon Fraser
It turns out that some of the layout test expected.png files have color profiles (Generic RGB), and some do not . On my Lion machine, at least, this affects the appearance of the standard green color, and causes pixel tests to fail. It appears tha

Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?

2011-09-09 Thread Nico Weber
Hi Eric, chromium's mac tryservers (which are similar to webkit's EWS) all build with svg disabled. Nico On Fri, Sep 9, 2011 at 2:42 PM, Eric Seidel wrote: > I am interested in removing the ENABLE_SVG define, and all associated > sub-defines > > ENABLE_SVG_ANIMATION > ENABLE_SVG_AS_IMAGE > ENAB