Re: [webkit-dev] Eliminate potential null pointer dereference?

On Thu, Apr 19, 2012 at 11:36 PM, Ryosuke Niwa wrote: > On Thu, Apr 19, 2012 at 10:35 PM, David Barr wrote: > >> Regarding style, the change homogenizes the loop constructs within that >> method. > > > I don't think that's necessary an improvement. e.g. we don't have a style > guide that mandate

Re: [webkit-dev] Eliminate potential null pointer dereference?

On Thu, Apr 19, 2012 at 10:35 PM, David Barr wrote: > > Regarding style, the change homogenizes the loop constructs within that > method. I don't think that's necessary an improvement. e.g. we don't have a style guide that mandates it. I completely agree with Maciej here that if this is a reach

Re: [webkit-dev] Eliminate potential null pointer dereference?

I think this all started with a lot of effort put into fixing an issue reported by a user where they said "the most popular online forum in Malaysia is broken." Then folks had to do a lot of builds (bisecting) to track down where the problem was introduced. Then they had to figure out what had brok

Re: [webkit-dev] How can I get some debug infomation in MediaPlayerPrivateGStreamer.cpp

hi Terry, In fact, I do something like this below: MediaPlayerPrivateInterface* MediaPlayerPrivateGStreamer::create(MediaPlayer* player) { printf("MediaPlayerPrivateGStreamer::create(MediaPlayer* player) is called\n");// added by zqhuan return new MediaPlayerPrivateGStreamer(player); } v

Re: [webkit-dev] Eliminate potential null pointer dereference?

On Apr 19, 2012, at 10:35 PM, David Barr wrote: > On Fri, Apr 20, 2012 at 3:18 PM, Alexey Proskuryakov wrote: >> >> I noticed a number of patches going in recently that add null checks, or >> refactor the code under the premise of "eliminating potential null >> dereference". What does that me

Re: [webkit-dev] CMake for Apple's Windows port

A lot of folks have laptops, so perhaps someone could be convinced to give you the scoop by IRC. - Maciej On Apr 19, 2012, at 10:11 PM, Patrick Gansterer wrote: > I'm very interested in that discussion, but I can't be physically there. :-( > Is there any any possibility for me to attend it on

Re: [webkit-dev] Eliminate potential null pointer dereference?

On Fri, Apr 20, 2012 at 3:18 PM, Alexey Proskuryakov wrote: > > I noticed a number of patches going in recently that add null checks, or > refactor the code under the premise of "eliminating potential null > dereference". What does that mean, and why are we allowing such patches to be > landed?

[webkit-dev] Eliminate potential null pointer dereference?

I noticed a number of patches going in recently that add null checks, or refactor the code under the premise of "eliminating potential null dereference". What does that mean, and why are we allowing such patches to be landed? For example, this change doesn't look nice:

Re: [webkit-dev] CMake for Apple's Windows port

I'm very interested in that discussion, but I can't be physically there. :-( Is there any any possibility for me to attend it online or get a recording of it? -- Patrick Am 20.04.2012 um 06:08 schrieb Eric Seidel: > We're discussing reducing the number of build-systems at the WebKit > meeting t

Re: [webkit-dev] CMake for Apple's Windows port

We're discussing reducing the number of build-systems at the WebKit meeting tomorrow @ 10am. Interested parties should definitely be there. Especially ones who know something about CMake (since I know nothing). :) -eric On Thu, Apr 12, 2012 at 5:41 AM, Patrick Gansterer wrote: > Hi, > > it's m

Re: [webkit-dev] How can I get some debug infomation in MediaPlayerPrivateGStreamer.cpp

Are you sure that the code is even being reached? Try an ASSERT(false); to make sure. Terry On Apr 19, 2012 7:42 PM, "ZiQiangHuan" wrote: > hi， > > I build webkit with gstreamer support, but I encountered a problem when I > test with it. When I write a simple statement "printf("*\n")" in th

[webkit-dev] How can I get some debug infomation in MediaPlayerPrivateGStreamer.cpp

hi， I build webkit with gstreamer support, but I encountered a problem when I test with it. When I write a simple statement "printf("*\n")" in the function isAvailable() of MediaPlayerPrivateGStreamer.cpp, I got nothing output. When I do the same thing with the function create of MediaPlayerP

[webkit-dev] Contributor meeting hackathon: Move methods from layoutTestController

We're capturing ideas for which LayoutTestController methods could be moved to Internals here: . Even found some that are completely unused in tests! - WBR, Alexey Proskuryakov ___ webkit-dev mailing

Re: [webkit-dev] New feature: Implement command API in webkit

It appears no consensus was reached? The patch is still up for review: https://bugs.webkit.org/show_bug.cgi?id=72955 On Thu, Nov 24, 2011 at 11:34 AM, Ryosuke Niwa wrote: > On Thu, Nov 24, 2011 at 9:32 AM, Ian Hickson wrote: >> >> On Thu, 24 Nov 2011, Ryosuke Niwa wrote: >> > >> > For example,

[webkit-dev] gardening status (mac10.5 build slave needs clobber)

Hi, I did WebKit roll to 114621 now. This will be my last roll today (and of this my gardening cycle). many webgl related layout tests failed, then I reverted a chromium side change. It will fix failures, but you might see failures for a while because of delayed test results. svg/as-image/img-pre

Re: [webkit-dev] run-webkit-tests --pixel-tests and text-based tests

On Wednesday 18 April 2012 14:03:51 Dirk Pranke wrote: > On Wed, Apr 18, 2012 at 10:40 AM, Milian Wolff wrote: > > Hey all, > > > > I'm working on isPrinting() support for the Qt port and noticed that if I > > do something like this: > > > > ./Tools/Scripts/run-webkit-tests -p LayoutTests/print