[webkit-dev] can we stop using Skipped files?

2012-06-07 Thread Dirk Pranke
I believe most if not all of the ports have started using either TestExpectations files or a combination of TestExpectations files (except for the Apple Win port). Can we explicitly switch to the TestExpectations files at this point and drop support for Skipped files on the other ports (and perhap

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

2012-06-07 Thread Annie Sullivan
On Thu, Jun 7, 2012 at 4:41 PM, Brendan Eich wrote: > Adam Barth wrote: >> >> On Thu, Jun 7, 2012 at 1:00 PM, Ryosuke Niwa  wrote: >>> >>> What is the rationale for adding this property on the navigator object >>> >>> instead of the chrome object we also expose if your'e not expecting this >>> pro

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

2012-06-07 Thread Brendan Eich
Adam Barth wrote: On Thu, Jun 7, 2012 at 1:00 PM, Ryosuke Niwa wrote: What is the rationale for adding this property on the navigator object instead of the chrome object we also expose if your'e not expecting this property to be ever standarized? Generally, we avoid implementing web visible f

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

2012-06-07 Thread Dean Jackson
On 07/06/2012, at 1:10 PM, Adam Barth wrote: > On Thu, Jun 7, 2012 at 1:00 PM, Ryosuke Niwa wrote: >> On Wed, Jun 6, 2012 at 1:51 PM, Annie Sullivan >> wrote: >>> >>> I wanted to let you know that I plan to add support for >>> navigator.buildType (e.g., "nightly", "beta", "final") to WebKit.

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

2012-06-07 Thread Dean Jackson
On 07/06/2012, at 12:53 PM, Annie Sullivan wrote: > On Thu, Jun 7, 2012 at 3:43 PM, Dean Jackson wrote: >> >> On 07/06/2012, at 12:05 PM, Annie Sullivan wrote: >> >>> In many browsers in the past, it's been >>> pretty easy to determine from "a" and "b" characters in the user agent >>> of man

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

2012-06-07 Thread Adam Barth
On Thu, Jun 7, 2012 at 1:00 PM, Ryosuke Niwa wrote: > On Wed, Jun 6, 2012 at 1:51 PM, Annie Sullivan > wrote: >> >> I wanted to let you know that I plan to add support for >> navigator.buildType (e.g., "nightly", "beta", "final") to WebKit. This >> feature isn't on the standards track (but neithe

Re: [webkit-dev] Rename FAIL to DIFF Was (Re: PSA: FAIL test expectation does not encompass MISSING, CRASH, or TIMEOUT)

2012-06-07 Thread Ryosuke Niwa
On Thu, Jun 7, 2012 at 12:59 PM, Dirk Pranke wrote: > > FAIL was supposed to have been removed long ago in favor of > TEXT/IMAGE/IMAGE+TEXT as necessary as Peter suggests, but I never got > around to it :) I agree with his reasoning, and have not been > convinced that not having to be specific abo

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

2012-06-07 Thread Ryosuke Niwa
On Wed, Jun 6, 2012 at 1:51 PM, Annie Sullivan wrote: > I wanted to let you know that I plan to add support for > navigator.buildType (e.g., "nightly", "beta", "final") to WebKit. This > feature isn't on the standards track (but neither are a bunch of other > similar properties on Navigator). This

Re: [webkit-dev] Rename FAIL to DIFF Was (Re: PSA: FAIL test expectation does not encompass MISSING, CRASH, or TIMEOUT)

2012-06-07 Thread Dirk Pranke
On Wed, Jun 6, 2012 at 10:36 PM, Peter Kasting wrote: > On Wed, Jun 6, 2012 at 10:22 PM, Ryosuke Niwa wrote: >> >> Now that everyone knows the problem, I propose to rename FAIL to DIFF. >> >> FAIL should mean that the test fails, not that it fails with image, text, >> or image and text failures.

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

2012-06-07 Thread Adam Barth
On Thu, Jun 7, 2012 at 12:53 PM, Annie Sullivan wrote: > On Thu, Jun 7, 2012 at 3:43 PM, Dean Jackson wrote: >> On 07/06/2012, at 12:05 PM, Annie Sullivan wrote: >>> In many browsers in the past, it's been >>> pretty easy to determine from "a" and "b" characters in the user agent >>> of many bro

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

2012-06-07 Thread Annie Sullivan
On Thu, Jun 7, 2012 at 3:43 PM, Dean Jackson wrote: > > On 07/06/2012, at 12:05 PM, Annie Sullivan wrote: > >> In many browsers in the past, it's been >> pretty easy to determine from "a" and "b" characters in the user agent >> of many browsers which builds are "alpha" and "beta", and I haven't >

Re: [webkit-dev] Rename FAIL to DIFF Was (Re: PSA: FAIL test expectation does not encompass MISSING, CRASH, or TIMEOUT)

2012-06-07 Thread Ryosuke Niwa
On Thu, Jun 7, 2012 at 12:44 PM, Peter Kasting wrote: > On Thu, Jun 7, 2012 at 12:33 PM, Ryosuke Niwa wrote: > >> Not if the test was padding. I'm talking about the case where you're >> modifying WebCore and know that some tests are going to need rebaselines. >> People have advised in the past th

Re: [webkit-dev] Rename FAIL to DIFF Was (Re: PSA: FAIL test expectation does not encompass MISSING, CRASH, or TIMEOUT)

2012-06-07 Thread Peter Kasting
On Thu, Jun 7, 2012 at 12:33 PM, Ryosuke Niwa wrote: > Not if the test was padding. I'm talking about the case where you're > modifying WebCore and know that some tests are going to need rebaselines. > People have advised in the past that patch authors add failing test > expectations to TestExpec

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

2012-06-07 Thread Dean Jackson
On 07/06/2012, at 12:05 PM, Annie Sullivan wrote: > In many browsers in the past, it's been > pretty easy to determine from "a" and "b" characters in the user agent > of many browsers which builds are "alpha" and "beta", and I haven't > heard of bugs caused specifically by checking for build typ

Re: [webkit-dev] PSA: FAIL test expectation does not encompass MISSING, CRASH, or TIMEOUT

2012-06-07 Thread Dirk Pranke
The reason for this (which is debatable) is that CRASH and TIMEOUT are deemed to be more serious and shouldn't be suppressed as lightly. MISSING, on the other hand, just indicates that there's something wrong (tests should never have missing results for very long). -- Dirk On Wed, Jun 6, 2012 at

Re: [webkit-dev] Rename FAIL to DIFF Was (Re: PSA: FAIL test expectation does not encompass MISSING, CRASH, or TIMEOUT)

2012-06-07 Thread Ryosuke Niwa
On Thu, Jun 7, 2012 at 11:03 AM, Peter Kasting wrote: > On Wed, Jun 6, 2012 at 11:28 PM, Ryosuke Niwa wrote: > >> > I don't think DIFF is any better. It sounds like it means the output >> is "different than what we wanted", thus it effectively means "didn't >> pass", and one would expect it to m

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

2012-06-07 Thread Annie Sullivan
On Thu, Jun 7, 2012 at 2:08 PM, Dean Jackson wrote: > > On 07/06/2012, at 10:07 AM, Annie Sullivan wrote: > >> Oops, forgot to reply-all. >> >> On Thu, Jun 7, 2012 at 9:05 AM, Annie Sullivan wrote: >>> On Wed, Jun 6, 2012 at 4:59 PM, Darin Adler wrote: Our past experience with this so

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

2012-06-07 Thread Adam Barth
On Thu, Jun 7, 2012 at 11:48 AM, Konstantin Tokarev wrote: > > > 07.06.2012, 21:07, "Annie Sullivan" : >> Oops, forgot to reply-all. >> >> On Thu, Jun 7, 2012 at 9:05 AM, Annie Sullivan wrote: >> >>> On Wed, Jun 6, 2012 at 4:59 PM, Darin Adler wrote: Our past experience with this sort of

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

2012-06-07 Thread Konstantin Tokarev
07.06.2012, 21:07, "Annie Sullivan" : > Oops, forgot to reply-all. > > On Thu, Jun 7, 2012 at 9:05 AM, Annie Sullivan wrote: > >>  On Wed, Jun 6, 2012 at 4:59 PM, Darin Adler wrote: >>>  Our past experience with this sort of thing at Apple is that it led to >>> bugs we didn’t find until after

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

2012-06-07 Thread Dean Jackson
On 07/06/2012, at 10:07 AM, Annie Sullivan wrote: > Oops, forgot to reply-all. > > On Thu, Jun 7, 2012 at 9:05 AM, Annie Sullivan wrote: >> On Wed, Jun 6, 2012 at 4:59 PM, Darin Adler wrote: >>> >>> Our past experience with this sort of thing at Apple is that it led to bugs >>> we didn’t fi

Re: [webkit-dev] Rename FAIL to DIFF Was (Re: PSA: FAIL test expectation does not encompass MISSING, CRASH, or TIMEOUT)

2012-06-07 Thread Peter Kasting
On Wed, Jun 6, 2012 at 11:28 PM, Ryosuke Niwa wrote: > > I don't think DIFF is any better. It sounds like it means the output is > "different than what we wanted", thus it effectively means "didn't pass", > and one would expect it to match MISSING/CRASH/TIMEOUT as much as one would > expect FAIL

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

2012-06-07 Thread Annie Sullivan
Oops, forgot to reply-all. On Thu, Jun 7, 2012 at 9:05 AM, Annie Sullivan wrote: > On Wed, Jun 6, 2012 at 4:59 PM, Darin Adler wrote: >> >> Our past experience with this sort of thing at Apple is that it led to bugs >> we didn’t find until after we shipped “final” software because they did not

Re: [webkit-dev] EditBugs permissions for bugs.webkit.org account

2012-06-07 Thread Adam Barth
Done. On Thu, Jun 7, 2012 at 8:35 AM, Simon Pena wrote: > Hi, > > I'd like to request EditBugs permissions to be added to my > bugs.webkit.org account (spena at igalia.com) > > I'm not a committer, but I have worked on several patches already, > mainly for the GTK port. > > Thanks in advance, > >

[webkit-dev] EditBugs permissions for bugs.webkit.org account

2012-06-07 Thread Simon Pena
Hi, I'd like to request EditBugs permissions to be added to my bugs.webkit.org account (spena at igalia.com) I'm not a committer, but I have worked on several patches already, mainly for the GTK port. Thanks in advance, -- Simon Pena Igalia - Free Software Engineering signature.asc Descrip