Re: [webkit-dev] Can protocol handler be moved to the modules ?

This change looks reasonable for me. I hope the client interface to be extracted from ChromeClient to its own. ChromeClient is like a zoo of ifdefs, which modularization effort has aimed to improve. (I don't think we need to split the implementations of ChromeClient: they can implement both interf

Re: [webkit-dev] Removing BUILDING_ON / TARGETING macros in favor of system availability macros

Tony and Mark (Mentovai) would know more, but I believe the Chromium port uses these macros in order to build against a specific SDK. For example, the Chromium port currently builds against the 10.5 SDK. (This is slated to change shortly as the Chromium project has dropped support for 10.5.) Ada

[webkit-dev] Removing BUILDING_ON / TARGETING macros in favor of system availability macros

I would like to propose removing the BUILDING_ON and TARGETING family of macros that are used to build code conditionally for different versions of OS X. I propose this in order to address several problems: The checks are verbose, and getting worse. For instance, in order to write code targetin

[webkit-dev] Heads up: Updating ANGLE to r1170 in WebKit

Hi all, Just a heads up, I'm updating ANGLE to r1170 in this bug: https://bugs.webkit.org/show_bug.cgi?id=89039 It's in the commit-queue right now. It has passed the EWS bots, but it's a large patch (> 1MB), so please let me know if you run into any issues. Thanks, Max

[webkit-dev] [webkitwebsrc] problem of updating redirected uri

hi webkit-dev, when url is redirected, ResourceHandleClient calls willSendRequest with ResourceRequest. but StreamingClient of webkitwebsource doesn't update uri. so i want to add some codes for updating latest uri in StreamingClient::willSendRequest. is it reasonable? ___

Re: [webkit-dev] Notifications for Blob serialization/deserialization

On Tue, Jul 3, 2012 at 4:08 PM, Greg Billock wrote: > Do you think the way my patch does this, by exposing two new methods on > the BlobController for notifying serialization and deserialization, will be > sufficient? For IndexedDB, it looks to me that notifications like this (or on the > Blob

Re: [webkit-dev] iOS parsing of the viewport meta tag

On Jul 10, 2012, at 9:22 AM, Adam Barth wrote: > On Tue, Jul 10, 2012 at 9:16 AM, David Kilzer wrote: >> On Jul 10, 2012, at 8:48 AM, Adam Barth wrote: >>> Parse the viewport meta tag like iOS >>> https://bugs.webkit.org/show_bug.cgi?id=72722 >>> >>> Is the parsing code for the viewport meta tag

Re: [webkit-dev] iOS parsing of the viewport meta tag

On Tue, Jul 10, 2012 at 9:16 AM, David Kilzer wrote: > On Jul 10, 2012, at 8:48 AM, Adam Barth wrote: >> Parse the viewport meta tag like iOS >> https://bugs.webkit.org/show_bug.cgi?id=72722 >> >> Is the parsing code for the viewport meta tag in iOS open source? > > It's on

Re: [webkit-dev] iOS parsing of the viewport meta tag

On Jul 10, 2012, at 8:48 AM, Adam Barth wrote: > Parse the viewport meta tag like iOS > https://bugs.webkit.org/show_bug.cgi?id=72722 > > Is the parsing code for the viewport meta tag in iOS open source? It's on in ViewportArguments.cpp. Dave

[webkit-dev] iOS parsing of the viewport meta tag

Hi webkit-dev, I'm working on the following bug: Parse the viewport meta tag like iOS https://bugs.webkit.org/show_bug.cgi?id=72722 Is the parsing code for the viewport meta tag in iOS open source? If not, would it be possible for someone from Apple with access to the source to contribute it to

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

On Jul 10, 2012, at 5:25 AM, Alexis Menard wrote: > On Mon, Jul 9, 2012 at 6:53 PM, Brady Eidson wrote: >> >> On Jul 9, 2012, at 2:43 PM, Alexis Menard >> wrote: >> >>> Hi, >>> >>> For those who "secretly" use printf debugging :). I know the >>> recommended way is to use a debugger and it'

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

On Mon, Jul 9, 2012 at 6:53 PM, Brady Eidson wrote: > > On Jul 9, 2012, at 2:43 PM, Alexis Menard wrote: > >> Hi, >> >> For those who "secretly" use printf debugging :). I know the >> recommended way is to use a debugger and it's not the point of this >> discussion. > > A lot of us do this, and s

Re: [webkit-dev] [patch] fix webkit-gtk build with automake 1.12

Please see http://www.webkit.org/coding/contributing.html for how to contribute patches to WebKit. best -jochen On Tue, Jul 10, 2012 at 12:46 PM, Kamble, Nitin A wrote: > automake 1.12 has deprecated use of mkdir_p, and it recommends > > use of MKDIR_P instead. Changed the code to avoid th

[webkit-dev] [patch] fix webkit-gtk build with automake 1.12

automake 1.12 has deprecated use of mkdir_p, and it recommends use of MKDIR_P instead. Changed the code to avoid these kind of warning-errors. ./.deps/DerivedSources make[1]: ./.deps/DerivedSources: Command not found make[1]: *** [all-local] Error 127 Signed-Off-By: Nitin A Kamble 2012/07/10 In