Re: [webkit-dev] Prefix naming scheme for DOM-exposed functions

2012-12-10 Thread Antti Koivisto
On Fri, Dec 7, 2012 at 1:36 PM, Maciej Stachowiak wrote: > > Would this involve creating a bindingsFoo() for every method foo() that is > exposed to bindings? For example, would we have to add > XMLHttpRequest::bindingsSend(), even though there's no real need for a > special internal XMLHttpReque

Re: [webkit-dev] Proposal: Make Ninja the default build-system for build-webkit --chromium

2012-12-10 Thread Dirk Pranke
On Mon, Dec 10, 2012 at 1:30 AM, Jochen Eisinger wrote: > Will the buildbots use ninja or the "native" build tools? > > My only concern is that we're catching problems with e.g. MSVS only after we > roll the WebKit deps in chromium and one of the MSVS bots starts failing. > Eric is only suggestin

Re: [webkit-dev] Proposal: Make Ninja the default build-system for build-webkit --chromium

2012-12-10 Thread Nico Weber
On Mon, Dec 10, 2012 at 1:30 AM, Jochen Eisinger wrote: > Will the buildbots use ninja or the "native" build tools? > > My only concern is that we're catching problems with e.g. MSVS only after we > roll the WebKit deps in chromium and one of the MSVS bots starts failing. The idea is that gyp tri

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-10 Thread Alexis Menard
Le 10 déc. 2012 09:24, "Alexis Menard" a écrit : > > On Tue, Dec 4, 2012 at 8:36 AM, Alexis Menard wrote: > > On Mon, Dec 3, 2012 at 5:59 PM, Dirk Schulze wrote: > >> > >> On Dec 3, 2012, at 12:07 PM, Benjamin Poulain wrote: > >> > >>> On Mon, Dec 3, 2012 at 11:11 AM, Dirk Schulze wrote: > >>>

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-10 Thread Alexis Menard
On Tue, Dec 4, 2012 at 8:36 AM, Alexis Menard wrote: > On Mon, Dec 3, 2012 at 5:59 PM, Dirk Schulze wrote: >> >> On Dec 3, 2012, at 12:07 PM, Benjamin Poulain wrote: >> >>> On Mon, Dec 3, 2012 at 11:11 AM, Dirk Schulze wrote: >>> Why does this feature have a flag at all? background-position wit

Re: [webkit-dev] Proposal: Make Ninja the default build-system for build-webkit --chromium

2012-12-10 Thread Peter Beverloo
Clarifying the error messages seems like a win in either case. >From Android's perspective, I'm of course in favor of switching to ninja. One minor nit, but I'll reply with that on the bug. Thanks for doing this! Peter On Mon, Dec 10, 2012 at 9:39 AM, Eric Seidel wrote: > The buildbots will us

Re: [webkit-dev] Proposal: Make Ninja the default build-system for build-webkit --chromium

2012-12-10 Thread Eric Seidel
The buildbots will use ninja by default, but could opt-out (with --no-ninja) if that were desired behavior. I've so far received one other concern: Robert Hogan raised that chromium's depot_tools does not contain a 32-bit build of ninja, and the error message is somewhat confusing in that case.

Re: [webkit-dev] Proposal: Make Ninja the default build-system for build-webkit --chromium

2012-12-10 Thread Jochen Eisinger
Will the buildbots use ninja or the "native" build tools? My only concern is that we're catching problems with e.g. MSVS only after we roll the WebKit deps in chromium and one of the MSVS bots starts failing. Otherwise, I'm all for switching to ninja. best -jochen On Sat, Dec 8, 2012 at 9:29 AM