Re: [webkit-dev] Removal of trailing whitespace

2023-04-13 Thread Anthony Ricaud via webkit-dev
(not a stakeholder either) On top of ignoring whitespace, Git and Github support ignoring commits when performing `git blame`. With that tool, one commit could remove trailing whitespace over the all project and add some editorconfig or CI checks to prevent them from coming back. Then, a secon

Re: [webkit-dev] Removal of trailing whitespace

2023-04-13 Thread Vitor Ribeiro Roriz via webkit-dev
Besides enforcing no whitespaces in new lines. Are PRs exclusively removing whitespaces from a file (or a batch of files) welcome? > On 13. Apr 2023, at 12:20, Adrian Perez de Castro via webkit-dev > wrote: > > Hi, > > On Wed, 12 Apr 2023 10:23:06 -0700 Ryosuke Niwa via webkit-dev > wrote:

Re: [webkit-dev] Removal of trailing whitespace

2023-04-13 Thread Adrian Perez de Castro via webkit-dev
Hi, On Wed, 12 Apr 2023 10:23:06 -0700 Ryosuke Niwa via webkit-dev wrote: > Yeah, enforcing that new or otherwise modified lines don’t have trailing > whitespaces would be good. I very much agree with this. Let's leave existing code as-is, having new and modified lines without trailing whitesp

Re: [webkit-dev] Removal of trailing whitespace

2023-04-13 Thread Adrian Perez de Castro via webkit-dev
Hi, On Wed, 12 Apr 2023 20:27:25 -0500 Michael Catanzaro via webkit-dev wrote: > On Thu, Apr 13 2023 at 08:15:00 AM +0900, Tetsuharu Ohzeki via > webkit-dev wrote: > > > To digress a little, why does webkit now use a style checker based on > > python script instead of clang-format? > > In tod

Re: [webkit-dev] Removal of trailing whitespace

2023-04-13 Thread Mathias Bynens via webkit-dev
(not a stakeholder; just curious) Does it help that Git supports the `-w` / `--ignore-all-space` flag to ignore whitespace changes? It works with `git diff`, `git blame`, etc. GitHub also supports it — compare e.g. https://github.com/WebKit/WebKit/commit/2ca55a3e19df60127dec09f3af22e4d3ab2943ec