Re: [webkit-dev] Rolling out a patch requires a justification beyond a test failure in downstream projects

Was this an isolated incident then? On Tue, Dec 11, 2012 at 8:39 PM, Ryosuke Niwa wrote: > On Tue, Dec 11, 2012 at 1:44 PM, Ryosuke Niwa wrote: > >> First off, I don't think we should be rolling out patches based solely on >> a downstream test unless there is a clear evidence that the failure

Re: [webkit-dev] unsigned vs unsigned int

If someone wanted this and understood python, I suspect that they could search for "unsigned" in that cpp.py and in about 10 min have a pretty good idea of how to add such a check. If you don't understand Python, then 30 minutes :) dave On Thu, Sep 13, 2012 at 2:12 PM, Kenneth Rohde Christiansen

Re: [webkit-dev] How to access the page group settings from WorkerContext

Ditto? On Mon, Jun 11, 2012 at 5:45 PM, Charles Wei wrote: > Hi, webkit-dev, > > I am trying to make indexedDB working for JSC. One of the problems I am > now having is to access the page group settings from the WorkerContext to > get the indexedDataBasePath to store the database. Anybody can he

Re: [webkit-dev] How to access page GroupSettings from WorkerThread

A few possibilities, in order of increasing complexity and work 1. If it can't change, you could pass it in when the worker is created. 2. If it can change, you do a postMessage to the main thread to get the value. 3. If you can't get the value in an async manner, perhaps you can make a method to a

Re: [webkit-dev] webkitPostMessage

wrt #1, I believe that postMessage implements what is in the spec and webkitPostMessage additional has support for ArrayBuffers which wasn't in the postMessage spec yet but was going to be added. If the behaviors from webkitPostMessage were added to postMessage, then it coudl be removed. wrt #2, I

Re: [webkit-dev] Eliminate potential null pointer dereference?

On Fri, Apr 20, 2012 at 1:39 PM, Maciej Stachowiak wrote: > > On Apr 19, 2012, at 11:11 PM, David Levin wrote: > > I think this all started with a lot of effort put into fixing an issue > reported by a user where they said "the most popular online forum in > Malaysia is

Re: [webkit-dev] Eliminate potential null pointer dereference?

g. we don't have a style > guide that mandates it. > > I completely agree with Maciej here that if this is a reachable code, then > the patch author should put a reasonable effort into creating a test case. And > most importantly, these changes are clearly not "code cleanup"

Re: [webkit-dev] Eliminate potential null pointer dereference?

I think this all started with a lot of effort put into fixing an issue reported by a user where they said "the most popular online forum in Malaysia is broken." Then folks had to do a lot of builds (bisecting) to track down where the problem was introduced. Then they had to figure out what had brok

Re: [webkit-dev] Fwd: Please add EditBugs to my account

Done. On Mon, Mar 26, 2012 at 11:47 AM, Tony Payne wrote: > > Error message in webkit-patch upload says to email webkit-committers, but > that message is not going through and I've been told this is the proper > list to request the EditBugs permission. > > Thanks, > Tony > > -- Forwarded

Re: [webkit-dev] Throwing SECURITY_ERR on cross-origin window.location property accesses

posing the parent origin has complications that will make it harder for this to get into WebKit, etc. but if folks find that acceptable, it scratches my itch. dave > Adam > On Mar 23, 2012 12:02 PM, "David Levin" wrote: > >> >> >> On Thu, Mar 22, 2012 at 9:21

Re: [webkit-dev] Throwing SECURITY_ERR on cross-origin window.location property accesses

information disclosure issue that anyone can now detect the usage of unannounced.google.com when they are framed (especially if "unannounced" were more descriptive)? dave > > Adam > > > On Thu, Mar 22, 2012 at 9:16 PM, David Levin wrote: > > Suppose I am using a fram

Re: [webkit-dev] Throwing SECURITY_ERR on cross-origin window.location property accesses

case is about avoiding spurious console error messages, so console error messages are real errors.) dave On Thu, Mar 22, 2012 at 8:44 PM, Sam Weinig wrote: > Hey Dave, > > Can you describe the use case for this new property? When would an author > use it? > > -Sam > > On

Re: [webkit-dev] Throwing SECURITY_ERR on cross-origin window.location property accesses

Resurrecting a really old thread so continue the conversation now that I'm hitting this issue :). On Mon, Aug 16, 2010 at 2:16 PM, Sam Weinig wrote: > I am not sure I agree. Does our behavior actually cause any real bugs in > the places you have tracked down? The log spam really doesn't seem l

Re: [webkit-dev] ChangeLogs

I think the challenge in part is to explain why the ChangeLog is useful. Comments in there hopefully explain why as a guide to reviewers to give the reviewers and future onlookers a guide to the change. It feels like what comments are that useful but often get inserted in there to fill it out. Is

Re: [webkit-dev] Ambiguity in the style guide

On Mon, Mar 19, 2012 at 10:37 PM, Martin Robinson wrote: > Hello WebKittens, > > While I am loathe to take up list space with another style guide > threads, Eric Seidel recently pointed out to me some ambiguities in > the style guide at https://bugs.webkit.org/show_bug.cgi?id=81602. > Namely secti

Re: [webkit-dev] Separating ENABLE(NOTIFICATIONS) and ENABLE(LEGACY_NOTIFICATIONS)

On Tue, Mar 13, 2012 at 2:42 PM, David Levin wrote: > Will LEGACY_NOTIFICATIONS cover everything that is in there right now? By in there, I meant in WebKit and what hosts have been shipping. > > Hopefully host apps won't have to define both NOTIFICATIONS > and LEGACY_NOTI

Re: [webkit-dev] Separating ENABLE(NOTIFICATIONS) and ENABLE(LEGACY_NOTIFICATIONS)

Will LEGACY_NOTIFICATIONS cover everything that is in there right now? Hopefully host apps won't have to define both NOTIFICATIONS and LEGACY_NOTIFICATIONS to keep their current functionality since NOTIFICATIONS sounds like it will be guarding work that is in progress. dave On Tue, Mar 13, 2012

Re: [webkit-dev] Moving to Git?

On Fri, Mar 9, 2012 at 4:01 PM, Ryosuke Niwa wrote: > > git will touch Node.h twice by stashing and applying. This would mean > that I would be rebuilding the world even if all changes I get from masters > were in webkitpy or LayoutTests. > > Are there an easy way to work around this issue as we

Re: [webkit-dev] Web Notifications API

On Mon, Feb 13, 2012 at 5:29 PM, Adam Barth wrote: > On Mon, Feb 13, 2012 at 5:23 PM, Jon Lee wrote: > > I also have concerns about backwards compatibility support. Aside from > > Gmail, what other web sites have integrated the notifications feature? I > > could only find example pages, one of w

Re: [webkit-dev] optimizing browser handling of Facebook Timeline scrolling

Not sure what tools you have used but you may find this helpful: http://code.google.com/webtoolkit/speedtracer/ On Sat, Feb 11, 2012 at 10:02 PM, Steven Young wrote: > [cross posting from mozilla's dev lists] > > I'm on the Timeline team at Facebook, which is going to be the new > format for ever

Re: [webkit-dev] HTML notification usage

TLDR Sorry for the long delay in responding but the chromium folks need to delay slight longer before giving a response. On Mon, Jan 16, 2012 at 1:36 PM, Kenneth Rohde Christiansen < kenneth.christian...@gmail.com> wrote: > Could anyone brief explain the relation to > > http://www.html5rocks.com/

Re: [webkit-dev] chromium-cg-mac results

On Tue, Jan 3, 2012 at 8:33 PM, Dirk Pranke wrote: > On Tue, Jan 3, 2012 at 3:28 PM, Adam Barth wrote: > > On Tue, Jan 3, 2012 at 3:22 PM, Nico Weber wrote: > >> On Tue, Jan 3, 2012 at 3:00 PM, Adam Barth wrote: > >>> It looks like Chromium Mac has successfully moved to Skia. > >> > >> I'd wai

Re: [webkit-dev] Announcement of Coding Style Change in WebKit EFL port

Feel free to patch the style checker as appropriate. I suspect there may be some changes needed here: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/style/checker.py#L180 Best wishes, dave On Tue, Dec 27, 2011 at 11:54 PM, Gyuyoung Kim wrote: > Hello WebKit folks, > > > As you may

Re: [webkit-dev] WebKit branch to support multiple VMs (e.g., Dart)

On Wed, Dec 7, 2011 at 1:13 AM, Dominic Cooney wrote: > On Wed, Dec 7, 2011 at 4:53 PM, Oliver Hunt wrote: >> >> Web Content Engine The project's primary focus is content deployed on >> the World Wide Web, using standards-based technologies such as HTML, CSS, >> JavaScript and the DOM. >> --Olive

Re: [webkit-dev] run-webkit-tests is moving to parallell testing by default (this weekend)

I believe there are some tests (copy/paste) that it would be very hard to fully shard due to how they work. dave On Mon, Dec 5, 2011 at 11:08 AM, Ojan Vafai wrote: > I looked at one example that didn't exit early: > http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/b

[webkit-dev] EWS bots don't run when missing binary data in diff [was Re: Style bot complains of missing binary data in diff when deleting .png test results]

On Wed, Nov 30, 2011 at 5:42 PM, Alan Stearns wrote: > David, > > This is a bug where I accidentally turned on a pixel result, then needed > to remove the .pngs when I fixed the problem: > > https://bugs.webkit.org/show_bug.cgi?id=73343 > > The patch had two lines like this: > > Binary files

Re: [webkit-dev] Style bot complains of missing binary data in diff when deleting .png test results

Perhaps you could give a bug that has an example of what you are talking about. For me it is hard to guess at what the complaint by the style bot is. dave On Wed, Nov 30, 2011 at 5:20 PM, Alan Stearns wrote: > > If I delete a .png test result and I make a git diff without using the > --binary

Re: [webkit-dev] Using C++ constant local variables in WebKit

On Tue, Nov 29, 2011 at 6:19 PM, Darin Adler wrote: > On Nov 28, 2011, at 1:38 PM, David Kilzer wrote: > > In a discussion on Bug 71921, > Antti, Darin Adler and I started a discussion about using C++ constant > pointers in WebKit. Does the WebKit c

Re: [webkit-dev] Add a set of new APIs for the Custom Scheme and Content Handler.

On Tue, Nov 29, 2011 at 6:09 AM, Soo-Hyun Choi wrote: > On Tue, Nov 29, 2011 at 17:59, Maciej Stachowiak wrote: > > > > Looks like I was mistaken and misread the spec, so I withdraw this > comment. > > > > Do other browsers that implement the register functions also implement > the related isRegi

Re: [webkit-dev] Putting layout tests on a separate repository (was "Supporting w3c ref tests and changing our convention")

On Mon, Nov 7, 2011 at 8:00 PM, Ryosuke Niwa wrote: > On Nov 4, 2011 4:59 PM, "Dirk Pranke" wrote: > > Actually, we should be encouraging people to use reftests now, since > > every port but two supports them, and we should be moving the last two > > over ASAP. > > I'd argue that we should not e

Re: [webkit-dev] It's time to remove the Haiku port

On Fri, Nov 4, 2011 at 3:24 PM, Ryan Leavengood wrote: > There may be a time when I do this work, but I have bigger fish to fry at > the moment... > Exactly :) ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listi

Re: [webkit-dev] It's time to remove the Haiku port

On Fri, Nov 4, 2011 at 3:04 PM, Ryan Leavengood wrote: > I personally would like to see WebCore > evolve into being as self-contained as possible, with clear APIs for a > platform to attach to. > I suspect the pain hasn't been big enough so far for any person/organization to decide to address thi

Re: [webkit-dev] reminder: don't do blanket style fixups

Trailing whitespace guidelines aren't part of the WebKit style guide on purpose. Thus, it wasn't a style clean-up, so I guess that would make it a change to fit someone's preference. dave On Wed, Oct 19, 2011 at 6:38 PM, Ojan Vafai wrote: > I saw a patch get committed recently that just fixes

[webkit-dev] watchlist: A tool to alert you about patches of interest.

The watchlist is a simple way to watch for new patches that interest you. The watchlist is automatically applied to patches by a bot (currently the style bot). I'm happy to answer questions about it here or in irc (and/or review any patches you make to the config file, but of course I don't mind o

Re: [webkit-dev] Change to style guideline: should use type& instead of type* for out arguments

It feels like the material about RefPtr belongs here: http://www.webkit.org/coding/RefPtr.html instead of the style guide since that is where everything else about how to properly use RefPtr/PassRefPtr is. On Mon, Oct 10, 2011 at 10:42 AM, Ryosuke Niwa wrote: > FYI, a patch has been posted to >

Re: [webkit-dev] New feature flag proposal: Joystick API

On Thu, Oct 6, 2011 at 11:07 AM, Alexey Proskuryakov wrote: > > I share Simon's concern that that providing low level access to every > possible controller creates fragmentation, with purportedly "HTML" content > that only works on a few devices. There is no clear cut border here - it's > been me

Re: [webkit-dev] Please use platform prefixes in bug titles

On Wed, Oct 5, 2011 at 6:07 PM, Alexey Proskuryakov wrote: > > 05.10.2011, в 17:47, James Robinson написал(а): > > That would certainly be nice, but it wouldn't be as useful as having the > platform in the bug description. The "Platform" field is not very obvious > in the bugzilla UI and doesn't

Re: [webkit-dev] Compile-time assertions for object sizes

On Thu, Sep 29, 2011 at 12:11 PM, Simon Fraser wrote: > > On Sep 29, 2011, at 11:40 AM, Andreas Kling wrote: > > > Dear WebKittens, > > > > I'd like to add some compile-time assertions for the sizes of various > objects. The motivation comes a patch fixing bloat in InlineBox[1]. > > > > There are

Re: [webkit-dev] webkit-dev [check-webkit-style - shows warnings on the untouched code in repo]

If you run check-webkit-style on a file, it will show all style issues for the whole file. However, you can run it on a diff (which is what webkit-patch upload will do). Then it will only flag lines that you changed. It still may flag issues that you didn't cause but you changed those lines, so i

[webkit-dev] starting implementation of postMessage tranferables

*Summary*: Implementing postMessage with transferable support as webkitPostMessage. *Details*: *Spec*: http://www.whatwg.org/specs/web-apps/current-work/multipage/comms.html#posting-messages This describes window.postMessage and the same is true for Message Ports and Worker Context. It doesn't me

Re: [webkit-dev] Vendor Prefixing, was Re: New feature announcement - Implement HTML5 Microdata in WebKit

TL;DR (from Charles himself): My concern, on this WebKit development mailing list, is that introducing another method -without- vendor prefixing may create some tension that WebKit developers would like to avoid. ___ webkit-dev mailing list webkit-dev@lis

Re: [webkit-dev] What is an "active port"? [WAS: Do you maintain OS(WINCE)?]

On Thu, Sep 15, 2011 at 12:26 PM, Dirk Pranke wrote: > On Thu, Sep 15, 2011 at 12:17 PM, Geoffrey Garen wrote: > > On Sep 14, 2011, at 1:02 PM, Dirk Pranke wrote: > > > >> Maybe we need a webkit-port-maintainers@ list that one could easily cc > >> rather than trying to add people by hand? > > >

Re: [webkit-dev] Committing EFL baselines

On Mon, Sep 12, 2011 at 1:48 PM, Peter Kasting wrote: > On Mon, Sep 12, 2011 at 1:36 PM, Ryosuke Niwa wrote: > >> This is pretty much unreviewable, so I pretend to commit this directly, in >>> batches (one commit per toplevel directory in LayoutTests/platform/efl) in >>> the next weeks. Any objec

Re: [webkit-dev] RefPtr/PassRefPtr Question

fwiw, check-webkit-style has been fixed: http://trac.webkit.org/changeset/94803 On Wed, Sep 7, 2011 at 7:56 AM, Darin Adler wrote: > On Sep 6, 2011, at 6:24 PM, Maciej Stachowiak wrote: > > > On Aug 31, 2011, at 3:31 PM, David Levin wrote: > > > >> Ignore me. I

Re: [webkit-dev] RefPtr/PassRefPtr Question

Ignore me. I'm missing the "&". I suppose if you want a RefPtr&, then the style checker is wrong and the parameter should be allowed to be a RefPtr. Feel free to file a bug and I'll get to it (-- it may take me a week or two at the moment). dave On Wed, Aug 31,

Re: [webkit-dev] RefPtr/PassRefPtr Question

Any of these should work: RefPtr myLocal; bool success = myFunc(myLocal); Uses template PassRefPtr(const RefPtr&); Or RefPtr myLocal; bool success = myFunc(myLocal.release()); Or RefPtr myLocal; bool success = myFunc(myLocal.get()); Uses PassRefPtr(T* ptr) The second form is prefered if y

Re: [webkit-dev] lots of red in the tree.

On Tue, Aug 30, 2011 at 12:54 PM, David Levin wrote: > > > On Tue, Aug 30, 2011 at 10:55 AM, Jarred Nicholls wrote: > >> On Tue, Aug 30, 2011 at 1:52 PM, David Levin wrote: >> >>> It means that I'm much more likely to cause regressions because I miss >

Re: [webkit-dev] ping-pong with fast/files/create-blob-url-crash-expected.txt

On Wed, Aug 31, 2011 at 5:57 AM, Philippe Normand wrote: > Sorry for the last one. Looks like the patch in https://bugs.webkit.org/show_bug.cgi?id=66045 > is intended to fix this issue for both JSC and V8 code generators, if I > understood correctly. > Short story: http://trac.webkit.org/**cha

Re: [webkit-dev] lots of red in the tree.

On Tue, Aug 30, 2011 at 10:55 AM, Jarred Nicholls wrote: > On Tue, Aug 30, 2011 at 1:52 PM, David Levin wrote: > >> It means that I'm much more likely to cause regressions because I miss new >> test failures caused by my changes among the 12 to 62 failures >> alrea

[webkit-dev] lots of red in the tree.

It means that I'm much more likely to cause regressions because I miss new test failures caused by my changes among the 12 to 62 failures already occurring on the OS X bots. I think there are a few solutions to the current situation: 1. Live with it. All of the red and green reminds us of the fes

Re: [webkit-dev] Git mirror out of sync?

>From an irc conversation, it sounds like this is being worked on but "git-svn just hangs, hard to tell why its broken" dave On Wed, Aug 17, 2011 at 7:56 AM, Nico Weber wrote: > Hi, > > git fetch origin && git log origin/master > > suggests that the git mirror stopped syncing at r93166. Can so

Re: [webkit-dev] LayoutTests results fallback graph

On Mon, Jul 11, 2011 at 10:46 AM, Adam Barth wrote: > > There are two main benefits: > > 1) A tree is much easier to understand than a rats nest of interwoven > fallback paths. I find it impossible to know what the fallback path is. Even with Adam's graph, it is hard to figure it out as Mark dem

Re: [webkit-dev] Lets use PassRefPtr for arguments less; lets use RefPtr for locals and data members more

On Mon, Jun 20, 2011 at 9:39 PM, Alexey Proskuryakov wrote: > > 20.06.2011, в 21:29, David Levin написал(а): > > > Here's a few benefits: > > 1. It makes the code more self-documenting. It clearly indicates that > this function intends to take a reference to the

Re: [webkit-dev] Lets use PassRefPtr for arguments less; lets use RefPtr for locals and data members more

On Mon, Jun 20, 2011 at 6:11 PM, Alexey Proskuryakov wrote: > > 20.06.2011, в 17:25, Maciej Stachowiak написал(а): > > >> Yet it's the latter where PassRefPtr is beneficial. Why base the rule on > something that's disconnected from actual benefit? > > > > Because it's simpler to read the source o

Re: [webkit-dev] Lets use PassRefPtr for arguments less; lets use RefPtr for locals and data members more

On Mon, Jun 20, 2011 at 5:25 PM, Maciej Stachowiak wrote: > > On Jun 20, 2011, at 9:19 AM, Alexey Proskuryakov wrote: > > > 20.06.2011, в 03:22, Maciej Stachowiak написал(а): > > For a shared ownership model there are multiple possible definitions of > whether a function takes ownership to an obj

[webkit-dev] hook to re-author commit queue patches seems broken/off

For example, this patch http://trac.webkit.org/changeset/89287 says it is by commit-qu...@webkit.org but it should say mrobin...@webkit.org. dave ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-

Re: [webkit-dev] Why is gtest in the Source directory?

On Thu, May 12, 2011 at 11:33 AM, David Levin wrote: > > > On Thu, May 12, 2011 at 10:36 AM, Adam Barth wrote: > >> Here's a straw-man proposal: >> >> Tests/ > > -- All testing code. Do test harnesses go here too? > > Layout/ # Would be n

Re: [webkit-dev] Why is gtest in the Source directory?

tests are part of the source code > > - Scattered around by the files that tests test, as David suggests. > > In terms of gtest directory placement, I think it is nice to have all > > third-party libraries live in the same place. > > What do people think? > > Kind regar

Re: [webkit-dev] Why is gtest in the Source directory?

It sounds like you have a helpful mental mapping for what belongs in each directory that we haven't written anywhere. Perhaps you could write it down and send it to webkit-dev so that we can make it a common model. It feels like a related topic is why are the unit tests under Tools as opposed to

[webkit-dev] git repository seems out of date

(From two different machines) when I do a git fetch, I seem to only be getting up to r86081. Is something wrong with the main repository? If so, would someone fix it? Thanks, dave ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webk

Re: [webkit-dev] How to enable WebGL on WebKit QT port?

On Mon, May 2, 2011 at 1:39 PM, Won J Jeon wrote: > Dear David, > > Thanks for your response. However, my code base is r85509 and even with the > code changes that you mentioned, I got the same error message. Any idea? > Yes, there still need to be some changes to fix the build that you are doin

Re: [webkit-dev] How to enable WebGL on WebKit QT port?

It looks like there need to be a few build fixes in that code due to recent changes in the code. See http://trac.webkit.org/changeset/85343 for the types of changes to be done. Then feel free to submit a patch to fix this for others -- http://www.webkit.org/coding/contributing.html dave On Mo

Re: [webkit-dev] Renaming the blog (was Re: WebKit blog post proposal: Remote debugging with Web Inspector.)

What's what with WebKit On Mon, May 2, 2011 at 10:01 AM, Eric Seidel wrote: > Along the vein of cutesy CSS names: > > http://trac.webkit.org/browser/trunk/Source/WebCore/css/CSSPropertyNames.in > was rather inspiring: > > -webkit-writing-mode: blog > content: blog > "Style Overflow" > src=webkit

Re: [webkit-dev] WebKit unit test framework

On Wed, Apr 20, 2011 at 4:59 PM, Darin Fisher wrote: > I believe both maruel and jcivelli have had experience contributing changes > to gtest. > > While I wouldn't characterize its code as simple, I haven't had trouble > understanding it. It is a fairly mature project, having been used > interna

Re: [webkit-dev] WebKit unit test framework

On Wed, Apr 20, 2011 at 4:01 PM, Sam Weinig wrote: > Is a death test as scary as it sounds? > :) Useful if you want to verify that the program crashes. fwiw, chromium uses this to verify that asserts fire in debug in particular scenarios. ___ webkit-

Re: [webkit-dev] WebKit unit test framework

rt to do any of this would be better invested in other places where there isn't already something that works for us. fwiw, we could go with what we do with bugzilla where we start with gtest and people change the code if needed. dave > > On Apr 18, 2011, at 11:36 AM, David Levin wrote:

Re: [webkit-dev] choosing a unit test framework

On Tue, Apr 19, 2011 at 2:42 PM, Ryosuke Niwa wrote: > Can we see examples of tests that use TestWebKitAPI / gtest? I think it'll > be helpful for people who don't know how the said two testing frameworks > work. > > Ideally, we compare the same test written in TestWebKitAPI and gtest to > decid

[webkit-dev] choosing a unit test framework

In the interest of moving this along, I'll move to using the criteria listed in the previous email to evaluate the test frameworks. *Musts:* - Compatible license with WebKit - Builds/Can be built on the many platforms and build systems supported by WebKit (ideally without extra ins

[webkit-dev] WebKit unit test framework

*Issue: *There has been a long standing bug to add unit tests to WebKit ( https://bugs.webkit.org/show_bug.cgi?id=21010). It was also mentionedon webkit-dev that it would be helpful in various cases. *Landscape:* Surveying

Re: [webkit-dev] WebKit2 build system

Question answered (in irc): WebKit2 files should have config.h Thanks! On Mon, Apr 11, 2011 at 9:58 AM, David Levin wrote: > Hi, > I was looking at a patch (https://bugs.webkit.org/show_bug.cgi?id=57535) > in which it uses the OS() macro in some headers (to add a conditional >

Re: [webkit-dev] WebKit2 build system

Hi, I was looking at a patch (https://bugs.webkit.org/show_bug.cgi?id=57535) in which it uses the OS() macro in some headers (to add a conditional include to define time_t). Unfortunately, when these headers are included from WebKit2 files, the build breaks (on various platforms) because OS() isn'

Re: [webkit-dev] Who are the EFL reviewers?

On Mon, Apr 11, 2011 at 3:40 AM, Tomasz Morawski wrote: > Hi, > Is it possible to promote some other peoples to reviewers in the EFL > port? > A step that I usually suggest to chromium folks before becoming reviewers is to actually do reviews on patches. Do everything except the r+ (with the sub

Re: [webkit-dev] bugid in ChangeLog

On Mon, Mar 28, 2011 at 11:48 AM, Maciej Stachowiak wrote: > > On Mar 28, 2011, at 11:21 AM, Darin Adler wrote: > > > On Mar 28, 2011, at 10:44 AM, Jeremy Orlow wrote: > > > > Sure I am open to discussion about that. I think that some check-ins, > especially LayoutTest ones, don’t need change log

Re: [webkit-dev] bugid in ChangeLog

On Mon, Mar 28, 2011 at 10:44 AM, Jeremy Orlow wrote: > On Mon, Mar 28, 2011 at 10:06 AM, David Levin wrote: > >>http://trac.webkit.org/changeset/81305 >> PS Dmitry found a flaw in my original change log text -- due to my haste, >> I originally had put in the wrong v

Re: [webkit-dev] bugid in ChangeLog

Here's a change that I felt worth getting someone to glance at but didn't feel worth the overhead of a bug: http://trac.webkit.org/changeset/81305 Since I was gardener and this was affecting the bots, it was a timely situation. (Sometimes getting in your fix right before another break comes in

Re: [webkit-dev] bugid in ChangeLog

On Sat, Mar 26, 2011 at 3:24 AM, Patrick Gansterer wrote: > Hi, > > Sometimes folks commit changes without bug numbers. If those changes breaks > things it's hard to find the correct context for the change. > Can we make the bug number a requirement for a commit when it has a > corresponding bug?

Re: [webkit-dev] UA string changes blog draft

Ugh my strikethrough on "begs the question" was lost (and I meant that phrase as a joke). On Fri, Mar 25, 2011 at 11:54 AM, David Levin wrote: > The blog post begs the question made me wonder. > > Why was "Macintosh; " kept when it is redundant with "Intel M

Re: [webkit-dev] UA string changes blog draft

The blog post begs the question made me wonder. Why was "Macintosh; " kept when it is redundant with "Intel Mac OS X 10_6_7"? The reasoning seem analogous to what was given for why "Windows;" was removed. dave On Fri, Mar 25, 2011 at 11:44 AM, Peter Kasting wrote: > I've incorporated all the

Re: [webkit-dev] Build system update

On Wed, Mar 23, 2011 at 12:17 PM, Adam Barth wrote: > > $ time git svn rebase > [... update my working copy from changes during lunch (four revisions) ...] > real1m10.316s > user0m8.194s > sys 0m16.400s > > $ time ./Tools/Scripts/generate-project-files > real0m4.339s > user0m3.

Re: [webkit-dev] Build system update

On Wed, Mar 23, 2011 at 3:33 AM, Adam Barth wrote: > On Wed, Mar 23, 2011 at 12:22 AM, Mark Rowe wrote: > >> In any case, I'm glad we've found a technically feasible solution. > > > > We've had at least one technically feasible solution from day zip: check > in the generated project files. > > F

[webkit-dev] SnowLeopard debug buildbot not there

tL;dr "Why isn't there a SnowLeopard debug buildbot? Related: Why does the commit queue (appear) to only run release builds through tests?" Details: Yesterday, I did a build of WebKit on SnowLeopard and hit ~12 crashes (mostly in inspector tests). Then I realized that we don't have such a bot, so

Re: [webkit-dev] Towards a unified build system

On Tue, Mar 1, 2011 at 1:13 PM, Jeremy Orlow wrote: > We could quickly find ourselves in the position of generating build files > for many different ports every time we submit patches, which could add > several minutes to the submit process The alternative is to get everyone to spend this time :)

Re: [webkit-dev] Proposal: Let's make the WebKit2 test bot a core builder

r+'ed (only replied to keep others from clicking just to find out it was already done). On Sun, Feb 6, 2011 at 8:52 PM, Maciej Stachowiak wrote: > > https://bugs.webkit.org/show_bug.cgi?id=53901 > > On Feb 6, 2011, at 2:37 PM, Adam Barth wrote: > > > Go for it. The only requirement to be a core

Re: [webkit-dev] More information for crashing tests now available on build.webkit.org

Kudos! On Fri, Feb 4, 2011 at 11:25 AM, Adam Roben wrote: > Hi all- > > The results.html pages on build.webkit.org now make it much easier to > triage crashing tests on Mac and Windows XP (Windows Vista/7 are blocked by > ). When a test crashes, you'll see something >

[webkit-dev] Modification to WebKit reviewer nominations.

As the WebKit community continues to grow rapidly, it is useful to consider how to retain its health and culture. One important aspect of our community has been the way that people work together regardless of their affiliations. In order to emphasize this tradition, the WebKit reviewers have agree

Re: [webkit-dev] More thoughts on cleaning up the root directory

On Mon, Dec 27, 2010 at 7:17 PM, Maciej Stachowiak wrote: > > On Dec 27, 2010, at 1:11 PM, Sam Weinig wrote: > > > > On Mon, Dec 27, 2010 at 11:14 AM, Adam Barth wrote: > >> > Is it really a good idea to move platform out of WebCore? Lots of stuff >> > there seems quite WebCore related. >> >> Th

Re: [webkit-dev] Renaming directories

Sounded like MIT license is considered permittable: https://lists.webkit.org/pipermail/webkit-dev/2010-January/011406.html On Wed, Dec 22, 2010 at 1:05 PM, Kenneth Russell wrote: > On Wed, Dec 22, 2010 at 10:53 AM, Mark Rowe wrote: > > > > On 2010-12-22, at 10:45, Kenneth Russell wrote: > > >

Re: [webkit-dev] Post positive reviews

r- On Mon, Dec 13, 2010 at 12:01 PM, Evan Martin wrote: > That's a good point. The overwhelming majority of reviews of WebKit > are negative -- they even have a shorthand for it, "r-". > > It seems inevitable that the project is going to drop out of Google > anytime now. :( > > On Mon, Dec 13,

Re: [webkit-dev] Waiting time for patch with commit? status.

I don't know if my behavior is typical but I almost never scan the commit queue. I occasionally scan the review queue. So changing an already r+'ed bug to have cq? may not get noticed. I'd ping someone to be sure (and there are more committers than reviewers so you have more options even). dave

Re: [webkit-dev] about the Sputnik testsuite.

Click the "compare" link on the page that you included. Also see the blog about it: http://blog.chromium.org/2009/06/launching-sputnik-into-orbit.html Together they should answer your question pretty well. Disclaimer: I don't wo

Re: [webkit-dev] Faster Git SVN updates

Added by dimich, but it is a tip from Albert and I think how most chromium enlistments for git are setup iirc). dave On Thu, Nov 18, 2010 at 3:32 PM, Eric Seidel wrote: > There is this section of the WebKit Git wiki ( > http://trac.webkit.org/wiki/UsingGitWithWebKit): > > If you don't fetch new

Re: [webkit-dev] deleteOwnedPtr(T* ptr)

Do or do not. Then, there is no question. :) btw, in another code base, you may familiar with, the comment is the variable name: http://www.google.com/codesearch?q=type_must_be_complete&exact_package=chromium On Thu, Nov 11, 2010 at 12:24 AM, Finnur Thorarinsson wrote: > Umm... shouldn't this be

Re: [webkit-dev] Coding style change - Indentation of forward declarations in headers

On Mon, Nov 1, 2010 at 10:06 AM, Brady Eidson wrote: > > On Nov 1, 2010, at 10:00 AM, David Hyatt wrote: > > Yeah I agree with Peter. I think blank lines after { and before } would > improve the readability of the 2nd example even without indentation. > > namespace WebCore { > > class Authentica

Re: [webkit-dev] Should we recommend explicit constructors as part of WebKit style?

It sounds like there is consensus. Here's a patch for adding this to the style guide: https://bugs.webkit.org/show_bug.cgi?id=47646 dave On Wed, Sep 29, 2010 at 9:41 AM, Darin Adler wrote: > On Sep 28, 2010, at 4:31 PM, Maciej Stachowiak wrote: > >> I think the rule should be something like: >>

Re: [webkit-dev] PSA: Don't try to hold onto temporaries with references

On Tue, Oct 5, 2010 at 3:42 AM, Peter Kasting wrote: > On Mon, Oct 4, 2010 at 4:23 AM, Leandro Graciá Gil < > leandrogra...@chromium.org> wrote: > >> In summary, looking at code like this >>> >>> B& b = c->foo(); >>> ... >>> b.m(); >>> >>> If c->foo() returns a temporary ("return B();"), then

Re: [webkit-dev] PSA: Don't try to hold onto temporaries with references

Thanks Peter and Darin. In summary, looking at code like this B& b = c->foo(); ... b.m(); If c->foo() returns a temporary ("return B();"), then it is safe. If c->foo() returns a reference to a member variable ("return m_b;"), then it is up to the lifetime of of "c->m_b". The cases that Adam

Re: [webkit-dev] Should we recommend explicit constructors as part of WebKit style?

On Tue, Sep 28, 2010 at 4:30 PM, Oliver Hunt wrote: > > Pro's for #1 > It is a pain to remember to put explicit every time you have a > constructor with one argument. > > Could check-webkit-style be beaten into forcing this for us? > Yep, check-webkit-style could check this automatically, but i

[webkit-dev] Should we recommend explicit constructors as part of WebKit style?

This came up before: https://lists.webkit.org/pipermail/webkit-dev/2010-May/012873.html but I'd like to understand it a bit better. It feels there were two points of view: 1. Use explicit only when necessary to prevent an undesirable implicit conversion like int to vector. 2. Use explici

Re: [webkit-dev] Blob scheme implementation

On Tue, Sep 14, 2010 at 6:53 PM, Oliver Hunt wrote: > > On Sep 14, 2010, at 5:56 PM, David Levin wrote: > > On Tue, Sep 14, 2010 at 5:42 PM, Adam Barth wrote: > >> What do you think of the idea of having a re-useable BlobCore module >> that all the ports can share? &

Re: [webkit-dev] Blob scheme implementation

On Tue, Sep 14, 2010 at 5:42 PM, Adam Barth wrote: > What do you think of the idea of having a re-useable BlobCore module > that all the ports can share? > I don't think this is a good idea. This "re-usable module" would only be used by the Safari WebKit port. As I understand it, Chromium wouldn

  1   2   >