If someone wanted this and understood python, I suspect that they could search for "unsigned" in that cpp.py and in about 10 min have a pretty good idea of how to add such a check. If you don't understand Python, then 30 minutes :)
dave On Thu, Sep 13, 2012 at 2:12 PM, Kenneth Rohde Christiansen < kenneth.christian...@gmail.com> wrote: > Filed https://bugs.webkit.org/show_bug.cgi?id=96693 > > On Thu, Sep 13, 2012 at 10:47 PM, Ryosuke Niwa <rn...@webkit.org> wrote: > > No. I think we can update webkitpy/style/checkers/cpp.py to do that. > > Unfortunately, I don't understand that code base. > > > > - Ryosuke > > > > > > On Thu, Sep 13, 2012 at 1:34 PM, Oliver Hunt <oli...@apple.com> wrote: > >> > >> Does the style bot pick up "unsigned int" etc? > >> > >> --Oliver > >> > >> On Sep 13, 2012, at 1:19 PM, Ryosuke Niwa <rn...@webkit.org> wrote: > >> > >> Landed in http://trac.webkit.org/changeset/128499 (Thanks ggaren!) > >> > >> On Thu, Sep 13, 2012 at 12:29 PM, Ryosuke Niwa <rn...@webkit.org> > wrote: > >>> > >>> Uploaded a patch on https://bugs.webkit.org/show_bug.cgi?id=96682. > >>> > >>> - Ryosuke > >>> > >>> On Thu, Sep 13, 2012 at 8:11 AM, Dan Bernstein <m...@apple.com> wrote: > >>>> > >>>> > >>>> > >>>> On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen > >>>> <kenneth.christian...@gmail.com> wrote: > >>>> > >>>> > Hi there, > >>>> > > >>>> > I was telling people to use "unsigned" instead of "unsigned int", > as I > >>>> > have been told that was the preferred style before, but apparently > >>>> > that is not in the style guide. > >>>> > > >>>> > The question is, should it be? > >>>> > >>>> Yes. > >>>> > >>>> > > >>>> > A few greps in the code: > >>>> > > >>>> > "unsigned" -> 18406 occurrences. > >>>> > "unsigned int" -> 1721 > >>>> > "unsigned i =" -> 1548 > >>>> > > >>>> > It does in fact seem to be the preferred style. > >>>> > > >>>> > Cheers > >>>> > Kenneth > >>>> > > >>>> > -- > >>>> > Kenneth Rohde Christiansen > >>>> > Senior Engineer, WebKit, Qt, EFL > >>>> > Phone +45 4093 0598 / E-mail kenneth at webkit.org > >>>> > > >>>> > ﹆﹆﹆ > >>>> > _______________________________________________ > >>>> > webkit-dev mailing list > >>>> > webkit-dev@lists.webkit.org > >>>> > http://lists.webkit.org/mailman/listinfo/webkit-dev > >>>> _______________________________________________ > >>>> webkit-dev mailing list > >>>> webkit-dev@lists.webkit.org > >>>> http://lists.webkit.org/mailman/listinfo/webkit-dev > >>> > >>> > >> > >> _______________________________________________ > >> webkit-dev mailing list > >> webkit-dev@lists.webkit.org > >> http://lists.webkit.org/mailman/listinfo/webkit-dev > >> > >> > > > > > > _______________________________________________ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > http://lists.webkit.org/mailman/listinfo/webkit-dev > > > > > > -- > Kenneth Rohde Christiansen > Senior Engineer, WebKit, Qt, EFL > Phone +45 4093 0598 / E-mail kenneth at webkit.org > > ﹆﹆﹆ > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev >
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
