Re: [webkit-dev] [PATCH] Errors from build-webkit --debug --minimal

2012-06-25 Thread Eric Seidel
It appears we still have a Qt-Minimal builder, I'm just not sure how minimal it is: http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal On Mon, Jun 25, 2012 at 12:56 PM, Eric Seidel e...@webkit.org wrote: If someone wanted to set up a --minimal bot, I'm sure that would be welcome

Re: [webkit-dev] build.webkit.org down?

2012-06-21 Thread Eric Seidel
One can run: http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py to test the master locally, but that's all I know of. On Thu, Jun 21, 2012 at 11:15 AM, Sergio Villar Senin svil...@igalia.com wrote: En 21/06/12 19:54, William Siegrist

Re: [webkit-dev] Proposal to add 'compile-tools' step to the build bots

2012-06-19 Thread Eric Seidel
Sounds like a good idea to me. Many ports already build DumpRenderTree, etc. as part of build-webkit. (Gtk/Qt come to mind.) http://trac.webkit.org/browser/trunk/Tools/Scripts/build-dumprendertree#L74 On Tue, Jun 19, 2012 at 1:33 PM, Lucas Forschler lforsch...@apple.com wrote: Hello all,

Re: [webkit-dev] Block 3rd part cookies implementation

2012-05-29 Thread Eric Seidel
trac.webkit.org is your friend here. For example, searching for 3rd party cookie (per the title of your mail), finds: http://trac.webkit.org/search?q=3rd+party+cookie There are also various code-search tools on the web, including Chromium's (which will search the full source of WebKit):

[webkit-dev] AppleWin Bot is sick?

2012-05-28 Thread Eric Seidel
http://build.webkit.org/builders/Windows%20Release%20%28Build%29 Looks like it's 60 hours behind? I was looking into unskipping some tests on windows to get the results from the bots, but that seems infeasible. :) More generally it seems that bot may be borked? -eric

Re: [webkit-dev] Changes to window.focus/window.blur controlled by a setting?

2012-05-21 Thread Eric Seidel
So this would just make pop-unders turn into pop-overs correct? On Mon, May 21, 2012 at 2:17 AM, Jochen Eisinger joc...@chromium.org wrote: Hey, in https://bugs.webkit.org/show_bug.cgi?id=86969 I'm changing window.focus and window.blur to match Firefox's behavior: window.blur does nothing,

Re: [webkit-dev] Changes to window.focus/window.blur controlled by a setting?

2012-05-21 Thread Eric Seidel
Resent from the correct account. On Mon, May 21, 2012 at 4:16 AM, Eric Seidel esei...@google.com wrote: So this would just make pop-unders turn into pop-overs correct? On Mon, May 21, 2012 at 2:17 AM, Jochen Eisinger joc...@chromium.org wrote: Hey, in https://bugs.webkit.org/show_bug.cgi?id

Re: [webkit-dev] please add EditBugs permission

2012-05-15 Thread Eric Seidel
    login_userid_pairs = [self._login_and_uid_from_row(row) for row in results_table('tr')] TypeError: 'NoneType' object is not callable On Thu, Apr 12, 2012 at 6:47 PM, Eric Seidel e...@webkit.org wrote: Done. % webkit-patch add-users-to-groups shezbaig...@gmail.com Add users matching shezbaig...@gmail.com

Re: [webkit-dev] Error while applying on EWS bots.

2012-05-11 Thread Eric Seidel
Presumably this is the same as https://bugs.webkit.org/show_bug.cgi?id=85742. On Thu, May 10, 2012 at 10:56 PM, Pravin D pravind@gmail.com wrote: Hi All, I had uploaded a patch for a Bug from Windows cygwin, using webkit-patch upload command. All the EWS bots are not able to apply the

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-01 Thread Eric Seidel
of week, assuming timely reviews. -eric On Sun, Apr 1, 2012 at 4:28 PM, Eric Seidel e...@webkit.org wrote: Adding ENABLE, skipping tests, and reverting any non-passing tests, proved complicated.  So I've reverted my work on trunk: http://trac.webkit.org/changeset/112820 and I'll be doing my

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-01 Thread Eric Seidel
Is your goal to be able to disable the feature to prevent a late-known security issue? Or is your goal to universally disable seamless for a port entirely? On Tue, May 1, 2012 at 2:06 PM, Maciej Stachowiak m...@apple.com wrote: On May 1, 2012, at 12:20 PM, Eric Seidel e...@webkit.org wrote

Re: [webkit-dev] PSA: Commit-queue/Cr-Linux Delays expected until EOD

2012-04-30 Thread Eric Seidel
, Apr 23, 2012 at 2:36 PM, Eric Seidel e...@webkit.org wrote: run-webkit-unittests was hung on the 2 cr-linux EWS machines: https://bugs.webkit.org/show_bug.cgi?id=84611 Causing a queue overflow: http://ews-watcher.kov.eti.br/ (big red line to the sky) The CQ was unaffected, but because most

Re: [webkit-dev] Implementing CSS3 Paged Media Margin Boxes

2012-04-27 Thread Eric Seidel
want to be able to test taht page 27 has the right number and that it was laid out on the 4th printed page, etc. :) On Fri, Apr 27, 2012 at 10:29 AM, Milian Wolff milian.wo...@kdab.com wrote: On Friday 27 April 2012 10:08:13 Eric Seidel wrote: When I last looked at the page media stuff (long ago

Re: [webkit-dev] Deprecating features guideline wiki

2012-04-27 Thread Eric Seidel
Is the concern that we've been deprecating too many things too quickly? On Fri, Apr 27, 2012 at 5:00 PM, Benjamin Poulain benja...@webkit.org wrote: On Fri, Apr 27, 2012 at 2:18 PM, Dirk Pranke dpra...@chromium.org wrote: That said, what sort of officialness does this writeup/guideline/policy

Re: [webkit-dev] Deprecating features guideline wiki

2012-04-27 Thread Eric Seidel
wrote: On Fri, Apr 27, 2012 at 5:10 PM, Eric Seidel e...@webkit.org wrote: Is the concern that we've been deprecating too many things too quickly? Quite the contrary. People were concerned about the way to deprecate more stuff and making fewer mistakes when adding and removing features

[webkit-dev] A plug for the Watch List

2012-04-25 Thread Eric Seidel
Are you an expert on FOO? Does your port need to know if BAR changes? Are you sick and tired of those insert company name here people breaking your favorite BAZ!?!? Add yourself to the watchlist: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/watchlist Especially if

Re: [webkit-dev] A plug for the Watch List

2012-04-25 Thread Eric Seidel
As explained here: http://trac.webkit.org/wiki/WatchList The style-bot applies the watchlist regexps when it checks a patch, and will CC you at that time. On Wed, Apr 25, 2012 at 11:26 AM, Eric Seidel e...@webkit.org wrote: Are you an expert on FOO? Does your port need to know if BAR changes

Re: [webkit-dev] Double-Resolution (Retina) Images - Re: -webkit-image-set

2012-04-24 Thread Eric Seidel
Assuming I'm understanding Kalle correctly, it seems this could already be accomplished with @media resolution? http://www.w3.org/TR/css3-mediaqueries/#resolution @media screen and (min-resolution: 264dpi) { … } Which according to: http://en.wikipedia.org/wiki/List_of_displays_by_pixel_density

Re: [webkit-dev] Double-Resolution (Retina) Images - Re: -webkit-image-set

2012-04-24 Thread Eric Seidel
To answer my own question: http://trac.webkit.org/browser/trunk/Source/WebCore/css/MediaQueryEvaluator.cpp#L66 On Mon, Apr 23, 2012 at 11:11 PM, Eric Seidel e...@webkit.org wrote: Assuming I'm understanding Kalle correctly, it seems this could already be accomplished with @media resolution

Re: [webkit-dev] Debugging With Xcode

2012-04-24 Thread Eric Seidel
that we don't have to manually attach dbg)? - Ryosuke On Mon, Apr 23, 2012 at 7:07 PM, Jarred Nicholls jar...@webkit.org wrote: On Apr 23, 2012, at 9:03 PM, Eric Seidel e...@webkit.org wrote: Does anyone still debug WebKit on Mac OS X with Xcode 4? 1.  I don't know how to actually

[webkit-dev] PSA: Commit-queue/Cr-Linux Delays expected until EOD

2012-04-23 Thread Eric Seidel
run-webkit-unittests was hung on the 2 cr-linux EWS machines: https://bugs.webkit.org/show_bug.cgi?id=84611 Causing a queue overflow: http://ews-watcher.kov.eti.br/ (big red line to the sky) The CQ was unaffected, but because most patches are fast-tracked (don't get re-tested if the cr-linux-ews

[webkit-dev] Debugging With Xcode

2012-04-23 Thread Eric Seidel
Does anyone still debug WebKit on Mac OS X with Xcode 4? 1. I don't know how to actually set up Xcode to point to WebKitBuild like it used to. http://www.webkit.org/building/debug.html Mentions a Legacy option which does not exist for me. Simon Fraser helped me set up WebKitBuild on one of my

Re: [webkit-dev] New feature: Implement command API in webkit

2012-04-19 Thread Eric Seidel
It appears no consensus was reached? The patch is still up for review: https://bugs.webkit.org/show_bug.cgi?id=72955 On Thu, Nov 24, 2011 at 11:34 AM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Nov 24, 2011 at 9:32 AM, Ian Hickson i...@hixie.ch wrote: On Thu, 24 Nov 2011, Ryosuke Niwa

Re: [webkit-dev] CMake for Apple's Windows port

2012-04-19 Thread Eric Seidel
We're discussing reducing the number of build-systems at the WebKit meeting tomorrow @ 10am. Interested parties should definitely be there. Especially ones who know something about CMake (since I know nothing). :) -eric On Thu, Apr 12, 2012 at 5:41 AM, Patrick Gansterer par...@paroga.com

Re: [webkit-dev] Reg.use of WTF_CHANGES in FastMalloc.cpp...

2012-04-12 Thread Eric Seidel
FastMalloc is a fork of tcmalloc: http://trac.webkit.org/browser/trunk/Source/WTF/wtf/FastMalloc.cpp#L37 http://goog-perftools.sourceforge.net/doc/tcmalloc.html from several years ago. On Thu, Apr 12, 2012 at 2:11 AM, Hajime Morrita morr...@chromium.org wrote: Hi, The code was brought from a

Re: [webkit-dev] EditBugs permission

2012-04-12 Thread Eric Seidel
Done. % webkit-patch add-users-to-groups shezbaig...@gmail.com Add users matching shezbaig...@gmail.com which groups? 1. canconfirm 2. editbugs Enter one or more numbers (comma-separated), or all: Reading Keychain for bugs.webkit.org account and password. Click Allow to continue... Logging in

[webkit-dev] trac.webkit.org seems down?

2012-04-11 Thread Eric Seidel
http://trac.webkit.org/ is failing to load for me. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] NPAPI plugin may be broken in mac latest sources?

2012-04-11 Thread Eric Seidel
The first step is to file a bug. Then we can CC the right people and triage your troubles. http://www.webkit.org/quality/reporting.html On Wed, Apr 11, 2012 at 3:02 PM, Rudi Sherry rshe...@adobe.com wrote: Yesterday I updated to the latest webkit sources for the mac (`Tools\Scripts

Re: [webkit-dev] builds pending on cr-linux bot

2012-04-09 Thread Eric Seidel
That builder just had a stuck build. I canceled the build, and things seem better. I believe I also fixed the bug which was hanging the commit-queue and chromium-linux EWS bots. Those should return to normal by morning (just in time for the rush!). -eric On Sun, Apr 8, 2012 at 10:56 PM, Eric

Re: [webkit-dev] builds pending on cr-linux bot

2012-04-08 Thread Eric Seidel
Unclear what's going on with that builder. The CommitQueue also seems unhappy. Will poke around (I don't have access to the build bots, but I can look at the EWS/CQ.) On Sun, Apr 8, 2012 at 8:02 PM, Sravan sra1sand...@gmail.com wrote: Hi, I've submitted a patch almost 2 days ago, and i've

[webkit-dev] Feature Announcement: Adding iframe seamless

2012-03-30 Thread Eric Seidel
Per http://www.webkit.org/coding/adding-features.html I'm working on adding iframe seamless support to WebKit. http://www.whatwg.org/specs/web-apps/current-work/#dom-iframe-seamless Folks interested can follow along at home: https://bugs.webkit.org/show_bug.cgi?id=45950 It's currently

Re: [webkit-dev] PSA: Bit fields won't be packed on Windows if you mix types

2012-03-29 Thread Eric Seidel
For core classes like these we should COMPILE_ASSERT their size. We do this for many, but not all of these classes. On Thu, Mar 29, 2012 at 1:21 AM, Ryosuke Niwa rn...@webkit.org wrote: Hi, Unlike gcc and clang, MSVC pads each consecutive member variables of the same type in bitfields. e.g.

Re: [webkit-dev] Hosting the webkitgtk.org site on svn.webkit.org

2012-03-27 Thread Eric Seidel
I don't think moving the page to svn.webkit.org will help. It will cause the elite cabre to need svn.webkit.org commit access to do their work. Given how little work is done on www.webkit.org it seems unlikely the move will cause more maintenance to be done on webkitgtk.org. I guess if it were

Re: [webkit-dev] Documentation for WTF/JSC exports?

2012-03-22 Thread Eric Seidel
I think that might have worked. :) Thanks. On Thu, Mar 22, 2012 at 12:36 AM, Hajime Morrita morr...@chromium.org wrote: On Thu, Mar 22, 2012 at 10:38 AM, Eric Seidel e...@webkit.org wrote: Thank you.  Mark Rowe was kind enough to resolve https://bugs.webkit.org/show_bug.cgi?id=81838#c8

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012-03-22 Thread Eric Seidel
Going ahead with the land now. Will be around for several hours fixing builds. I'm sorry for any breaks. -eric On Wed, Mar 21, 2012 at 7:08 PM, Eric Seidel e...@webkit.org wrote: I've posted my first-draft patch to: https://bugs.webkit.org/show_bug.cgi?id=81844 If port maintainers would

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012-03-22 Thread Eric Seidel
their help with their respective platforms! If I can be of further help, let me know. -eric On Thu, Mar 22, 2012 at 3:50 PM, Eric Seidel e...@webkit.org wrote: Going ahead with the land now. Will be around for several hours fixing builds.  I'm sorry for any breaks. -eric On Wed, Mar 21

[webkit-dev] Documentation for WTF/JSC exports?

2012-03-21 Thread Eric Seidel
Do we have any documentation for how the current symbol export system for WTF/JSC is supposed to work? I'm hitting errors when trying to move WTF files to their own libwtf.a, such as: https://bugs.webkit.org/show_bug.cgi?id=81838 and http://pastebin.com/dVjV8UiR But looking at

Re: [webkit-dev] Documentation for WTF/JSC exports?

2012-03-21 Thread Eric Seidel
pieces. -- morrita On Thu, Mar 22, 2012 at 9:49 AM, Eric Seidel e...@webkit.org wrote: Do we have any documentation for how the current symbol export system for WTF/JSC is supposed to work? I'm hitting errors when trying to move WTF files to their own libwtf.a, such as: https

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012-03-21 Thread Eric Seidel
the buildbots after the fact. We should be very close, with all the header work which has been done over the last month. -eric On Tue, Mar 20, 2012 at 5:18 PM, Eric Seidel e...@webkit.org wrote: We're ready to complete the move. https://bugs.webkit.org/show_bug.cgi?id=80911 should land later this evening

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012-03-20 Thread Eric Seidel
will also update svn-apply so that in-flight patches should transparently patch the right files post-move. Let me know if you have questions or concerns. -eric On Tue, Feb 28, 2012 at 3:53 PM, Eric Seidel e...@webkit.org wrote: I'm going to push off the move, probably until next week. Thank you

[webkit-dev] Is the New XMLParser dead?

2012-03-15 Thread Eric Seidel
It seems the New XML Parser hasn't been touched in about 8 months: http://trac.webkit.org/browser/trunk/Source/WebCore/xml/parser Are there any plans to continue work on such, or can it be removed? The refactoring which was done to support it seems to mostly just confuse the HTML 5 Parser

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-08 Thread Eric Seidel
help with this bug[1]?) [1] https://bugs.webkit.org/show_bug.cgi?id=79509 -Ash From: Simon Fraser simon.fra...@apple.com To: Eric Seidel e...@webkit.org Cc: WebKit Development webkit-dev@lists.webkit.org Sent: Thursday, March 8, 2012 3:37 AM Subject: Re

Re: [webkit-dev] New Qt-WK2 EWS

2012-03-07 Thread Eric Seidel
I would strongly encourage other ports (at least those who like not having their build break all the time) to see up EWSes. We recently added a wiki on the topic: http://trac.webkit.org/wiki/EWS Post-commit testing (buildbots) is great. But it's much better if patch authors can know they might

Re: [webkit-dev] FYI: ForwardingHeaders/wtf is dead

2012-03-07 Thread Eric Seidel
The patch landed, buildbots look green. Let me know if there is any fallout I missed. Extra thanks to Mark Rowe for all his help with this! -eric On Tue, Mar 6, 2012 at 8:18 PM, Eric Seidel e...@webkit.org wrote: In preparation for moving the WTF code out of JavaScriptCore, support

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-07 Thread Eric Seidel
Unless this is enforced by a tool, it's very likely to be forgotten. https://bugs.webkit.org/show_bug.cgi?id=75824 https://bugs.webkit.org/show_bug.cgi?id=75825 On Wed, Mar 7, 2012 at 3:21 PM, Dan Bernstein m...@apple.com wrote: Please set the svn:mime-type property on binary files that you

[webkit-dev] FYI: ForwardingHeaders/wtf is dead

2012-03-06 Thread Eric Seidel
In preparation for moving the WTF code out of JavaScriptCore, support for including WTF headers as JavaScriptCore.framework private headers will shortly be removed: #include JavaScriptCore/Unicode.h // No longer possible #include wtf/unicode/Unicode.h // The proper way. Similarly: #include

Re: [webkit-dev] error while build webkit for gtk on mac lion

2012-03-05 Thread Eric Seidel
I'm told webkit-help is a better place to ask build questions. Also, there are IRC channels which may be of help: http://webkitgtk.org/?page=contact On Mon, Mar 5, 2012 at 12:27 AM, Victor LI rtj...@hotmail.com wrote: I get the code from trunk or webkit.org, and compile for gtk port, and it

Re: [webkit-dev] Error while building on Mac SL 10.6.6

2012-03-02 Thread Eric Seidel
Building from snapshots is not supported. I recommend you follow the instructions here: http://www.webkit.org/building/checkout.html http://www.webkit.org/building/build.html Best of luck. Lots of helpful people in #webkit if you get stuck. http://www.webkit.org/contact.html On Fri, Mar 2,

Re: [webkit-dev] Error while building on Mac SL 10.6.6

2012-03-02 Thread Eric Seidel
Am I wrong? Feel encouraged to correct me. I don't validate the snapshots to make sure they build. But perhaps you do. -eric On Fri, Mar 2, 2012 at 3:48 PM, Mark Rowe mr...@apple.com wrote: On 2012-03-02, at 15:45, Eric Seidel e...@webkit.org wrote: Building from snapshots

Re: [webkit-dev] Error while building on Mac SL 10.6.6

2012-03-02 Thread Eric Seidel
My apologies, Vivek. Of course I'm wrong! :) I recommend you follow up with Mark for how to get your snapshot to build. -eric On Fri, Mar 2, 2012 at 3:58 PM, Mark Rowe mr...@apple.com wrote: On 2012-03-02, at 15:53, Eric Seidel e...@webkit.org wrote: Am I wrong?  Feel encouraged to correct

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012-02-28 Thread Eric Seidel
the new date for landing these patches. I would be happier with a more CET timezone friendly timing. - 08:00-00:00 in CET. br, Ossy Eric Seidel írta: We've been talking about moving WTF out of JavaScriptCore for a long time.  We believe we're nearly there. https://bugs.webkit.org

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012-02-28 Thread Eric Seidel
somewhat tangential to the goal of moving WTF out of JavaScriptCore. - Mark Eric Seidel írta: We've been talking about moving WTF out of JavaScriptCore for a long time.  We believe we're nearly there. https://bugs.webkit.org/show_bug.cgi?id=75673 This will mean that WTF will be built

Re: [webkit-dev] CSS properties vs. their JS bindings on the style object

2012-02-28 Thread Eric Seidel
It would have to be WebKit-only content, correct? On Tue, Feb 28, 2012 at 5:04 PM, Simon Fraser simon.fra...@apple.comwrote: On Feb 28, 2012, at 5:00 PM, Tom Zakrajsek wrote: While investigating https://bugs.webkit.org/show_bug.cgi?id=77427, Dave and I have been trekking through the bindings

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012-02-28 Thread Eric Seidel
I'm fine with Source/wtf. Very easy to implement. On Tue, Feb 28, 2012 at 4:59 PM, Geoffrey Garen gga...@apple.com wrote: My current plan is to have a WTF/wtf directory to avoid this exact issue. :) WTF/wtf makes the think, WTF? -- which is a fun mental onomatopoeia, but probably not a

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012-02-27 Thread Eric Seidel
break a couple bots, but I'll be watching the bots and will pick up any pieces. Let me know if you have issues with this specific timeframe, and thanks again for all your help. -eric On Tue, Jan 10, 2012 at 10:35 AM, Eric Seidel e...@webkit.org wrote: If a Qt person wants to make this move even

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012-02-27 Thread Eric Seidel
to ensure that it doesn't break Apple's internal builds. It would be great if you could post a patch ahead of time so that we have some time to test and prepare for the changes on our side. Thanks, - Mark On 2012-02-27, at 15:27, Eric Seidel e...@webkit.org wrote: Thank you, particularly

Re: [webkit-dev] webkit

2012-02-25 Thread Eric Seidel
Please ban this spammer. On Sat, Feb 25, 2012 at 1:27 PM, Tyler Cumberton tylercw...@gmail.com wrote: I have a question : webkit site -- -Tyler. ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Removing obsolete File attributes

2012-02-24 Thread Eric Seidel
My 2¢: - I'm glad to see these properties go. - I think Darin is correct to be concerned about a potential web-compat risk. (But, I suspect grepping extensions for .fileSize and .fileName might actually turn up useful data. Assuming that's easy to do?) - I agree with ap that warnings are mostly

Re: [webkit-dev] Is the style bot OK?

2012-02-14 Thread Eric Seidel
It does seem wedged. However it will reset itself every 20 patches or so: http://trac.webkit.org/browser/trunk/Tools/EWSTools/start-queue.sh On Tue, Feb 14, 2012 at 8:44 AM, Raphael Kubo da Costa k...@profusion.mobi wrote: I've been trying to send a patch to bug 78600 for a few hours, but the

Re: [webkit-dev] When should we turn on new features?

2012-02-13 Thread Eric Seidel
Related to this is the question of what ports are even on for various ports. I don't believe it's possible today to list what features are on for what ports. At least not without a lot of emailing... Before designing a finer-granularity on/off switch, it seems it might make sense to have a

Re: [webkit-dev] Snow Leopard WebKit2 tester bot

2012-02-02 Thread Eric Seidel
I filed https://bugs.webkit.org/show_bug.cgi?id=3761 a while back. I'm not sure why it hasn't been addressed yet. :p But I did fix your bug just now. :) -eric On Thu, Feb 2, 2012 at 11:46 AM, Simon Fraser simon.fra...@apple.com wrote: I filed https://bugs.webkit.org/show_bug.cgi?id=75145 a

Re: [webkit-dev] Mac and Chromium Mac EWS

2012-01-25 Thread Eric Seidel
It's also possible that the NRWT don't peg the machine heuristics are failing for the EWS bots. You'd have to SSH in to know. But if you see it running too many DRT processes (or too many associated Python processes) we can change the heuristic:

Re: [webkit-dev] Mac EWS is dead :(

2012-01-12 Thread Eric Seidel
cr-jail-8 should have been offline long ago. I'm not sure how it survived my nuke-from-orbit. I'll see about nuking it again. -eric On Thu, Jan 12, 2012 at 1:13 PM, Lucas Forschler lforsch...@apple.com wrote: apple-mac-1/2 are back online.  cr-jail-8 needs a clean build, can someone in

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012-01-10 Thread Eric Seidel
10, 2012 at 7:07 AM, Alexis Menard alexis.men...@openbossa.org wrote: On Mon, Jan 9, 2012 at 8:36 PM, Eric Seidel e...@webkit.org wrote: We've been talking about moving WTF out of JavaScriptCore for a long time.  We believe we're nearly there. https://bugs.webkit.org/show_bug.cgi?id=75673

[webkit-dev] Moving WTF out of JavaScriptCore

2012-01-09 Thread Eric Seidel
We've been talking about moving WTF out of JavaScriptCore for a long time. We believe we're nearly there. https://bugs.webkit.org/show_bug.cgi?id=75673 This will mean that WTF will be built as a separate static library on all ports. The plan is to do this move all in one piece, after work hours

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-01-08 Thread Eric Seidel
Seems like something our tools should do automatically for you. Humans are inevitably going to get this wrong. https://bugs.webkit.org/show_bug.cgi?id=75824 https://bugs.webkit.org/show_bug.cgi?id=75825 On Sun, Jan 8, 2012 at 6:44 PM, Benjamin Poulain benja...@webkit.org wrote: On Sun, Jan 8,

[webkit-dev] Seeking Reproductions

2012-01-03 Thread Eric Seidel
We've had several reports of hitting an ASSERT I added back in November (relating to plugin creation): https://bugs.webkit.org/show_bug.cgi?id=50312 Unfortunately, none of them reproduce for me. They're likely all caused by certain flash ads on those pages (which are certainly changed by now).

Re: [webkit-dev] Can anyone help to add EditBugs privilege for my account?

2011-12-28 Thread Eric Seidel
./Tools/Scripts/webkit-patch add-users-to-groups rgbbo...@gmail.com                                      [/Stuff/Projects/WebKitSVN]Add users matching rgbbo...@gmail.com which groups? 1. canconfirm 2. editbugsEnter one or more numbers (comma-separated), or all: Reading Keychain for

Re: [webkit-dev] js-test-(pre|post).js in http tests

2011-12-19 Thread Eric Seidel
Yes we certainly have many useless/broken tests in the repository. Alexey is correct, that it's difficult to tell when a test is useless however. :) -eric On Mon, Dec 19, 2011 at 6:16 PM, Benjamin Poulain benja...@webkit.org wrote: 2011/12/19 Alexey Proskuryakov a...@webkit.org: Generally

Re: [webkit-dev] What's the difference RefPtr and OwnPtr?

2011-12-13 Thread Eric Seidel
OwnPtr holds a pointer and calls delete on that pointer when it goes out of scope. Just like RefPtr, you can .release() the pointer from an OwnPtr, into a PassRefPtr. PassOwnPtr functions similarly to an OwnPtr (in that it will delete its pointer when it goes out of scope) except when you assign a

Re: [webkit-dev] Removing support for the RVCT compiler

2011-12-10 Thread Eric Seidel
I'm curious what the practical implications of this are? Are there 500 #ifdefs for RVCT or 5? If it doesn't have a build bot, I'm sure it is broken anyway, and can just be removed regardless. :) -eric On Sat, Dec 10, 2011 at 7:24 PM, Benjamin Poulain benja...@webkit.org wrote: On Sat, Dec 10,

Re: [webkit-dev] run-webkit-tests is moving to parallell testing by default (this weekend)

2011-12-05 Thread Eric Seidel
/disable. Let me know if you see any troubles. -eric On Fri, Dec 2, 2011 at 3:55 PM, Eric Seidel e...@webkit.org wrote: run-webkit-tests is moving to parallell testing by default (this weekend) I just moved Mac this afternoon.  The SnowLeopard bot went from a 1 hr 4 min (!?!) cycle time, to 38

Re: [webkit-dev] run-webkit-tests is moving to parallell testing by default (this weekend)

2011-12-05 Thread Eric Seidel
I should have said all platforms. run-webkit-tests will use parallel testing on all platforms (except Qt), not just on the buildbot machines. -eric On Mon, Dec 5, 2011 at 1:24 AM, Eric Seidel e...@webkit.org wrote: All bots (except Qt) are now transitioned to using parallel testing

Re: [webkit-dev] WebKit branch to support multiple VMs (e.g., Dart)

2011-12-05 Thread Eric Seidel
Could you post a complete patch of your multi-vm changes to a WebKit bug? I final chromium's diff viewer very difficult to use. Regardless of whether this is good for the web or not, some of your multi-vm changes may be nice to have in WebCore. -eric On Mon, Dec 5, 2011 at 11:48 AM, Geoffrey

[webkit-dev] run-webkit-tests is moving to parallell testing by default (this weekend)

2011-12-02 Thread Eric Seidel
run-webkit-tests is moving to parallell testing by default (this weekend) I just moved Mac this afternoon. The SnowLeopard bot went from a 1 hr 4 min (!?!) cycle time, to 38 min (still !?!). http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Tests%29/builds/3317

Re: [webkit-dev] run-webkit-tests is moving to parallell testing by default (this weekend)

2011-12-02 Thread Eric Seidel
On Fri, Dec 2, 2011 at 6:44 PM, Dirk Pranke dpra...@chromium.org wrote: some of those tests are taking 10 minutes or more to complete ... there's clearly one or more bugs here keeping NRWT from timing out DRT properly. Some are almost certainly in NRWT, but I wonder if there are things in the

Re: [webkit-dev] failed to upload a patch to bugs.webkit.org by webkit-patch!

2011-11-28 Thread Eric Seidel
I suspect your account does not have edit-bugs permission. webkit-patch does not warn you very well in that case, but should. Please file a bug at bugs.webkit.org. On Mon, Nov 28, 2011 at 7:13 AM, Hongbo Min hongbo@gmail.com wrote: I try to upload a patch to bugs.webkit.org but without

Re: [webkit-dev] WML build error

2011-11-21 Thread Eric Seidel
I'm sorry. webkit-dev can't help you with anything other than the latest revisions of WebKit. Best of luck. -eric On Sun, Nov 20, 2011 at 11:41 PM, Nataraj Bukkambudi natarajb...@gmail.com wrote: Dear Eric Seidel, Yes WML Code removed from Webcore trunk from r85256, but  we are using

Re: [webkit-dev] CORS Access-Control-Expose-Headers not supported by webkit?

2011-11-21 Thread Eric Seidel
This is where you would look: http://trac.webkit.org/browser/trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp You might also find these documents useful: http://www.webkit.org/coding/contributing.html http://www.webkit.org/quality/reporting.html

Re: [webkit-dev] WML build error

2011-11-20 Thread Eric Seidel
WML has been removed. https://bugs.webkit.org/show_bug.cgi?id=59678 On Sun, Nov 20, 2011 at 11:17 PM, Nataraj Bukkambudi natarajb...@gmail.com wrote: Hi All, I Enabled the WML Flag in r84325 Webkit version in \WebKitLibraries\win\tools\vsprops\FeatureDefines, but it's giving error like

Re: [webkit-dev] Cleaning up directories in WebCore

2011-11-18 Thread Eric Seidel
SGTM. manual-tests is a no-brainer for sure. On Fri, Nov 18, 2011 at 1:51 AM, Adam Barth aba...@webkit.org wrote: I've been looking for ways to improve the hackability of WebCore, and one thing that's been bothering me is the organization of our files. It seems like we're due for a bit of

Re: [webkit-dev] Removing Support for Python 2.5

2011-11-17 Thread Eric Seidel
I would like to move forward with this change. Any further objections? On Fri, Nov 4, 2011 at 3:20 PM, Eric Seidel e...@webkit.org wrote: Now that Apple has removed the Leopard build bot (and presumably stopped supporting WebKit on Leopard), all webkit platforms I know of have Python 2.6

Re: [webkit-dev] Removing Support for Python 2.5

2011-11-17 Thread Eric Seidel
Other bot steps in Chromium depend on webkitpy? I'm tempted to just make the change and see what breaks. We can always roll it out if things are really bad. I'll prepare an updated patch. -eric On Thu, Nov 17, 2011 at 4:37 PM, Tony Chang t...@chromium.org wrote: Only new-run-webkit-tests

Re: [webkit-dev] Tools/Scripts/webkit-patch rebaseline-expectations does not launch html comparison page?

2011-11-08 Thread Eric Seidel
I believe that tool just got nuked. Seems the Wiki page should as well: https://bugs.webkit.org/show_bug.cgi?id=71833 On Tue, Nov 8, 2011 at 9:09 AM, Adam Barth aba...@webkit.org wrote: On Tue, Nov 8, 2011 at 7:06 AM, Elliot Poger epo...@chromium.org wrote: I have just run 

Re: [webkit-dev] The Purpose of Core Builders

2011-11-08 Thread Eric Seidel
The Core Builders are a failed experiment (for which I am guilty). They were intended as a set of builders which when green would allow the CommitQueue to commit. This was long before the CommitQueue knew how to commit when the bots were red (like real humans do). I know of no set of builders @

Re: [webkit-dev] The Purpose of Core Builders

2011-11-08 Thread Eric Seidel
On Tue, Nov 8, 2011 at 7:38 PM, Eric Seidel e...@webkit.org wrote: The Core Builders are a failed experiment (for which I am guilty). They were intended as a set of builders which when green would allow the CommitQueue to commit.  This was long before the CommitQueue knew how to commit when

Re: [webkit-dev] new-run-webkit-tests --gtk fails with AttributeError: GtkDriver instance has no attribute '_server_process'

2011-11-07 Thread Eric Seidel
Please file a bug at bugs.webkit.org and I will happily fix it. -eric On Mon, Nov 7, 2011 at 3:54 PM, Vanya Yani van...@gmail.com wrote: I'm trying to run NRWT for gtk build revision 99472. But script fails with exceptions: AttributeError: GtkDriver instance has no attribute '_server_process'

Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-11-06 Thread Eric Seidel
in NRWT. Cheers, Abhishek On Thu, Oct 27, 2011 at 3:40 PM, Eric Seidel e...@webkit.org wrote: Yes, thank you Ryosuke: https://bugs.webkit.org/show_bug.cgi?id=68931 If you have any other issues, I would love to know about them. -eric On Thu, Oct 27, 2011 at 3:18 PM, David Hyatt hy

Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-11-06 Thread Eric Seidel
Thank you. I have a patch, I expect to re-land it this week. On Fri, Oct 28, 2011 at 5:57 AM, Antti Koivisto koivi...@iki.fi wrote: On Fri, Oct 28, 2011 at 1:00 AM, Eric Seidel e...@webkit.org wrote: If you're still using old-run-webkit-tests for your work, I would *love* to know and fix any

Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-11-06 Thread Eric Seidel
I've filed --32-bit support as https://bugs.webkit.org/show_bug.cgi?id=71634, per your request. On Mon, Oct 31, 2011 at 10:22 AM, Gavin Barraclough barraclo...@apple.com wrote: On Oct 27, 2011, at 3:00 PM, Eric Seidel wrote: If you're still using old-run-webkit-tests for your work, I would

[webkit-dev] Removing Support for Python 2.5

2011-11-04 Thread Eric Seidel
Now that Apple has removed the Leopard build bot (and presumably stopped supporting WebKit on Leopard), all webkit platforms I know of have Python 2.6 or higher. My plan is to remove all of our 2.5 supporting code in the next week, requiring Python 2.6 or later for WebKit. Let me know if this

Re: [webkit-dev] Removing Support for Python 2.5

2011-11-04 Thread Eric Seidel
, no? On Fri, Nov 4, 2011 at 3:23 PM, Nico Weber tha...@chromium.org wrote: The chromium port still has a bot that runs tests (but doesn't build) on 10.5. Nico On Fri, Nov 4, 2011 at 3:20 PM, Eric Seidel e...@webkit.org wrote: Now that Apple has removed the Leopard build bot

Re: [webkit-dev] Removing Support for Python 2.5

2011-11-04 Thread Eric Seidel
...@chromium.org wrote: I believe the chromium port always uses 2.6 though, no? On Fri, Nov 4, 2011 at 3:23 PM, Nico Weber tha...@chromium.org wrote: The chromium port still has a bot that runs tests (but doesn't build) on 10.5. Nico On Fri, Nov 4, 2011 at 3:20 PM, Eric Seidel e

Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-10-28 Thread Eric Seidel
Please file these as bugs so they get tracked, fixed and not forgotten. :) On Fri, Oct 28, 2011 at 2:57 AM, Nikolas Zimmermann zimmerm...@physik.rwth-aachen.de wrote: Am 28.10.2011 um 00:40 schrieb Eric Seidel: Yes, thank you Ryosuke: https://bugs.webkit.org/show_bug.cgi?id=68931 If you

Re: [webkit-dev] Subpixel Layout Update

2011-10-28 Thread Eric Seidel
Most interesting is to see the branch diff. Is that possible from the web? Could you tell me what the magic svn command is if it's not possible? Thanks! On Fri, Oct 28, 2011 at 1:43 PM, Levi Weintraub le...@chromium.org wrote: WebKittens, As you may know, Emil and I have been diligently

Re: [webkit-dev] Subpixel Layout Update

2011-10-28 Thread Eric Seidel
://bugs.webkit.org/show_bug.cgi?id=71143 -Levi On Fri, Oct 28, 2011 at 2:38 PM, Eric Seidel e...@webkit.org wrote: Do you have a master bug we can CC ourselves on to follow along at home? I've attached the diff, btw. On Fri, Oct 28, 2011 at 1:54 PM, Emil A Eklund e...@chromium.org wrote: On Fri, Oct 28

[webkit-dev] old-run-webkit-tests is officially deprecated.

2011-10-27 Thread Eric Seidel
As of this afternoon, the Apple-Win bot is the only remaining buildbot (to my knowledge) using old-run-webkit-tests (https://bugs.webkit.org/show_bug.cgi?id=38756). Unfortunately, that's not likely to change soon. But all other platforms (and all other developers) besides Apple-Win should be

Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-10-27 Thread Eric Seidel
instead of platform-specific directories been fixed? That was the showstopper for me. dave (hy...@apple.com) On Oct 27, 2011, at 5:00 PM, Eric Seidel wrote: As of this afternoon, the Apple-Win bot is the only remaining buildbot (to my knowledge) using old-run-webkit-tests (https

Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-10-27 Thread Eric Seidel
in NRWT. Cheers, Abhishek On Thu, Oct 27, 2011 at 3:40 PM, Eric Seidel e...@webkit.org wrote: Yes, thank you Ryosuke: https://bugs.webkit.org/show_bug.cgi?id=68931 If you have any other issues, I would love to know about them. -eric On Thu, Oct 27, 2011 at 3:18 PM, David Hyatt hy

Re: [webkit-dev] Mobile Safari Source Code

2011-10-23 Thread Eric Seidel
None of the Safari browsers (Mobile included) are open-source. Chromium (chromium.org) is open source, if that helps you. -eric On Sun, Oct 23, 2011 at 7:36 AM, 道雄野口 mnopq...@gmail.com wrote: Hi I am looking for a source code of mobile safari.(iOS Safari) I want to see address bar and

<    1   2   3   4   5   6   7   8   9   >