+1 on not introducing new pixel tests and allowing someone other than the
test author to create the -expected file.
We may also be able to streamline some of this process by implementing
some helper scripts. Ultimately, someone will still have to review new
files manually, but scripts should be a
many cases this may not be too hard.
On the other hand, having the test author create the ref file is definitely
preferable. What would we do in the case where a test author is no longer
available?
From: Ryosuke Niwa mailto:rn...@webkit.org>>
Date: Wed, 11 Apr 2012 16:00:44 -070
Isn't the goal of writing a ref test that it is not platform specific?
From: Ryosuke Niwa mailto:rn...@webkit.org>>
Date: Thu, 12 Apr 2012 12:29:42 -0700
To: Ojan Vafai mailto:o...@chromium.org>>
Cc: Dirk Pranke mailto:dpra...@chromium.org>>, WebKit
Development mailto:webkit-dev@lists.webkit.org>
to:rn...@webkit.org>>
Date: Thu, 12 Apr 2012 13:43:26 -0700
To: Jacob Goldstein mailto:jac...@adobe.com>>
Cc: Ojan Vafai mailto:o...@chromium.org>>, Dirk Pranke
mailto:dpra...@chromium.org>>, WebKit Development
mailto:webkit-dev@lists.webkit.org>>
Subject: Re: [webkit-de
At the recent WebKit Contributors Meeting, a process was drafted for importing
third party tests into WebKit.
I created a wiki page that captures the process that we came up with here:
http://trac.webkit.org/wiki/ImportingThirdPartyTests
We'd like to get more input from the community on all asp
At the WebKit contributor's meeting in April, we discussed a process for
importing third party tests into the WebKit repository (specifically, from the
W3C test repository).
I documented the process that we came up with at the meeting on the WebKit
wiki, here:
http://trac.webkit.org/wiki/Import
I agree. If nothing else, getting W3C tests into the WebKit repository will
help catch regressions.
From: Ryosuke Niwa mailto:rn...@webkit.org>>
To: Jacob Goldstein mailto:jac...@adobe.com>>
Cc: WebKit Development
mailto:webkit-dev@lists.webkit.org>>
Subject: Re: [webkit-
Dirk, my apologies, I was on travel the week you replied and missed your
message. I found it and will review / update now.
On 5/23/12 1:25 PM, "Dirk Pranke" wrote:
>On Wed, May 23, 2012 at 11:56 AM, Ryosuke Niwa wrote:
>> As I have said in the past, we should just import all tests, and treat
On 5/23/12 2:30 PM, "Maciej Stachowiak" wrote:
>
>On May 23, 2012, at 2:16 PM, Dirk Pranke wrote:
>
>> On Wed, May 23, 2012 at 1:41 PM, Ryosuke Niwa wrote:
> The only sane argument I've heard so far to gate pixel tests is that
>the
> correctness of such tests need to be manually i
I added the following Wiki page to provide some information on testharness.js
(the JavaScript framework from W3C recently landed in WebKit):
http://trac.webkit.org/wiki/Writing%20testharness%20Tests
I also updated the text under "Writing JavaScript-based DOM only test cases" on
this page
http:/
On 5/31/12 11:56 AM, "Darin Adler" wrote:
>I am thinking we should rename layoutTestController to testController. Or
>if you don¹t like that name, maybe testHarness or some even better name.
testHarness is probably not a good choice as the W3C JavaScript framework
that recently landed in WebK
than yours. Peter Linss, who wrote
and maintains the W3C testharness, would likely be open to suggestions for
improvement if there is anything specific that we want to change.
From: Maciej Stachowiak mailto:m...@apple.com>>
To: Jacob Goldstein mailto:jac...@adobe.com>>
Cc:
Actually, I misspoke, it's not Peter Linss who maintains testharness, it's
James Graham.
From: Jacob Goldstein mailto:jac...@adobe.com>>
To: Maciej Stachowiak mailto:m...@apple.com>>
Cc: WebKit Development
mailto:webkit-dev@lists.webkit.org>>
Subject: Re: [webki
On Thu, May 31, 2012 at 11:18 AM, Jacob Goldstein
mailto:jac...@adobe.com>> wrote:
I added the following Wiki page to provide some information on testharness.js
(the JavaScript framework from W3C recently landed in WebKit):
http://trac.webkit.org/wiki/Writing%20testharness%20Tests
On 5/31/12 7:55 PM, "Maciej Stachowiak" mailto:m...@apple.com>>
wrote:
On May 31, 2012, at 5:51 PM, Jacob Goldstein
mailto:jac...@adobe.com>> wrote:
I haven't found that to be the case for the tests I have written for each
suite, the output from testharness ca
test(function() {assert_equals(oAnchor.getAttribute('href'), value, "Optional
debug info.")}, description);
On 6/1/12 2:40 PM, "Jacob Goldstein"
mailto:jac...@adobe.com>> wrote:
On 5/31/12 7:55 PM, "Maciej Stachowiak" mailto:m...@apple.com>>
On 6/11/12 11:11 AM, "Alexis Menard" wrote:
>On Mon, Jun 11, 2012 at 3:09 PM, Simon Fraser
>wrote:
>> I think imported tests should be outside of LayoutTests/fast.
>
>I agree a dedicated folder seems more appropriate.
>
>My two cents.
>
>>
>> Simon
>>
>> On Jun 11, 2012, at 1:57 AM, Ryosuke Niwa
On 6/11/12 2:24 PM, "Ryosuke Niwa" mailto:rn...@webkit.org>>
wrote:
On Mon, Jun 11, 2012 at 2:21 PM, Jacob Goldstein
mailto:jac...@adobe.com>> wrote:
Can we just create an imported-w3c folder at the same level as LayoutTests?
You mean at trunk? I don't think that m
On 6/11/12 2:37 PM, "Ryosuke Niwa" mailto:rn...@webkit.org>>
wrote:
On Mon, Jun 11, 2012 at 2:33 PM, Dirk Pranke
mailto:dpra...@chromium.org>> wrote:
Technically, it does (at least NRWT does), but I wouldn't recommend
it. NRWT is designed to allow tests to live in multiple repos, but it
seems li
Has any tried to build WebKit on Mountain Lion?
I just attempted with a new install of Mountain Lion and Xcode 4.4 and the
build keeps failing while trying to compile AlternativeTextUIController. If
anyone has thoughts as to why this could be, please let me know.
___
On 7/25/12 2:21 PM, "Mark Rowe" wrote:
>
>On 2012-07-25, at 14:15, Jacob Goldstein wrote:
>
>> Has any tried to build WebKit on Mountain Lion?
>>
>> I just attempted with a new install of Mountain Lion and Xcode 4.4 and
>>the
I recently uploaded a patch to https://bugs.webkit.org/show_bug.cgi?id=80709
which converted an existing JavaScript regions parsing test to use the W3C
testharness.js in place of js-test-pre.js/js-test-post.js. This patch also
places testharness.js and a WebKit-specific testharnessreport.js fil
to:rn...@webkit.org>>
Date: Fri, 9 Mar 2012 14:37:18 -0800
To: Jacob Goldstein mailto:jac...@adobe.com>>
Cc: "webkit-dev@lists.webkit.org<mailto:webkit-dev@lists.webkit.org>"
mailto:webkit-dev@lists.webkit.org>>
Subject: Re: [webkit-dev] Test conversion to use W3C test
subtests pass or fail from a text
>dump.
>
>Adam
>
>
>On Fri, Mar 9, 2012 at 3:19 PM, Jacob Goldstein wrote:
>> LayoutTests/resources is fine with me that was the location I
>>considered
>> using originally and only moved them to LayoutTests/fast/js/resourc
we use some CSS tricks like :before to put the word PASS at the
>beginning of the line for each subtest?
>
>Adam
>
>
>On Fri, Mar 9, 2012 at 3:51 PM, Jacob Goldstein wrote:
>> I replied to your comment in the bug, but will also copy below
>> -
>>
>> I
e it ran together with the next couple words.
> Having spaces between the words would address my concern.
>
> Thanks!
> Adam
>
>
> 2012/3/9 Jacob Goldstein :
>> Is your concern that the Pass is not in all caps?
>>
>> The current output looks like this:
>
26 matches
Mail list logo
