Hi,
just sharing a few words from hyatt on IRC:
May 17 00:07:00 dhyattyeah your analysis is right
May 17 00:08:34 dhyattthat RenderLayer comment is about dragging
the map in google maps
May 17 00:08:41 dhyattso that would be the thing to test to make
sure it doesn't break
Hi,
As part of my (spare-time) effort to keep developing the Spatial
Navigation [1], I've been getting great reviewing support from Simon
Fraser and Kenneth Christiansen, but lately the number of pending
review patches increased a bit. There are on my plate patches from
polishment work to real
- preparation for feature implementation:
* bug 37803 - Spatial Navigation: adapt the logic of
{deep}findFocusableNodeInDirection to do traversal starting from Node*
not Document*
For this one I even added a comment in the bug with a detailed
explaination about the changes [2], so a reviewer
Hi.
While working on bug 16809 (Clicking a scrollbar blurs the currently
focused element), a couple of questions raised about the current
behavior of mouse clicks on scrollbars.
On ports that do *not* use platform/native widgets for rendering
scrollbars (including Qt, Windows, Chromium):
1)
Hi,
Eventually, I'd like to make --squash the default, but I want this to bake
and get some usage before flipping that switch.
But I don't think this makes sense as a default to me. But maybe I use git
differently than everyone else… I don't do the whole branch-per-bug
business.
I
I agree with the fact that it should not rely on currentTime() as it
currently does. It is probably the root of bugs like
https://bugs.webkit.org/show_bug.cgi?id=31550 and many others.
On Fri, Apr 16, 2010 at 11:50 AM, Yong Li yong.li.web...@gmail.com wrote:
Hi All
The default implementation
clean up needed!
http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Debug/builds/4614/steps/compile-webkit/logs/stdio
(...)
DerivedSources/JSSVGZoomEvent.lo DerivedSources/JSWebSocket.lo
/bin/mkdir -p ./.deps/DerivedSources
ranlib: .libs/libWebCoreJS.a: No space left on device
make[1]: ***
Hi
It sounds like a bug. Please file one in bugs.webkit.org , preferable
with test case and detailed steps to reproduce, specifying also which
port and platform are you running.
2010/3/23 巴丁-Partin xyts...@gmail.com:
Is that anyone working with WML in webkit?
I use webkit to open the wml page,
Hey all.
I am facing a strange issue while trying to the get repaintable rect
of a given Node* object. In my code I am doing something like:
(...)
ASSERT(node);
node-renderer()-absoluteClippedOverflowRect();
(...)
, where node is a valid reference to an a in the following simple
html sample in
Hi Simon.
That was my thought. Thank you for confirming.
On Tue, Mar 23, 2010 at 2:54 PM, Simon Fraser simon.fra...@apple.com wrote:
On Mar 23, 2010, at 11:38 AM, tonikitoo (Antonio Gomes) wrote:
Hey all.
I am facing a strange issue while trying to the get repaintable rect
of a given Node
Hey, these 42 missing results files on Qt are there for a while, indeed.
I am also trying Kenneth and Ossy w/ the crashy Qt bot, by looking at
fast/media/print-restores-previous-mediatype.html
On Fri, Mar 19, 2010 at 3:41 PM, Xan Lopez x...@gnome.org wrote:
On Fri, Mar 19, 2010 at 9:59 PM, Eric
See this: https://bugs.webkit.org/show_bug.cgi?id=36193
On Thu, Mar 18, 2010 at 1:25 PM, Jens Alfke s...@chromium.org wrote:
This morning, whenever I try to pull from webkit's git repo I get the
following scary error:
remote: error: failed to unpack compressed delta at offset 167772124 from
Adam, qt 4.5 support in WebKit trunk is about to be dropped ((or even
already dropped).
See comment from Benjamin Poulain (from Nokia):
Webkit trunk only support the current version of Qt, and the one in
development.
So, currently we only support Qt 4.6, and the branch of Qt 4.7.
There has been
Hi,
I think the commit bot should change the patch title after landing it,
mentioning the changeset. For example:
- patch title before landing:
proposed fix
- same patch landed by the commit bot, but w/ title referring to the changeset:
commited in changeset X: proposed fix.
It could make
Hi,
The Spatial Navigation feature consists in the ability to navigate
between focusable elements, such as hyperlinks and form controls,
within a structured document or user interface according to the
spatial location. [1]. It is currently implemented in some desktop
browsers including newer
Hi.
Q) Why doesn't the EWS post a success message? I like positive
re-enforcement.
A) I'm worried about spamming bugs with too many happy status
messages. If we have N ports with EWS bots, we don't want to have N
happy status messages. Eric and I have some ideas for a more passive
that to two or even on submit to
bugzilla ? e.g. merge _1_ and _3_ maybe ...
On Tue, Jan 5, 2010 at 3:51 PM, Maciej Stachowiak m...@apple.com wrote:
On Jan 5, 2010, at 10:21 AM, Adam Barth wrote:
On Tue, Jan 5, 2010 at 9:42 AM, tonikitoo (Antonio Gomes)
toniki...@gmail.com wrote:
Q) Why
It was agreed on IRC that having DRTs able to handle error pages in
not a bad thing, but good since it brings DRT closer to a real
browsers behavior. Hence, I moved on here and implemented it for QT's
DRT (see https://bugs.webkit.org/show_bug.cgi?id=31509#c0).
Currently the single test depending
Thanks for replying, Darin. Comments below ...
WebKit itself does not have error pages. This is a feature of specific
browsers: Recent versions of Safari do this, although earlier versions used
sheets and alerts instead.
I agree that supporting error pages is a browser-specific feature.
The
Hi,
As I replied in the bug, i totally agree about patch needing a test,
and more generically that Test Coverage is something to be improved
(not to get worse).
Talking in my own defense, (again) i knew patch was not yet ready to
get in (no tests) but since I do not have a MAC box handy and then
Adam, something else that imho must be considered ( while refactoring
the state machine ) is adding a load type that specifically does not
touch session and global history, and avoid abusing some of the
existent load types like below:
abuse
// FIXME: This seems like a dangerous overloading of
wrote:
There's a notion of lockHistory in FrameLoader. Is that related to
what you mean? I haven't studied load type yet.
Adam
On Tue, Oct 13, 2009 at 8:22 AM, tonikitoo (Antonio Gomes)
toniki...@gmail.com wrote:
Adam, something else that imho must be considered ( while refactoring
I've just noticed a strange behaviour in WebCore's IconDatabase class.
In the Qt port code we provide a method for client applications to enable
and open WebCore's icon database for its use. It is done by calling the
following code:
(...)
void QWebSettings::setIconDatabasePath(const QString
I went through the queue tonight and manually marked the bugs as
commit-ready by adding [commit+] to their titles. This worked well,
except that it made the bug titles ugly. I think a better solution is
to have flag analogous to r+ which is commit+.
Adam, as I suggedted previously, bugzilla
Zoltan, I think it would be a great add from a embedder-dev point of view.
Particularly, such leaks have been faced here in a soon past, when we
were loading a webkit browser as a plugin, and not as an application
by itself. So, we the webkit plugin was unloaded, it used to left
behind lots of
If the font size is not specified in the HTML page, what is the default one
used by webkit?
Haithem, (although i might be wrong) I believe different ports have
different default font sizes. Qt is 14, for example. iirc, windows is
18 ...
--
--Antonio Gomes
Bug filed: https://bugs.webkit.org/show_bug.cgi?id=27444
On Fri, Jul 17, 2009 at 4:04 PM, tonikitoo (Antonio
Gomes)toniki...@gmail.com wrote:
Answering myself, that could explain things :
@FrameLoader.h
(...)
// Document loaders for the three phases of frame loading.
Note that while
you could have a look at WebKit/your working
port/WebCoreSupport/EditorClientXXX.cpp :
void EditorClientXXX::setInputMethodState(bool active)
{
... code could come here ...
}
On Sat, Jul 18, 2009 at 7:10 AM, Nikolas
Zimmermannzimmerm...@physik.rwth-aachen.de wrote:
Am 18.07.2009 um 13:02
Hi. So I ran into this while developing a feature to qt webkit, but it
is possibly not a port specific issue, but webcore.
1) If i load an existent local page (through FrameLoader::load) that
redirects (e.g. file:///test1.html redirects to file:///test2.html) ,
i get
Hi,
honorEditableBoundaryAtOrAfter does check whether the visPos is null or not,
and if it's null, then it returns the original visible position, so it's
harmless (i.e. does not crash or has a side-effect). But I'm not sure what
the caller of logicalStartOfLine is expecting; maybe we're
I grew up listing and seeing people not writing their emails *as it*
and publishing on the internet
so would replacing m...@apple.com by mjs at apple dot com be a
good practice ?
it reduces the spam count in your inbox for sure.
On Thu, Jul 9, 2009 at 2:11 PM, Maciej Stachowiakm...@apple.com
Hi,
trying to understand this part of the webcore code, I faced a possibly
wrong impl:
(...)
VisiblePosition logicalStartOfLine(const VisiblePosition c)
{
VisiblePosition visPos = logicalStartPositionForLine(c);
if (visPos.isNull())
return
Guys, I would like your opinion about the following feature request add
in WebKit's bugzilla.
Now, for every bug filed there is a default assignee (
webkit-unassig...@lists.webkit.org). In order to make possible for
developers to follow bug activities of a specific component. My proposal is
the
we
easily do this ?
br
On Mon, Jul 6, 2009 at 2:05 PM, William Siegrist wsiegr...@apple.comwrote:
On Jul 6, 2009, at 12:59 PM, tonikitoo (Antonio Gomes) wrote:
Guys, I would like your opinion about the following feature request add
in WebKit's bugzilla.
Now, for every bug filed
David, as far as I could understand your situation, you are not
implementing a new Port of WebKit, so no support to a new toolkit or
something. If that is the case, the existing platform you are using
probably has layout tests already implemented. They are useful for
regression tests mainly,
you have probably an old version on libsoup-dev.
ago...@tonix:~$ grep -nHR soup_message_headers_get_content_type /usr/include/
/usr/include/libsoup-2.4/libsoup/soup-message-headers.h:114:const char
*soup_message_headers_get_content_type (SoupMessageHeaders *hdrs,
ago...@tonix:~$ dpkg -l |
As addition resources, look at
http://webkit.org/quality/testwriting.html and
http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree
to get into this deeper
Br
On Thu, Jun 25, 2009 at 11:04 PM, Oliver Huntoli...@apple.com wrote:
Hi Dave,
On Jun 25, 2009, at 7:54 PM, David
You can find default implementation in WebCore, yes:
void EventHandler::defaultKeyboardEventHandler(KeyboardEvent* event)
{
if (event-type() == eventNames().keydownEvent) {
m_frame-editor()-handleKeyboardEvent(event);
if (event-defaultHandled())
return;
if
A possible solution (adopted by Mozilla) is the use of
checkin-needed keyword. So:
1) In case of a patch with r+ and a commiter is assignee, all
requested modifications can be needed before landing
2) when a patch has r+ and a non-commiter is assignee, it needs an
updated patch (that can carry
deuxliquid, assuming that you have already a sandboxed toolchain set
to cross compile webkit to your MIPS platform, your question can be
considered quite vague ... please , inform in more details port you
would like to build, compiler version, chroot you are using ...
2009/6/14 deuxliquid
TianShijun,
QtWebKit (as well as Gtk and possibly others port) uses XEmbed to get
plugins (e.g. Flash) running. XEmbed is a X protocol to embed X window
onto others (containers). That said, when you try dumping flash by
the way you pasted below, you are not even touching the plugin
painting
On Mon, Jun 1, 2009 at 1:31 PM, Simon Frasersimon.fra...@apple.com wrote:
There is a method on RenderObject to get the correct absolute coordinates of
the renderer, which correctly takes transforms, scrolling etc into account:
RenderObject::localToAbsolute(). This is not a trivial problem.
I am seeing it too. Firefox 3.5preb4 renders its top bar all fine,
fwiw. see http://farm4.static.flickr.com/3638/3560998719_d26d476d73.jpg?v=0
have you tried w/ other webkit ports ? it can be not qt-specific (?)
br
2009/5/24 TianShijun tians...@hotmail.com:
Hi All,
I cannot open the
The last step depends on the architecture (supported or not) and C++
compiler directives. If JIT is enabled (see wtf/Platform.h), it always
generates machine code. Otherwise an interpreter executes the byte code. A
mixed environment (both jit and interpreter) is not yet supported.
Are there
Hi,
That is something reproducible by every one who builds libcurl as
network backend in a non-debug build, and really has to be fixed. Code
looks like this:
(...) WebCore/platform/network/curl/ResourceHandleManager.cpp
#ifndef NDEBUG
char* url = 0;
It sounds like we can be misusing the base_url parameter. could you
paste how you are calling the method (parameters and so) and a snippet
of the local html file.
On Wed, May 13, 2009 at 6:58 AM, Zhe Su james...@gmail.com wrote:
Hi,
When I call webkit_web_view_load_html_string() to load a
Another way to go could depending on the port you are using. if it
exposes DOM APIs (like qt does in trunk), for example, it is a matter
of DOM: get element by its id, traverse its param child nodes, and
get the name parameter value...
On Tue, May 12, 2009 at 8:56 PM, naixuan guan
47 matches
Mail list logo
