Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-10 Thread Alexis Menard
Le 10 déc. 2012 09:24, "Alexis Menard" a écrit : > > On Tue, Dec 4, 2012 at 8:36 AM, Alexis Menard wrote: > > On Mon, Dec 3, 2012 at 5:59 PM, Dirk Schulze wrote: > >> > >> On Dec 3, 2012, at 12:07 PM, Benjamin Poulain wrote: > >> > >>> On Mon, Dec 3, 2012 at 11:11 AM, Dirk Schulze wrote: > >>>

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-10 Thread Alexis Menard
On Tue, Dec 4, 2012 at 8:36 AM, Alexis Menard wrote: > On Mon, Dec 3, 2012 at 5:59 PM, Dirk Schulze wrote: >> >> On Dec 3, 2012, at 12:07 PM, Benjamin Poulain wrote: >> >>> On Mon, Dec 3, 2012 at 11:11 AM, Dirk Schulze wrote: >>> Why does this feature have a flag at all? background-position wit

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-04 Thread Alexis Menard
On Mon, Dec 3, 2012 at 5:59 PM, Dirk Schulze wrote: > > On Dec 3, 2012, at 12:07 PM, Benjamin Poulain wrote: > >> On Mon, Dec 3, 2012 at 11:11 AM, Dirk Schulze wrote: >> Why does this feature have a flag at all? background-position with up to 4 >> arguments is specified with CSS3 background and

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Julien Chaffraix
>> On Mon, Dec 3, 2012 at 12:59 PM, Dirk Schulze wrote: >> Depends on the future. But for such a small patch, a new flag seems to be >> overdone. I looked into the patch, and adding the flag caused more code, >> then the actual feature (even if the computed style is missing). I believe >> we sh

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Dirk Schulze
On Dec 3, 2012, at 2:54 PM, Alexis Menard wrote: > > On Dec 3, 2012 6:21 PM, "Dirk Schulze" wrote: > > > > > > On Dec 3, 2012, at 1:15 PM, Benjamin Poulain wrote: > > > > > On Mon, Dec 3, 2012 at 12:59 PM, Dirk Schulze wrote: > > > Depends on the future. But for such a small patch, a new fla

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Alexis Menard
On Dec 3, 2012 6:21 PM, "Dirk Schulze" wrote: > > > On Dec 3, 2012, at 1:15 PM, Benjamin Poulain wrote: > > > On Mon, Dec 3, 2012 at 12:59 PM, Dirk Schulze wrote: > > Depends on the future. But for such a small patch, a new flag seems to be overdone. I looked into the patch, and adding the flag

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Dirk Schulze
On Dec 3, 2012, at 1:15 PM, Benjamin Poulain wrote: > On Mon, Dec 3, 2012 at 12:59 PM, Dirk Schulze wrote: > Depends on the future. But for such a small patch, a new flag seems to be > overdone. I looked into the patch, and adding the flag caused more code, then > the actual feature (even if

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Benjamin Poulain
On Mon, Dec 3, 2012 at 12:59 PM, Dirk Schulze wrote: > Depends on the future. But for such a small patch, a new flag seems to be > overdone. I looked into the patch, and adding the flag caused more code, > then the actual feature (even if the computed style is missing). I believe > we should remo

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Dirk Schulze
On Dec 3, 2012, at 12:07 PM, Benjamin Poulain wrote: > On Mon, Dec 3, 2012 at 11:11 AM, Dirk Schulze wrote: > Why does this feature have a flag at all? background-position with up to 4 > arguments is specified with CSS3 background and borders. There are three > major implementations with this

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Benjamin Poulain
On Mon, Dec 3, 2012 at 11:11 AM, Dirk Schulze wrote: > > Why does this feature have a flag at all? background-position with up to 4 > arguments is specified with CSS3 background and borders. There are three > major implementations with this feature. So we are just catching up. If the > future work

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Dirk Schulze
On Dec 3, 2012, at 8:43 AM, Simon Fraser wrote: > On Dec 3, 2012, at 4:51 AM, Alexis Menard wrote: > >> I plan to enable it by default on Qt and EFL ports this week. If >> somebody wants me to enable it on their ports please tell me, I'll be >> happy to do it. > > I think it's preferable to en

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Simon Fraser
On Dec 3, 2012, at 4:51 AM, Alexis Menard wrote: > I plan to enable it by default on Qt and EFL ports this week. If > somebody wants me to enable it on their ports please tell me, I'll be > happy to do it. I think it's preferable to enable for all ports if you think it's ready. In general, featu

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Alexis Menard
On Mon, Dec 3, 2012 at 12:08 PM, Dirk Schulze wrote: > > On Dec 3, 2012, at 6:12 AM, "Alexis Menard" wrote: > >> On Mon, Dec 3, 2012 at 10:42 AM, Dirk Schulze wrote: >>> >>> On Dec 3, 2012, at 5:31 AM, Alexis Menard wrote: >>> On Mon, Dec 3, 2012 at 10:19 AM, Dirk Schulze wrote: > >>>

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Dirk Schulze
On Dec 3, 2012, at 6:12 AM, "Alexis Menard" wrote: > On Mon, Dec 3, 2012 at 10:42 AM, Dirk Schulze wrote: >> >> On Dec 3, 2012, at 5:31 AM, Alexis Menard wrote: >> >>> On Mon, Dec 3, 2012 at 10:19 AM, Dirk Schulze wrote: On Dec 3, 2012, at 4:51 AM, Alexis Menard wrote: >>>

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Alexis Menard
On Mon, Dec 3, 2012 at 10:42 AM, Dirk Schulze wrote: > > On Dec 3, 2012, at 5:31 AM, Alexis Menard wrote: > >> On Mon, Dec 3, 2012 at 10:19 AM, Dirk Schulze wrote: >>> >>> On Dec 3, 2012, at 4:51 AM, Alexis Menard wrote: >>> Hi everyone, I wanted to let you know that I have added

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Dirk Schulze
On Dec 3, 2012, at 5:31 AM, Alexis Menard wrote: > On Mon, Dec 3, 2012 at 10:19 AM, Dirk Schulze wrote: >> >> On Dec 3, 2012, at 4:51 AM, Alexis Menard wrote: >> >>> Hi everyone, >>> >>> I wanted to let you know that I have added the new CSS3 >>> background-position offsets support to WebKi

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Alexis Menard
On Mon, Dec 3, 2012 at 10:19 AM, Dirk Schulze wrote: > > On Dec 3, 2012, at 4:51 AM, Alexis Menard wrote: > >> Hi everyone, >> >> I wanted to let you know that I have added the new CSS3 >> background-position offsets support to WebKit. >> >> This support is behind the ENABLE_CSS3_BACKGROUND featu

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Dirk Schulze
On Dec 3, 2012, at 4:51 AM, Alexis Menard wrote: > Hi everyone, > > I wanted to let you know that I have added the new CSS3 > background-position offsets support to WebKit. > > This support is behind the ENABLE_CSS3_BACKGROUND feature define and > it's disabled by default on all ports. I took

[webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Alexis Menard
Hi everyone, I wanted to let you know that I have added the new CSS3 background-position offsets support to WebKit. This support is behind the ENABLE_CSS3_BACKGROUND feature define and it's disabled by default on all ports. I took the conservative approach despite it's a cool feature. Long story