Re: [webkit-dev] Changes to the WebKit2 development process

2013-01-29 Thread Osztrogonác Csaba
Hi, Carlos Garcia Campos írta: El mar, 29-01-2013 a las 09:39 +0100, Balazs Kelemen escribió: IMHO, recently, contributors as well as WK2 owners are a bit suffering from it. I think we can go to a better direction: making all developers happy as well as resolving WK2 owners' concerns. I thin

Re: [webkit-dev] Changes to the WebKit2 development process

2013-01-29 Thread Carlos Garcia Campos
El mar, 29-01-2013 a las 09:39 +0100, Balazs Kelemen escribió: > > > > IMHO, recently, contributors as well as WK2 owners are a bit suffering > > from it. I think we can go to a better direction: making all > > developers happy as well as resolving WK2 owners' concerns. > > > > I think the strai

Re: [webkit-dev] Changes to the WebKit2 development process

2013-01-29 Thread Balazs Kelemen
IMHO, recently, contributors as well as WK2 owners are a bit suffering from it. I think we can go to a better direction: making all developers happy as well as resolving WK2 owners' concerns. I think the straightforward way to achieve this is to let somebody be an owner from every port.

Re: [webkit-dev] Changes to the WebKit2 development process

2013-01-28 Thread Dongsung Huang
2013/1/10 Sam Weinig > At this point, we ask that all completely non-trivial patches be reviewed > by an owner, even if in port specific code. > > - Sam Hi Sam and webkit developers. I really appreciate WK2 owners' effort to improve all port specific code as well as WK2 code. However, recently

Re: [webkit-dev] Changes to the WebKit2 development process

2013-01-09 Thread Antonio Gomes
Hi Sam. Some comments below. Cheers, --Antonio >> Curious about this myself, I just reviewed a patch only affecting the >> GTK-specific parts of WebKit2, I believe that is OK? Should we ammend >> the Owners file to include information about port-specific directories >> and reviewers? >> >> Cheer

Re: [webkit-dev] Changes to the WebKit2 development process

2013-01-09 Thread Sam Weinig
On Jan 9, 2013, at 8:10 AM, Gustavo Noronha Silva wrote: > On Qua, 2013-01-09 at 12:04 +0200, Thiago Marcos P. Santos wrote: >>> I think the fact that the regular WebKit review process stops at the >>> boundary >>> of WebKit2 should be documented in the WebKit Committers and Reviewer >>> Polic

Re: [webkit-dev] Changes to the WebKit2 development process

2013-01-09 Thread Sam Weinig
Trivial changes like this do not need to be approved by an owner. -Sam On Jan 9, 2013, at 9:38 AM, Gregg Tavares wrote: > I've got a patch in flight that adds a feature flag. > https://bugs.webkit.org/show_bug.cgi?id=106275 > > According to the instructions liked below I need to edit a WebKit

Re: [webkit-dev] Changes to the WebKit2 development process

2013-01-09 Thread Gregg Tavares
I've got a patch in flight that adds a feature flag. https://bugs.webkit.org/show_bug.cgi?id=106275 According to the instructions liked below I need to edit a WebKit2 file http://trac.webkit.org/wiki/AddingFeatures#ActivatingafeatureforAutotoolsbasedports Does that guideline change? Should I remo

Re: [webkit-dev] Changes to the WebKit2 development process

2013-01-09 Thread Gustavo Noronha Silva
On Qua, 2013-01-09 at 12:04 +0200, Thiago Marcos P. Santos wrote: > > I think the fact that the regular WebKit review process stops at the > > boundary > > of WebKit2 should be documented in the WebKit Committers and Reviewer > > Policy. > > > > Agree. And please clarify on the policy if we are

Re: [webkit-dev] Changes to the WebKit2 development process

2013-01-09 Thread Jesus Sanchez-Palencia
Hi, 2013/1/8 Sam Weinig : > Hello webkit-dev, > > We are making some changes to the development process for WebKit2. These > changes were announced to reviewers in advance, and I'd like to share them > with you now. > > WebKit2 has a core set of functionality that is valuable to all ports, and

Re: [webkit-dev] Changes to the WebKit2 development process

2013-01-09 Thread Thiago Marcos P. Santos
On Wed, Jan 9, 2013 at 11:32 AM, Simon Hausmann wrote: > On Tuesday, January 08, 2013 02:57:53 PM Sam Weinig wrote: >> Hello webkit-dev, >> >> We are making some changes to the development process for WebKit2. These >> changes were announced to reviewers in advance, and I'd like to share them >> w

Re: [webkit-dev] Changes to the WebKit2 development process

2013-01-09 Thread Simon Hausmann
On Tuesday, January 08, 2013 02:57:53 PM Sam Weinig wrote: > Hello webkit-dev, > > We are making some changes to the development process for WebKit2. These > changes were announced to reviewers in advance, and I'd like to share them > with you now. > > WebKit2 has a core set of functionality that

Re: [webkit-dev] Changes to the WebKit2 development process

2013-01-08 Thread Dirk Schulze
On Jan 8, 2013, at 2:57 PM, Sam Weinig wrote: > Hello webkit-dev, > > We are making some changes to the development process for WebKit2. These > changes were announced to reviewers in advance, and I'd like to share them > with you now. > > WebKit2 has a core set of functionality that is valu

[webkit-dev] Changes to the WebKit2 development process

2013-01-08 Thread Sam Weinig
Hello webkit-dev, We are making some changes to the development process for WebKit2. These changes were announced to reviewers in advance, and I'd like to share them with you now. WebKit2 has a core set of functionality that is valuable to all ports, and then aspects that are only of limited/s