Re: [webkit-dev] Clarifying 3D feature defines

2015-04-24 Thread Simon Fraser
On Apr 24, 2015, at 9:14 PM, Martin Robinson wrote: > On Thu, Apr 23, 2015 at 4:48 PM, Simon Fraser wrote: >> USE(3D_GRAPHICS) appears to surround WebGL code in general. I don’t see any >> non-WebGL bits in a quick search. > > It seems that USE(3D_GRAPHICS) simply enables GraphicsContext3D and

Re: [webkit-dev] Clarifying 3D feature defines

2015-04-24 Thread Martin Robinson
On Thu, Apr 23, 2015 at 4:48 PM, Simon Fraser wrote: > USE(3D_GRAPHICS) appears to surround WebGL code in general. I don’t see any > non-WebGL bits in a quick search. It seems that USE(3D_GRAPHICS) simply enables GraphicsContext3D and its helper classes, so I propose that we rename this to ENABL

Re: [webkit-dev] Clarifying 3D feature defines

2015-04-23 Thread Martin Robinson
Thanks for bringing up the point about perspective versus 3D transforms. For the sake of clarity, one reason 3D_GRAPHICS may be different from WebGL is that GraphicsContext3D is used to render accelerated compositing contents when using the TextureMapper and not simply WebGL. --Martin On Thu, Apr

Re: [webkit-dev] Clarifying 3D feature defines

2015-04-23 Thread Simon Fraser
On Apr 23, 2015, at 4:39 PM, Martin Robinson wrote: > > In the process of cleaning up and dusting off the GTK+ cmake build > system, we have rediscovered the pair of somewhat confusing feature > defines WTF_USE_3D_GRAPHICS and ENABLE_3D_RENDERING. From a brief > audit, it appears that WTF_USE_3D_

[webkit-dev] Clarifying 3D feature defines

2015-04-23 Thread Martin Robinson
In the process of cleaning up and dusting off the GTK+ cmake build system, we have rediscovered the pair of somewhat confusing feature defines WTF_USE_3D_GRAPHICS and ENABLE_3D_RENDERING. From a brief audit, it appears that WTF_USE_3D_GRAPHICS is a generic flag for any kind of 3D rendering at all (