Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread Darin Fisher
On Mon, Jul 13, 2009 at 3:17 PM, David Hyatt wrote: > On Jul 13, 2009, at 5:02 PM, Darin Fisher wrote: > > This small interval rule-of-thumb idea sounds pretty good, but I still >> wish it didn't put the burden on the guy doing the branch to figure out what >> is or isn't incomplete about a part

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread David Hyatt
On Jul 13, 2009, at 5:17 PM, David Hyatt wrote: It's the organization shipping their product that should be working to determine when their product is shippable. This may in fact be the most incomprehensible sentence I have ever typed. :) dave (hy...@apple.com) ___

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread David Hyatt
On Jul 13, 2009, at 5:02 PM, Darin Fisher wrote: This small interval rule-of-thumb idea sounds pretty good, but I still wish it didn't put the burden on the guy doing the branch to figure out what is or isn't incomplete about a particular snapshot of WebKit. That guy might not be savy enou

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread Darin Fisher
On Mon, Jul 13, 2009 at 2:55 PM, Maciej Stachowiak wrote: > > On Jul 13, 2009, at 11:57 AM, David Hyatt wrote: > > On Jul 13, 2009, at 1:52 PM, Jeremy Orlow wrote: > > On Mon, Jul 13, 2009 at 11:40 AM, David Hyatt wrote: > >> On Jul 13, 2009, at 12:52 PM, Peter Kasting wrote: >> >> On Mon, Jul 1

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread Maciej Stachowiak
On Jul 13, 2009, at 11:57 AM, David Hyatt wrote: On Jul 13, 2009, at 1:52 PM, Jeremy Orlow wrote: On Mon, Jul 13, 2009 at 11:40 AM, David Hyatt wrote: On Jul 13, 2009, at 12:52 PM, Peter Kasting wrote: On Mon, Jul 13, 2009 at 10:47 AM, David Hyatt wrote: I agree. We should formalize t

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread Jeremy Orlow
On Mon, Jul 13, 2009 at 11:57 AM, David Hyatt wrote: > On Jul 13, 2009, at 1:52 PM, Jeremy Orlow wrote: > > On Mon, Jul 13, 2009 at 11:40 AM, David Hyatt wrote: > >> On Jul 13, 2009, at 12:52 PM, Peter Kasting wrote: >> >> On Mon, Jul 13, 2009 at 10:47 AM, David Hyatt wrote: >> >>> I agree. W

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread David Hyatt
On Jul 13, 2009, at 1:52 PM, Jeremy Orlow wrote: On Mon, Jul 13, 2009 at 11:40 AM, David Hyatt wrote: On Jul 13, 2009, at 12:52 PM, Peter Kasting wrote: On Mon, Jul 13, 2009 at 10:47 AM, David Hyatt wrote: I agree. We should formalize this as policy too in my opinion. Maybe something ti

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread Jeremy Orlow
On Mon, Jul 13, 2009 at 11:40 AM, David Hyatt wrote: > On Jul 13, 2009, at 12:52 PM, Peter Kasting wrote: > > On Mon, Jul 13, 2009 at 10:47 AM, David Hyatt wrote: > >> I agree. We should formalize this as policy too in my opinion. Maybe >> something time-based, e.g., if you have an implementat

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread David Hyatt
On Jul 13, 2009, at 12:52 PM, Peter Kasting wrote: On Mon, Jul 13, 2009 at 10:47 AM, David Hyatt wrote: I agree. We should formalize this as policy too in my opinion. Maybe something time-based, e.g., if you have an implementation of a new Web technology that is going to take > (1month?)

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread Peter Kasting
On Mon, Jul 13, 2009 at 10:47 AM, David Hyatt wrote: > I agree. We should formalize this as policy too in my opinion. Maybe > something time-based, e.g., if you have an implementation of a new Web > technology that is going to take > (1month?) to implement, then the feature > should be landed i

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread Michelangelo De Simone
2009/7/13 Peter Kasting : > When it relands I will see if I can figure out what the ENABLE flag should > cover and make sure it's covered.  I'm concerned about other things already > in the tree with "valid" in their name, e.g. "readonly attribute boolean > willValidate" -- not sure if these shoul

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread Michelangelo De Simone
2009/7/13 Darin Fisher : > I'd like to propose that we add an ENABLE_FORM_VALIDATION flag (or something > similarly named).  I'm writing this to webkit-dev because I want to make > sure that other new web platform features that may be in development get > similar treatment while they are still in

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread David Hyatt
I agree. We should formalize this as policy too in my opinion. Maybe something time-based, e.g., if you have an implementation of a new Web technology that is going to take > (1month?) to implement, then the feature should be landed inside ENABLE ifdefs (that can then be removed when the

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread Peter Kasting
On Mon, Jul 13, 2009 at 10:40 AM, Darin Fisher wrote: > I'd like to propose that we add an ENABLE_FORM_VALIDATION flag (or > something similarly named). I'm writing this to webkit-dev because I want > to make sure that other new web platform features that may be in development > get similar trea

[webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread Darin Fisher
I noticed that some new form validation code is landing (e.g., http://trac.webkit.org/changeset/45739). That change adds stubs for the ValidityState object. What I didn't see in that patch is any kind of ENABLE flag. I suspect there should be one since otherwise it becomes difficult for a web de