[webkit-dev] Feeling stuck on preparing next patches for CSSRegions/CSSExclusions

2011-06-17 Thread Mihnea-Vlad Ovidenie
Hello, Part of our efforts towards enabling CSSRegions/CSSExclusions support in WebKit, we have submitted 2 patches last week: [61726][CSSExclusions]Parse wrap shape property [61730][CSSRegions]Parse flow property In addition to these patches, we would like to prepare more patches. However, we

Re: [webkit-dev] Feeling stuck on preparing next patches for CSSRegions/CSSExclusions

2011-06-17 Thread Darin Adler
On Jun 17, 2011, at 1:58 AM, Mihnea-Vlad Ovidenie wrote: We have seen some patterns for handling properties and we are not sure which one to follow. It would be helpful if you were more specific here. What were the patterns you have seen? If you give a specific bug number or revision number

Re: [webkit-dev] Feeling stuck on preparing next patches for CSSRegions/CSSExclusions

2011-06-17 Thread Simon Fraser
I made some comments in the bugs. Simon On Jun 17, 2011, at 9:38 AM, Darin Adler wrote: On Jun 17, 2011, at 1:58 AM, Mihnea-Vlad Ovidenie wrote: We have seen some patterns for handling properties and we are not sure which one to follow. It would be helpful if you were more specific

Re: [webkit-dev] Feeling stuck on preparing next patches for CSSRegions/CSSExclusions

2011-06-17 Thread Eric Seidel
You should also feel welcome to land test suites which entirely/mostly fail, and then later land the code changes which make them pass. We used this method with great success for the HTML parser re-write. This can be useful in cases where your individual tests have larger coverage than any