Re: [webkit-dev] LayoutTestHelper

2012-05-03 Thread Dirk Pranke
On Thu, May 3, 2012 at 9:16 AM, Maciej Stachowiak wrote: > > On May 3, 2012, at 8:54 AM, Dirk Pranke wrote: > >> On Thu, May 3, 2012 at 7:35 AM, Maciej Stachowiak wrote: >>> >>> Better naming/documentation may help. But I think the root problem here was >>> that the Chromium Android LayoutTestHe

Re: [webkit-dev] LayoutTestHelper

2012-05-03 Thread Maciej Stachowiak
On May 3, 2012, at 8:54 AM, Dirk Pranke wrote: > On Thu, May 3, 2012 at 7:35 AM, Maciej Stachowiak wrote: >> >> Better naming/documentation may help. But I think the root problem here was >> that the Chromium Android LayoutTestHelper does not exist in the WebKit >> repository, as far as I can

Re: [webkit-dev] LayoutTestHelper

2012-05-03 Thread Dirk Pranke
On Thu, May 3, 2012 at 7:35 AM, Maciej Stachowiak wrote: > > Better naming/documentation may help. But I think the root problem here was > that the Chromium Android LayoutTestHelper does not exist in the WebKit > repository, as far as I can tell. So there was no reasonable way for anyone > to cons

Re: [webkit-dev] LayoutTestHelper

2012-05-03 Thread Maciej Stachowiak
Better naming/documentation may help. But I think the root problem here was that the Chromium Android LayoutTestHelper does not exist in the WebKit repository, as far as I can tell. So there was no reasonable way for anyone to consider it when making changes. All the LayoutTestHelpers that exi

Re: [webkit-dev] LayoutTestHelper

2012-05-03 Thread Ryosuke Niwa
Could you rename all these "helper" methods and programs to have more descriptive names? None of this may not have happened if we had more semantically precise program/method names. On Mon, Apr 30, 2012 at 12:33 PM, Dirk Pranke wrote: > On Sun, Apr 29, 2012 at 6:20 PM, Maciej Stachowiak wrote:

Re: [webkit-dev] LayoutTestHelper

2012-04-30 Thread Dirk Pranke
On Sun, Apr 29, 2012 at 6:20 PM, Maciej Stachowiak wrote: > > On Apr 29, 2012, at 5:49 PM, Maciej Stachowiak wrote: > >> >> Hi folks, >> >> new-run-webkit-tests seems to mess with the system color profile on Mac, >> even when not running pixel tests. Historically, I believe we did this only >>

Re: [webkit-dev] LayoutTestHelper

2012-04-29 Thread Maciej Stachowiak
On Apr 29, 2012, at 5:49 PM, Maciej Stachowiak wrote: > > Hi folks, > > new-run-webkit-tests seems to mess with the system color profile on Mac, even > when not running pixel tests. Historically, I believe we did this only when > running pixel tests. I noticed that this is because it launche

[webkit-dev] LayoutTestHelper

2012-04-29 Thread Maciej Stachowiak
Hi folks, new-run-webkit-tests seems to mess with the system color profile on Mac, even when not running pixel tests. Historically, I believe we did this only when running pixel tests. I noticed that this is because it launches the LayoutTestHelper tool unconditionally, and in addition to chan