Re: [webkit-dev] MD5 in WebCore

2010-04-21 Thread 鵜飼文敏
Thanks for suggestion. I'll add MD5 implementation in WTF, based on chrome's base/md5, which seems came from sqlite public domain code. I believe this would be a platform-independent implementation. -- ukai On Wed, Apr 21, 2010 at 04:58, Maciej Stachowiak wrote: > > On Apr 20, 2010, at 11:48

Re: [webkit-dev] MD5 in WebCore

2010-04-20 Thread Maciej Stachowiak
On Apr 20, 2010, at 12:45 PM, Jeremy Orlow wrote: Agreed. Can you give us a pointer to the email thread this decision was made on? Discussion was on the IETF hybi list (which is trying to standardize the WebSocket protocol). I encourage anyone in the WebKit community who is interested i

Re: [webkit-dev] MD5 in WebCore

2010-04-20 Thread Maciej Stachowiak
On Apr 20, 2010, at 11:48 AM, Michael Nordman wrote: In webcore, should we use the same impl on all platforms rather than use cryptdll on windows and md5.cc elsewhere? For chrome, I don't think we can have a dependency between WebKit/ WebKit/chromium and /src/base/, and 'base' depending on

Re: [webkit-dev] MD5 in WebCore

2010-04-20 Thread Jeremy Orlow
Agreed. Can you give us a pointer to the email thread this decision was made on? On Tue, Apr 20, 2010 at 12:12 PM, Alex Russell wrote: > Hate to ask a dumb question, but why MD5? Isn't it on its last legs as > a secure hash? New protocols should be avoiding it. > > On Tue, Apr 20, 2010 at 11:48

Re: [webkit-dev] MD5 in WebCore

2010-04-20 Thread Alex Russell
Hate to ask a dumb question, but why MD5? Isn't it on its last legs as a secure hash? New protocols should be avoiding it. On Tue, Apr 20, 2010 at 11:48 AM, Michael Nordman wrote: > In webcore, should we use the same impl on all platforms rather than use > cryptdll on windows and md5.cc elsewhere

Re: [webkit-dev] MD5 in WebCore

2010-04-20 Thread Michael Nordman
In webcore, should we use the same impl on all platforms rather than use cryptdll on windows and md5.cc elsewhere? For chrome, I don't think we can have a dependency between WebKit/WebKit/chromium and /src/base/, and 'base' depending on 'webkit' also doesn't work. How can we avoid replicating the

Re: [webkit-dev] MD5 in WebCore

2010-04-20 Thread Maciej Stachowiak
On Apr 20, 2010, at 3:32 AM, Fumitoshi Ukai (鵜飼文敏) wrote: I'm implementing new protocol of WebSocket ( http://www.whatwg.org/specs/web-socket-protocol/ ). Since it now requires MD5 in handshake, I wonder how I could add MD5 in WebCore. For now, there is no MD5 in WebCore. It is in WebKit

[webkit-dev] MD5 in WebCore

2010-04-20 Thread 鵜飼文敏
I'm implementing new protocol of WebSocket ( http://www.whatwg.org/specs/web-socket-protocol/ ). Since it now requires MD5 in handshake, I wonder how I could add MD5 in WebCore. For now, there is no MD5 in WebCore. It is in WebKitTools/DumpRenderTree to get message digest of image file. I'm thin