Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

EWS doesn't hate it anymore! Reviews welcome. I've been slowly integrating feedback as I've received it. -Filip > On Nov 4, 2016, at 11:52 AM, Filip Pizlo wrote: > > Haha, I'm fixing it! > > I could use a review of the time API even while I fix some broken corners in > WebCore and WK2. >

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

Haha, I'm fixing it! I could use a review of the time API even while I fix some broken corners in WebCore and WK2. -Filip > On Nov 4, 2016, at 11:31 AM, Brent Fulgham wrote: > > EWS Hates your patch! :-) > >> On Nov 4, 2016, at 10:01 AM, Filip Pizlo > > wrote: >> >

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

EWS Hates your patch! :-) > On Nov 4, 2016, at 10:01 AM, Filip Pizlo wrote: > > Hi everyone! > > That last time we talked about this, there seemed to be a lot of agreement > that we should go with the Seconds/MonotonicTime/WallTime approach. > > I have implemented it: https://bugs.webkit.org/

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

Hi everyone! That last time we talked about this, there seemed to be a lot of agreement that we should go with the Seconds/MonotonicTime/WallTime approach. I have implemented it: https://bugs.webkit.org/show_bug.cgi?id=152045 That patch just takes a subset of our time code - all of the stuff th

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

>> Can we go with “WallClock” and “MonotonicClock” instead of “WallTime” and >> “MonotonicTime"? Clock is a nice clear noun. Also, time is an illusion >> caused by parallax in the astral plane. > > I think time is the right term. "3pm" is a "time", not a "clock". Also 42 > seconds since monoton

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

I think the actual issue here was that std::chrono::duration can't represent infinite duration and some of our code has been hacking around that with std::chrono::duration::max(). Clock time + duration is not going to overflow if the duration is natural (a finite constant or produced by diffing tim

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

On May 23, 2016, at 11:16 AM, Geoffrey Garen wrote: >> 3 - There exists a solution - non-templated custom classes - that removes >> both classes of subtle bugs, without the template creep. > > Hard to argue with this. > > Can we go with “WallClock” and “MonotonicClock” instead of “WallTime”

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

> 3 - There exists a solution - non-templated custom classes - that removes > both classes of subtle bugs, without the template creep. Hard to argue with this. Can we go with “WallClock” and “MonotonicClock” instead of “WallTime” and “MonotonicTime"? Clock is a nice clear noun. Also, time is an

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

ts::infinity(); } > }; > > } > } > > Best regards, > Michal Debski > > --- Original Message ------- > Sender : Filip Pizlomailto:fpi...@apple.com>> > Date : May 23, 2016 02:41 (GMT+01:00) > Title : [webkit-dev] RFC: stop using std::chrono, go back to u

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

+1 to Michael’s point. Naming of variables holding seconds/milliseconds is all over the place. So, I would favor using Seconds/WallTime/MonotonicTime classes, since they will basically guarantee that the variable name and/or type will describe the units near use-sites and avoid ambiguity. Not t

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

On Mon, 2016-05-23 at 07:27 -0700, Filip Pizło wrote: > You guys are making a convincing case for > Seconds/WallTime/MonotonicTime! > > -Filip I will add: the convention "double means seconds" is very much not obvious. It's OK when we're careful to consistently use "seconds" in function and varia

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

You guys are making a convincing case for Seconds/WallTime/MonotonicTime! -Filip > On May 22, 2016, at 11:19 PM, Ryosuke Niwa wrote: > > I'm with Brady here. In WebCore, there are enough DOM and network > APIs that mix wall time and monotonically increasing time (e.g. there > has been proposal

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

at the changes > required to make this work are as simple as what you say. >> Oh and the infinity: >> >> >> >> namespace std { >> namespace chrono { >> >> template<> >> struct duration_values { >> static constexpr double min()

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

our? Also move operator is not canonical in WTF strictly speaking.   I just remember about ugly bugs in MediaTime arithmetics.   Best regards, Michal Debski   --- Original Message --- Sender : Filip Pizlo Date : May 23, 2016 07:32 (GMT+01:00) Title : Re: [webkit-dev] RFC: stop using

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

finity(); } > }; > > } > } > > Best regards, > Michal Debski > > > > --- Original Message --- > > Sender : Filip Pizlo > > Date : May 23, 2016 02:41 (GMT+01:00) > > Title : [webkit-dev] RFC: stop using std::chrono, go back to usin

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

I'm with Brady here. In WebCore, there are enough DOM and network APIs that mix wall time and monotonically increasing time (e.g. there has been proposals to use monodically increasing time in event.prototype.timeStamp even though various event related code relies on it being a wall clock time) th

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

- Sender : Filip Pizlo Date : May 23, 2016 02:41 (GMT+01:00) Title : [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time   Hi everyone! I’d like us to stop using std::chrono and go back to using doubles for time.  First I list the things that I think we wante

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

> On May 22, 2016, at 6:41 PM, Filip Pizlo wrote: > > Hi everyone! > > I’d like us to stop using std::chrono and go back to using doubles for time. > First I list the things that I think we wanted to get from std::chrono - the > reasons why we started switching to it in the first place. The

[webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

Hi everyone! I’d like us to stop using std::chrono and go back to using doubles for time. First I list the things that I think we wanted to get from std::chrono - the reasons why we started switching to it in the first place. Then I list some disadvantages of std::chrono that we've seen from