Re: [webkit-dev] Supporting w3c ref tests and changing our convention

2011-11-14 Thread Darin Adler
On Nov 11, 2011, at 4:24 AM, Tor Arne Vestbø wrote: On 07.11.11 15:44, Alan Stearns wrote: What if we defer some of the W3C metadata work until tests were actually submitted to the W3C? 1. Tests we pull from W3C can run from manifests, since they are provided. 2. Tests we develop

Re: [webkit-dev] Supporting w3c ref tests and changing our convention

2011-11-14 Thread Ryosuke Niwa
On Mon, Nov 14, 2011 at 11:41 AM, Darin Adler da...@apple.com wrote: We may find we can automate (3) with a script. It sounds pretty mechanical. It appears that W3C mandates author name, etc... be included in the meta data as well but I guess we can add something like WebKit Community or

Re: [webkit-dev] Supporting w3c ref tests and changing our convention

2011-11-14 Thread Alan Stearns
On 11/14/11 12:07 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Nov 14, 2011 at 11:41 AM, Darin Adler da...@apple.com wrote: We may find we can automate (3) with a script. It sounds pretty mechanical. It appears that W3C mandates author name, etc... be included in the meta data as well

Re: [webkit-dev] Supporting w3c ref tests and changing our convention

2011-11-07 Thread Alan Stearns
On 11/4/11 7:20 PM, Ojan Vafai o...@chromium.org wrote: On Fri, Nov 4, 2011 at 7:16 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Nov 4, 2011 at 7:07 PM, Ojan Vafai o...@chromium.org wrote: On Fri, Nov 4, 2011 at 7:03 PM, Ryosuke Niwa rn...@webkit.org wrote: I am, but I'm particularly

Re: [webkit-dev] Supporting w3c ref tests and changing our convention

2011-11-07 Thread Ryosuke Niwa
It appears that we're not reaching any consensus here, and I don't feel like continuing any more bikeshedding. If anyone's interested, my patch for https://bugs.webkit.org/show_bug.cgi?id=66837 and Hayato's patch for https://bugs.webkit.org/show_bug.cgi?id=71567 add a basic support for W3C style

[webkit-dev] Supporting w3c ref tests and changing our convention

2011-11-04 Thread Ryosuke Niwa
Hi, There was a discussion about supporting W3C ref tests at TPAC yesterday. However, there appears to be some disagreement in how we support them. *Overview* CSS WG ref tests contain link elements that specify reference files. e.g. !DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0 Strict//EN

Re: [webkit-dev] Supporting w3c ref tests and changing our convention

2011-11-04 Thread Hayato Ito
Could you clarify why we have to need to modify DRT if we have Link Element approach? I guess one of the reasons is the performance. It might be better that we use DRT to parse and extract reference links from HTML since parsing HTML using Python might take unacceptable time and might be

Re: [webkit-dev] Supporting w3c ref tests and changing our convention

2011-11-04 Thread Ryosuke Niwa
On Fri, Nov 4, 2011 at 1:32 PM, Hayato Ito hay...@chromium.org wrote: Could you clarify why we have to need to modify DRT if we have Link Element approach? I guess one of the reasons is the performance. It might be better that we use DRT to parse and extract reference links from HTML since

Re: [webkit-dev] Supporting w3c ref tests and changing our convention

2011-11-04 Thread Dirk Pranke
On Fri, Nov 4, 2011 at 1:32 PM, Hayato Ito hay...@chromium.org wrote: Could you clarify why we have to need to modify DRT if we have Link Element approach? I guess one of the reasons is the performance. It might be better that we use DRT to parse and extract reference links from HTML since

Re: [webkit-dev] Supporting w3c ref tests and changing our convention

2011-11-04 Thread Hayato Ito
If we import a bunch of w3c reftests in the future, it sounds reasonable and unavoidable to use manifest file, assuming the manifest file is auto-generated by w3c's build process. But I'd like to leave an option to developers to write reftests more casually without worrying about maintaing the

Re: [webkit-dev] Supporting w3c ref tests and changing our convention

2011-11-04 Thread Ryosuke Niwa
On Fri, Nov 4, 2011 at 1:47 PM, Dirk Pranke dpra...@chromium.org wrote: It's unclear how much of a perf impact there would be but that's easy enough to determine - I would expect it to be minimal compared to the time of actually rendering a page. Since I expect w3c to end up having hundreds

Re: [webkit-dev] Supporting w3c ref tests and changing our convention

2011-11-04 Thread Ryan Leavengood
On Fri, Nov 4, 2011 at 4:47 PM, Dirk Pranke dpra...@chromium.org wrote: Separately, if we are throwing around numbers in the range of 100K for tests to run, we should consider when we actually want to run them - i.e., what will the cycle time be if we run them on every change, etc.? But that

Re: [webkit-dev] Supporting w3c ref tests and changing our convention

2011-11-04 Thread Ojan Vafai
I don't see any need for manifest files. Needing to maintain information about a test somewhere other than in the test itself or in the expected result file is a significant maintenance burden. We should avoid it if we can. On Fri, Nov 4, 2011 at 2:00 PM, Ryosuke Niwa rn...@webkit.org wrote: On

Re: [webkit-dev] Supporting w3c ref tests and changing our convention

2011-11-04 Thread Ryosuke Niwa
On Fri, Nov 4, 2011 at 4:01 PM, Ojan Vafai o...@chromium.org wrote: I don't see any need for manifest files. W3C's build step auto-generates them. On Fri, Nov 4, 2011 at 2:00 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Nov 4, 2011 at 1:47 PM, Dirk Pranke dpra...@chromium.org wrote:

Re: [webkit-dev] Supporting w3c ref tests and changing our convention

2011-11-04 Thread Ryosuke Niwa
On Fri, Nov 4, 2011 at 6:31 PM, Ojan Vafai o...@chromium.org wrote: On Fri, Nov 4, 2011 at 5:52 PM, Ryosuke Niwa rn...@webkit.org wrote: W3C's build step auto-generates them. I thought you were arguing that we should use manifest files for all reftests because having multiple ways to do

Re: [webkit-dev] Supporting w3c ref tests and changing our convention

2011-11-04 Thread Ryosuke Niwa
On Fri, Nov 4, 2011 at 7:07 PM, Ojan Vafai o...@chromium.org wrote: On Fri, Nov 4, 2011 at 7:03 PM, Ryosuke Niwa rn...@webkit.org wrote: I am, but I'm particularly concerned about W3C tests. It'll be nice if we had exactly one way of running / writing ref tests. I think we can easily

Re: [webkit-dev] Supporting w3c ref tests and changing our convention

2011-11-04 Thread Ojan Vafai
On Fri, Nov 4, 2011 at 7:16 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Nov 4, 2011 at 7:07 PM, Ojan Vafai o...@chromium.org wrote: On Fri, Nov 4, 2011 at 7:03 PM, Ryosuke Niwa rn...@webkit.org wrote: I am, but I'm particularly concerned about W3C tests. It'll be nice if we had exactly