Re: [webkit-dev] WebKit Commit Queue blocked by build errors in ToT

> On Dec 7, 2018, at 08:55, Chris Fleizach wrote: > > To confirm, this is what is expected? Is WebKit the root namespace? > > namespace WebKit { > using namespace WebCore; > using namespace WebKit; No, that’s fine. It would be outside of that. > > Thanks > > >> On Dec 7, 2018, at 8:45 AM,

Re: [webkit-dev] WebKit Commit Queue blocked by build errors in ToT

To confirm, this is what is expected? Is WebKit the root namespace? namespace WebKit { using namespace WebCore; using namespace WebKit; Thanks > On Dec 7, 2018, at 8:45 AM, Chris Fleizach wrote: > > Looks like there's quite a few of these. Will try to get them all > >> On Dec 7, 2018, at 8:3

Re: [webkit-dev] WebKit Commit Queue blocked by build errors in ToT

Looks like there's quite a few of these. Will try to get them all > On Dec 7, 2018, at 8:37 AM, Tim Horton wrote: > > Someone in UnifiedSource28-mm.mm is “using namespace WebCore” outside of the > root namespace. > >> On Dec 7, 2018, at 08:31, Chris Fleizach wrote: >> >> I'm hitting this tou

Re: [webkit-dev] WebKit Commit Queue blocked by build errors in ToT

Someone in UnifiedSource28-mm.mm is “using namespace WebCore” outside of the root namespace. > On Dec 7, 2018, at 08:31, Chris Fleizach wrote: > > I'm hitting this tougher one now. Namespace conflict between Rect in Carbon > and WebCore::Rect > > Any ideas? > Thanks for your help > > n file

Re: [webkit-dev] WebKit Commit Queue blocked by build errors in ToT

I'm hitting this tougher one now. Namespace conflict between Rect in Carbon and WebCore::Rect Any ideas? Thanks for your help n file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource28-mm.mm:6: In file included from /Volumes/Data/EW

Re: [webkit-dev] WebKit Commit Queue blocked by build errors in ToT

On it > On Dec 6, 2018, at 4:44 PM, Andy Estes wrote: > > > >> On Dec 6, 2018, at 4:37 PM, Chris Fleizach > > wrote: >> >> >> >>> On Dec 6, 2018, at 4:37 PM, Ryan Haddad >> > wrote: >>> >>> Chris, >>> >>> I'm assuming that this is i

Re: [webkit-dev] WebKit Commit Queue blocked by build errors in ToT

> On Dec 6, 2018, at 4:37 PM, Chris Fleizach wrote: > > > >> On Dec 6, 2018, at 4:37 PM, Ryan Haddad > > wrote: >> >> Chris, >> >> I'm assuming that this is in reference to the patch in >> https://bugs.webkit.org/show_bug.cgi?id=192373 >>

Re: [webkit-dev] WebKit Commit Queue blocked by build errors in ToT

Chris, I'm assuming that this is in reference to the patch in https://bugs.webkit.org/show_bug.cgi?id=192373 . My guess is that something about the changes to Source/WebKit/WebKit.xcodeproj/project.pbxproj is causing an issue with unified sources

Re: [webkit-dev] WebKit Commit Queue blocked by build errors in ToT

> On Dec 6, 2018, at 4:37 PM, Ryan Haddad wrote: > > Chris, > > I'm assuming that this is in reference to the patch in > https://bugs.webkit.org/show_bug.cgi?id=192373 > . My guess is that something > about the changes to Source/WebKit/WebKit.

[webkit-dev] WebKit Commit Queue blocked by build errors in ToT

Hi Looks like Commit Queue is blocked on processing patches because of a build failure that's been there for a day -- https://webkit-queues.webkit.org/results/10296999 In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/u