Re: [webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

2010-03-10 Thread Alex Milowski
On Tue, Mar 9, 2010 at 1:17 PM, David Hyatt wrote: > > On Mar 9, 2010, at 1:45 PM, Adam Barth wrote: > >> >>  (1) The patch needs to be reviewed by David Hyatt.   David Hyatt >> appears to be a bottleneck in the project because he's an expert on a >> number of components that no one else understan

Re: [webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

2010-03-10 Thread Peter Kasting
On Tue, Mar 9, 2010 at 11:45 PM, Zoltan Herczeg wrote: > > It's also a big help when peers (which aren't necessarily WebKit > > reviewers) > > look over it and give review-style feedback as well. Especially when > said > > peers know more about that code than any of the official reviewers. > > Is

Re: [webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

2010-03-09 Thread Zoltan Herczeg
Hi, > It's also a big help when peers (which aren't necessarily WebKit > reviewers) > look over it and give review-style feedback as well. Especially when said > peers know more about that code than any of the official reviewers. Is that really help? Sometimes when a patch looks good to me, it s

Re: [webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

2010-03-09 Thread Ojan Vafai
On Tue, Mar 9, 2010 at 11:45 AM, Adam Barth wrote: > Q: Why are you doing this? You should stick to reviewing code in your own > area. > A: The pending-review queue is out of control. It's past the tipping > point where there are too many patches for someone to reasonably look > at the queue.

Re: [webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

2010-03-09 Thread Jeremy Orlow
On Tue, Mar 9, 2010 at 9:39 PM, David Levin wrote: > >> (3) Someone reviewed an earlier version of the patch but then didn't >> follow up. I think having a partial review by one person encourages >> other people to assume that person will finish the review. That cause >> the patch to float upw

Re: [webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

2010-03-09 Thread David Levin
> > > (3) Someone reviewed an earlier version of the patch but then didn't > follow up. I think having a partial review by one person encourages > other people to assume that person will finish the review. That cause > the patch to float upwards in pending-review until it gets lost in the > sea

Re: [webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

2010-03-09 Thread David Hyatt
On Mar 9, 2010, at 1:45 PM, Adam Barth wrote: > > (1) The patch needs to be reviewed by David Hyatt. David Hyatt > appears to be a bottleneck in the project because he's an expert on a > number of components that no one else understands as well but he > doesn't spend as much time reviewing pa

[webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

2010-03-09 Thread Adam Barth
Over the past 24 hours, I've been aggressively reviewing patches in pending-review that have been sitting around for over a month. My approach as been to review the patches in order from oldest to newest with a "the buck stops here" perspective. That means I'm g