On Friday, January 23, 2015, Darin Adler da...@apple.com wrote:
On Jan 22, 2015, at 10:36 PM, Alexey Proskuryakov a...@webkit.org
javascript:; wrote:
22 янв. 2015 г., в 17:57, Darin Adler da...@apple.com javascript:;
написал(а):
What about the test I cited?
On Jan 23, 2015, at 10:01 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Friday, January 23, 2015, Darin Adler da...@apple.com
mailto:da...@apple.com wrote:
On Jan 22, 2015, at 10:36 PM, Alexey Proskuryakov a...@webkit.org
javascript:; wrote:
22 янв. 2015 г., в 17:57, Darin Adler
23 янв. 2015 г., в 10:01, Ryosuke Niwa rn...@webkit.org написал(а):
We could add a new test expectation like ImageDiff to suppress these or we
could expose a new internals or testRunner methods to mark a test as such.
Good idea! An ImageHashMismatch expectation seems like a reasonable way to
On Jan 22, 2015, at 10:36 PM, Alexey Proskuryakov a...@webkit.org wrote:
22 янв. 2015 г., в 17:57, Darin Adler da...@apple.com написал(а):
What about the test I cited?
svg/css/svg-resource-fragment-identifier-img-src.html
This particular test is buggy - it is a hidpi test, so it dumps
On Thu, Jan 22, 2015 at 1:56 PM, Darin Adler da...@apple.com wrote:
On Jan 22, 2015, at 12:58 PM, Dirk Pranke dpra...@chromium.org wrote:
Of course, Chromium was more willing to incur the cost of keeping all of
the pixel tests up to date when trivial things changed the output
This
On Jan 22, 2015, at 11:30 AM, Simon Fraser simon.fra...@apple.com wrote:
For example, some of the tests in question render a green box either via
CALayers, or by painting, and there’s a slight color difference between the
two code paths.
What about the test I cited?
On Jan 22, 2015, at 8:44 AM, Darin Adler da...@apple.com wrote:
I noticed that when running tests I get messages like this:
svg/css/svg-resource-fragment-identifier-img-src.html - ref test hashes
didn't match but diff passed
I understand that we can have hash mismatches in actual
22 янв. 2015 г., в 11:30, Simon Fraser simon.fra...@apple.com написал(а):
This happens when the expected and actual images are very close, but not
identical. ImageDiff has some built-in rounding that effectively acts as a
small tolerance, so the hashes are different, but ImageDiff
I noticed that when running tests I get messages like this:
svg/css/svg-resource-fragment-identifier-img-src.html - ref test hashes
didn't match but diff passed
I understand that we can have hash mismatches in actual checked in images
(expected.png files), and there, at least, I believe
22 янв. 2015 г., в 17:57, Darin Adler da...@apple.com написал(а):
What about the test I cited?
svg/css/svg-resource-fragment-identifier-img-src.html
This particular test is buggy - it is a hidpi test, so it dumps results as a
1600x1200 image, but its -expected.html is not hidpi, and is
10 matches
Mail list logo
