Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

I don't think non-reviewers should be able to reject/block PRs as well.- R. NiwaOn Nov 29, 2023, at 07:45, Chris Dumez via webkit-dev wrote:FYI, our official documentation on WebKit.org says:```Making unofficial reviews before you become a reviewer is encouraged. This is an excellent way to show

Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

> On Nov 28, 2023, at 4:06 PM, Jean-Yves Avenard > wrote: > > Hi > >> On 29 Nov 2023, at 9:44 am, Chris Dumez via webkit-dev >> wrote: >> >> FYI, our official documentation on WebKit.org says: >> ``` >> Making unofficial reviews before you become a reviewer is encourage

Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

Hi > On 29 Nov 2023, at 9:44 am, Chris Dumez via webkit-dev > wrote: > > FYI, our official documentation on WebKit.org says: > ``` > Making unofficial reviews before you become a reviewer is encouraged. This is > an excellent way to show your skills. Note that you should n

Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

FYI, our official documentation on WebKit.org says: ``` Making unofficial reviews before you become a reviewer is encouraged. This is an excellent way to show your skills. Note that you should not put r+ nor r- on patches in such unofficial reviews. ``` I guess this wan’t upd

Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

On Tue, Nov 28 2023 at 01:23:12 PM -0800, Chris Dumez via webkit-dev wrote: I’m on board if it also cancels PR rejections from non-reviewers, not just approvals. I don’t see how approvals differ from rejections. Sure. It doesn't really matter whether rejections are canceled or not, because t

Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

> Hi, > > Back in the Bugzilla days, only reviewers were allowed to r+ or r- patches. > Non-reviewers were - of course - encouraged to do informal reviews but they > would do so by leaving comments. They would never r+ / r-. > > Since we?ve moved to Github, it seems we have become a lot more l

Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

(I already answered this, but that message failed to reach the mailing list, sorry to the folks receiving my reply twice) Everyone in the WebKit Github organization gets a green checkmark afaik (that’s just how the Github UI works), so as of right now that means everyone in contributors.json wi

Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

> On Nov 28, 2023, at 3:02 PM, Chris Dumez wrote: > > FYI, my understanding is that the person gets a *green* checkmark when the > person is present in contributors.json (common case), even if not marked as a > reviewer in that file. Does anyone know why we chose green for all contributors rath

Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

I think we could fix this by making EWS smarter. There is GitHub API to list and “dismiss” reviews on a PR that repository admins have permissions to use. https://docs.github.com/en/rest/pulls/reviews?apiVersion=2022-11-28#dismiss-a-review-for-a-pull-request Thanks, Pascoe > On Nov 28, 2023,

Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

> On Nov 28, 2023, at 11:51 AM, Michael Catanzaro wrote: > > On Tue, Nov 28 2023 at 10:27:41 AM -0800, Chris Dumez via webkit-dev > wrote: >> The reason I would like us to make enforce this rule is that I find it >> confusing. We have a lot of new comers in the project and I do not always >>

Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

+1! The bugzilla-style “unofficial r=me” comment was much clearer for exactly these reasons. > On Nov 28, 2023, at 10:27 AM, Chris Dumez via webkit-dev > wrote: > > Hi, > > Back in the Bugzilla days, only reviewers were allowed to r+ or r- patches. > Non-reviewers were - of course - encourag