FYI, our official documentation on WebKit.org <http://webkit.org/> says: ``` Making unofficial reviews before you become a reviewer is encouraged. This is an excellent way to show your skills. Note that you should not put r+ nor r- on patches in such unofficial reviews. ``` I guess this wan’t updated after the move to GitHub. For me, no r+ or r- on bugzilla translates to no approve / deny PRs on GitHub. So I simply wish we’d start enforcing this policy again.
Having the tools help us would be great but I don’t think it stops us from enforcing our own policies like we used to. > On Nov 28, 2023, at 1:58 PM, Michael Catanzaro <mcatanz...@redhat.com> wrote: > > On Tue, Nov 28 2023 at 01:23:12 PM -0800, Chris Dumez via webkit-dev > <webkit-dev@lists.webkit.org> wrote: >> I´m on board if it also cancels PR rejections from non-reviewers, not just >> approvals. I don´t see how approvals differ from rejections. > > Sure. It doesn't really matter whether rejections are canceled or not, > because the important part of the rejection is the comments that were added, > not the rejection status itself. A rejection from a non-reviewer is not > effective anyway, so it's fine to have a bot clarify that. > > Michael > >
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
