Re: [webkit-dev] We need OwnPtrHashMap

2010-08-30 Thread Maciej Stachowiak
On Aug 29, 2010, at 9:34 PM, Maciej Stachowiak wrote: > > On Aug 29, 2010, at 9:14 PM, Maciej Stachowiak wrote: > >> Yet another possibility is to use a hash to do the de-duping instead of >> sorting; I can't tell from context if the sorting is needed for any purpose >> other than subsequent

Re: [webkit-dev] We need OwnPtrHashMap

2010-08-29 Thread Maciej Stachowiak
On Aug 29, 2010, at 9:14 PM, Maciej Stachowiak wrote: > Yet another possibility is to use a hash to do the de-duping instead of > sorting; I can't tell from context if the sorting is needed for any purpose > other than subsequent de-duping. Turns out this doesn't work - the CSS Media Queries

Re: [webkit-dev] We need OwnPtrHashMap

2010-08-29 Thread Maciej Stachowiak
On Aug 28, 2010, at 10:57 PM, Darin Adler wrote: > We need Vector too. It has similar issues to HashMap with OwnPtr > values, including the ones mentioned by Maciej. > > For one example, look at CSSParser::m_floatingMediaQueryExpList. Vector actually works[1], and I have an almost complete pat

Re: [webkit-dev] We need OwnPtrHashMap

2010-08-28 Thread Darin Adler
We need Vector too. It has similar issues to HashMap with OwnPtr values, including the ones mentioned by Maciej. For one example, look at CSSParser::m_floatingMediaQueryExpList. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http

Re: [webkit-dev] We need OwnPtrHashMap

2010-08-25 Thread Maciej Stachowiak
On Aug 25, 2010, at 1:46 PM, Geoffrey Garen wrote: >> Sorry for the late-night webkit-dev spam, but in deploying adoptPtr, >> I've noticed a number of places where have a HashMap that owns its >> values as OwnPtrs. Unfortunately, this very clumsy currently. Each >> instance of this pattern has

Re: [webkit-dev] We need OwnPtrHashMap

2010-08-25 Thread Geoffrey Garen
> Sorry for the late-night webkit-dev spam, but in deploying adoptPtr, > I've noticed a number of places where have a HashMap that owns its > values as OwnPtrs. Unfortunately, this very clumsy currently. Each > instance of this pattern has its own way of hacking around the > problem, which might