[webstack-discuss] [sfwnv-discuss] Request to review fix for CR6717705 (memcached)

2008-07-01 Thread Roland Mainz
David.Comay at Sun.COM wrote: > >> 1. Have you determined that -xO5 generates the best performing code on both > >> SPARC and Intel. The fact that -xO5 is the highest optimization level > >> doesn't > >> always mean it generates the fastest, best performing code. Aggressive > >> inlining > >> can

[webstack-discuss] [sfwnv-discuss] resend: need Code Review for Lighttpd 1.4integration

2008-04-15 Thread Roland Mainz
Amanda Waite wrote: > > [resending to include sfwnv-discuss and setting reply-to to > webstack-discuss] > > Please review the webrev for the Lighttpd integration (CR6687382) at > http://cr.opensolaris.org/~tekgrrl/lighttpd14 5min race through http://cr.opensolaris.org/~tekgrrl/lighttpd14/lighttp

[webstack-discuss] [sfwnv-discuss] webrev review requested for the various miscellaneous PHP5 features

2007-11-27 Thread Roland Mainz
Mike.Sullivan at sun.com wrote: > >From sfwnv-discuss-bounces at opensolaris.org Mon Nov 26 15:50:11 2007 > >> If not, we > >> should discuss and decide on one. > > > >Ok... > >... who is the gatekeeper for SFWNV ? > > me... but while I would like things to be as consistent as they > can be (becau

[webstack-discuss] [sfwnv-discuss] webrev review requested for the various miscellaneous PHP5 features

2007-11-27 Thread Roland Mainz
Jyri Virkki wrote: > Roland Mainz wrote: > > Please use [...] > > I'd find it useful it you could state comments in terms of the > reasoning behind them, not just the end result. That would convey more > info and be a lot more educational.. > > Instead of &quo

[webstack-discuss] [sfwnv-discuss] webrev review requested for the variousmiscellaneous PHP5 features

2007-11-26 Thread Roland Mainz
Sriram Natarajan wrote: > Kindly find the webrev for PHP5 More Features > > http://cr.opensolaris.org/~sn123202/PHP5_ARC_CASE_2007_656/ [snip] Here comes a 5min race through the patch (patch code is quoted with "> "): > --- old/usr/src/cmd/php5/install-php5 Mon Nov 26 12:45:39 2007 > +++ new/usr

[webstack-discuss] [sfwnv-discuss] Webrev review requestedformemcached

2007-11-23 Thread Roland Mainz
Victor Kirkebo wrote: > Roland Mainz wrote: > > Victor Kirkebo wrote: > >>Kindly find the webrev for memcached integration at : > >>http://cr.opensolaris.org/~vk136562/memcached/ > >> > >>Code reviews are solicited from this team and review/feedback i

[webstack-discuss] [sfwnv-discuss] Webrev review requested formemcached

2007-11-20 Thread Roland Mainz
Victor Kirkebo wrote: > Kindly find the webrev for memcached integration at : > > http://cr.opensolaris.org/~vk136562/memcached/ > > Code reviews are solicited from this team and review/feedback is > requested by 11/20. A quick 5min race over http://cr.opensolaris.org/~vk136562/memcached/memcach

[webstack-discuss] [sfwnv-discuss] Webrev review requested for MySQL

2007-11-05 Thread Roland Mainz
Ritu Kamboj wrote: > Kindly find the webrev for MySQL integration at : > > http://cr.opensolaris.org/~rkamboj/MySQLWebRev/ > > Code reviews are solicited from this team and review/feedback is > requested by 11/8. - new/usr/src/cmd/mysql-5-0/Makefile.sfw > + CFLAGS="-xO3 -xprefetch=auto -xpr

[webstack-discuss] [sfwnv-discuss] Webrevs for Review: Ruby Integration.

2007-11-05 Thread Roland Mainz
Sriram Natarajan wrote: > Shanti > Well, there seems to be a bit of disconnect here. Sun Studio Compiler > folks consistently recommend us to use '-fast' compiler option but at > the same time folks reviewing our integration within SXDE give a > consistent 'NO' to this option. AFAIK the project i

[webstack-discuss] [sfwnv-discuss] Webrevs for Review: Ruby Integration.

2007-11-05 Thread Roland Mainz
Shanti Subramanyam - PAE wrote: > Alan Coopersmith wrote: > > Jyri Virkki wrote: [snip] > > "-fast" is definitely wrong in anything you're publishing for others to > > use. > > It makes binaries tuned specifically for the hardware on your build machine > > which may not even run on other machines,

[webstack-discuss] [sfwnv-discuss] Webrevs for Review: Ruby Integration.

2007-11-05 Thread Roland Mainz
Jyri Virkki wrote: > Roland Mainz wrote: > > http://cr.opensolaris.org/~chriszhu/ruby-webrev/usr/src/cmd/ruby18/Makefile.sfw.html > > > RUBY_CFLAGS="-fast -xipo -xtarget=generic" > > > > Please do _not_ use "-fast". "-fast" is a macro w

[webstack-discuss] [sfwnv-discuss] Webrevs for Review: Ruby Integration.

2007-11-02 Thread Roland Mainz
Roland Mainz wrote: > Prashant Srinivasan wrote: [snip] > Combined these flags would be: > -- snip -- > RUBY_CFLAGS="-xc99=%all -D_XOPEN_SOURCE=600 -D__EXTENSIONS__=1 -xO4 > -xipo=2 -xspace -xstrconst" > -- snip -- > > > clean: > > -rm

[webstack-discuss] [sfwnv-discuss] Webrevs for Review: Ruby Integration.

2007-11-02 Thread Roland Mainz
Prashant Srinivasan wrote: > http://cr.opensolaris.org/~chriszhu/ruby-webrev/ is the webrev for the > inclusion of Ruby 1.8 into Solaris(PSARC/2007/600). > > Code reviews are solicited from this team, and review/feedback is > requested by 11/5/2007. Only a 5min race through the patch (patch code

[webstack-discuss] [sfwnv-discuss] Squid 2.6 integration into SXDE review request

2007-10-24 Thread Roland Mainz
Danek Duvall wrote: > On Wed, Oct 24, 2007 at 07:04:29AM +0200, Roland Mainz wrote: > > > 3. Nit: Use "/usr/bin/ksh" (or "/usr/bin/ksh93"), not "/bin/ksh": > > -- snip -- > > +MAKE=/usr/ccs/bin/make \ > > +/bin/ksh ./c

[webstack-discuss] [sfwnv-discuss] Squid 2.6 integration into SXDE review request

2007-10-24 Thread Roland Mainz
rahul wrote: > I have prepared changes for including Squid 2.6 into SXDE - through > WebStack. Here is a webrev http://cr.opensolaris.org/~vrthra/squid/ Can > I get a reviewer for this from sfwnv community? > > (We'd like someone outside the project team to take a look.) Looking at http://cr.open