Re: Al's repository restructure

2007-03-13 Thread Martijn Dashorst
It seems that the jdk1.5 profile gets called by default when running in a 1.5 java version. Since we can fix the bamboo build to use the -pJDK1.5 parameter I think, we should remove the jdk activation for that profile. Martijn On 3/14/07, Frank Bille <[EMAIL PROTECTED]> wrote: Where is wicket 1

Re: Al's repository restructure

2007-03-13 Thread Frank Bille
Where is wicket 1.3 builds anyway? They seem to be missing. I still can't get 1.3 setup on local computer. I'm no maven shark, but it looks like it's not building everything now from the parent: http://papernapkin.org/pastebin/view/5032 Frank On 3/14/07, Eelco Hillenius <[EMAIL PROTECTED]> wr

Re: Al's repository restructure

2007-03-13 Thread Eelco Hillenius
It seems Bamboo isn't updated for the new structure yet, and no snapshots are deployed to wicket-stuff's repo, is that correct? Eelco On 3/12/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: And it is in... I took the liberty of cleaning up the pom's further. Please put all your dependency inf

Re: 1.x test errors?

2007-03-13 Thread Gwyn Evans
Turned out to be something odd when JAVA_HOME being set to JDK1.5 but path pointing to a JDK1.4, specifically when using Maven to build & run there were errors, e.g. java.lang.NoSuchMethodError: java.lang.StringBuffer.append(Ljava/lang/CharSequence;) Ljava/lang/StringBuffer; ... Sorting out t

Empty string values in 1.x ConverterLocator#convertToString(Object, Locale) logic

2007-03-13 Thread Alastair Maw
ConverterLocator's default converter has on line 130: if (value == null || "".equals(value)) { return null; } This doesn't look right to me. I don't want the default converter to be converting "" strings to null - surely it should leave them alone and just be doing type conversions? Can

Re: WicketServlet from wicket-1.x is not working?

2007-03-13 Thread Eelco Hillenius
Hmmm. I just tested by setting back the old web.xml for wicket-examples (servlets) and everything works. There must be something else that went wrong Bruno. Eelco On 3/12/07, Bruno Borges <[EMAIL PROTECTED]> wrote: I moved a simple application that I was using to implement wicket:link from wic

Re: ListDataProvider ignores count parameter in iterate()

2007-03-13 Thread Igor Vaynberg
the dataview wraps the returned iterator in a bounded one that will only call next() max (count) number of times as a safeguard for users doing a thing just like that :) but if its really itching you then go ahead. -igor On 3/13/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: While porting ou

ListDataProvider ignores count parameter in iterate()

2007-03-13 Thread Martijn Dashorst
While porting our app to current head I noticed that one of our developers discovered something he called a bug: Iterator iterate(int first, int count) { return list.listIterator(first); } ignores the count parameter. It would be better/nicer to return: list.sublist(first, count).iterator();

Re: Release 1.3 - status

2007-03-13 Thread Al Maw
Martijn Dashorst wrote: I've been working on the release and have come to a last point: how to package stuff. The default src assembly is IMO moot: it packages each project without context. It seems to me that a zip containing the sources for all projects is better, as it makes it one package as

Re: [Vote] Al's repository restructure

2007-03-13 Thread Jonathan Locke
Thanks Martijn!! Al Maw wrote: > > Jonathan Locke wrote: >> this is SO much better. thanks almaw! > > Thank Martijn, who actually put in the elbow grease to make it all work > (site templates, etc.). I just faffed with some pom files. Anyway, glad > you like it. :-) > > Al > > --

Re: Release 1.3 - status

2007-03-13 Thread Martijn Dashorst
The warnings have been resolved, and the META-INF directory of each jar file will now include the LICENSE, NOTICE and DISCLAIMER file (incubator disclaimer). I suggest that everyone upgrades their maven to 2.0.5 to prevent conflicts. Martijn On 3/13/07, Martijn Dashorst <[EMAIL PROTECTED]> wrot

Re: 1.x test errors?

2007-03-13 Thread Martijn Dashorst
Even 1.2 seems to be available... and doesn't generate warnings. Martijn On 3/13/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: Bumping the version number of the resourcebundle jar to 1.1 seems to fix the warnings... Martijn On 3/13/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > The effec

Re: 1.x test errors?

2007-03-13 Thread Martijn Dashorst
Bumping the version number of the resourcebundle jar to 1.1 seems to fix the warnings... Martijn On 3/13/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: The effective pom is correct. Could be a bug in maven? Martijn On 3/13/07, Al Maw <[EMAIL PROTECTED]> wrote: > Gwyn Evans wrote: > > Ignorin

Re: 1.x test errors?

2007-03-13 Thread Martijn Dashorst
The effective pom is correct. Could be a bug in maven? Martijn On 3/13/07, Al Maw <[EMAIL PROTECTED]> wrote: Gwyn Evans wrote: > Ignoring the Velocity warnings (anyone else get them?), I get 5 test > errors - See attatched. Yeah, I also get these. Guess we ought to look into why they're there.

Re: [wicket-374] Allow disable "autoEnable" for wicket:links

2007-03-13 Thread Bruno Borges
Guys, is it possible to apply this patch before 1.3 goes out? :D Cheers On 3/12/07, Bruno Borges <[EMAIL PROTECTED]> wrote: Well... As you guys can see in JIRA, I sent the diff implementing this functionality... Really... It's really useful :) https://issues.apache.org/jira/browse/WICKET-374

Release 1.3 - status

2007-03-13 Thread Martijn Dashorst
I've been working on the release and have come to a last point: how to package stuff. The default src assembly is IMO moot: it packages each project without context. It seems to me that a zip containing the sources for all projects is better, as it makes it one package as a whole The default bin

AW: 1.x test errors?

2007-03-13 Thread Korbinian Bachl
im sorry, but still its so, look yourself: C:\Dokumente und Einstellungen\korbinian\wicket\wicket1.3-20070313\wicket-1.x\jd k-1.4\wicket>mvn clean [INFO] Scanning for projects... [INFO] - --- [INFO] Building Wicket [I

Re: 1.x test errors?

2007-03-13 Thread Al Maw
Gwyn Evans wrote: Ignoring the Velocity warnings (anyone else get them?), I get 5 test errors - See attatched. Yeah, I also get these. Guess we ought to look into why they're there. The stuff is defined in the parent pom, so I'm wondering if it doesn't propagate down to the children. Perhaps

Re: [Vote] Al's repository restructure

2007-03-13 Thread Al Maw
Jonathan Locke wrote: this is SO much better. thanks almaw! Thank Martijn, who actually put in the elbow grease to make it all work (site templates, etc.). I just faffed with some pom files. Anyway, glad you like it. :-) Al

Re: 1.x test errors?

2007-03-13 Thread Martijn Dashorst
Did you do a clean before running the tests? mvn clean mvn test ? Martijn On 3/13/07, Korbinian Bachl <[EMAIL PROTECTED]> wrote: im on revision 517624 as well and just checked out the 1.x (1.3) and did a maven install, and i got following: Results : Failed tests: testDetachPage(wicket.Com

AW: 1.x test errors?

2007-03-13 Thread Korbinian Bachl
im on revision 517624 as well and just checked out the 1.x (1.3) and did a maven install, and i got following: Results : Failed tests: testDetachPage(wicket.ComponentTest) testDetachPageAjaxRequest(wicket.ComponentTest) testHeaderContribution1(wicket.ajax.AjaxRequestTargetTest) testHeader

Re: 1.x test errors?

2007-03-13 Thread Gwyn Evans
It was HEAD at the time! Anyway, specifically focussing on 1.x\jdk-1.4\wicket, it builds fine under both jdk1.5 & jdk1.4 (build 1.4.2_13-b06) but 5 tests error when doing "mvn test" using the jdk1.4 to supply the run-time environment, whereas they're fine under jdk1.5. /Gwyn On 13/03/07, Martij

Re: 1.x test errors?

2007-03-13 Thread Martijn Dashorst
But I am on revision: 517624 Martijn On 3/13/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: Works for me... I just updated to head of branch 1.x [INFO] [INFO] [INFO] [INFO] Reactor Summary: [INFO] ---

Re: 1.x test errors?

2007-03-13 Thread Martijn Dashorst
Works for me... I just updated to head of branch 1.x [INFO] [INFO] [INFO] [INFO] Reactor Summary: [INFO] [INFO] Wicket Parent .

Re: 1.x test errors?

2007-03-13 Thread Gwyn Evans
Hmm - it was only 30K - See http://www.javaguy.co.uk/build.log On 13/03/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: Attachment is gone :) On 3/13/07, Gwyn Evans <[EMAIL PROTECTED]> wrote: > Hi, > Anyone else getting 1.x test errors or is it just my setup? > > Using https://svn.apache.org/

Re: 1.x test errors?

2007-03-13 Thread Martijn Dashorst
The only test that failed here was the license test which borked on some invisible difference for a site descriptor in wicket-quickstart Martijn On 3/13/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: Attachment is gone :) On 3/13/07, Gwyn Evans <[EMAIL PROTECTED]> wrote: > Hi, > Anyone else

Re: 1.x test errors?

2007-03-13 Thread Martijn Dashorst
Attachment is gone :) On 3/13/07, Gwyn Evans <[EMAIL PROTECTED]> wrote: Hi, Anyone else getting 1.x test errors or is it just my setup? Using https://svn.apache.org/repos/asf/incubator/wicket/branches/wicket-1.x Updated (to r517607) Ignoring the Velocity warnings (anyone else get them?), I g

1.x test errors?

2007-03-13 Thread Gwyn Evans
Hi, Anyone else getting 1.x test errors or is it just my setup? Using https://svn.apache.org/repos/asf/incubator/wicket/branches/wicket-1.x Updated (to r517607) Ignoring the Velocity warnings (anyone else get them?), I get 5 test errors - See attatched. /Gwyn