> I've opened an issue for it
http://issues.apache.org/jira/browse/WICKET-730
Getting back to the original issue ...
As I understand it, the complaint comes from this behavior:
* Close the streams which has been opened when getting the InputStream
* using [EMAIL PROTECTED] #getInputStream()}
Eelco Hillenius wrote:
> > Not only should you not need to add a finalizer, but most importantly,
> > review your codebase and *remove* all finalizers.
> It's the only one in there.
Good. Makes the review easier ;-), and you've only the one to remove.
--- Noel
icket
> Yeah, that's one of the reasons why we felt we would be able to get
> rid of the dependency without troubles.
I have no issue with you pulling pieces of Commons IO and Commons
FileUpload. I object to the use of and dependence on finalizers.
As noted:
> Noel J. Bergman wr
: FileUploadField closing input streams behind my back
On 7/5/07, Noel J. Bergman <[EMAIL PROTECTED]> wrote:
>
> a/org/apache/commons/fileupload/
>
> Sorry if this comes across as being snarky, but rewriting the wheel is bad
> enough; getting it wrong is worse.
>
>
> Do we really need to go around and aggressively clean up these
> InputStreams? Can't we do that in a finalize() method somewhere?
NO!! NEVER use finalize(), especially not server-side.
If you need to automatically cleanup resources when they are unused, without
having to call explicit clea
Is the obvious too much so? Ask Craig about the provanance.
--- Noel
> the servletapi jar seems a bit out-of-the-blue.
And it evolves, too, e.g., the newest listeners.
--- Noel
What's the deal with
http://svn.apache.org/viewvc/incubator/wicket/tags/wicket-1.3.0-incubating-b
eta-2/licenses/log4j-license.txt?revision=545721&view=markup ?
Log4J is an ASF project, and we have not permitted new code to go out with
the old license for years. I checked pom.xml, and wicket uses
Martijn Dashorst wrote:
> My biggest problem at the moment with a release is that it always is
> the code of one week ago: that is the time it takes from building it
> and moving it through the votes.
That's pretty standard for any project. The release manager tags the
release, does the build, p
rom: Ate Douma [mailto:[EMAIL PROTECTED]
Sent: Tuesday, May 29, 2007 17:39
To: Noel J. Bergman
Subject: [Fwd: A new proposal for Wicket Portlet support]
Noel,
As you can read below, I've just presented a new proposal for bringing
portlet support back into Wicket.
Martijn mentioned you ar
10 matches
Mail list logo
