Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version)

2007-03-29 Thread Gwyn Evans
Likewise... :-) [x] Yes release the damned thing already /Gwyn On 29/03/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: I forgot +1 myself On 3/28/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > And you can find the stuff here: > > http://people.apache.org/~dashorst/releases/apache-wicket-1

Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version)

2007-03-29 Thread Jean-Baptiste Quenot
> [x] Yes release the damned thing already > [ ] Yes, this is the last time I vote on this... My + and 1 keys show > signs of wear > [ ] No, I found this issue and you'd better fix it, or ... -- Jean-Baptiste Quenot aka John Banana Qwerty http://caraldi.com/jbq/

Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version)

2007-03-29 Thread Martijn Dashorst
I have 7 +1 votes, and no -1's, and no burning issues to resolve, so that makes this a go. Sorry for abusing the + and 1 keys... be gentle with them, give them a special scrubbing tonight or something. I'll write up a proposal for the IPMC and send it here. If noone objects within 24 hours, I'll

Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version)

2007-03-29 Thread Martijn Dashorst
I forgot +1 myself On 3/28/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: And you can find the stuff here: http://people.apache.org/~dashorst/releases/apache-wicket-1.3.0-incubating-alpha Martijn On 3/28/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > I've tried to remove some issues from

Re: Failing unit tests (WAS: Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version))

2007-03-28 Thread Johan Compagner
can;'t we do a XML based equals? Most of the time it is xml what we output. So why not do a xml bases compare johan On 3/28/07, Janne Hietamäki <[EMAIL PROTECTED]> wrote: On Mar 28, 2007, at 11:23 AM, Al Maw wrote: > > Other than that, things I've checked are: > - Tests all pass. Hmm. I

Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version)

2007-03-28 Thread Jean-Baptiste Quenot
* Al Maw: > I can't verify the ASC sigs, 'cos I don't have your public PGP key. Have you tried this: $ gpg --search-keys [EMAIL PROTECTED] -- Jean-Baptiste Quenot aka John Banana Qwerty http://caraldi.com/jbq/

Re: Failing unit tests (WAS: Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version))

2007-03-28 Thread Eelco Hillenius
Depends on what is easier to fix. I'm certainly not for changing to a less efficient implementation just for the sake of the unit tests, so if the DiffUtil could be changed, that would be great. IMO, our unit tests are too brittle anyway, so a diffutil that would be a little bit smarter would be v

Re: Failing unit tests (WAS: Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version))

2007-03-28 Thread Janne Hietamäki
Yeah, that's why I changed the subject.. On Mar 28, 2007, at 12:58 PM, Martijn Dashorst wrote: This is a known issue and does not hold back the release. Martijn On 3/28/07, Janne Hietamäki <[EMAIL PROTECTED]> wrote: On Mar 28, 2007, at 11:23 AM, Al Maw wrote: > > Other than that, things I

Re: Failing unit tests (WAS: Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version))

2007-03-28 Thread Janne Hietamäki
Yup, that's why I changed the subject. Janne On Mar 28, 2007, at 12:58 PM, Martijn Dashorst wrote: This is a known issue and does not hold back the release. Martijn On 3/28/07, Janne Hietamäki <[EMAIL PROTECTED]> wrote: On Mar 28, 2007, at 11:23 AM, Al Maw wrote: > > Other than that, thi

Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version)

2007-03-28 Thread Gwyn Evans
On 28/03/07, Al Maw <[EMAIL PROTECTED]> wrote: I can't verify the ASC sigs, 'cos I don't have your public PGP key. https://svn.apache.org/repos/asf/incubator/wicket/common/KEYS /Gwyn -- Download Wicket 1.2.5 now! - http://wicketframework.org

Re: Failing unit tests (WAS: Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version))

2007-03-28 Thread Martijn Dashorst
This is a known issue and does not hold back the release. Martijn On 3/28/07, Janne Hietamäki <[EMAIL PROTECTED]> wrote: On Mar 28, 2007, at 11:23 AM, Al Maw wrote: > > Other than that, things I've checked are: > - Tests all pass. Hmm. I tried to run the tests, and some of them are failing

Failing unit tests (WAS: Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version))

2007-03-28 Thread Janne Hietamäki
On Mar 28, 2007, at 11:23 AM, Al Maw wrote: Other than that, things I've checked are: - Tests all pass. Hmm. I tried to run the tests, and some of them are failing because the outputted markup has attributes in wrong order. Tests pass ok when I use JDK 1.5.0, but with 1.4.2 or 1

Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version)

2007-03-28 Thread Martijn Dashorst
Al thx for your investigation... you're welcome to fix anything in the release branch. :) Martijn On 3/28/07, Al Maw <[EMAIL PROTECTED]> wrote: Martijn Dashorst wrote: > I've tried to remove some issues from our previous round. The less > issues to cope with, the better. > - just one target dir

Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version)

2007-03-28 Thread Al Maw
Martijn Dashorst wrote: I've tried to remove some issues from our previous round. The less issues to cope with, the better. - just one target directory still eludes me, the rest have been eliminated - jetty jars are now provided, and not put in the examples war - build artifacts now go into targe

Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version)

2007-03-27 Thread Frank Bille
On 3/28/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: [x] Yes release the damned thing already Frank P.s. I really think it's a cool distribution now. It's really well structured and self-contained. If only every software distribution (also the apache ones) were like this :)

Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version)

2007-03-27 Thread Igor Vaynberg
with all the votes lately those keys dont work anymore thus i couldnt use them, its a good thing martijn provides these alternate choices -igor On 3/27/07, Johan Compagner <[EMAIL PROTECTED]> wrote: how is that possible? You didn't use + and then 1 key at all for this reply so don't lie! On

Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version)

2007-03-27 Thread Johan Compagner
[x] Yes, this is the last time I vote on this... My x key shows signs of wear On 3/28/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: I've tried to remove some issues from our previous round. The less issues to cope with, the better. - just one target directory still eludes me, the rest have b

Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version)

2007-03-27 Thread Johan Compagner
how is that possible? You didn't use + and then 1 key at all for this reply so don't lie! On 3/28/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote: [x] Yes, this is the last time I vote on this... My + and 1 keys show signs of wear -igor

Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version)

2007-03-27 Thread Igor Vaynberg
[x] Yes, this is the last time I vote on this... My + and 1 keys show signs of wear -igor

Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version)

2007-03-27 Thread Janne Hietamäki
On 28.3.2007, at 2.23, Martijn Dashorst wrote: [ x] Yes release the damned thing already [ ] Yes, this is the last time I vote on this... My + and 1 keys show signs of wear [ ] No, I found this issue and you'd better fix it, or ...

Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version)

2007-03-27 Thread Eelco Hillenius
[ ] Yes release the damned thing already [ x ] Yes, this is the last time I vote on this... My + and 1 keys show signs of wear [ ] No, I found this issue and you'd better fix it, or ... Eelco

Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version)

2007-03-27 Thread Martijn Dashorst
And you can find the stuff here: http://people.apache.org/~dashorst/releases/apache-wicket-1.3.0-incubating-alpha Martijn On 3/28/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: I've tried to remove some issues from our previous round. The less issues to cope with, the better. - just one targ

[VOTE] release wicket-1.3.0-incubating-alpha (new version)

2007-03-27 Thread Martijn Dashorst
I've tried to remove some issues from our previous round. The less issues to cope with, the better. - just one target directory still eludes me, the rest have been eliminated - jetty jars are now provided, and not put in the examples war - build artifacts now go into target/dist and target/m2-repo