GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1388166 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1388166 in widelands: Cannot open savegame of build 18 with bzr 7237
https://bugs.launchpad.net/widelands/+bug/1388166
For
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1388028 into
lp:widelands.
Requested reviews:
TiborB (tiborb95)
Related bugs:
Bug #1388028 in widelands: Unable to load saved game
https://bugs.launchpad.net/widelands/+bug/1388028
For more details, see:
GunChleoc - this is not about zero division but about out-of-range - I think.
Do you think that problem is that genstats is not populated some very short
time after loading and AI tries to access members that are not there yet? So
that genstats.size()==0?
If this is the case I would use other
I added the try/catch because I was suspecting holes in the genstats
array, but the hole is in miltary_strength. So, the important point here
is to check for military_strength.empty() - if miltary_strength.back()
gives us nothing, we do get a division by 0. The try/catch isn't that
important
from http://www.cplusplus.com/reference/vector/vector/back/
Calling this function on an empty container causes undefined behavior.
But what is more interesting is that if really the genstats or miltary_strength
can be empty during a small period of time after loading.
Also, it can be empty
Please, testers on Linux and Windows are searched for :).
--
https://code.launchpad.net/~widelands-dev/widelands/glsl/+merge/240363
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/glsl into lp:widelands.
SirVer has proposed merging lp:~widelands-dev/widelands/glsl into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #984372 in widelands: opengl-es support
https://bugs.launchpad.net/widelands/+bug/984372
For more details, see:
What do you think?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1388028/+merge/240357
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1388028.
___
Mailing list: https://launchpad.net/~widelands-dev
I got this problem:
[ 55%] Building CXX object
src/graphic/CMakeFiles/graphic.dir/gl/dither_program.cc.o
In file included from
/var/widelands/BZR/glsl/src/graphic/gl/dither_program.h:23:0,
from
/var/widelands/BZR/glsl/src/graphic/gl/dither_program.cc:20:
Also, I tested the savegame, I got:
ComputerPlayer(5): initializing (2)
ComputerPlayer(5): miltary_strength empty
ComputerPlayer(5): miltary_strength empty
ComputerPlayer(5): miltary_strength empty
ComputerPlayer(6): initializing (2)
ComputerPlayer(6): miltary_strength empty
ComputerPlayer(6):
Do we really need the
if (genstats.size()j) {
As I said, the try/catch was just something I added while searching, and the
real fix for this particular crash was the check for
genstats.at(j - 1).miltary_strength.empty())
I don't mind either way though. I expect that these cases will mostly
I fixed the compiler error. The warning about switch (order_index) { should
still be fixed.
--
https://code.launchpad.net/~widelands-dev/widelands/glsl/+merge/240363
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/glsl into lp:widelands.
I have no idea if a case genstats.size()==0 can ever happen, if samebody
guarantees that it cannot happen ever, we can omit it. But this way we will be
on a safe side.
Can AI know that saving or loading of a game is in progress?
--
13 matches
Mail list logo
