Martin Schmidt has proposed merging
lp:~martinschmidt/widelands/observer_building_spaces into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1419537 in widelands: Allow Observers to show building spaces
* State: Failed to build
* Recipe: widelands-dev/widelands-daily
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Distroseries: utopic
* Duration: 3 minutes
* Build Log:
https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+recipebuild/868809/+files/buildlog.txt.gz
*
* State: Failed to build
* Recipe: widelands-dev/widelands-daily
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Distroseries: vivid
* Duration: 2 minutes
* Build Log:
https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+recipebuild/868810/+files/buildlog.txt.gz
*
* State: Failed to build
* Recipe: widelands-dev/widelands-daily
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Distroseries: trusty
* Duration: 3 minutes
* Build Log:
https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+recipebuild/868808/+files/buildlog.txt.gz
*
The proposal to merge lp:~widelands-dev/widelands/bug-1380286 into lp:widelands
has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1380286/+merge/242975
--
Your team Widelands Developers is subscribed to branch
Review: Approve
I looked at this again right now and went ahead and merged.
I thought it was a good idea to split the tests into two separates, but it had
some code duplication that I decided in the end it is better to keep the test
together. I just made the tests a bit tighter by directly
The proposal to merge lp:~widelands-dev/widelands/seafaring-ai into
lp:widelands has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271
--
Your team Widelands Developers is subscribed to branch
Thanks, Tibor. I will take care of the merging :)
--
https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/seafaring-ai.
___
Mailing list:
SirVer - I added such test:
test_rip_portdock_with_worker_and_ware_in_transit.lua
It is bit lost among other tests, because they all uses the word portdock
when in fact they mean port
Though situation when portdock is lost but cannot be restored and port itself
has to be destroyed is not
If i add more than one normal road to each tribe, could i use this branch
again for upload? Or must i create a new branch from trunk?
Making a new branch is usually the cleaner way of action. If that is
inconvenient you can also reuse this one.
--
Review: Approve
Time to merge then.
The one issue that concerns me still in this branch is that there is no new
test for a warehouse that needs to recreate it's port dock. I feel this corner
case can easily regress without a test. But since this branch has been sitting
for so long, I think
Bug report, so we won't forget:
https://bugs.launchpad.net/widelands/+bug/1421107
--
https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/seafaring-ai.
SirVer - I added such test:
test_rip_portdock_with_worker_and_ware_in_transit.lua
My apologize. I did not remember/see it in the branch. I think this is great
then.
The other test case you describe is indeed harder to do. You would need to
construct a map with military buildings of another
13 matches
Mail list logo
