Review: Approve
I can't test this, but code LGTM - just some small formatting nits.
I also found a typo that's not in the diff:
line 86: at given position and prepaire all for wl_markdown
prepaire => prepare
Diff comments:
> === modified file 'mainpage/views.py'
> --- mainpage/views.py 2015-0
I incorporated the comments, I belive all of them, though I was unsure about
iterators, there is a lot of places where iterators are used here... Maybe it
will be reworked gradually.
regression tests passed OK
--
https://code.launchpad.net/~widelands-dev/widelands/trainingsites_and_teams/+m
kaputtnik has proposed merging
lp:~franku/widelands-website/devs_and_locales_list into lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1424072 in Widelands Website: "Automatically add translator credits to
authors list"
https://bugs.launchpa
Added a small change in the JSON files to make things easier for the website
side of things.
--
https://code.launchpad.net/~widelands-dev/widelands/authors_and_languages/+merge/265892
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/authors_and_languages.
_
I don't know why a delete was necessary - maybe it was just old code?
2 of the methods now return unique_ptr. add_text is trickier and was giving me
segfaults (probably because it is being used directly as well as for the member
object), so I just added a todo comment for it.
We should run clan
Review: Needs Fixing
Only reviewed the code that I did not write. Some comments inlined.
Diff comments:
>
> === modified file 'src/editor/ui_menus/editor_main_menu_random_map.cc'
> --- src/editor/ui_menus/editor_main_menu_random_map.cc2014-11-30
> 18:49:38 +
> +++ src/editor/ui_men
Review: Needs Information
I am unsure about this change now. Most UI elements are owned by their parents.
Why did we need the delete before in the first place? More comments inlined.
Diff comments:
>
> === modified file 'src/wui/attack_box.cc'
> --- src/wui/attack_box.cc 2015-03-30 08:45:0
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1357510 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1357510 in widelands: "Integrate the use of pgettext from the gettext
library in C++"
https://bugs.launchpad.net/widelands/+b
The proposal to merge lp:~widelands-dev/widelands/bug-1326395 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1326395/+merge/265905
--
Your team Widelands Developers is subscribed to branch
lp
Thanks for the comments - all implemented. I also fixed up the building
statistics, because that's where I stole the code from ;)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-653308/+merge/265931
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug
In revision 7492,the change "Working radius" -> "Work area" in the file
tribes/scripting/format_help.lua should be revised. The string prints the
work area radius, so the original text "Working radius" seems more
appropriate.
On 27 July 2015 at 11:10, wrote:
> The proposal to merge lp:~widelands
Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1326395/+merge/265905
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1326395.
___
Mailing list: https://launchpad.net/~widelands-dev
Po
The proposal to merge lp:~widelands-dev/widelands/string-fixes into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/265906
--
Your team Widelands Developers is subscribed to branch
Review: Approve
Gonna merge.
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/265906
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/string-fixes.
___
Mailing list: https://launchpad.net/~wi
Review: Needs Fixing
couple of nits not related to your changes. But while you are digging through
the code
Diff comments:
> === modified file 'src/ui_basic/slider.cc'
> --- src/ui_basic/slider.cc2014-11-27 12:02:08 +
> +++ src/ui_basic/slider.cc2015-07-27 07:23:23 +
> @@ -1
Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/authors_and_languages/+merge/265892
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/authors_and_languages.
___
Mailing list: https://launchpad.n
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-653308 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #653308 in widelands: "The attack dialog is not updating the number of
possible attackers"
https://bugs.launchpad.net/widelands
17 matches
Mail list logo
