[Widelands-dev] [Merge] lp:~widelands-dev/widelands/avoid_wraparound into lp:widelands

2016-01-27 Thread SirVer
SirVer has proposed merging lp:~widelands-dev/widelands/avoid_wraparound into lp:widelands. Commit message: Switched overzealous uint32_t -> int to avoid underflow errors on minus arithmetic. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1522582 in widelands: "v

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/avoid_wraparound into lp:widelands

2016-01-27 Thread bunnybot
Hi, I am bunnybot (https://github.com/widelands/bunnybot). I am keeping the source branch lp:~widelands-dev/widelands/avoid_wraparound mirrored to https://github.com/widelands/widelands/tree/_widelands_dev_widelands_avoid_wraparound You can give me commands by starting a line with @bunnybot . I

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1397500 into lp:widelands

2016-01-27 Thread SirVer
I made the regression tests work in this branch. Could you take it from here? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1397500/+merge/243860 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1397500. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/avoid_wraparound into lp:widelands

2016-01-27 Thread GunChleoc
Review: Approve Code LGTM, not tested yet. -- https://code.launchpad.net/~widelands-dev/widelands/avoid_wraparound/+merge/284067 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/avoid_wraparound. ___ Mailing list: htt

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/changelog_license_date into lp:widelands

2016-01-27 Thread GunChleoc
We could combine the prosa from the development reports, what do you think? -- https://code.launchpad.net/~widelands-dev/widelands/changelog_license_date/+merge/283871 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/changelog_license_date in

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/avoid_wraparound into lp:widelands

2016-01-27 Thread kaputtnik
Review: Approve No vertical stripes anymore. I tested also some other windows, no failure. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/avoid_wraparound/+merge/284067 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/avoid_wraparound.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/avoid_wraparound into lp:widelands

2016-01-27 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/avoid_wraparound into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/avoid_wraparound/+merge/284067 -- Your team Widelands Developers is subscribed to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1397500 into lp:widelands

2016-01-27 Thread GunChleoc
Thanks - will have a look. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1397500/+merge/243860 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1397500. ___ Mailing list: https://launchpad.net/~widelan

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/multiline_textarea into lp:widelands

2016-01-27 Thread GunChleoc
Thanks - bookmarked for fixing :) -- https://code.launchpad.net/~widelands-dev/widelands/multiline_textarea/+merge/283736 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/multiline_textarea. ___ Mailing list: https://l

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/changelog_license_date into lp:widelands

2016-01-27 Thread SirVer
Maybe too long. I say we merge that in and review the full changelog for b19 and write ~10 bullets of prose with the highlights. -- https://code.launchpad.net/~widelands-dev/widelands/changelog_license_date/+merge/283871 Your team Widelands Developers is requested to review the proposed merge of

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_huge_boxes into lp:widelands

2016-01-27 Thread SirVer
SirVer has proposed merging lp:~widelands-dev/widelands/fix_huge_boxes into lp:widelands. Commit message: Fix ptr = 0 to *ptr = 0 Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1538685 in widelands: "Some windows are huge" https://bugs.launchpad.net/widelands/+b

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_huge_boxes into lp:widelands

2016-01-27 Thread bunnybot
Hi, I am bunnybot (https://github.com/widelands/bunnybot). I am keeping the source branch lp:~widelands-dev/widelands/fix_huge_boxes mirrored to https://github.com/widelands/widelands/tree/_widelands_dev_widelands_fix_huge_boxes You can give me commands by starting a line with @bunnybot . I un

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_huge_boxes into lp:widelands

2016-01-27 Thread bunnybot
Continuous integration builds have changed state: Travis build 419. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/105250971. Appveyor build 320. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fix_huge_box

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_huge_boxes into lp:widelands

2016-01-27 Thread GunChleoc
Isn't it fun that 0 still evaluates to NULL... Code LGTM and tested. Travis also looks clean. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/fix_huge_boxes/+merge/284176 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelan

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1397500 into lp:widelands

2016-01-27 Thread GunChleoc
Review: Resubmit This is ready for testing and review now. I tried clicking on everything that has an image in it, but I might have missed something. The packaging also needs to be tested for all OSses. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1397500/+merge/243860 Your team

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1397500 into lp:widelands

2016-01-27 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/bug-1397500 into lp:widelands has been updated. Commit Message changed to: Moved all data-related directories into a new "data" directory. For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1397500/+merge/243860 -- Y

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/padding_in_atlas into lp:widelands

2016-01-27 Thread SirVer
The proposal to merge lp:~widelands-dev/widelands/padding_in_atlas into lp:widelands has been updated. Commit Message changed to: - Add 1 pixel padding in the texture atlas to avoid texture bleeding. - Filter all textures linearly instead of near. This looks nicer and texture bleeding has been

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/padding_in_atlas into lp:widelands

2016-01-27 Thread SirVer
The proposal to merge lp:~widelands-dev/widelands/padding_in_atlas into lp:widelands has been updated. Description changed to: See commit. For more details, see: https://code.launchpad.net/~widelands-dev/widelands/padding_in_atlas/+merge/284216 -- Your team Widelands Developers is requested to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/changelog_license_date into lp:widelands

2016-01-27 Thread GunChleoc
Agreed - the development reports are definitely too long for this, but they might be easier as a point of departure than a list of fixed bugs. I'd say we wait until we're about to branch the release candidate before we touch this again? @bunnybot merge -- https://code.launchpad.net/~widelands-

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/padding_in_atlas into lp:widelands

2016-01-27 Thread SirVer
SirVer has proposed merging lp:~widelands-dev/widelands/padding_in_atlas into lp:widelands. Commit message: - Add 1 pixel padding in the texture atlas to avoid texture bleeding. - Filter all textures linearly instead of near. This looks nicer and texture bleeding has been taken care off. Reque

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/padding_in_atlas into lp:widelands

2016-01-27 Thread bunnybot
Hi, I am bunnybot (https://github.com/widelands/bunnybot). I am keeping the source branch lp:~widelands-dev/widelands/padding_in_atlas mirrored to https://github.com/widelands/widelands/tree/_widelands_dev_widelands_padding_in_atlas You can give me commands by starting a line with @bunnybot . I

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_huge_boxes into lp:widelands

2016-01-27 Thread bunnybot
Continuous integration builds have changed state: Travis build 419. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/105250971. Appveyor build 320. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fix_huge_boxe

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_huge_boxes into lp:widelands

2016-01-27 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/fix_huge_boxes into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/fix_huge_boxes/+merge/284176 -- Your team Widelands Developers is requested to revie

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/changelog_license_date into lp:widelands

2016-01-27 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/changelog_license_date into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/changelog_license_date/+merge/283871 -- Your team Widelands Developers is re

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/padding_in_atlas into lp:widelands

2016-01-27 Thread GunChleoc
Review: Approve I can't reproduce the problem, so somebody else will need to test. Code LGTM. -- https://code.launchpad.net/~widelands-dev/widelands/padding_in_atlas/+merge/284216 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/padding_in_atlas. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/load_library into lp:widelands

2016-01-27 Thread SirVer
The SDL_Init in the richtext renderer was called twice. -- https://code.launchpad.net/~widelands-dev/widelands/load_library/+merge/284218 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/load_library into lp:widelands. __

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/load_library into lp:widelands

2016-01-27 Thread SirVer
SirVer has proposed merging lp:~widelands-dev/widelands/load_library into lp:widelands. Commit message: Explicitly load the GL library, so we might get notified about errors. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1536377 in widelands: "The texture atlas

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/load_library into lp:widelands

2016-01-27 Thread bunnybot
Hi, I am bunnybot (https://github.com/widelands/bunnybot). I am keeping the source branch lp:~widelands-dev/widelands/load_library mirrored to https://github.com/widelands/widelands/tree/_widelands_dev_widelands_load_library You can give me commands by starting a line with @bunnybot . I unders

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1397500 into lp:widelands

2016-01-27 Thread bunnybot
Continuous integration builds have changed state: Travis build 420. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/105347928. Appveyor build 321. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1397500-3

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1397500 into lp:widelands

2016-01-27 Thread Tino
Review: Approve I've removed the breaking comment in the iss file and my local build is working (but this uses a different iss file). Let's wait for appveyor and travis... -- https://code.launchpad.net/~widelands-dev/widelands/bug-1397500/+merge/243860 Your team Widelands Developers is subscribe

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1397500 into lp:widelands

2016-01-27 Thread Tino
Review: Needs Fixing Sorry, it does not work: If started without --datadir Widelands assumes {execdir}\data correctly, but does not build the path correctly: $ ./widelands Set home directory: C:\Users\mit\.widelands Widelands executable directory: C:\bin\Widelands Adding directory: C:\bin\Widela