Continuous integration builds have changed state:
Travis build 1083. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/127258989.
Appveyor build 914. State: success. Details:
I think selecting info tool in EditorInteractive::cleanup_for_load is
unnecessary and does not fix the problem at its root. I propose:
- changing 'current_player_ = 0;' to 'current_player_ = 1;' in
EditorSetStartingPosTool's constructor
- replacing 'select_tool(tools()->info,
Continuous integration builds have changed state:
Travis build 1081. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/127194426.
Appveyor build 912. State: failed. Details:
GunChleoc has proposed merging
lp:~widelands-dev/widelands/barbarians2-starting-objective into lp:widelands.
Commit message:
Barbarian Campaign 2: Added an objective to the first message.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1276247 in widelands:
Continuous integration builds have changed state:
Travis build 1078. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/127169362.
Appveyor build 909. State: success. Details:
The proposal to merge lp:~widelands-dev/widelands/bug-1576280-help-textdomains
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1576280-help-textdomains/+merge/293479
--
Your team Widelands
I didn't check the datatype ;)
Diff comments:
>
> === modified file 'src/map_io/map_players_view_packet.cc'
> --- src/map_io/map_players_view_packet.cc 2016-02-16 10:27:23 +
> +++ src/map_io/map_players_view_packet.cc 2016-05-01 10:05:57 +
> @@ -991,12 +991,12 @@
>
Thanks!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1576280-help-textdomains/+merge/293479
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1576280-help-textdomains.
___
Mailing
Review: Approve
LGTM.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1576280-help-textdomains/+merge/293479
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1576280-help-textdomains.
___
Mailing list:
The proposal to merge lp:~widelands-dev/widelands/bug-1535732-testfix into
lp:widelands has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1535732-testfix/+merge/292734
--
Your team Widelands Developers is
Replied to a diff comment.
Diff comments:
>
> === modified file 'src/map_io/map_players_view_packet.cc'
> --- src/map_io/map_players_view_packet.cc 2016-02-16 10:27:23 +
> +++ src/map_io/map_players_view_packet.cc 2016-05-01 10:05:57 +
> @@ -991,12 +991,12 @@
>
Woohoo :D
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1572879-broken_bidi/+merge/293491
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1572879-broken_bidi.
___
Mailing list:
The proposal to merge lp:~widelands-dev/widelands/bug-1572879-broken_bidi into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1572879-broken_bidi/+merge/293491
--
Your team Widelands Developers is
Might be Ubuntu-sepecific numbering.
--
https://code.launchpad.net/~widelands-dev/widelands/gcc531/+merge/293478
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/gcc531.
___
Mailing list:
That's what my gcc --version says.
--
https://code.launchpad.net/~widelands-dev/widelands/gcc531/+merge/293478
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/gcc531.
___
Mailing list:
GCC 5.3.1 ?
It is not listed on https://gcc.gnu.org/ ...
--
https://code.launchpad.net/~widelands-dev/widelands/gcc531/+merge/293478
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/gcc531.
___
Mailing list:
Review: Approve
Looking good on my windows machine!
Let's skip appveyor ;)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1572879-broken_bidi/+merge/293491
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1572879-broken_bidi.
Review: Approve
LGTM :)
Let's wait for a Windows build before merging, so we can test.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1572879-broken_bidi/+merge/293491
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1572879-broken_bidi.
The proposal to merge lp:~widelands-dev/widelands/bug-1535732-fun-with-pointers
into lp:widelands has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1535732-fun-with-pointers/+merge/292735
--
Your team Widelands
Replied to the comments.
Diff comments:
> === modified file 'src/logic/queue_cmd_factory.cc'
> --- src/logic/queue_cmd_factory.cc2016-01-18 05:12:51 +
> +++ src/logic/queue_cmd_factory.cc2016-05-01 10:05:57 +
> @@ -112,7 +112,7 @@
> case QueueCommandTypes::kReplaySyncRead:
20 matches
Mail list logo
